Re: [PATCH] Autodetect libdrm path (v2)

From: Emil Velikov <emil.l.velikov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "StDenis, Tom" <Tom.StDenis-5C7GfCeVMHo@public.gmane.org>
Cc: Tom St Denis <tstdenis82-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	amd-gfx mailing list
	<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Subject: Re: [PATCH] Autodetect libdrm path (v2)
Date: Tue, 7 Feb 2017 11:02:17 +0000	[thread overview]
Message-ID: <CACvgo537ciLvg=Q6enktu6ndMSEuSCM+RpmniJdgYNgZDQjUeQ@mail.gmail.com> (raw)
In-Reply-To: <CY4PR12MB1768AED537A0253EB70B1E4BF7400-rpdhrqHFk06yjjPBNVDk/QdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>

On 6 February 2017 at 22:39, StDenis, Tom <Tom.StDenis@amd.com> wrote:
>
> Apparently I missed the bottom of your reply (all of the clients I have outlook/gmail do top post only ...)
Both Outlook and Gmail can do inline replies and plain text. There
might be some magic required for the former though :-\
I would kindly suggest using inline/text when possible.

> as for the cmake changes. I'm for it if you want to submit a patch.  I can't imagine a lot of cross compiling though since users will typically be using it on the platform they built it for.
>
>
> Ironically, I had the pkg_check originally but was told that's a faux-pas.
>
It's a common misconception, influenced by the sheer volume of copy/paste :-)

>
> Unless this is breaking for actual users though it's not really a priority to bikeshed the build system of a 30 file project that is meant to work only on developer machines who are likely building for themselves
>
Up-to you really. FWIW using cmake/autoconf/etc. is a huge overkill.
The original makefile was missing a few things* worth 10-20 lines of
code while being noticeably smaller, quicker and easier to read ;-)

* Dependency tracking (pkg-config + foo.pc), incremental builds - ($CC
... -MM -MP ...), tarballs.

> Tom
>
> ________________________________
> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of StDenis, Tom <Tom.StDenis@amd.com>
> Sent: Monday, February 6, 2017 16:33
> To: Emil Velikov; Tom St Denis
> Cc: amd-gfx mailing list
>
> Subject: Re: [PATCH] Autodetect libdrm path (v2)
>
>
> I have to NAK that idea since we use umr on NPI work which doesn't necessarily have libdrm support.
>
>
> Also umr can read/write registers via pci access without amdgpu loaded (handy if amdgpu fails to init properly).
>
Must have missed this part. Thanks for the correction.

>
> Though you are right that libdrm is technically a requirement and I should add that to the README.
>
Ack.

Thanks
Emil
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx