* [PATCH] x86: remove obsolete comment in uapi/e820.h
@ 2014-05-19 17:50 Ross Zwisler
2014-08-20 20:25 ` Ross Zwisler
2014-08-21 6:45 ` [tip:x86/cleanups] x86: Remove " tip-bot for Ross Zwisler
0 siblings, 2 replies; 3+ messages in thread
From: Ross Zwisler @ 2014-05-19 17:50 UTC (permalink / raw)
To: linux-kernel
Cc: Ross Zwisler, Thomas Gleixner, Ingo Molnar, H. Peter Anvin, x86
A comment introduced by this commit:
028b785888c5 x86 boot: extend some internal memory map arrays to handle
larger EFI input
had to do with some nested preprocessor directives. The directives were
split into separate files by this commit:
af170c5061dd UAPI: (Scripted) Disintegrate arch/x86/include/asm
The comment explaining their interaction was retained and is now present
in arch/x86/include/uapi/asm/e820.h. This comment is no longer correct,
so delete it.
Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: x86@kernel.org
---
arch/x86/include/uapi/asm/e820.h | 5 -----
1 file changed, 5 deletions(-)
diff --git a/arch/x86/include/uapi/asm/e820.h b/arch/x86/include/uapi/asm/e820.h
index bbae024..d993e33 100644
--- a/arch/x86/include/uapi/asm/e820.h
+++ b/arch/x86/include/uapi/asm/e820.h
@@ -21,11 +21,6 @@
* this size.
*/
-/*
- * Odd: 'make headers_check' complains about numa.h if I try
- * to collapse the next two #ifdef lines to a single line:
- * #if defined(__KERNEL__) && defined(CONFIG_EFI)
- */
#ifndef __KERNEL__
#define E820_X_MAX E820MAX
#endif
--
1.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] x86: remove obsolete comment in uapi/e820.h
2014-05-19 17:50 [PATCH] x86: remove obsolete comment in uapi/e820.h Ross Zwisler
@ 2014-08-20 20:25 ` Ross Zwisler
2014-08-21 6:45 ` [tip:x86/cleanups] x86: Remove " tip-bot for Ross Zwisler
1 sibling, 0 replies; 3+ messages in thread
From: Ross Zwisler @ 2014-08-20 20:25 UTC (permalink / raw)
To: linux-kernel; +Cc: Thomas Gleixner, Ingo Molnar, H. Peter Anvin, x86
On Mon, 2014-05-19 at 11:50 -0600, Ross Zwisler wrote:
> A comment introduced by this commit:
>
> 028b785888c5 x86 boot: extend some internal memory map arrays to handle
> larger EFI input
>
> had to do with some nested preprocessor directives. The directives were
> split into separate files by this commit:
>
> af170c5061dd UAPI: (Scripted) Disintegrate arch/x86/include/asm
>
> The comment explaining their interaction was retained and is now present
> in arch/x86/include/uapi/asm/e820.h. This comment is no longer correct,
> so delete it.
>
> Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: x86@kernel.org
> ---
> arch/x86/include/uapi/asm/e820.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/arch/x86/include/uapi/asm/e820.h b/arch/x86/include/uapi/asm/e820.h
> index bbae024..d993e33 100644
> --- a/arch/x86/include/uapi/asm/e820.h
> +++ b/arch/x86/include/uapi/asm/e820.h
> @@ -21,11 +21,6 @@
> * this size.
> */
>
> -/*
> - * Odd: 'make headers_check' complains about numa.h if I try
> - * to collapse the next two #ifdef lines to a single line:
> - * #if defined(__KERNEL__) && defined(CONFIG_EFI)
> - */
> #ifndef __KERNEL__
> #define E820_X_MAX E820MAX
> #endif
Ping. :)
^ permalink raw reply [flat|nested] 3+ messages in thread
* [tip:x86/cleanups] x86: Remove obsolete comment in uapi/e820.h
2014-05-19 17:50 [PATCH] x86: remove obsolete comment in uapi/e820.h Ross Zwisler
2014-08-20 20:25 ` Ross Zwisler
@ 2014-08-21 6:45 ` tip-bot for Ross Zwisler
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Ross Zwisler @ 2014-08-21 6:45 UTC (permalink / raw)
To: linux-tip-commits; +Cc: linux-kernel, hpa, mingo, ross.zwisler, tglx
Commit-ID: 448466b723cc7b44016547116aa2b55a3736f1f0
Gitweb: http://git.kernel.org/tip/448466b723cc7b44016547116aa2b55a3736f1f0
Author: Ross Zwisler <ross.zwisler@linux.intel.com>
AuthorDate: Mon, 19 May 2014 11:50:24 -0600
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Thu, 21 Aug 2014 08:43:39 +0200
x86: Remove obsolete comment in uapi/e820.h
A comment introduced by this old commit:
028b785888c5 ("x86 boot: extend some internal memory map arrays to handle larger EFI input")
had to do with some nested preprocessor directives. The
directives were split into separate files by this commit:
af170c5061dd ("UAPI: (Scripted) Disintegrate arch/x86/include/asm")
The comment explaining their interaction was retained and is now
present in arch/x86/include/uapi/asm/e820.h. This comment is no
longer correct, so delete it.
Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
Link: http://lkml.kernel.org/r/1400521824-21040-1-git-send-email-ross.zwisler@linux.intel.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/include/uapi/asm/e820.h | 5 -----
1 file changed, 5 deletions(-)
diff --git a/arch/x86/include/uapi/asm/e820.h b/arch/x86/include/uapi/asm/e820.h
index bbae024..d993e33 100644
--- a/arch/x86/include/uapi/asm/e820.h
+++ b/arch/x86/include/uapi/asm/e820.h
@@ -21,11 +21,6 @@
* this size.
*/
-/*
- * Odd: 'make headers_check' complains about numa.h if I try
- * to collapse the next two #ifdef lines to a single line:
- * #if defined(__KERNEL__) && defined(CONFIG_EFI)
- */
#ifndef __KERNEL__
#define E820_X_MAX E820MAX
#endif
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-08-21 6:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-19 17:50 [PATCH] x86: remove obsolete comment in uapi/e820.h Ross Zwisler
2014-08-20 20:25 ` Ross Zwisler
2014-08-21 6:45 ` [tip:x86/cleanups] x86: Remove " tip-bot for Ross Zwisler
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.