[PATCH] ARM: EXYNOS: Use wfi macro in platform_do_lowpower

[PATCH] ARM: EXYNOS: Use wfi macro in platform_do_lowpower

[Leela Krishna Amudala]

This patch is originally based on commit b3377d186572 ("ARM: 7064/1:
vexpress: Use wfi macro in platform_do_lowpower.")

Current Exynos CPU hotplug code includes a hardcoded WFI
instruction, in ARM encoding.  When the kernel is compiled in Thumb-2
mode, this is invalid and causes the machine to hang hard when a CPU
is offlined.

Use wfi macro instead of the hardcoded WFI instruction.

Signed-off-by: Leela Krishna Amudala <leela.krishna@linaro.org>
---
 arch/arm/mach-exynos/hotplug.c |    8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/arch/arm/mach-exynos/hotplug.c b/arch/arm/mach-exynos/hotplug.c
index 69fa483..8a134d0 100644
--- a/arch/arm/mach-exynos/hotplug.c
+++ b/arch/arm/mach-exynos/hotplug.c
@@ -46,13 +46,7 @@ static inline void platform_do_lowpower(unsigned int cpu, int *spurious)
 		if (cpu == 1)
 			exynos_cpu_power_down(cpu);
 
-		/*
-		 * here's the WFI
-		 */
-		asm(".word	0xe320f003\n"
-		    :
-		    :
-		    : "memory", "cc");
+		wfi();
 
 		if (pen_release == cpu_logical_map(cpu)) {
 			/*
-- 
1.7.9.5

[PATCH] ARM: EXYNOS: Use wfi macro in platform_do_lowpower

[Leela Krishna Amudala]

This patch is originally based on commit b3377d186572 ("ARM: 7064/1:
vexpress: Use wfi macro in platform_do_lowpower.")

Current Exynos CPU hotplug code includes a hardcoded WFI
instruction, in ARM encoding.  When the kernel is compiled in Thumb-2
mode, this is invalid and causes the machine to hang hard when a CPU
is offlined.

Use wfi macro instead of the hardcoded WFI instruction.

Signed-off-by: Leela Krishna Amudala <leela.krishna@linaro.org>
---
 arch/arm/mach-exynos/hotplug.c |    8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/arch/arm/mach-exynos/hotplug.c b/arch/arm/mach-exynos/hotplug.c
index 69fa483..8a134d0 100644
--- a/arch/arm/mach-exynos/hotplug.c
+++ b/arch/arm/mach-exynos/hotplug.c
@@ -46,13 +46,7 @@ static inline void platform_do_lowpower(unsigned int cpu, int *spurious)
 		if (cpu == 1)
 			exynos_cpu_power_down(cpu);
 
-		/*
-		 * here's the WFI
-		 */
-		asm(".word	0xe320f003\n"
-		    :
-		    :
-		    : "memory", "cc");
+		wfi();
 
 		if (pen_release == cpu_logical_map(cpu)) {
 			/*
-- 
1.7.9.5

Re: [PATCH] ARM: EXYNOS: Use wfi macro in platform_do_lowpower

[Daniel Lezcano]

On 05/22/2014 09:57 AM, Leela Krishna Amudala wrote:
> This patch is originally based on commit b3377d186572 ("ARM: 7064/1:
> vexpress: Use wfi macro in platform_do_lowpower.")
>
> Current Exynos CPU hotplug code includes a hardcoded WFI
> instruction, in ARM encoding.  When the kernel is compiled in Thumb-2
> mode, this is invalid and causes the machine to hang hard when a CPU
> is offlined.
>
> Use wfi macro instead of the hardcoded WFI instruction.

Is it possible to change it for cpu_do_idle() ?

I guess, that should be backported to the previous kernel version, right 
? (Cc stable@).

Thanks
   -- Daniel

> Signed-off-by: Leela Krishna Amudala <leela.krishna@linaro.org>
> ---
>   arch/arm/mach-exynos/hotplug.c |    8 +-------
>   1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/hotplug.c b/arch/arm/mach-exynos/hotplug.c
> index 69fa483..8a134d0 100644
> --- a/arch/arm/mach-exynos/hotplug.c
> +++ b/arch/arm/mach-exynos/hotplug.c
> @@ -46,13 +46,7 @@ static inline void platform_do_lowpower(unsigned int cpu, int *spurious)
>   		if (cpu == 1)
>   			exynos_cpu_power_down(cpu);
>
> -		/*
> -		 * here's the WFI
> -		 */
> -		asm(".word	0xe320f003\n"
> -		    :
> -		    :
> -		    : "memory", "cc");
> +		wfi();
>
>   		if (pen_release == cpu_logical_map(cpu)) {
>   			/*
>


-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

[PATCH] ARM: EXYNOS: Use wfi macro in platform_do_lowpower

[Daniel Lezcano]

On 05/22/2014 09:57 AM, Leela Krishna Amudala wrote:
> This patch is originally based on commit b3377d186572 ("ARM: 7064/1:
> vexpress: Use wfi macro in platform_do_lowpower.")
>
> Current Exynos CPU hotplug code includes a hardcoded WFI
> instruction, in ARM encoding.  When the kernel is compiled in Thumb-2
> mode, this is invalid and causes the machine to hang hard when a CPU
> is offlined.
>
> Use wfi macro instead of the hardcoded WFI instruction.

Is it possible to change it for cpu_do_idle() ?

I guess, that should be backported to the previous kernel version, right 
? (Cc stable@).

Thanks
   -- Daniel

> Signed-off-by: Leela Krishna Amudala <leela.krishna@linaro.org>
> ---
>   arch/arm/mach-exynos/hotplug.c |    8 +-------
>   1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/hotplug.c b/arch/arm/mach-exynos/hotplug.c
> index 69fa483..8a134d0 100644
> --- a/arch/arm/mach-exynos/hotplug.c
> +++ b/arch/arm/mach-exynos/hotplug.c
> @@ -46,13 +46,7 @@ static inline void platform_do_lowpower(unsigned int cpu, int *spurious)
>   		if (cpu == 1)
>   			exynos_cpu_power_down(cpu);
>
> -		/*
> -		 * here's the WFI
> -		 */
> -		asm(".word	0xe320f003\n"
> -		    :
> -		    :
> -		    : "memory", "cc");
> +		wfi();
>
>   		if (pen_release == cpu_logical_map(cpu)) {
>   			/*
>


-- 
  <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

Re: [PATCH] ARM: EXYNOS: Use wfi macro in platform_do_lowpower

[Nicolas Pitre]

On Thu, 22 May 2014, Daniel Lezcano wrote:

> On 05/22/2014 09:57 AM, Leela Krishna Amudala wrote:
> > This patch is originally based on commit b3377d186572 ("ARM: 7064/1:
> > vexpress: Use wfi macro in platform_do_lowpower.")
> >
> > Current Exynos CPU hotplug code includes a hardcoded WFI
> > instruction, in ARM encoding.  When the kernel is compiled in Thumb-2
> > mode, this is invalid and causes the machine to hang hard when a CPU
> > is offlined.
> >
> > Use wfi macro instead of the hardcoded WFI instruction.
> 
> Is it possible to change it for cpu_do_idle() ?

Please let's not encourage every wfi() to be turned into cpu_do_idle().  
They are not always equivalent.  And semantically they are not.


Nicolas

[PATCH] ARM: EXYNOS: Use wfi macro in platform_do_lowpower

[Nicolas Pitre]

On Thu, 22 May 2014, Daniel Lezcano wrote:

> On 05/22/2014 09:57 AM, Leela Krishna Amudala wrote:
> > This patch is originally based on commit b3377d186572 ("ARM: 7064/1:
> > vexpress: Use wfi macro in platform_do_lowpower.")
> >
> > Current Exynos CPU hotplug code includes a hardcoded WFI
> > instruction, in ARM encoding.  When the kernel is compiled in Thumb-2
> > mode, this is invalid and causes the machine to hang hard when a CPU
> > is offlined.
> >
> > Use wfi macro instead of the hardcoded WFI instruction.
> 
> Is it possible to change it for cpu_do_idle() ?

Please let's not encourage every wfi() to be turned into cpu_do_idle().  
They are not always equivalent.  And semantically they are not.


Nicolas

Re: [PATCH] ARM: EXYNOS: Use wfi macro in platform_do_lowpower

[Daniel Lezcano]

On 05/22/2014 09:57 AM, Leela Krishna Amudala wrote:
> This patch is originally based on commit b3377d186572 ("ARM: 7064/1:
> vexpress: Use wfi macro in platform_do_lowpower.")
>
> Current Exynos CPU hotplug code includes a hardcoded WFI
> instruction, in ARM encoding.  When the kernel is compiled in Thumb-2
> mode, this is invalid and causes the machine to hang hard when a CPU
> is offlined.
>
> Use wfi macro instead of the hardcoded WFI instruction.
>
> Signed-off-by: Leela Krishna Amudala <leela.krishna@linaro.org>

Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>


-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

[PATCH] ARM: EXYNOS: Use wfi macro in platform_do_lowpower

[Daniel Lezcano]

On 05/22/2014 09:57 AM, Leela Krishna Amudala wrote:
> This patch is originally based on commit b3377d186572 ("ARM: 7064/1:
> vexpress: Use wfi macro in platform_do_lowpower.")
>
> Current Exynos CPU hotplug code includes a hardcoded WFI
> instruction, in ARM encoding.  When the kernel is compiled in Thumb-2
> mode, this is invalid and causes the machine to hang hard when a CPU
> is offlined.
>
> Use wfi macro instead of the hardcoded WFI instruction.
>
> Signed-off-by: Leela Krishna Amudala <leela.krishna@linaro.org>

Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>


-- 
  <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

Re: [PATCH] ARM: EXYNOS: Use wfi macro in platform_do_lowpower

[Leela Krishna Amudala]

Hi Kgene,


On Fri, May 23, 2014 at 12:31 AM, Daniel Lezcano
<daniel.lezcano@linaro.org> wrote:
> On 05/22/2014 09:57 AM, Leela Krishna Amudala wrote:
>>
>> This patch is originally based on commit b3377d186572 ("ARM: 7064/1:
>> vexpress: Use wfi macro in platform_do_lowpower.")
>>
>> Current Exynos CPU hotplug code includes a hardcoded WFI
>> instruction, in ARM encoding.  When the kernel is compiled in Thumb-2
>> mode, this is invalid and causes the machine to hang hard when a CPU
>> is offlined.
>>
>> Use wfi macro instead of the hardcoded WFI instruction.
>>
>> Signed-off-by: Leela Krishna Amudala <leela.krishna@linaro.org>
>
>
> Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>

Can you please take action on this patch.

Best Regards,
Leela Krishna.

>
>
> --
>  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
>
> Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
> <http://twitter.com/#!/linaroorg> Twitter |
> <http://www.linaro.org/linaro-blog/> Blog
>

[PATCH] ARM: EXYNOS: Use wfi macro in platform_do_lowpower

[Leela Krishna Amudala]

Hi Kgene,


On Fri, May 23, 2014 at 12:31 AM, Daniel Lezcano
<daniel.lezcano@linaro.org> wrote:
> On 05/22/2014 09:57 AM, Leela Krishna Amudala wrote:
>>
>> This patch is originally based on commit b3377d186572 ("ARM: 7064/1:
>> vexpress: Use wfi macro in platform_do_lowpower.")
>>
>> Current Exynos CPU hotplug code includes a hardcoded WFI
>> instruction, in ARM encoding.  When the kernel is compiled in Thumb-2
>> mode, this is invalid and causes the machine to hang hard when a CPU
>> is offlined.
>>
>> Use wfi macro instead of the hardcoded WFI instruction.
>>
>> Signed-off-by: Leela Krishna Amudala <leela.krishna@linaro.org>
>
>
> Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>

Can you please take action on this patch.

Best Regards,
Leela Krishna.

>
>
> --
>  <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs
>
> Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
> <http://twitter.com/#!/linaroorg> Twitter |
> <http://www.linaro.org/linaro-blog/> Blog
>

Re: [PATCH] ARM: EXYNOS: Use wfi macro in platform_do_lowpower

[Kukjin Kim]

On 05/23/14 15:13, Leela Krishna Amudala wrote:
> Hi Kgene,
>
Hi,

>
> On Fri, May 23, 2014 at 12:31 AM, Daniel Lezcano
> <daniel.lezcano@linaro.org>  wrote:
>> On 05/22/2014 09:57 AM, Leela Krishna Amudala wrote:
>>>
>>> This patch is originally based on commit b3377d186572 ("ARM: 7064/1:
>>> vexpress: Use wfi macro in platform_do_lowpower.")
>>>
>>> Current Exynos CPU hotplug code includes a hardcoded WFI
>>> instruction, in ARM encoding.  When the kernel is compiled in Thumb-2
>>> mode, this is invalid and causes the machine to hang hard when a CPU
>>> is offlined.
>>>
>>> Use wfi macro instead of the hardcoded WFI instruction.
>>>
>>> Signed-off-by: Leela Krishna Amudala<leela.krishna@linaro.org>
>>
>>
>> Acked-by: Daniel Lezcano<daniel.lezcano@linaro.org>
>>
>
> Can you please take action on this patch.
>
Applied, thanks.

- Kukjin

[PATCH] ARM: EXYNOS: Use wfi macro in platform_do_lowpower

[Kukjin Kim]

On 05/23/14 15:13, Leela Krishna Amudala wrote:
> Hi Kgene,
>
Hi,

>
> On Fri, May 23, 2014 at 12:31 AM, Daniel Lezcano
> <daniel.lezcano@linaro.org>  wrote:
>> On 05/22/2014 09:57 AM, Leela Krishna Amudala wrote:
>>>
>>> This patch is originally based on commit b3377d186572 ("ARM: 7064/1:
>>> vexpress: Use wfi macro in platform_do_lowpower.")
>>>
>>> Current Exynos CPU hotplug code includes a hardcoded WFI
>>> instruction, in ARM encoding.  When the kernel is compiled in Thumb-2
>>> mode, this is invalid and causes the machine to hang hard when a CPU
>>> is offlined.
>>>
>>> Use wfi macro instead of the hardcoded WFI instruction.
>>>
>>> Signed-off-by: Leela Krishna Amudala<leela.krishna@linaro.org>
>>
>>
>> Acked-by: Daniel Lezcano<daniel.lezcano@linaro.org>
>>
>
> Can you please take action on this patch.
>
Applied, thanks.

- Kukjin

Re: [PATCH] ARM: EXYNOS: Use wfi macro in platform_do_lowpower

[Tushar Behera]

Ping !!!

On 03/08/2013 04:39 PM, Tushar Behera wrote:
> As per commit b3377d186572 ("ARM: 7064/1: vexpress: Use wfi macro
> in platform_do_lowpower."), wfi macro should be used instead
> of the hardcoded WFI instruction.
> 
> This fixes following oops when the kernel is compiled in Thumb-2 mode
> on EXYNOS5. (Tested on EXYNOS5250 based Arndale board)
> 
> $ reboot
> Disabling non-boot CPUs ...
> IRQ153 no longer affine to CPU1
> CPU1: shutdown
> Internal error: Oops - undefined instruction: 0 [#1] PREEMPT SMP THUMB2
> Modules linked in:
> CPU: 1    Not tainted  (3.9.0-rc1-00015-gce76372 #1)
> PC is at 0xc065858e
> LR is at exynos_cpu_die+0x53/0xc0
> 
> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
> ---
>  arch/arm/mach-exynos/hotplug.c |    8 +-------
>  1 files changed, 1 insertions(+), 7 deletions(-)
> 
> diff --git a/arch/arm/mach-exynos/hotplug.c b/arch/arm/mach-exynos/hotplug.c
> index c3f825b..d9712fe 100644
> --- a/arch/arm/mach-exynos/hotplug.c
> +++ b/arch/arm/mach-exynos/hotplug.c
> @@ -99,13 +99,7 @@ static inline void platform_do_lowpower(unsigned int cpu, int *spurious)
>  		if (cpu == 1)
>  			__raw_writel(0, S5P_ARM_CORE1_CONFIGURATION);
>  
> -		/*
> -		 * here's the WFI
> -		 */
> -		asm(".word	0xe320f003\n"
> -		    :
> -		    :
> -		    : "memory", "cc");
> +		wfi();
>  
>  		if (pen_release == cpu_logical_map(cpu)) {
>  			/*
> 


-- 
Tushar Behera

[PATCH] ARM: EXYNOS: Use wfi macro in platform_do_lowpower

[Tushar Behera]

Ping !!!

On 03/08/2013 04:39 PM, Tushar Behera wrote:
> As per commit b3377d186572 ("ARM: 7064/1: vexpress: Use wfi macro
> in platform_do_lowpower."), wfi macro should be used instead
> of the hardcoded WFI instruction.
> 
> This fixes following oops when the kernel is compiled in Thumb-2 mode
> on EXYNOS5. (Tested on EXYNOS5250 based Arndale board)
> 
> $ reboot
> Disabling non-boot CPUs ...
> IRQ153 no longer affine to CPU1
> CPU1: shutdown
> Internal error: Oops - undefined instruction: 0 [#1] PREEMPT SMP THUMB2
> Modules linked in:
> CPU: 1    Not tainted  (3.9.0-rc1-00015-gce76372 #1)
> PC is at 0xc065858e
> LR is at exynos_cpu_die+0x53/0xc0
> 
> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
> ---
>  arch/arm/mach-exynos/hotplug.c |    8 +-------
>  1 files changed, 1 insertions(+), 7 deletions(-)
> 
> diff --git a/arch/arm/mach-exynos/hotplug.c b/arch/arm/mach-exynos/hotplug.c
> index c3f825b..d9712fe 100644
> --- a/arch/arm/mach-exynos/hotplug.c
> +++ b/arch/arm/mach-exynos/hotplug.c
> @@ -99,13 +99,7 @@ static inline void platform_do_lowpower(unsigned int cpu, int *spurious)
>  		if (cpu == 1)
>  			__raw_writel(0, S5P_ARM_CORE1_CONFIGURATION);
>  
> -		/*
> -		 * here's the WFI
> -		 */
> -		asm(".word	0xe320f003\n"
> -		    :
> -		    :
> -		    : "memory", "cc");
> +		wfi();
>  
>  		if (pen_release == cpu_logical_map(cpu)) {
>  			/*
> 


-- 
Tushar Behera

[PATCH] ARM: EXYNOS: Use wfi macro in platform_do_lowpower

[Tushar Behera]

As per commit b3377d186572 ("ARM: 7064/1: vexpress: Use wfi macro
in platform_do_lowpower."), wfi macro should be used instead
of the hardcoded WFI instruction.

This fixes following oops when the kernel is compiled in Thumb-2 mode
on EXYNOS5. (Tested on EXYNOS5250 based Arndale board)

$ reboot
Disabling non-boot CPUs ...
IRQ153 no longer affine to CPU1
CPU1: shutdown
Internal error: Oops - undefined instruction: 0 [#1] PREEMPT SMP THUMB2
Modules linked in:
CPU: 1    Not tainted  (3.9.0-rc1-00015-gce76372 #1)
PC is at 0xc065858e
LR is at exynos_cpu_die+0x53/0xc0

Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
---
 arch/arm/mach-exynos/hotplug.c |    8 +-------
 1 files changed, 1 insertions(+), 7 deletions(-)

diff --git a/arch/arm/mach-exynos/hotplug.c b/arch/arm/mach-exynos/hotplug.c
index c3f825b..d9712fe 100644
--- a/arch/arm/mach-exynos/hotplug.c
+++ b/arch/arm/mach-exynos/hotplug.c
@@ -99,13 +99,7 @@ static inline void platform_do_lowpower(unsigned int cpu, int *spurious)
 		if (cpu == 1)
 			__raw_writel(0, S5P_ARM_CORE1_CONFIGURATION);
 
-		/*
-		 * here's the WFI
-		 */
-		asm(".word	0xe320f003\n"
-		    :
-		    :
-		    : "memory", "cc");
+		wfi();
 
 		if (pen_release == cpu_logical_map(cpu)) {
 			/*
-- 
1.7.4.1

[PATCH] ARM: EXYNOS: Use wfi macro in platform_do_lowpower

[Tushar Behera]

As per commit b3377d186572 ("ARM: 7064/1: vexpress: Use wfi macro
in platform_do_lowpower."), wfi macro should be used instead
of the hardcoded WFI instruction.

This fixes following oops when the kernel is compiled in Thumb-2 mode
on EXYNOS5. (Tested on EXYNOS5250 based Arndale board)

$ reboot
Disabling non-boot CPUs ...
IRQ153 no longer affine to CPU1
CPU1: shutdown
Internal error: Oops - undefined instruction: 0 [#1] PREEMPT SMP THUMB2
Modules linked in:
CPU: 1    Not tainted  (3.9.0-rc1-00015-gce76372 #1)
PC is at 0xc065858e
LR is at exynos_cpu_die+0x53/0xc0

Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
---
 arch/arm/mach-exynos/hotplug.c |    8 +-------
 1 files changed, 1 insertions(+), 7 deletions(-)

diff --git a/arch/arm/mach-exynos/hotplug.c b/arch/arm/mach-exynos/hotplug.c
index c3f825b..d9712fe 100644
--- a/arch/arm/mach-exynos/hotplug.c
+++ b/arch/arm/mach-exynos/hotplug.c
@@ -99,13 +99,7 @@ static inline void platform_do_lowpower(unsigned int cpu, int *spurious)
 		if (cpu == 1)
 			__raw_writel(0, S5P_ARM_CORE1_CONFIGURATION);
 
-		/*
-		 * here's the WFI
-		 */
-		asm(".word	0xe320f003\n"
-		    :
-		    :
-		    : "memory", "cc");
+		wfi();
 
 		if (pen_release == cpu_logical_map(cpu)) {
 			/*
-- 
1.7.4.1