* [PATCH] [media] mt9v032: fix hblank calculation
@ 2014-05-23 7:47 Philipp Zabel
2014-05-26 12:56 ` Laurent Pinchart
0 siblings, 1 reply; 2+ messages in thread
From: Philipp Zabel @ 2014-05-23 7:47 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: Mauro Carvalho Chehab, linux-media, Philipp Zabel
Since (min_row_time - crop->width) can be negative, we have to do a signed
comparison here. Otherwise max_t casts the negative value to unsigned int
and sets min_hblank to that invalid value.
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/media/i2c/mt9v032.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/mt9v032.c b/drivers/media/i2c/mt9v032.c
index 40172b8..4d7afad 100644
--- a/drivers/media/i2c/mt9v032.c
+++ b/drivers/media/i2c/mt9v032.c
@@ -305,7 +305,7 @@ mt9v032_update_hblank(struct mt9v032 *mt9v032)
if (mt9v032->version->version == MT9V034_CHIP_ID_REV1)
min_hblank += (mt9v032->hratio - 1) * 10;
- min_hblank = max_t(unsigned int, (int)mt9v032->model->data->min_row_time - crop->width,
+ min_hblank = max_t(int, (int)mt9v032->model->data->min_row_time - crop->width,
(int)min_hblank);
hblank = max_t(unsigned int, mt9v032->hblank, min_hblank);
--
2.0.0.rc0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] [media] mt9v032: fix hblank calculation
2014-05-23 7:47 [PATCH] [media] mt9v032: fix hblank calculation Philipp Zabel
@ 2014-05-26 12:56 ` Laurent Pinchart
0 siblings, 0 replies; 2+ messages in thread
From: Laurent Pinchart @ 2014-05-26 12:56 UTC (permalink / raw)
To: Philipp Zabel; +Cc: Mauro Carvalho Chehab, linux-media
Hi Philipp,
Thank you for the patch.
On Friday 23 May 2014 09:47:57 Philipp Zabel wrote:
> Since (min_row_time - crop->width) can be negative, we have to do a signed
> comparison here. Otherwise max_t casts the negative value to unsigned int
> and sets min_hblank to that invalid value.
>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
> drivers/media/i2c/mt9v032.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/mt9v032.c b/drivers/media/i2c/mt9v032.c
> index 40172b8..4d7afad 100644
> --- a/drivers/media/i2c/mt9v032.c
> +++ b/drivers/media/i2c/mt9v032.c
> @@ -305,7 +305,7 @@ mt9v032_update_hblank(struct mt9v032 *mt9v032)
>
> if (mt9v032->version->version == MT9V034_CHIP_ID_REV1)
> min_hblank += (mt9v032->hratio - 1) * 10;
> - min_hblank = max_t(unsigned int, (int)mt9v032->model->data->min_row_time
> - crop->width,
> + min_hblank = max_t(int, (int)mt9v032->model->data->min_row_time
> - crop->width, (int)min_hblank);
As max_t now casts to int, wouldn't it make sense to remove the manual casts
on both operands ? The first one is useless anyway, as the compiler will cast
mt9v032->model->data->min_row_time back to an unsigned int as crop->width is
unsigned.
> hblank = max_t(unsigned int, mt9v032->hblank, min_hblank);
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-26 12:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-23 7:47 [PATCH] [media] mt9v032: fix hblank calculation Philipp Zabel
2014-05-26 12:56 ` Laurent Pinchart
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.