* [PATCH net-next v2] mrf24j40: add managed API's provided by device layer
@ 2014-05-29 6:05 Varka Bhadram
2014-05-29 8:50 ` [Linux-zigbee-devel] " Alexander Aring
0 siblings, 1 reply; 2+ messages in thread
From: Varka Bhadram @ 2014-05-29 6:05 UTC (permalink / raw)
To: alan
Cc: alex.bluesman.smirnov, dbaryshkov, linux-zigbee-devel, netdev,
linux-kernel, davem, alex.aing, Varka Bhadram
forgot to use devm_* for spi buff.
sorry for that.
-Varka Bhadram
Signed-off-by: Varka Bhadram <varkab@cdac.in>
---
drivers/net/ieee802154/mrf24j40.c | 21 +++++++++------------
1 file changed, 9 insertions(+), 12 deletions(-)
diff --git a/drivers/net/ieee802154/mrf24j40.c b/drivers/net/ieee802154/mrf24j40.c
index 78a6552..90aed9b 100644
--- a/drivers/net/ieee802154/mrf24j40.c
+++ b/drivers/net/ieee802154/mrf24j40.c
@@ -618,10 +618,10 @@ static int mrf24j40_probe(struct spi_device *spi)
printk(KERN_INFO "mrf24j40: probe(). IRQ: %d\n", spi->irq);
- devrec = kzalloc(sizeof(struct mrf24j40), GFP_KERNEL);
+ devrec = devm_kzalloc(&spi->dev, sizeof(struct mrf24j40), GFP_KERNEL);
if (!devrec)
goto err_devrec;
- devrec->buf = kzalloc(3, GFP_KERNEL);
+ devrec->buf = devm_kzalloc(&spi->dev, 3, GFP_KERNEL);
if (!devrec->buf)
goto err_buf;
@@ -676,12 +676,13 @@ static int mrf24j40_probe(struct spi_device *spi)
val &= ~0x3; /* Clear RX mode (normal) */
write_short_reg(devrec, REG_RXMCR, val);
- ret = request_threaded_irq(spi->irq,
- NULL,
- mrf24j40_isr,
- IRQF_TRIGGER_LOW|IRQF_ONESHOT,
- dev_name(&spi->dev),
- devrec);
+ ret = devm_request_threaded_irq(&spi->dev,
+ spi->irq,
+ NULL,
+ mrf24j40_isr,
+ IRQF_TRIGGER_LOW|IRQF_ONESHOT,
+ dev_name(&spi->dev),
+ devrec);
if (ret) {
dev_err(printdev(devrec), "Unable to get IRQ");
@@ -709,15 +710,11 @@ static int mrf24j40_remove(struct spi_device *spi)
dev_dbg(printdev(devrec), "remove\n");
- free_irq(spi->irq, devrec);
ieee802154_unregister_device(devrec->dev);
ieee802154_free_device(devrec->dev);
/* TODO: Will ieee802154_free_device() wait until ->xmit() is
* complete? */
- /* Clean up the SPI stuff. */
- kfree(devrec->buf);
- kfree(devrec);
return 0;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Linux-zigbee-devel] [PATCH net-next v2] mrf24j40: add managed API's provided by device layer
2014-05-29 6:05 [PATCH net-next v2] mrf24j40: add managed API's provided by device layer Varka Bhadram
@ 2014-05-29 8:50 ` Alexander Aring
0 siblings, 0 replies; 2+ messages in thread
From: Alexander Aring @ 2014-05-29 8:50 UTC (permalink / raw)
To: Varka Bhadram
Cc: alan, Varka Bhadram, netdev, linux-kernel, linux-zigbee-devel,
alex.aing, davem
Hi Varka,
On Thu, May 29, 2014 at 11:35:35AM +0530, Varka Bhadram wrote:
> forgot to use devm_* for spi buff.
> sorry for that.
>
> -Varka Bhadram
>
> Signed-off-by: Varka Bhadram <varkab@cdac.in>
> ---
> drivers/net/ieee802154/mrf24j40.c | 21 +++++++++------------
> 1 file changed, 9 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/net/ieee802154/mrf24j40.c b/drivers/net/ieee802154/mrf24j40.c
> index 78a6552..90aed9b 100644
> --- a/drivers/net/ieee802154/mrf24j40.c
> +++ b/drivers/net/ieee802154/mrf24j40.c
> @@ -618,10 +618,10 @@ static int mrf24j40_probe(struct spi_device *spi)
>
> printk(KERN_INFO "mrf24j40: probe(). IRQ: %d\n", spi->irq);
>
> - devrec = kzalloc(sizeof(struct mrf24j40), GFP_KERNEL);
> + devrec = devm_kzalloc(&spi->dev, sizeof(struct mrf24j40), GFP_KERNEL);
> if (!devrec)
> goto err_devrec;
> - devrec->buf = kzalloc(3, GFP_KERNEL);
> + devrec->buf = devm_kzalloc(&spi->dev, 3, GFP_KERNEL);
> if (!devrec->buf)
> goto err_buf;
>
> @@ -676,12 +676,13 @@ static int mrf24j40_probe(struct spi_device *spi)
> val &= ~0x3; /* Clear RX mode (normal) */
> write_short_reg(devrec, REG_RXMCR, val);
>
> - ret = request_threaded_irq(spi->irq,
> - NULL,
> - mrf24j40_isr,
> - IRQF_TRIGGER_LOW|IRQF_ONESHOT,
> - dev_name(&spi->dev),
> - devrec);
> + ret = devm_request_threaded_irq(&spi->dev,
> + spi->irq,
> + NULL,
> + mrf24j40_isr,
> + IRQF_TRIGGER_LOW|IRQF_ONESHOT,
> + dev_name(&spi->dev),
> + devrec);
>
when using devm_* it's also freed when the probe function failed, so you
can also remove the error path handling.
err_alloc_dev:
kfree(devrec->buf);
err_buf:
kfree(devrec);
and so on...
- Alex
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-29 8:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-29 6:05 [PATCH net-next v2] mrf24j40: add managed API's provided by device layer Varka Bhadram
2014-05-29 8:50 ` [Linux-zigbee-devel] " Alexander Aring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.