* [PATCH v2 1/2] [media] coda: Return the real error on platform_get_irq()
@ 2014-06-04 18:46 Fabio Estevam
2014-06-04 18:46 ` [PATCH v2 2/2] [media] coda: Propagate the correct error on devm_request_threaded_irq() Fabio Estevam
0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2014-06-04 18:46 UTC (permalink / raw)
To: m.chehab; +Cc: p.zabel, linux-media, Fabio Estevam
From: Fabio Estevam <fabio.estevam@freescale.com>
No need to return a 'fake' return value on platform_get_irq() failure.
Propagate the real error instead.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
---
Changes since v1:
- None. Only rebased against latest tree
drivers/media/platform/coda.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/coda.c b/drivers/media/platform/coda.c
index b178379..32b3b6d 100644
--- a/drivers/media/platform/coda.c
+++ b/drivers/media/platform/coda.c
@@ -3229,7 +3229,7 @@ static int coda_probe(struct platform_device *pdev)
irq = platform_get_irq(pdev, 0);
if (irq < 0) {
dev_err(&pdev->dev, "failed to get irq resource\n");
- return -ENOENT;
+ return irq;
}
if (devm_request_threaded_irq(&pdev->dev, irq, NULL, coda_irq_handler,
--
1.8.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH v2 2/2] [media] coda: Propagate the correct error on devm_request_threaded_irq()
2014-06-04 18:46 [PATCH v2 1/2] [media] coda: Return the real error on platform_get_irq() Fabio Estevam
@ 2014-06-04 18:46 ` Fabio Estevam
0 siblings, 0 replies; 2+ messages in thread
From: Fabio Estevam @ 2014-06-04 18:46 UTC (permalink / raw)
To: m.chehab; +Cc: p.zabel, linux-media, Fabio Estevam
From: Fabio Estevam <fabio.estevam@freescale.com>
If devm_request_threaded_irq() fails, we should better propagate the real error.
Also, print out the error code in the dev_err message.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
---
Changes since v1:
- None. Only rebased against latest tree
drivers/media/platform/coda.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/media/platform/coda.c b/drivers/media/platform/coda.c
index 32b3b6d..661bbe6 100644
--- a/drivers/media/platform/coda.c
+++ b/drivers/media/platform/coda.c
@@ -3232,10 +3232,11 @@ static int coda_probe(struct platform_device *pdev)
return irq;
}
- if (devm_request_threaded_irq(&pdev->dev, irq, NULL, coda_irq_handler,
- IRQF_ONESHOT, dev_name(&pdev->dev), dev) < 0) {
- dev_err(&pdev->dev, "failed to request irq\n");
- return -ENOENT;
+ ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, coda_irq_handler,
+ IRQF_ONESHOT, dev_name(&pdev->dev), dev);
+ if (ret < 0) {
+ dev_err(&pdev->dev, "failed to request irq: %d\n", ret);
+ return ret;
}
/* Get IRAM pool from device tree or platform data */
--
1.8.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-04 18:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-04 18:46 [PATCH v2 1/2] [media] coda: Return the real error on platform_get_irq() Fabio Estevam
2014-06-04 18:46 ` [PATCH v2 2/2] [media] coda: Propagate the correct error on devm_request_threaded_irq() Fabio Estevam
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.