All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/libcec: fix missing libraries from rpi-userland
@ 2014-06-04 21:30 Yann E. MORIN
  2014-06-08 12:39 ` Maxime Hadjinlian
  0 siblings, 1 reply; 2+ messages in thread
From: Yann E. MORIN @ 2014-06-04 21:30 UTC (permalink / raw)
  To: buildroot

From: "Yann E. MORIN" <yann.morin.1998@free.fr>

When rpi-userland libraries are built as shared-objects, not all needed
libraries are passed in the LD_FLAGS, leading to failure at linkage.

To avoid this issue, set the LIBS variable content in accordance with
INCLUDES variable value.

This is needed because libcec does not use pkg-config to look for the
ldflags needed for -lbcm_host, even though bcm_host provides a .pc
file (even a correct one!)

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Samuel Martin <s.martin49@gmail.com>
---
 package/libcec/libcec.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/libcec/libcec.mk b/package/libcec/libcec.mk
index 0aabb06..ad919fc 100644
--- a/package/libcec/libcec.mk
+++ b/package/libcec/libcec.mk
@@ -26,6 +26,7 @@ ifeq ($(BR2_PACKAGE_RPI_USERLAND),y)
 LIBCEC_CONF_OPT = --enable-rpi \
    --with-rpi-include-path=$(STAGING_DIR)/usr/include
 LIBCEC_DEPENDENCIES += rpi-userland
+LIBCEC_CONF_ENV += LIBS="-lvcos -lvchostif"
 else
 LIBCEC_CONF_OPT = --disable-rpi
 endif
-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH] package/libcec: fix missing libraries from rpi-userland
  2014-06-04 21:30 [Buildroot] [PATCH] package/libcec: fix missing libraries from rpi-userland Yann E. MORIN
@ 2014-06-08 12:39 ` Maxime Hadjinlian
  0 siblings, 0 replies; 2+ messages in thread
From: Maxime Hadjinlian @ 2014-06-08 12:39 UTC (permalink / raw)
  To: buildroot

Hi all,

I could not test if it works or not since I don't have a compatible
hardware, but it builds.

Tested-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>

On Wed, Jun 4, 2014 at 11:30 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> When rpi-userland libraries are built as shared-objects, not all needed
> libraries are passed in the LD_FLAGS, leading to failure at linkage.
>
> To avoid this issue, set the LIBS variable content in accordance with
> INCLUDES variable value.
>
> This is needed because libcec does not use pkg-config to look for the
> ldflags needed for -lbcm_host, even though bcm_host provides a .pc
> file (even a correct one!)
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Samuel Martin <s.martin49@gmail.com>
> ---
>  package/libcec/libcec.mk | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/package/libcec/libcec.mk b/package/libcec/libcec.mk
> index 0aabb06..ad919fc 100644
> --- a/package/libcec/libcec.mk
> +++ b/package/libcec/libcec.mk
> @@ -26,6 +26,7 @@ ifeq ($(BR2_PACKAGE_RPI_USERLAND),y)
>  LIBCEC_CONF_OPT = --enable-rpi \
>     --with-rpi-include-path=$(STAGING_DIR)/usr/include
>  LIBCEC_DEPENDENCIES += rpi-userland
> +LIBCEC_CONF_ENV += LIBS="-lvcos -lvchostif"
>  else
>  LIBCEC_CONF_OPT = --disable-rpi
>  endif
> --
> 1.8.3.2
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-06-08 12:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-04 21:30 [Buildroot] [PATCH] package/libcec: fix missing libraries from rpi-userland Yann E. MORIN
2014-06-08 12:39 ` Maxime Hadjinlian

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.