All of lore.kernel.org
 help / color / mirror / Atom feed
* [RFC] android/gatt: Fix error status override
@ 2014-06-09  8:26 Andrei Emeltchenko
  2014-06-12  9:55 ` Szymon Janc
  0 siblings, 1 reply; 2+ messages in thread
From: Andrei Emeltchenko @ 2014-06-09  8:26 UTC (permalink / raw)
  To: linux-bluetooth

From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>

---
 android/gatt.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/android/gatt.c b/android/gatt.c
index 3fd88fa..7cf70a9 100644
--- a/android/gatt.c
+++ b/android/gatt.c
@@ -1950,8 +1950,10 @@ static void handle_client_search_service(const void *buf, uint16_t len)
 		if (s) {
 			send_client_primary_notify(s, INT_TO_PTR(conn->id));
 		} else {
-			if (!search_dev_for_srvc(conn, &uuid))
+			if (!search_dev_for_srvc(conn, &uuid)) {
 				status = HAL_STATUS_FAILED;
+				goto reply;
+			}
 
 			status = HAL_STATUS_SUCCESS;
 			goto reply;
-- 
1.8.3.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [RFC] android/gatt: Fix error status override
  2014-06-09  8:26 [RFC] android/gatt: Fix error status override Andrei Emeltchenko
@ 2014-06-12  9:55 ` Szymon Janc
  0 siblings, 0 replies; 2+ messages in thread
From: Szymon Janc @ 2014-06-12  9:55 UTC (permalink / raw)
  To: Andrei Emeltchenko; +Cc: linux-bluetooth

Hi Andrei,

On Monday 09 of June 2014 11:26:16 Andrei Emeltchenko wrote:
> From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> 
> ---
>  android/gatt.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/android/gatt.c b/android/gatt.c
> index 3fd88fa..7cf70a9 100644
> --- a/android/gatt.c
> +++ b/android/gatt.c
> @@ -1950,8 +1950,10 @@ static void handle_client_search_service(const void *buf, uint16_t len)
>  		if (s) {
>  			send_client_primary_notify(s, INT_TO_PTR(conn->id));
>  		} else {
> -			if (!search_dev_for_srvc(conn, &uuid))
> +			if (!search_dev_for_srvc(conn, &uuid)) {
>  				status = HAL_STATUS_FAILED;
> +				goto reply;
> +			}
>  
>  			status = HAL_STATUS_SUCCESS;
>  			goto reply;
> 

Patch applied, thanks.

-- 
Best regards, 
Szymon Janc

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-06-12  9:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-09  8:26 [RFC] android/gatt: Fix error status override Andrei Emeltchenko
2014-06-12  9:55 ` Szymon Janc

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.