All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] embestmx6boards: Fix CONFIG_CONSOLE_DEV
@ 2014-06-09 16:35 Fabio Estevam
  2014-06-09 17:43 ` Iain Paton
  2014-06-17 14:36 ` Stefano Babic
  0 siblings, 2 replies; 3+ messages in thread
From: Fabio Estevam @ 2014-06-09 16:35 UTC (permalink / raw)
  To: u-boot

mars and riot boards use UART2 as console, so CONFIG_CONSOLE_DEV should point
to 'ttymxc1' instead.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
Untested as I don't have access to this board.

 include/configs/embestmx6boards.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/configs/embestmx6boards.h b/include/configs/embestmx6boards.h
index eb91c44..1d5fde6 100644
--- a/include/configs/embestmx6boards.h
+++ b/include/configs/embestmx6boards.h
@@ -20,7 +20,7 @@
 #include <linux/sizes.h>
 
 #define CONFIG_MXC_UART_BASE		UART2_BASE
-#define CONFIG_CONSOLE_DEV		"ttymxc0"
+#define CONFIG_CONSOLE_DEV		"ttymxc1"
 #define CONFIG_MMCROOT			"/dev/mmcblk1p2"
 
 #define PHYS_SDRAM_SIZE		(1u * 1024 * 1024 * 1024)
-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] embestmx6boards: Fix CONFIG_CONSOLE_DEV
  2014-06-09 16:35 [U-Boot] [PATCH] embestmx6boards: Fix CONFIG_CONSOLE_DEV Fabio Estevam
@ 2014-06-09 17:43 ` Iain Paton
  2014-06-17 14:36 ` Stefano Babic
  1 sibling, 0 replies; 3+ messages in thread
From: Iain Paton @ 2014-06-09 17:43 UTC (permalink / raw)
  To: u-boot

On 09/06/14 17:35, Fabio Estevam wrote:
> mars and riot boards use UART2 as console, so CONFIG_CONSOLE_DEV should point
> to 'ttymxc1' instead.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> Untested as I don't have access to this board.
> 
>  include/configs/embestmx6boards.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/configs/embestmx6boards.h b/include/configs/embestmx6boards.h
> index eb91c44..1d5fde6 100644
> --- a/include/configs/embestmx6boards.h
> +++ b/include/configs/embestmx6boards.h
> @@ -20,7 +20,7 @@
>  #include <linux/sizes.h>
>  
>  #define CONFIG_MXC_UART_BASE		UART2_BASE
> -#define CONFIG_CONSOLE_DEV		"ttymxc0"
> +#define CONFIG_CONSOLE_DEV		"ttymxc1"
>  #define CONFIG_MMCROOT			"/dev/mmcblk1p2"
>  
>  #define PHYS_SDRAM_SIZE		(1u * 1024 * 1024 * 1024)
> 

Tested-by: Iain Paton <ipaton0@gmail.com>

I expect that, like me, most people will never see a problem with this as 
it's not used to define the u-Boot console.
For the kernel console, most people are likely to simply use boot.scr to 
override it or completely replace bootcmd with one that doesn't force 
booting from emmc.

Either way, changing this is the correct thing to do.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] embestmx6boards: Fix CONFIG_CONSOLE_DEV
  2014-06-09 16:35 [U-Boot] [PATCH] embestmx6boards: Fix CONFIG_CONSOLE_DEV Fabio Estevam
  2014-06-09 17:43 ` Iain Paton
@ 2014-06-17 14:36 ` Stefano Babic
  1 sibling, 0 replies; 3+ messages in thread
From: Stefano Babic @ 2014-06-17 14:36 UTC (permalink / raw)
  To: u-boot

Hi Fabio,

On 09/06/2014 18:35, Fabio Estevam wrote:
> mars and riot boards use UART2 as console, so CONFIG_CONSOLE_DEV should point
> to 'ttymxc1' instead.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic


-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-06-17 14:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-09 16:35 [U-Boot] [PATCH] embestmx6boards: Fix CONFIG_CONSOLE_DEV Fabio Estevam
2014-06-09 17:43 ` Iain Paton
2014-06-17 14:36 ` Stefano Babic

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.