* [PATCH -next] sysctl: Remove now unused typedef ctl_table
@ 2014-06-09 17:51 Joe Perches
2014-06-09 19:01 ` [PATCH -next] proc_sysctl: convert use of typedef ctl_table to struct ctl_table Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: Joe Perches @ 2014-06-09 17:51 UTC (permalink / raw)
To: Andrew Morton; +Cc: LKML
All the uses have been removed so remove the typedef.
Signed-off-by: Joe Perches <joe@perches.com>
---
include/linux/sysctl.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/linux/sysctl.h b/include/linux/sysctl.h
index 14a8ff2..b7361f8 100644
--- a/include/linux/sysctl.h
+++ b/include/linux/sysctl.h
@@ -34,8 +34,6 @@ struct ctl_table_root;
struct ctl_table_header;
struct ctl_dir;
-typedef struct ctl_table ctl_table;
-
typedef int proc_handler (struct ctl_table *ctl, int write,
void __user *buffer, size_t *lenp, loff_t *ppos);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH -next] proc_sysctl: convert use of typedef ctl_table to struct ctl_table
2014-06-09 17:51 [PATCH -next] sysctl: Remove now unused typedef ctl_table Joe Perches
@ 2014-06-09 19:01 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2014-06-09 19:01 UTC (permalink / raw)
To: Andrew Morton; +Cc: LKML
This typedef is unnecessary and should just be removed.
Remove the last actual use of typedef ctl_table.
Signed-off-by: Joe Perches <joe@perches.com>
---
On Mon, 2014-06-09 at 10:51 -0700, Joe Perches wrote:
> All the uses have been removed so remove the typedef.
Not so fast buckwheat.
I was showing off my obviously insufficient grep skills...
There's still this one.
These patches need reordering so that this one is first...
fs/proc/proc_sysctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/proc/proc_sysctl.c b/fs/proc/proc_sysctl.c
index 7129046..f92d5dd 100644
--- a/fs/proc/proc_sysctl.c
+++ b/fs/proc/proc_sysctl.c
@@ -632,7 +632,7 @@ out:
return ret;
}
-static int scan(struct ctl_table_header *head, ctl_table *table,
+static int scan(struct ctl_table_header *head, struct ctl_table *table,
unsigned long *pos, struct file *file,
struct dir_context *ctx)
{
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-09 19:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-09 17:51 [PATCH -next] sysctl: Remove now unused typedef ctl_table Joe Perches
2014-06-09 19:01 ` [PATCH -next] proc_sysctl: convert use of typedef ctl_table to struct ctl_table Joe Perches
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.