All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] graphs/depends: do not draw transitive dependencis by default
@ 2014-06-09 22:28 Yann E. MORIN
  2014-06-13 12:35 ` Peter Korsgaard
  0 siblings, 1 reply; 2+ messages in thread
From: Yann E. MORIN @ 2014-06-09 22:28 UTC (permalink / raw)
  To: buildroot

From: "Yann E. MORIN" <yann.morin.1998@free.fr>

The transitive dependencies make the graphs barely readable for large
configs, with a large number of packages.

So, just switch to not drawing the transitive dependencies by default.

By popular demand... ;-)

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc; Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 docs/manual/common-usage.txt  | 2 +-
 support/scripts/graph-depends | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/docs/manual/common-usage.txt b/docs/manual/common-usage.txt
index eb83990..71fe5a3 100644
--- a/docs/manual/common-usage.txt
+++ b/docs/manual/common-usage.txt
@@ -207,7 +207,7 @@ The +graph-depends+ behaviour can be controlled by setting options in the
   default, +0+, means no limit.
 
 * +--transitive+, +--no-transitive+, to draw (or not) the transitive
-  dependencies. The default is to draw transitive dependencies.
+  dependencies. The default is not to draw transitive dependencies.
 
 * +--colours R,T,H+, the comma-separated list of colours to draw the
   root package (+R+), the target packages (+T+) and the host packages
diff --git a/support/scripts/graph-depends b/support/scripts/graph-depends
index 42a42a8..29f271a 100755
--- a/support/scripts/graph-depends
+++ b/support/scripts/graph-depends
@@ -48,7 +48,7 @@ parser.add_argument("--colours", "-c", metavar="COLOR_LIST", dest="colours",
                        + " packages, and the host packages, in this order." \
                        + " Defaults to: 'lightblue,grey,gainsboro'")
 parser.add_argument("--transitive", dest="transitive", action='store_true',
-                    default=True)
+                    default=False)
 parser.add_argument("--no-transitive", dest="transitive", action='store_false',
                     help="Draw (do not draw) transitive dependencies")
 args = parser.parse_args()
-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH] graphs/depends: do not draw transitive dependencis by default
  2014-06-09 22:28 [Buildroot] [PATCH] graphs/depends: do not draw transitive dependencis by default Yann E. MORIN
@ 2014-06-13 12:35 ` Peter Korsgaard
  0 siblings, 0 replies; 2+ messages in thread
From: Peter Korsgaard @ 2014-06-13 12:35 UTC (permalink / raw)
  To: buildroot

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > From: "Yann E. MORIN" <yann.morin.1998@free.fr>
 > The transitive dependencies make the graphs barely readable for large
 > configs, with a large number of packages.

 > So, just switch to not drawing the transitive dependencies by default.

 > By popular demand... ;-)

 > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
 > Cc; Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
 > ---
 >  docs/manual/common-usage.txt  | 2 +-
 >  support/scripts/graph-depends | 2 +-
 >  2 files changed, 2 insertions(+), 2 deletions(-)

 > diff --git a/docs/manual/common-usage.txt b/docs/manual/common-usage.txt
 > index eb83990..71fe5a3 100644
 > --- a/docs/manual/common-usage.txt
 > +++ b/docs/manual/common-usage.txt
 > @@ -207,7 +207,7 @@ The +graph-depends+ behaviour can be controlled by setting options in the
 >    default, +0+, means no limit.
 
 >  * +--transitive+, +--no-transitive+, to draw (or not) the transitive
 > -  dependencies. The default is to draw transitive dependencies.
 > +  dependencies. The default is not to draw transitive dependencies.

I'm not a native speaker, but I think it should be '.. is to not draw'.

Committed with that (and the commit title) fixed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-06-13 12:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-09 22:28 [Buildroot] [PATCH] graphs/depends: do not draw transitive dependencis by default Yann E. MORIN
2014-06-13 12:35 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.