All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	Joe Konno <joe.konno@intel.com>,
	Paulo Zanoni <paulo.r.zanoni@intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: [PATCH] drm/i915: Force full PSR setup during crtc enable.
Date: Tue, 10 Jun 2014 03:49:57 -0700	[thread overview]
Message-ID: <1402397397-914-1-git-send-email-rodrigo.vivi@intel.com> (raw)
In-Reply-To: <20140610152457.GY5821@phenom.ffwll.local>

Some registers set during setup might not be persistent after suspend/resume,
and also on crtc off/on cycles.

This was causing bugs for some people that was unable to get PSR entry state
after suspend/resume cycle.

v2: Adding some comments and better commit message explaining why this is
needed. (by Paulo)
v3: Moving psr.setup_done reset to crtc_enable because same issues might apply
also on crtc off/on cycle. (by Daniel)

Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Joe Konno <joe.konno@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/i915/intel_display.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index b5cbb28..077ab0e 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -3938,6 +3938,10 @@ static void intel_crtc_enable_planes(struct drm_crtc *crtc)
 
 	mutex_lock(&dev->struct_mutex);
 	intel_update_fbc(dev);
+	/* Forcing a full init sequence here to make sure all
+	* registers are properly set. Some might not be persistent after
+	* crtc on/off cycle. */
+	dev_priv->psr.setup_done = false;
 	intel_edp_psr_update(dev);
 	mutex_unlock(&dev->struct_mutex);
 }
-- 
1.9.3

  reply	other threads:[~2014-06-10 17:48 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-16  0:12 [PATCH 00/11] HSW/BDW PSR Rodrigo Vivi
2014-05-16  0:13 ` [PATCH 01/11] drm/i915: move psr_setup_done to psr struct Rodrigo Vivi
2014-05-22 17:50   ` Paulo Zanoni
2014-05-23 20:45     ` [PATCH] " Rodrigo Vivi
2014-05-26  7:44       ` Daniel Vetter
2014-05-16  0:13 ` [PATCH 02/11] drm/i915: Update PSR on resume Rodrigo Vivi
2014-05-23 20:51   ` Paulo Zanoni
2014-05-27 23:50     ` [PATCH] " Rodrigo Vivi
2014-05-28 12:57       ` Daniel Vetter
2014-06-04 19:17         ` Rodrigo Vivi
2014-06-05  9:15           ` Daniel Vetter
2014-06-10 15:11             ` Rodrigo Vivi
2014-06-10 15:24               ` Daniel Vetter
2014-06-10 10:49                 ` Rodrigo Vivi [this message]
2014-06-11  9:42                   ` [PATCH] drm/i915: Force full PSR setup during crtc enable Daniel Vetter
2014-08-08 17:19                 ` [PATCH] drm/i915: Update PSR on resume Rodrigo Vivi
2014-08-09  7:40                   ` Daniel Vetter
2014-08-11 16:57                     ` Rodrigo Vivi
2014-08-11 17:31                       ` Daniel Vetter
2014-05-16  0:13 ` [PATCH 03/11] drm/i915: Use HAS_PSR to avoid unecessary interactions Rodrigo Vivi
2014-06-03  9:26   ` Vijay Purushothaman
2014-05-16  0:13 ` [PATCH 04/11] drm/i915: Don't let update_psr function actually enable PSR Rodrigo Vivi
2014-06-03 11:04   ` Vijay Purushothaman
2014-05-16  0:13 ` [PATCH 05/11] drm/i915: Do not try to enable PSR when Panel doesn't suport it Rodrigo Vivi
2014-05-16 10:21   ` Chris Wilson
2014-05-16 16:39     ` Rodrigo Vivi
2014-05-16  0:13 ` [PATCH 06/11] drm/i915: Force PSR exit by inactivating it Rodrigo Vivi
2014-05-16 10:23   ` Chris Wilson
2014-05-16 16:42     ` Rodrigo Vivi
2014-06-03 11:10       ` Vijay Purushothaman
2014-05-16 10:25   ` Chris Wilson
2014-05-16  0:13 ` [PATCH 07/11] drm/i915: BDW PSR: Add single frame update support Rodrigo Vivi
2014-05-16  0:13 ` [PATCH 08/11] drm/i915: BDW PSR: Remove limitations that aren't valid for BDW Rodrigo Vivi
2014-06-03 11:20   ` Vijay Purushothaman
2014-05-16  0:13 ` [PATCH 09/11] drm/i915: BDW PSR: Remove DDIA limitation for Broadwell Rodrigo Vivi
2014-05-16  0:13 ` [PATCH 10/11] drm/i915: Improve PSR debugfs status Rodrigo Vivi
2014-06-02 18:24   ` Vijay Purushothaman
2014-06-03  7:40     ` Daniel Vetter
2014-06-03 11:22       ` Vijay Purushothaman
2014-05-16  0:13 ` [PATCH 11/11] drm/i915: PSR HSW: update after enabling sprite Rodrigo Vivi
2014-06-03 11:25   ` Vijay Purushothaman
2014-06-12 10:12 ` [PATCH 00/11] HSW/BDW PSR Vijay Purushothaman
2014-06-10 10:47 [PATCH] drm/i915: Force full PSR setup during crtc enable Rodrigo Vivi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1402397397-914-1-git-send-email-rodrigo.vivi@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=joe.konno@intel.com \
    --cc=paulo.r.zanoni@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.