All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@gmail.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH] drm/i915: Update PSR on resume.
Date: Mon, 11 Aug 2014 09:57:12 -0700	[thread overview]
Message-ID: <CABVU7+tcEbsR1pYqTd+5b3A6LE5R0eEngh2mwOS8QGSMu7osLA@mail.gmail.com> (raw)
In-Reply-To: <CAKMK7uH7K3H76Bq=jUjgmA3Sir7zELKAuUCzLGmPxx7iS8Ttuw@mail.gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 1529 bytes --]

Well, this fix the issue Linus faced.

Actually the issue I was aware of and trying to fix with this patch for a
long time was reported by chromeos guys saying the psr wasn't propperly
working after suspend/resume. They got the screen back but never got psr
back again.

The original patch fix suspend/resume issues with psr and I decided to keep
the same and subject for reference of what the problem this fixes and what
was the patch history, but changed the place for the full setup to
crtc_enable per your recommendation.

Thanks,
Rodrigo.



On Sat, Aug 9, 2014 at 12:40 AM, Daniel Vetter <daniel.vetter@ffwll.ch>
wrote:

> On Fri, Aug 8, 2014 at 7:19 PM, Rodrigo Vivi <rodrigo.vivi@intel.com>
> wrote:
> > From: Rodrigo Vivi <rodrigo.vivi@gmail.com>
> >
> > Some registers set during setup might not be persistent after
> suspend/resume.
> > This was causing bugs for some people that was unable to get PSR entry
> state
> > after resume cycle.
> >
> > v2: Adding some comments and better commit message explaining why this
> is needed.
> > v3: Getting back old setup_done variable and move from resume to
> crtc_enable
> >     as Daniel requested.
> >
> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
> I'm confused ... whats the use of this? Afaict that's exactly what the
> code currently does.
> -Daniel
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> +41 (0) 79 365 57 48 - http://blog.ffwll.ch
>



-- 
Rodrigo Vivi
Blog: http://blog.vivi.eng.br

[-- Attachment #1.2: Type: text/html, Size: 2555 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2014-08-11 16:57 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-16  0:12 [PATCH 00/11] HSW/BDW PSR Rodrigo Vivi
2014-05-16  0:13 ` [PATCH 01/11] drm/i915: move psr_setup_done to psr struct Rodrigo Vivi
2014-05-22 17:50   ` Paulo Zanoni
2014-05-23 20:45     ` [PATCH] " Rodrigo Vivi
2014-05-26  7:44       ` Daniel Vetter
2014-05-16  0:13 ` [PATCH 02/11] drm/i915: Update PSR on resume Rodrigo Vivi
2014-05-23 20:51   ` Paulo Zanoni
2014-05-27 23:50     ` [PATCH] " Rodrigo Vivi
2014-05-28 12:57       ` Daniel Vetter
2014-06-04 19:17         ` Rodrigo Vivi
2014-06-05  9:15           ` Daniel Vetter
2014-06-10 15:11             ` Rodrigo Vivi
2014-06-10 15:24               ` Daniel Vetter
2014-06-10 10:49                 ` [PATCH] drm/i915: Force full PSR setup during crtc enable Rodrigo Vivi
2014-06-11  9:42                   ` Daniel Vetter
2014-08-08 17:19                 ` [PATCH] drm/i915: Update PSR on resume Rodrigo Vivi
2014-08-09  7:40                   ` Daniel Vetter
2014-08-11 16:57                     ` Rodrigo Vivi [this message]
2014-08-11 17:31                       ` Daniel Vetter
2014-05-16  0:13 ` [PATCH 03/11] drm/i915: Use HAS_PSR to avoid unecessary interactions Rodrigo Vivi
2014-06-03  9:26   ` Vijay Purushothaman
2014-05-16  0:13 ` [PATCH 04/11] drm/i915: Don't let update_psr function actually enable PSR Rodrigo Vivi
2014-06-03 11:04   ` Vijay Purushothaman
2014-05-16  0:13 ` [PATCH 05/11] drm/i915: Do not try to enable PSR when Panel doesn't suport it Rodrigo Vivi
2014-05-16 10:21   ` Chris Wilson
2014-05-16 16:39     ` Rodrigo Vivi
2014-05-16  0:13 ` [PATCH 06/11] drm/i915: Force PSR exit by inactivating it Rodrigo Vivi
2014-05-16 10:23   ` Chris Wilson
2014-05-16 16:42     ` Rodrigo Vivi
2014-06-03 11:10       ` Vijay Purushothaman
2014-05-16 10:25   ` Chris Wilson
2014-05-16  0:13 ` [PATCH 07/11] drm/i915: BDW PSR: Add single frame update support Rodrigo Vivi
2014-05-16  0:13 ` [PATCH 08/11] drm/i915: BDW PSR: Remove limitations that aren't valid for BDW Rodrigo Vivi
2014-06-03 11:20   ` Vijay Purushothaman
2014-05-16  0:13 ` [PATCH 09/11] drm/i915: BDW PSR: Remove DDIA limitation for Broadwell Rodrigo Vivi
2014-05-16  0:13 ` [PATCH 10/11] drm/i915: Improve PSR debugfs status Rodrigo Vivi
2014-06-02 18:24   ` Vijay Purushothaman
2014-06-03  7:40     ` Daniel Vetter
2014-06-03 11:22       ` Vijay Purushothaman
2014-05-16  0:13 ` [PATCH 11/11] drm/i915: PSR HSW: update after enabling sprite Rodrigo Vivi
2014-06-03 11:25   ` Vijay Purushothaman
2014-06-12 10:12 ` [PATCH 00/11] HSW/BDW PSR Vijay Purushothaman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABVU7+tcEbsR1pYqTd+5b3A6LE5R0eEngh2mwOS8QGSMu7osLA@mail.gmail.com \
    --to=rodrigo.vivi@gmail.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.