* [PATCH] staging: lustre: Use %ld to format long
@ 2014-06-11 17:00 Geert Uytterhoeven
2014-06-16 6:59 ` Geert Uytterhoeven
0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2014-06-11 17:00 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: devel, linux-kernel, Geert Uytterhoeven
drivers/staging/lustre/lustre/llite/rw26.c: In function ‘ll_direct_IO_26’:
drivers/staging/lustre/lustre/llite/rw26.c:388: warning: format ‘%zd’ expects type ‘signed size_t’, but argument 6 has type ‘long int’
drivers/staging/lustre/lustre/llite/rw26.c:388: warning: format ‘%zd’ expects type ‘signed size_t’, but argument 10 has type ‘long int’
Introduced by commit b41a1fe067c34b40736860458b9d62b2139471d5 ("staging:
lustre: Use %zd to format ssize_t"), which was part of a series to fix
issues in -next. However, the commits introducing the issues never made it
to mainline.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/staging/lustre/lustre/llite/rw26.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/llite/rw26.c b/drivers/staging/lustre/lustre/llite/rw26.c
index 55ca8d3c3e46..5b944d3fb80c 100644
--- a/drivers/staging/lustre/lustre/llite/rw26.c
+++ b/drivers/staging/lustre/lustre/llite/rw26.c
@@ -386,7 +386,7 @@ static ssize_t ll_direct_IO_26(int rw, struct kiocb *iocb,
return -EINVAL;
CDEBUG(D_VFSTRACE,
- "VFS Op:inode=%lu/%u(%p), size=%zd (max %lu), offset=%lld=%llx, pages %zd (max %lu)\n",
+ "VFS Op:inode=%lu/%u(%p), size=%ld (max %lu), offset=%lld=%llx, pages %ld (max %lu)\n",
inode->i_ino, inode->i_generation, inode, count, MAX_DIO_SIZE,
file_offset, file_offset, count >> PAGE_CACHE_SHIFT,
MAX_DIO_SIZE >> PAGE_CACHE_SHIFT);
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: lustre: Use %ld to format long
2014-06-11 17:00 [PATCH] staging: lustre: Use %ld to format long Geert Uytterhoeven
@ 2014-06-16 6:59 ` Geert Uytterhoeven
2014-06-18 22:31 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2014-06-16 6:59 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: driverdevel, linux-kernel, Geert Uytterhoeven
Hi Greg,
On Wed, Jun 11, 2014 at 7:00 PM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> drivers/staging/lustre/lustre/llite/rw26.c: In function ‘ll_direct_IO_26’:
> drivers/staging/lustre/lustre/llite/rw26.c:388: warning: format ‘%zd’ expects type ‘signed size_t’, but argument 6 has type ‘long int’
> drivers/staging/lustre/lustre/llite/rw26.c:388: warning: format ‘%zd’ expects type ‘signed size_t’, but argument 10 has type ‘long int’
>
> Introduced by commit b41a1fe067c34b40736860458b9d62b2139471d5 ("staging:
> lustre: Use %zd to format ssize_t"), which was part of a series to fix
> issues in -next. However, the commits introducing the issues never made it
> to mainline.
They have now, so please drop this patch.
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> drivers/staging/lustre/lustre/llite/rw26.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lustre/llite/rw26.c b/drivers/staging/lustre/lustre/llite/rw26.c
> index 55ca8d3c3e46..5b944d3fb80c 100644
> --- a/drivers/staging/lustre/lustre/llite/rw26.c
> +++ b/drivers/staging/lustre/lustre/llite/rw26.c
> @@ -386,7 +386,7 @@ static ssize_t ll_direct_IO_26(int rw, struct kiocb *iocb,
> return -EINVAL;
>
> CDEBUG(D_VFSTRACE,
> - "VFS Op:inode=%lu/%u(%p), size=%zd (max %lu), offset=%lld=%llx, pages %zd (max %lu)\n",
> + "VFS Op:inode=%lu/%u(%p), size=%ld (max %lu), offset=%lld=%llx, pages %ld (max %lu)\n",
> inode->i_ino, inode->i_generation, inode, count, MAX_DIO_SIZE,
> file_offset, file_offset, count >> PAGE_CACHE_SHIFT,
> MAX_DIO_SIZE >> PAGE_CACHE_SHIFT);
> --
> 1.9.1
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: lustre: Use %ld to format long
2014-06-16 6:59 ` Geert Uytterhoeven
@ 2014-06-18 22:31 ` Greg Kroah-Hartman
0 siblings, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2014-06-18 22:31 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: driverdevel, linux-kernel
On Mon, Jun 16, 2014 at 08:59:45AM +0200, Geert Uytterhoeven wrote:
> Hi Greg,
>
> On Wed, Jun 11, 2014 at 7:00 PM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
> > drivers/staging/lustre/lustre/llite/rw26.c: In function ‘ll_direct_IO_26’:
> > drivers/staging/lustre/lustre/llite/rw26.c:388: warning: format ‘%zd’ expects type ‘signed size_t’, but argument 6 has type ‘long int’
> > drivers/staging/lustre/lustre/llite/rw26.c:388: warning: format ‘%zd’ expects type ‘signed size_t’, but argument 10 has type ‘long int’
> >
> > Introduced by commit b41a1fe067c34b40736860458b9d62b2139471d5 ("staging:
> > lustre: Use %zd to format ssize_t"), which was part of a series to fix
> > issues in -next. However, the commits introducing the issues never made it
> > to mainline.
>
> They have now, so please drop this patch.
Now dropped :)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-06-18 22:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-11 17:00 [PATCH] staging: lustre: Use %ld to format long Geert Uytterhoeven
2014-06-16 6:59 ` Geert Uytterhoeven
2014-06-18 22:31 ` Greg Kroah-Hartman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.