All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] block: remove WQ_POWER_EFFICIENT from kblockd
@ 2014-06-11 21:43 Matias Bjørling
  0 siblings, 0 replies; only message in thread
From: Matias Bjørling @ 2014-06-11 21:43 UTC (permalink / raw)
  To: axboe, linux-kernel; +Cc: Matias Bjørling

blk-mq issues async requests through kblockd. To issue a work request on a
specific CPU, kblockd_schedule_delayed_work_on is used. However, the CPU can
change if the machine is a laptop or similar. In that case its
workqueue.power_efficient parameter is set to true. That enables kblockd to be
WQ_UNBOUND by default. Leaving blk-mq to bounce its hw ctx queues between CPUs.

Remove the kblockd WQ_POWER_EFFICIENT flag to prevent this behavior.

Signed-off-by: Matias Bjørling <m@bjorling.me>
---
 block/blk-core.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/block/blk-core.c b/block/blk-core.c
index f6f6b9a..6f8dba1 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -3312,8 +3312,7 @@ int __init blk_dev_init(void)
 
 	/* used for unplugging and affects IO latency/throughput - HIGHPRI */
 	kblockd_workqueue = alloc_workqueue("kblockd",
-					    WQ_MEM_RECLAIM | WQ_HIGHPRI |
-					    WQ_POWER_EFFICIENT, 0);
+					    WQ_MEM_RECLAIM | WQ_HIGHPRI, 0);
 	if (!kblockd_workqueue)
 		panic("Failed to create kblockd\n");
 
-- 
1.9.1


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2014-06-11 21:44 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-11 21:43 [PATCH] block: remove WQ_POWER_EFFICIENT from kblockd Matias Bjørling

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.