[PATCH] i2c: sun6-p2wi: fix erroneous error message

[PATCH] i2c: sun6-p2wi: fix erroneous error message

[Boris BREZILLON]

The variable containing the return value of platform_get_irq is irq not
ret, this means the error code printed in the error message will be false.

Signed-off-by: Boris BREZILLON <boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Reported-by: Fengguang Wu <fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---

Hello Wolfram,

This patch fixes a bug reported by Fengguang's build robot.

I know you've already applied my series to your for-next tree, but let me
know if you want me to squash this patch into the P2WI series and send a v8.

Best Regards,

Boris

 drivers/i2c/busses/i2c-sun6i-p2wi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-sun6i-p2wi.c b/drivers/i2c/busses/i2c-sun6i-p2wi.c
index f1d3e6f..5d2d678 100644
--- a/drivers/i2c/busses/i2c-sun6i-p2wi.c
+++ b/drivers/i2c/busses/i2c-sun6i-p2wi.c
@@ -240,7 +240,7 @@ static int p2wi_probe(struct platform_device *pdev)
 	snprintf(p2wi->adapter.name, sizeof(p2wi->adapter.name), pdev->name);
 	irq = platform_get_irq(pdev, 0);
 	if (irq < 0) {
-		dev_err(dev, "failed to retrieve irq: %d\n", ret);
+		dev_err(dev, "failed to retrieve irq: %d\n", irq);
 		return irq;
 	}
 
-- 
1.8.3.2

[PATCH] i2c: sun6-p2wi: fix erroneous error message

[Boris BREZILLON]

The variable containing the return value of platform_get_irq is irq not
ret, this means the error code printed in the error message will be false.

Signed-off-by: Boris BREZILLON <boris.brezillon@free-electrons.com>
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
---

Hello Wolfram,

This patch fixes a bug reported by Fengguang's build robot.

I know you've already applied my series to your for-next tree, but let me
know if you want me to squash this patch into the P2WI series and send a v8.

Best Regards,

Boris

 drivers/i2c/busses/i2c-sun6i-p2wi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-sun6i-p2wi.c b/drivers/i2c/busses/i2c-sun6i-p2wi.c
index f1d3e6f..5d2d678 100644
--- a/drivers/i2c/busses/i2c-sun6i-p2wi.c
+++ b/drivers/i2c/busses/i2c-sun6i-p2wi.c
@@ -240,7 +240,7 @@ static int p2wi_probe(struct platform_device *pdev)
 	snprintf(p2wi->adapter.name, sizeof(p2wi->adapter.name), pdev->name);
 	irq = platform_get_irq(pdev, 0);
 	if (irq < 0) {
-		dev_err(dev, "failed to retrieve irq: %d\n", ret);
+		dev_err(dev, "failed to retrieve irq: %d\n", irq);
 		return irq;
 	}
 
-- 
1.8.3.2

Re: [PATCH] i2c: sun6-p2wi: fix erroneous error message

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 260 bytes --]

> I know you've already applied my series to your for-next tree, but let me
> know if you want me to squash this patch into the P2WI series and send a v8.

I can't rebase my for-next.

Had it already fixed locally, just forgot to send out due to NMI.

Thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[PATCH] i2c: sun6-p2wi: fix erroneous error message

[Wolfram Sang]

> I know you've already applied my series to your for-next tree, but let me
> know if you want me to squash this patch into the P2WI series and send a v8.

I can't rebase my for-next.

Had it already fixed locally, just forgot to send out due to NMI.

Thanks.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140612/3a5f58ae/attachment.sig>