All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: [PATCH] ALSA: compress: Cancel the optimization of compiler and fix the size of struct for all platform.
  2014-06-12 22:47 [PATCH] ALSA: compress: Cancel the optimization of compiler and fix the size of struct for all platform Wang, Xiaoming
@ 2014-06-12  9:25 ` Vinod Koul
  2014-06-12  9:59   ` Takashi Iwai
  0 siblings, 1 reply; 3+ messages in thread
From: Vinod Koul @ 2014-06-12  9:25 UTC (permalink / raw)
  To: Wang, Xiaoming
  Cc: tiwai, jeeja.kp, dhowells, arnd, tglx, mtk.manpages, paulmck,
	davej, linux-kernel, dongxing.zhang

On Thu, Jun 12, 2014 at 06:47:07PM -0400, Wang, Xiaoming wrote:
> Cancel the optimization of compiler for struct snd_compr_avail
> which size will be 0x1c in 32bit kernel while 0x20 in 64bit
> kernel under the optimizer. That will make compaction between
> 32bit and 64bit. So add packed to fix the size of struct
> snd_compr_avail to 0x1c for all platform.
> 
> Signed-off-by: Zhang Dongxing <dongxing.zhang@intel.com>
> Signed-off-by: xiaoming wang <xiaoming.wang@intel.com>

Acked-by: Vinod Koul <vinod.koul@intel.com>

Takashi, can we cc stable on this, would help fixing in older kernels too

Thanks
-- 
~Vinod
> ---
>  include/uapi/sound/compress_offload.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/include/uapi/sound/compress_offload.h b/include/uapi/sound/compress_offload.h
> index 5759810..21eed48 100644
> --- a/include/uapi/sound/compress_offload.h
> +++ b/include/uapi/sound/compress_offload.h
> @@ -80,7 +80,7 @@ struct snd_compr_tstamp {
>  struct snd_compr_avail {
>  	__u64 avail;
>  	struct snd_compr_tstamp tstamp;
> -};
> +} __attribute__((packed));
>  
>  enum snd_compr_direction {
>  	SND_COMPRESS_PLAYBACK = 0,
> -- 
> 1.7.1
> 

-- 

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] ALSA: compress: Cancel the optimization of compiler and fix the size of struct for all platform.
  2014-06-12  9:25 ` Vinod Koul
@ 2014-06-12  9:59   ` Takashi Iwai
  0 siblings, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2014-06-12  9:59 UTC (permalink / raw)
  To: Vinod Koul
  Cc: Wang, Xiaoming, jeeja.kp, dhowells, arnd, tglx, mtk.manpages,
	paulmck, davej, linux-kernel, dongxing.zhang

At Thu, 12 Jun 2014 14:55:13 +0530,
Vinod Koul wrote:
> 
> On Thu, Jun 12, 2014 at 06:47:07PM -0400, Wang, Xiaoming wrote:
> > Cancel the optimization of compiler for struct snd_compr_avail
> > which size will be 0x1c in 32bit kernel while 0x20 in 64bit
> > kernel under the optimizer. That will make compaction between
> > 32bit and 64bit. So add packed to fix the size of struct
> > snd_compr_avail to 0x1c for all platform.
> > 
> > Signed-off-by: Zhang Dongxing <dongxing.zhang@intel.com>
> > Signed-off-by: xiaoming wang <xiaoming.wang@intel.com>
> 
> Acked-by: Vinod Koul <vinod.koul@intel.com>
> 
> Takashi, can we cc stable on this, would help fixing in older kernels too

Yes, applied with Cc to stable now.


thanks,

Takashi

> 
> Thanks
> -- 
> ~Vinod
> > ---
> >  include/uapi/sound/compress_offload.h |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/include/uapi/sound/compress_offload.h b/include/uapi/sound/compress_offload.h
> > index 5759810..21eed48 100644
> > --- a/include/uapi/sound/compress_offload.h
> > +++ b/include/uapi/sound/compress_offload.h
> > @@ -80,7 +80,7 @@ struct snd_compr_tstamp {
> >  struct snd_compr_avail {
> >  	__u64 avail;
> >  	struct snd_compr_tstamp tstamp;
> > -};
> > +} __attribute__((packed));
> >  
> >  enum snd_compr_direction {
> >  	SND_COMPRESS_PLAYBACK = 0,
> > -- 
> > 1.7.1
> > 
> 
> -- 
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread
* [PATCH] ALSA: compress: Cancel the optimization of compiler and fix the size of struct for all platform.
@ 2014-06-12 22:47 Wang, Xiaoming
  2014-06-12  9:25 ` Vinod Koul
  0 siblings, 1 reply; 3+ messages in thread
From: Wang, Xiaoming @ 2014-06-12 22:47 UTC (permalink / raw)
  To: tiwai, vinod.koul, jeeja.kp, dhowells, arnd, tglx, mtk.manpages,
	paulmck, davej, linux-kernel
  Cc: dongxing.zhang, xiaoming.wang

Cancel the optimization of compiler for struct snd_compr_avail
which size will be 0x1c in 32bit kernel while 0x20 in 64bit
kernel under the optimizer. That will make compaction between
32bit and 64bit. So add packed to fix the size of struct
snd_compr_avail to 0x1c for all platform.

Signed-off-by: Zhang Dongxing <dongxing.zhang@intel.com>
Signed-off-by: xiaoming wang <xiaoming.wang@intel.com>
---
 include/uapi/sound/compress_offload.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/uapi/sound/compress_offload.h b/include/uapi/sound/compress_offload.h
index 5759810..21eed48 100644
--- a/include/uapi/sound/compress_offload.h
+++ b/include/uapi/sound/compress_offload.h
@@ -80,7 +80,7 @@ struct snd_compr_tstamp {
 struct snd_compr_avail {
 	__u64 avail;
 	struct snd_compr_tstamp tstamp;
-};
+} __attribute__((packed));
 
 enum snd_compr_direction {
 	SND_COMPRESS_PLAYBACK = 0,
-- 
1.7.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-06-12  9:59 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-12 22:47 [PATCH] ALSA: compress: Cancel the optimization of compiler and fix the size of struct for all platform Wang, Xiaoming
2014-06-12  9:25 ` Vinod Koul
2014-06-12  9:59   ` Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.