All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Kiper <daniel.kiper@oracle.com>
To: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
	x86@kernel.org, xen-devel@lists.xenproject.org
Cc: mjg59@srcf.ucam.org, jeremy@goop.org, matt.fleming@intel.com,
	ian.campbell@citrix.com, andrew.cooper3@citrix.com,
	stefano.stabellini@eu.citrix.com, mingo@redhat.com,
	david.vrabel@citrix.com, jbeulich@suse.com, hpa@zytor.com,
	boris.ostrovsky@oracle.com, tglx@linutronix.de,
	eshelton@pobox.com
Subject: [PATCH v5 7/7] arch/x86: Comment out efi_set_rtc_mmss()
Date: Fri, 13 Jun 2014 19:00:23 +0200	[thread overview]
Message-ID: <1402678823-24589-8-git-send-email-daniel.kiper__28411.3599373542$1402678996$gmane$org@oracle.com> (raw)
In-Reply-To: <1402678823-24589-1-git-send-email-daniel.kiper@oracle.com>

efi_set_rtc_mmss() is never used to set RTC due to bugs found
on many EFI platforms. It is set directly by mach_set_rtc_mmss().

Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
---
 arch/x86/platform/efi/efi.c |    6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c
index deb4f05..bd3e080 100644
--- a/arch/x86/platform/efi/efi.c
+++ b/arch/x86/platform/efi/efi.c
@@ -244,6 +244,11 @@ static efi_status_t __init phys_efi_set_virtual_address_map(
 	return status;
 }
 
+#if 0
+/*
+ * efi_set_rtc_mmss() is never used to set RTC due to bugs found
+ * on many EFI platforms. It is set directly by mach_set_rtc_mmss().
+ */
 int efi_set_rtc_mmss(const struct timespec *now)
 {
 	unsigned long nowtime = now->tv_sec;
@@ -279,6 +284,7 @@ int efi_set_rtc_mmss(const struct timespec *now)
 	}
 	return 0;
 }
+#endif
 
 void efi_get_time(struct timespec *now)
 {
-- 
1.7.10.4

  parent reply	other threads:[~2014-06-13 17:01 UTC|newest]

Thread overview: 107+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-13 17:00 [PATCH v5 0/7] xen: Add EFI support Daniel Kiper
2014-06-13 17:00 ` Daniel Kiper
2014-06-13 17:00 ` [PATCH v5 1/7] efi: Use early_mem*() instead of early_io*() Daniel Kiper
2014-06-13 17:00   ` Daniel Kiper
2014-06-16  1:19   ` Matthew Garrett
2014-06-16  1:19   ` Matthew Garrett
2014-06-16  1:19     ` Matthew Garrett
2014-06-18 12:17   ` Matt Fleming
2014-06-18 12:31     ` David Vrabel
2014-06-18 12:31     ` David Vrabel
2014-06-18 12:31       ` David Vrabel
2014-06-18 12:59     ` Daniel Kiper
2014-06-18 12:59     ` Daniel Kiper
2014-06-18 14:56       ` Matt Fleming
2014-06-18 14:56       ` Matt Fleming
2014-06-18 14:56         ` Matt Fleming
2014-06-18 13:59     ` Mark Salter
2014-06-18 13:59       ` Mark Salter
2014-06-18 13:59     ` Mark Salter
2014-06-18 12:17   ` Matt Fleming
2014-06-13 17:00 ` [PATCH v5 2/7] efi: Introduce EFI_NO_DIRECT flag Daniel Kiper
2014-06-16 10:52   ` [Xen-devel] " David Vrabel
2014-06-16 10:52     ` David Vrabel
2014-06-16 10:52   ` David Vrabel
2014-06-18 13:52   ` Matt Fleming
2014-06-18 13:52   ` Matt Fleming
2014-06-18 13:52     ` Matt Fleming
2014-06-18 13:58     ` Jan Beulich
2014-06-18 13:58     ` Jan Beulich
2014-06-18 13:58       ` Jan Beulich
2014-06-18 14:30       ` Stefano Stabellini
2014-06-18 14:30         ` Stefano Stabellini
2014-06-18 15:08         ` Daniel Kiper
2014-06-18 15:08           ` Daniel Kiper
2014-06-18 15:08         ` Daniel Kiper
2014-06-18 15:12         ` Matt Fleming
2014-06-18 15:12         ` Matt Fleming
2014-06-18 15:12           ` Matt Fleming
2014-06-18 14:30       ` Stefano Stabellini
2014-06-18 16:48     ` Daniel Kiper
2014-06-18 16:48     ` Daniel Kiper
2014-06-18 16:48       ` Daniel Kiper
2014-06-19 14:41       ` Matt Fleming
2014-06-19 14:41       ` Matt Fleming
2014-06-19 14:41         ` Matt Fleming
2014-06-20 14:36         ` Daniel Kiper
2014-06-20 14:36           ` Daniel Kiper
2014-06-20 14:36         ` Daniel Kiper
2014-06-13 17:00 ` Daniel Kiper
2014-06-13 17:00 ` [PATCH v5 3/7] xen: Define EFI related stuff Daniel Kiper
2014-06-13 17:00 ` Daniel Kiper
2014-06-16 10:54   ` David Vrabel
2014-06-16 10:54   ` [Xen-devel] " David Vrabel
2014-06-16 10:54     ` David Vrabel
2014-06-13 17:00 ` [PATCH v5 4/7] xen: Put EFI machinery in place Daniel Kiper
2014-06-13 17:00 ` Daniel Kiper
2014-06-16 11:55   ` Stefano Stabellini
2014-06-16 11:55   ` Stefano Stabellini
2014-06-16 11:55     ` Stefano Stabellini
2014-06-16 18:45     ` Daniel Kiper
2014-06-16 18:45     ` Daniel Kiper
2014-06-16 18:45       ` Daniel Kiper
2014-06-16 12:00   ` David Vrabel
2014-06-16 12:00   ` David Vrabel
2014-06-16 12:00     ` David Vrabel
2014-06-16 19:06     ` Daniel Kiper
2014-06-16 19:06     ` Daniel Kiper
2014-06-16 19:06       ` Daniel Kiper
2014-06-13 17:00 ` [PATCH v5 5/7] arch/x86: Replace plain strings with constants Daniel Kiper
2014-06-18 13:56   ` Matt Fleming
2014-06-18 13:56     ` Matt Fleming
2014-06-18 13:56   ` Matt Fleming
2014-06-13 17:00 ` Daniel Kiper
2014-06-13 17:00 ` [PATCH v5 6/7] arch/x86: Remove redundant set_bit() call Daniel Kiper
2014-06-13 17:00 ` Daniel Kiper
2014-06-18 13:56   ` Matt Fleming
2014-06-18 13:56   ` Matt Fleming
2014-06-18 13:56     ` Matt Fleming
2014-06-18 14:01     ` Konrad Rzeszutek Wilk
2014-06-18 14:01       ` Konrad Rzeszutek Wilk
2014-06-18 14:09       ` Matt Fleming
2014-06-18 14:09       ` Matt Fleming
2014-06-18 14:09         ` Matt Fleming
2014-06-18 14:01     ` Konrad Rzeszutek Wilk
2014-06-13 17:00 ` Daniel Kiper [this message]
2014-06-13 17:00 ` [PATCH v5 7/7] arch/x86: Comment out efi_set_rtc_mmss() Daniel Kiper
2014-06-13 17:00   ` Daniel Kiper
2014-06-16 11:43   ` Stefano Stabellini
2014-06-16 11:43   ` Stefano Stabellini
2014-06-16 11:43     ` Stefano Stabellini
2014-06-16 11:54     ` Juergen Gross
2014-06-16 11:54     ` [Xen-devel] " Juergen Gross
2014-06-16 18:59       ` H. Peter Anvin
2014-06-16 18:59         ` H. Peter Anvin
2014-06-16 18:59       ` H. Peter Anvin
2014-06-18 14:08   ` Matt Fleming
2014-06-18 14:08   ` Matt Fleming
2014-06-18 14:08     ` Matt Fleming
2014-06-18 14:15 ` [PATCH v5 0/7] xen: Add EFI support Matt Fleming
2014-06-18 14:15 ` Matt Fleming
2014-06-18 14:15   ` Matt Fleming
2014-06-18 14:31   ` Konrad Rzeszutek Wilk
2014-06-18 14:31   ` Konrad Rzeszutek Wilk
2014-06-18 14:31     ` Konrad Rzeszutek Wilk
2014-06-18 14:48     ` Matt Fleming
2014-06-18 14:48       ` Matt Fleming
2014-06-18 14:48     ` Matt Fleming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='1402678823-24589-8-git-send-email-daniel.kiper__28411.3599373542$1402678996$gmane$org@oracle.com' \
    --to=daniel.kiper@oracle.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=david.vrabel@citrix.com \
    --cc=eshelton@pobox.com \
    --cc=hpa@zytor.com \
    --cc=ian.campbell@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=jeremy@goop.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt.fleming@intel.com \
    --cc=mingo@redhat.com \
    --cc=mjg59@srcf.ucam.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.