Re: [PATCH v5 1/7] efi: Use early_mem*() instead of early_io*()

From: Matt Fleming <matt@console-pimps.org>
To: Daniel Kiper <daniel.kiper@oracle.com>
Cc: mjg59@srcf.ucam.org, jeremy@goop.org, linux-efi@vger.kernel.org,
	Mark Salter <msalter@redhat.com>,
	ian.campbell@citrix.com, andrew.cooper3@citrix.com,
	x86@kernel.org, linux-kernel@vger.kernel.org,
	matt.fleming@intel.com, tglx@linutronix.de,
	david.vrabel@citrix.com, jbeulich@suse.com, hpa@zytor.com,
	xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com,
	mingo@redhat.com, stefano.stabellini@eu.citrix.com,
	eshelton@pobox.com
Subject: Re: [PATCH v5 1/7] efi: Use early_mem*() instead of early_io*()
Date: Wed, 18 Jun 2014 15:56:19 +0100	[thread overview]
Message-ID: <20140618145619.GP24049__14730.9120082811$1403103456$gmane$org@console-pimps.org> (raw)
In-Reply-To: <20140618125957.GA28489@olila.local.net-space.pl>

On Wed, 18 Jun, at 02:59:57PM, Daniel Kiper wrote:
> 
> I think that it improves readability a bit but if you wish I will not
> do that in the future.

That would be much appreciated.

> > As Matthew pointed out we may also need to access EFI mapped flash
> > devices.
> 
> Right, but I think it does not change a lot in that case. Flash
> is simply slower type of memory used as permanent storage.
> Am I missing something?

No you're not missing anything, I hit send too quickly while typing my
reply so the above isn't a complete thought. I don't think this
distinction between mapped flash and RAM matters in this case.

> As I saw David provided better explanation. If you wish I could include
> it in commit message.

Yeah, I think that would be very helpful, thanks!

-- 
Matt Fleming, Intel Open Source Technology Center