All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] cpuidle: mvebu: Fix the name of the states
@ 2014-06-18 12:37 ` Gregory CLEMENT
  0 siblings, 0 replies; 4+ messages in thread
From: Gregory CLEMENT @ 2014-06-18 12:37 UTC (permalink / raw)
  To: Daniel Lezcano, Rafael J. Wysocki, linux-pm
  Cc: Thomas Petazzoni, Ezequiel Garcia, linux-arm-kernel, Gregory CLEMENT

The length name of the states 2 was too long to fit in the allocated
string (limited to 16 bytes). This lead to improper string displayed
through sysfs.

This patch shorten the name by removing the reference to Marvell and
to the CPU as both are implicit. For coherency the same change have
been done for the states 1.

Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
---
Hi,

This fix should be merged in 3.16.

Thanks,
Gregory

 drivers/cpuidle/cpuidle-armada-370-xp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/cpuidle/cpuidle-armada-370-xp.c b/drivers/cpuidle/cpuidle-armada-370-xp.c
index 28587d0f3947..a5fba0287bfb 100644
--- a/drivers/cpuidle/cpuidle-armada-370-xp.c
+++ b/drivers/cpuidle/cpuidle-armada-370-xp.c
@@ -55,7 +55,7 @@ static struct cpuidle_driver armada_370_xp_idle_driver = {
 		.power_usage		= 50,
 		.target_residency	= 100,
 		.flags			= CPUIDLE_FLAG_TIME_VALID,
-		.name			= "MV CPU IDLE",
+		.name			= "Idle",
 		.desc			= "CPU power down",
 	},
 	.states[2]		= {
@@ -65,7 +65,7 @@ static struct cpuidle_driver armada_370_xp_idle_driver = {
 		.target_residency	= 1000,
 		.flags			= CPUIDLE_FLAG_TIME_VALID |
 						ARMADA_370_XP_FLAG_DEEP_IDLE,
-		.name			= "MV CPU DEEP IDLE",
+		.name			= "Deep idle",
 		.desc			= "CPU and L2 Fabric power down",
 	},
 	.state_count = ARMADA_370_XP_MAX_STATES,
-- 
1.8.1.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] cpuidle: mvebu: Fix the name of the states
@ 2014-06-18 12:37 ` Gregory CLEMENT
  0 siblings, 0 replies; 4+ messages in thread
From: Gregory CLEMENT @ 2014-06-18 12:37 UTC (permalink / raw)
  To: linux-arm-kernel

The length name of the states 2 was too long to fit in the allocated
string (limited to 16 bytes). This lead to improper string displayed
through sysfs.

This patch shorten the name by removing the reference to Marvell and
to the CPU as both are implicit. For coherency the same change have
been done for the states 1.

Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
---
Hi,

This fix should be merged in 3.16.

Thanks,
Gregory

 drivers/cpuidle/cpuidle-armada-370-xp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/cpuidle/cpuidle-armada-370-xp.c b/drivers/cpuidle/cpuidle-armada-370-xp.c
index 28587d0f3947..a5fba0287bfb 100644
--- a/drivers/cpuidle/cpuidle-armada-370-xp.c
+++ b/drivers/cpuidle/cpuidle-armada-370-xp.c
@@ -55,7 +55,7 @@ static struct cpuidle_driver armada_370_xp_idle_driver = {
 		.power_usage		= 50,
 		.target_residency	= 100,
 		.flags			= CPUIDLE_FLAG_TIME_VALID,
-		.name			= "MV CPU IDLE",
+		.name			= "Idle",
 		.desc			= "CPU power down",
 	},
 	.states[2]		= {
@@ -65,7 +65,7 @@ static struct cpuidle_driver armada_370_xp_idle_driver = {
 		.target_residency	= 1000,
 		.flags			= CPUIDLE_FLAG_TIME_VALID |
 						ARMADA_370_XP_FLAG_DEEP_IDLE,
-		.name			= "MV CPU DEEP IDLE",
+		.name			= "Deep idle",
 		.desc			= "CPU and L2 Fabric power down",
 	},
 	.state_count = ARMADA_370_XP_MAX_STATES,
-- 
1.8.1.2

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] cpuidle: mvebu: Fix the name of the states
  2014-06-18 12:37 ` Gregory CLEMENT
@ 2014-06-18 23:32   ` Rafael J. Wysocki
  -1 siblings, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2014-06-18 23:32 UTC (permalink / raw)
  To: Gregory CLEMENT
  Cc: Daniel Lezcano, linux-pm, Thomas Petazzoni, Ezequiel Garcia,
	linux-arm-kernel

On Wednesday, June 18, 2014 02:37:43 PM Gregory CLEMENT wrote:
> The length name of the states 2 was too long to fit in the allocated
> string (limited to 16 bytes). This lead to improper string displayed
> through sysfs.
> 
> This patch shorten the name by removing the reference to Marvell and
> to the CPU as both are implicit. For coherency the same change have
> been done for the states 1.
> 
> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
> ---
> Hi,
> 
> This fix should be merged in 3.16.

Applied, thanks!

>  drivers/cpuidle/cpuidle-armada-370-xp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/cpuidle/cpuidle-armada-370-xp.c b/drivers/cpuidle/cpuidle-armada-370-xp.c
> index 28587d0f3947..a5fba0287bfb 100644
> --- a/drivers/cpuidle/cpuidle-armada-370-xp.c
> +++ b/drivers/cpuidle/cpuidle-armada-370-xp.c
> @@ -55,7 +55,7 @@ static struct cpuidle_driver armada_370_xp_idle_driver = {
>  		.power_usage		= 50,
>  		.target_residency	= 100,
>  		.flags			= CPUIDLE_FLAG_TIME_VALID,
> -		.name			= "MV CPU IDLE",
> +		.name			= "Idle",
>  		.desc			= "CPU power down",
>  	},
>  	.states[2]		= {
> @@ -65,7 +65,7 @@ static struct cpuidle_driver armada_370_xp_idle_driver = {
>  		.target_residency	= 1000,
>  		.flags			= CPUIDLE_FLAG_TIME_VALID |
>  						ARMADA_370_XP_FLAG_DEEP_IDLE,
> -		.name			= "MV CPU DEEP IDLE",
> +		.name			= "Deep idle",
>  		.desc			= "CPU and L2 Fabric power down",
>  	},
>  	.state_count = ARMADA_370_XP_MAX_STATES,
> 

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [PATCH] cpuidle: mvebu: Fix the name of the states
@ 2014-06-18 23:32   ` Rafael J. Wysocki
  0 siblings, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2014-06-18 23:32 UTC (permalink / raw)
  To: linux-arm-kernel

On Wednesday, June 18, 2014 02:37:43 PM Gregory CLEMENT wrote:
> The length name of the states 2 was too long to fit in the allocated
> string (limited to 16 bytes). This lead to improper string displayed
> through sysfs.
> 
> This patch shorten the name by removing the reference to Marvell and
> to the CPU as both are implicit. For coherency the same change have
> been done for the states 1.
> 
> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
> ---
> Hi,
> 
> This fix should be merged in 3.16.

Applied, thanks!

>  drivers/cpuidle/cpuidle-armada-370-xp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/cpuidle/cpuidle-armada-370-xp.c b/drivers/cpuidle/cpuidle-armada-370-xp.c
> index 28587d0f3947..a5fba0287bfb 100644
> --- a/drivers/cpuidle/cpuidle-armada-370-xp.c
> +++ b/drivers/cpuidle/cpuidle-armada-370-xp.c
> @@ -55,7 +55,7 @@ static struct cpuidle_driver armada_370_xp_idle_driver = {
>  		.power_usage		= 50,
>  		.target_residency	= 100,
>  		.flags			= CPUIDLE_FLAG_TIME_VALID,
> -		.name			= "MV CPU IDLE",
> +		.name			= "Idle",
>  		.desc			= "CPU power down",
>  	},
>  	.states[2]		= {
> @@ -65,7 +65,7 @@ static struct cpuidle_driver armada_370_xp_idle_driver = {
>  		.target_residency	= 1000,
>  		.flags			= CPUIDLE_FLAG_TIME_VALID |
>  						ARMADA_370_XP_FLAG_DEEP_IDLE,
> -		.name			= "MV CPU DEEP IDLE",
> +		.name			= "Deep idle",
>  		.desc			= "CPU and L2 Fabric power down",
>  	},
>  	.state_count = ARMADA_370_XP_MAX_STATES,
> 

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-06-18 23:32 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-18 12:37 [PATCH] cpuidle: mvebu: Fix the name of the states Gregory CLEMENT
2014-06-18 12:37 ` Gregory CLEMENT
2014-06-18 23:32 ` Rafael J. Wysocki
2014-06-18 23:32   ` Rafael J. Wysocki

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.