* [PATCH 1/1] drivers/net/wireless/rt2x00/rt2x00dev.c: remove null test before kfree
@ 2014-06-18 14:51 Fabian Frederick
0 siblings, 0 replies; 3+ messages in thread
From: Fabian Frederick @ 2014-06-18 14:51 UTC (permalink / raw)
To: linux-wireless; +Cc: Fabian Frederick, Ivo van Doorn, Helmut Schaa
Fix checkpatch warning:
WARNING: kfree(NULL) is safe this check is probably not required
Cc: Ivo van Doorn <IvDoorn@gmail.com>
Cc: Helmut Schaa <helmut.schaa@googlemail.com>
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
drivers/net/wireless/rt2x00/rt2x00dev.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/rt2x00/rt2x00dev.c b/drivers/net/wireless/rt2x00/rt2x00dev.c
index 2bde672..c2c2300 100644
--- a/drivers/net/wireless/rt2x00/rt2x00dev.c
+++ b/drivers/net/wireless/rt2x00/rt2x00dev.c
@@ -1452,8 +1452,7 @@ void rt2x00lib_remove_dev(struct rt2x00_dev *rt2x00dev)
/*
* Free the driver data.
*/
- if (rt2x00dev->drv_data)
- kfree(rt2x00dev->drv_data);
+ kfree(rt2x00dev->drv_data);
}
EXPORT_SYMBOL_GPL(rt2x00lib_remove_dev);
--
1.8.4.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] drivers/net/wireless/rt2x00/rt2x00dev.c: remove null test before kfree
2014-06-17 19:36 Fabian Frederick
@ 2014-06-18 7:59 ` Helmut Schaa
0 siblings, 0 replies; 3+ messages in thread
From: Helmut Schaa @ 2014-06-18 7:59 UTC (permalink / raw)
To: Fabian Frederick; +Cc: LKML, Ivo van Doorn
Hi,
On Tue, Jun 17, 2014 at 9:36 PM, Fabian Frederick <fabf@skynet.be> wrote:
> Fix checkpatch warning:
> WARNING: kfree(NULL) is safe this check is probably not required
Thanks Fabian.
This should go through the wireless tree I guess, mind to send to
linux-wireless@vger.kernel.org?
Helmut
> Cc: Ivo van Doorn <IvDoorn@gmail.com>
> Cc: Helmut Schaa <helmut.schaa@googlemail.com>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> drivers/net/wireless/rt2x00/rt2x00dev.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2x00dev.c b/drivers/net/wireless/rt2x00/rt2x00dev.c
> index 2bde672..c2c2300 100644
> --- a/drivers/net/wireless/rt2x00/rt2x00dev.c
> +++ b/drivers/net/wireless/rt2x00/rt2x00dev.c
> @@ -1452,8 +1452,7 @@ void rt2x00lib_remove_dev(struct rt2x00_dev *rt2x00dev)
> /*
> * Free the driver data.
> */
> - if (rt2x00dev->drv_data)
> - kfree(rt2x00dev->drv_data);
> + kfree(rt2x00dev->drv_data);
> }
> EXPORT_SYMBOL_GPL(rt2x00lib_remove_dev);
>
> --
> 1.8.4.5
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/1] drivers/net/wireless/rt2x00/rt2x00dev.c: remove null test before kfree
@ 2014-06-17 19:36 Fabian Frederick
2014-06-18 7:59 ` Helmut Schaa
0 siblings, 1 reply; 3+ messages in thread
From: Fabian Frederick @ 2014-06-17 19:36 UTC (permalink / raw)
To: linux-kernel; +Cc: Fabian Frederick, Ivo van Doorn, Helmut Schaa
Fix checkpatch warning:
WARNING: kfree(NULL) is safe this check is probably not required
Cc: Ivo van Doorn <IvDoorn@gmail.com>
Cc: Helmut Schaa <helmut.schaa@googlemail.com>
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
drivers/net/wireless/rt2x00/rt2x00dev.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/rt2x00/rt2x00dev.c b/drivers/net/wireless/rt2x00/rt2x00dev.c
index 2bde672..c2c2300 100644
--- a/drivers/net/wireless/rt2x00/rt2x00dev.c
+++ b/drivers/net/wireless/rt2x00/rt2x00dev.c
@@ -1452,8 +1452,7 @@ void rt2x00lib_remove_dev(struct rt2x00_dev *rt2x00dev)
/*
* Free the driver data.
*/
- if (rt2x00dev->drv_data)
- kfree(rt2x00dev->drv_data);
+ kfree(rt2x00dev->drv_data);
}
EXPORT_SYMBOL_GPL(rt2x00lib_remove_dev);
--
1.8.4.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-06-18 14:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-18 14:51 [PATCH 1/1] drivers/net/wireless/rt2x00/rt2x00dev.c: remove null test before kfree Fabian Frederick
-- strict thread matches above, loose matches on Subject: below --
2014-06-17 19:36 Fabian Frederick
2014-06-18 7:59 ` Helmut Schaa
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.