* [PATCH] staging: lustre: obdclass: linux-sysctl.c: fix pointer coding style issue
@ 2014-06-12 15:27 Andrey Skvortsov
2014-06-18 22:35 ` Greg KH
0 siblings, 1 reply; 7+ messages in thread
From: Andrey Skvortsov @ 2014-06-12 15:27 UTC (permalink / raw)
To: gregkh
Cc: bergwolf, sachin.kamat, andreas.dilger, devel, linux-kernel,
Andrey Skvortsov
Signed-off-by: Andrey Skvortsov <Andrej.Skvortzov@gmail.com>
---
drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c b/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c
index c1ef0c9..b87ca10 100644
--- a/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c
+++ b/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c
@@ -196,7 +196,7 @@ int LL_PROC_PROTO(proc_max_dirty_pages_in_mb)
}
if (write) {
rc = lprocfs_write_frac_helper(buffer, *lenp,
- (unsigned int*)table->data,
+ (unsigned int *)table->data,
1 << (20 - PAGE_CACHE_SHIFT));
/* Don't allow them to let dirty pages exceed 90% of system
* memory and set a hard minimum of 4MB. */
@@ -214,7 +214,7 @@ int LL_PROC_PROTO(proc_max_dirty_pages_in_mb)
int len;
len = lprocfs_read_frac_helper(buf, sizeof(buf),
- *(unsigned int*)table->data,
+ *(unsigned int *)table->data,
1 << (20 - PAGE_CACHE_SHIFT));
if (len > *lenp)
len = *lenp;
@@ -238,15 +238,14 @@ int LL_PROC_PROTO(proc_alloc_fail_rate)
}
if (write) {
rc = lprocfs_write_frac_helper(buffer, *lenp,
- (unsigned int*)table->data,
+ (unsigned int *)table->data,
OBD_ALLOC_FAIL_MULT);
} else {
char buf[21];
int len;
len = lprocfs_read_frac_helper(buf, 21,
- *(unsigned int*)table->data,
+ *(unsigned int *)table->data,
OBD_ALLOC_FAIL_MULT);
if (len > *lenp)
len = *lenp;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] staging: lustre: obdclass: linux-sysctl.c: fix pointer coding style issue
2014-06-12 15:27 [PATCH] staging: lustre: obdclass: linux-sysctl.c: fix pointer coding style issue Andrey Skvortsov
@ 2014-06-18 22:35 ` Greg KH
2014-06-19 7:24 ` [PATCHv2 0/3] staging: lustre: obdclass: fixing coding style issues Andrey Skvortsov
0 siblings, 1 reply; 7+ messages in thread
From: Greg KH @ 2014-06-18 22:35 UTC (permalink / raw)
To: Andrey Skvortsov
Cc: devel, andreas.dilger, sachin.kamat, bergwolf, linux-kernel
On Thu, Jun 12, 2014 at 07:27:12PM +0400, Andrey Skvortsov wrote:
>
> Signed-off-by: Andrey Skvortsov <Andrej.Skvortzov@gmail.com>
> ---
> drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c | 8 ++++----
This patch does not apply to my tree for one chunk. Can you please
refresh it against the staging-next branch of the staging.git tree on
git.kernel.org?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCHv2 0/3] staging: lustre: obdclass: fixing coding style issues
2014-06-18 22:35 ` Greg KH
@ 2014-06-19 7:24 ` Andrey Skvortsov
2014-06-19 7:24 ` [PATCHv2 1/3] staging: lustre: obdclass: linux-sysctl.c: fix pointer coding style issue Andrey Skvortsov
0 siblings, 1 reply; 7+ messages in thread
From: Andrey Skvortsov @ 2014-06-19 7:24 UTC (permalink / raw)
To: Greg KH; +Cc: devel, andreas.dilger, sachin.kamat, bergwolf, linux-kernel
Changes since PATCHv1:
I refreshed patch against the staging-next branch of the staging.git tree
and added some other coding style fixes as separate patches.
Andrey Skvortsov (3):
staging: lustre: obdclass: linux-sysctl.c: fix pointer coding style
issue
staging: lustre: obdclass: linux-sysctl.c: fix checkpatch warnings
about included headers
staging: lustre: obdclass: linux-sysctl.c: fix unnecessary spaces
coding style issue
.../lustre/lustre/obdclass/linux/linux-sysctl.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
--
1.7.10.4
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCHv2 1/3] staging: lustre: obdclass: linux-sysctl.c: fix pointer coding style issue
2014-06-19 7:24 ` [PATCHv2 0/3] staging: lustre: obdclass: fixing coding style issues Andrey Skvortsov
@ 2014-06-19 7:24 ` Andrey Skvortsov
2014-06-19 7:24 ` Andrey Skvortsov
0 siblings, 1 reply; 7+ messages in thread
From: Andrey Skvortsov @ 2014-06-19 7:24 UTC (permalink / raw)
To: Greg KH
Cc: devel, andreas.dilger, sachin.kamat, bergwolf, linux-kernel,
Andrey Skvortsov
From: Andrey Skvortsov <andrej.skvortzov@gmail.com>
Signed-off-by: Andrey Skvortsov <andrej.skvortzov@gmail.com>
---
Changes since PATCHv1:
I refreshed patch against the staging-next branch of the staging.git tree
and added some other coding style fixes as separate patches.
drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c b/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c
index c1ef0c9..b87ca10 100644
--- a/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c
+++ b/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c
@@ -196,7 +196,7 @@ int LL_PROC_PROTO(proc_max_dirty_pages_in_mb)
}
if (write) {
rc = lprocfs_write_frac_helper(buffer, *lenp,
- (unsigned int*)table->data,
+ (unsigned int *)table->data,
1 << (20 - PAGE_CACHE_SHIFT));
/* Don't allow them to let dirty pages exceed 90% of system
* memory and set a hard minimum of 4MB. */
@@ -214,7 +214,7 @@ int LL_PROC_PROTO(proc_max_dirty_pages_in_mb)
int len;
len = lprocfs_read_frac_helper(buf, sizeof(buf),
- *(unsigned int*)table->data,
+ *(unsigned int *)table->data,
1 << (20 - PAGE_CACHE_SHIFT));
if (len > *lenp)
len = *lenp;
@@ -238,14 +238,14 @@ int LL_PROC_PROTO(proc_alloc_fail_rate)
}
if (write) {
rc = lprocfs_write_frac_helper(buffer, *lenp,
- (unsigned int*)table->data,
+ (unsigned int *)table->data,
OBD_ALLOC_FAIL_MULT);
} else {
char buf[21];
int len;
len = lprocfs_read_frac_helper(buf, 21,
- *(unsigned int*)table->data,
+ *(unsigned int *)table->data,
OBD_ALLOC_FAIL_MULT);
if (len > *lenp)
len = *lenp;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCHv2 1/3] staging: lustre: obdclass: linux-sysctl.c: fix pointer coding style issue
2014-06-19 7:24 ` [PATCHv2 1/3] staging: lustre: obdclass: linux-sysctl.c: fix pointer coding style issue Andrey Skvortsov
@ 2014-06-19 7:24 ` Andrey Skvortsov
2014-06-19 7:24 ` [PATCHv2 2/3] staging: lustre: obdclass: linux-sysctl.c: fix checkpatch warnings about included headers Andrey Skvortsov
0 siblings, 1 reply; 7+ messages in thread
From: Andrey Skvortsov @ 2014-06-19 7:24 UTC (permalink / raw)
To: Greg KH
Cc: devel, andreas.dilger, sachin.kamat, bergwolf, linux-kernel,
Andrey Skvortsov
From: Andrey Skvortsov <skvortsov.av@summatechnology.ru>
Signed-off-by: Andrey Skvortsov <Andrej.Skvortzov@gmail.com>
---
drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c b/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c
index c1ef0c9..b87ca10 100644
--- a/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c
+++ b/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c
@@ -196,7 +196,7 @@ int LL_PROC_PROTO(proc_max_dirty_pages_in_mb)
}
if (write) {
rc = lprocfs_write_frac_helper(buffer, *lenp,
- (unsigned int*)table->data,
+ (unsigned int *)table->data,
1 << (20 - PAGE_CACHE_SHIFT));
/* Don't allow them to let dirty pages exceed 90% of system
* memory and set a hard minimum of 4MB. */
@@ -214,7 +214,7 @@ int LL_PROC_PROTO(proc_max_dirty_pages_in_mb)
int len;
len = lprocfs_read_frac_helper(buf, sizeof(buf),
- *(unsigned int*)table->data,
+ *(unsigned int *)table->data,
1 << (20 - PAGE_CACHE_SHIFT));
if (len > *lenp)
len = *lenp;
@@ -238,14 +238,14 @@ int LL_PROC_PROTO(proc_alloc_fail_rate)
}
if (write) {
rc = lprocfs_write_frac_helper(buffer, *lenp,
- (unsigned int*)table->data,
+ (unsigned int *)table->data,
OBD_ALLOC_FAIL_MULT);
} else {
char buf[21];
int len;
len = lprocfs_read_frac_helper(buf, 21,
- *(unsigned int*)table->data,
+ *(unsigned int *)table->data,
OBD_ALLOC_FAIL_MULT);
if (len > *lenp)
len = *lenp;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCHv2 2/3] staging: lustre: obdclass: linux-sysctl.c: fix checkpatch warnings about included headers
2014-06-19 7:24 ` Andrey Skvortsov
@ 2014-06-19 7:24 ` Andrey Skvortsov
2014-06-19 7:24 ` [PATCHv2 3/3] staging: lustre: obdclass: linux-sysctl.c: fix unnecessary spaces coding style issue Andrey Skvortsov
0 siblings, 1 reply; 7+ messages in thread
From: Andrey Skvortsov @ 2014-06-19 7:24 UTC (permalink / raw)
To: Greg KH
Cc: devel, andreas.dilger, sachin.kamat, bergwolf, linux-kernel,
Andrey Skvortsov
From: Andrey Skvortsov <skvortsov.av@summatechnology.ru>
Signed-off-by: Andrey Skvortsov <Andrej.Skvortzov@gmail.com>
---
drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c b/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c
index b87ca10..4dcdfc2 100644
--- a/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c
+++ b/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c
@@ -42,8 +42,8 @@
#include <linux/slab.h>
#include <linux/stat.h>
#include <linux/ctype.h>
-#include <asm/bitops.h>
-#include <asm/uaccess.h>
+#include <linux/bitops.h>
+#include <linux/uaccess.h>
#include <linux/utsname.h>
#define DEBUG_SUBSYSTEM S_CLASS
--
1.7.10.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCHv2 3/3] staging: lustre: obdclass: linux-sysctl.c: fix unnecessary spaces coding style issue
2014-06-19 7:24 ` [PATCHv2 2/3] staging: lustre: obdclass: linux-sysctl.c: fix checkpatch warnings about included headers Andrey Skvortsov
@ 2014-06-19 7:24 ` Andrey Skvortsov
0 siblings, 0 replies; 7+ messages in thread
From: Andrey Skvortsov @ 2014-06-19 7:24 UTC (permalink / raw)
To: Greg KH
Cc: devel, andreas.dilger, sachin.kamat, bergwolf, linux-kernel,
Andrey Skvortsov
From: Andrey Skvortsov <skvortsov.av@summatechnology.ru>
Signed-off-by: Andrey Skvortsov <Andrej.Skvortzov@gmail.com>
---
drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c b/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c
index 4dcdfc2..140b570 100644
--- a/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c
+++ b/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c
@@ -408,18 +408,18 @@ static ctl_table_t parent_table[] = {
};
#endif
-void obd_sysctl_init (void)
+void obd_sysctl_init(void)
{
#ifdef CONFIG_SYSCTL
- if ( !obd_table_header )
+ if (!obd_table_header)
obd_table_header = register_sysctl_table(parent_table);
#endif
}
-void obd_sysctl_clean (void)
+void obd_sysctl_clean(void)
{
#ifdef CONFIG_SYSCTL
- if ( obd_table_header )
+ if (obd_table_header)
unregister_sysctl_table(obd_table_header);
obd_table_header = NULL;
#endif
--
1.7.10.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-06-19 7:24 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-12 15:27 [PATCH] staging: lustre: obdclass: linux-sysctl.c: fix pointer coding style issue Andrey Skvortsov
2014-06-18 22:35 ` Greg KH
2014-06-19 7:24 ` [PATCHv2 0/3] staging: lustre: obdclass: fixing coding style issues Andrey Skvortsov
2014-06-19 7:24 ` [PATCHv2 1/3] staging: lustre: obdclass: linux-sysctl.c: fix pointer coding style issue Andrey Skvortsov
2014-06-19 7:24 ` Andrey Skvortsov
2014-06-19 7:24 ` [PATCHv2 2/3] staging: lustre: obdclass: linux-sysctl.c: fix checkpatch warnings about included headers Andrey Skvortsov
2014-06-19 7:24 ` [PATCHv2 3/3] staging: lustre: obdclass: linux-sysctl.c: fix unnecessary spaces coding style issue Andrey Skvortsov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.