All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>
Cc: Brian Austin <brian.austin@cirrus.com>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	alsa-devel@alsa-project.org,
	Paul Handrigan <Paul.Handrigan@cirrus.com>,
	Peter Ujfalusi <peter.ujfalusi@ti.com>,
	Jyri Sarha <jsarha@ti.com>,
	Jarkko Nikula <jarkko.nikula@bitmer.com>
Subject: [PATCH 5/5] ASoC: sh/fsi: Make one-bit bitfields unsigned
Date: Thu, 19 Jun 2014 09:40:31 +0200	[thread overview]
Message-ID: <1403163631-26215-6-git-send-email-lars@metafoo.de> (raw)
In-Reply-To: <1403163631-26215-1-git-send-email-lars@metafoo.de>

One-bit signed bitfields have two possible values: 0 and -1. This sometimes
leads to unexpected results (e.g. foo.bar = 1; foo.bar == 1 => false) which is
why it is recommended to make one-bit bitfields unsigned.

This fixes the following sparse warnings:
	sound/soc/sh/fsi.c:267:25: error: dubious one-bit signed bitfield
	sound/soc/sh/fsi.c:268:22: error: dubious one-bit signed bitfield
	sound/soc/sh/fsi.c:269:20: error: dubious one-bit signed bitfield
	sound/soc/sh/fsi.c:270:28: error: dubious one-bit signed bitfield
	sound/soc/sh/fsi.c:271:26: error: dubious one-bit signed bitfield
	sound/soc/sh/fsi.c:272:25: error: dubious one-bit signed bitfield

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
 sound/soc/sh/fsi.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/sound/soc/sh/fsi.c b/sound/soc/sh/fsi.c
index 710a079..2c95d85 100644
--- a/sound/soc/sh/fsi.c
+++ b/sound/soc/sh/fsi.c
@@ -264,12 +264,12 @@ struct fsi_priv {
 	u32 fmt;
 
 	int chan_num:16;
-	int clk_master:1;
-	int clk_cpg:1;
-	int spdif:1;
-	int enable_stream:1;
-	int bit_clk_inv:1;
-	int lr_clk_inv:1;
+	unsigned int clk_master:1;
+	unsigned int clk_cpg:1;
+	unsigned int spdif:1;
+	unsigned int enable_stream:1;
+	unsigned int bit_clk_inv:1;
+	unsigned int lr_clk_inv:1;
 };
 
 struct fsi_stream_handler {
-- 
1.8.0

  parent reply	other threads:[~2014-06-19  7:40 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-19  7:40 [PATCH 0/5] ASoC: Fix trival sparse warnings Lars-Peter Clausen
2014-06-19  7:40 ` [PATCH 1/5] ASoC: tlv320aic31xx: Remove duplicate const Lars-Peter Clausen
2014-06-21 19:57   ` Mark Brown
2014-06-19  7:40 ` [PATCH 2/5] ASoC: cs42xx8: Make of match table static Lars-Peter Clausen
2014-06-19 13:50   ` Brian Austin
2014-06-21 19:58   ` Mark Brown
2014-06-19  7:40 ` [PATCH 3/5] ASoC: omap-pcm: Include omap-pcm.h Lars-Peter Clausen
2014-06-21 20:00   ` Mark Brown
2014-06-30 16:48     ` Lars-Peter Clausen
2014-06-30 21:54       ` Mark Brown
2014-07-01  5:57         ` Lars-Peter Clausen
2014-06-19  7:40 ` [PATCH 4/5] ASoC: rcar: Fix dma direction type Lars-Peter Clausen
2014-06-19  9:12   ` Kuninori Morimoto
2014-06-19  9:24     ` Lars-Peter Clausen
2014-06-19  9:38       ` Kuninori Morimoto
2014-06-21 20:00   ` Mark Brown
2014-06-19  7:40 ` Lars-Peter Clausen [this message]
2014-06-19  9:12   ` [PATCH 5/5] ASoC: sh/fsi: Make one-bit bitfields unsigned Kuninori Morimoto
2014-06-21 20:02   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1403163631-26215-6-git-send-email-lars@metafoo.de \
    --to=lars@metafoo.de \
    --cc=Paul.Handrigan@cirrus.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=brian.austin@cirrus.com \
    --cc=broonie@kernel.org \
    --cc=jarkko.nikula@bitmer.com \
    --cc=jsarha@ti.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lgirdwood@gmail.com \
    --cc=peter.ujfalusi@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.