From: Lars-Peter Clausen <lars@metafoo.de>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Brian Austin <brian.austin@cirrus.com>,
alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
Paul Handrigan <Paul.Handrigan@cirrus.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Mark Brown <broonie@kernel.org>, Jyri Sarha <jsarha@ti.com>,
Jarkko Nikula <jarkko.nikula@bitmer.com>
Subject: Re: [PATCH 4/5] ASoC: rcar: Fix dma direction type
Date: Thu, 19 Jun 2014 11:24:57 +0200 [thread overview]
Message-ID: <53A2AC69.6080508@metafoo.de> (raw)
In-Reply-To: <87wqcdntzh.wl%kuninori.morimoto.gx@renesas.com>
On 06/19/2014 11:12 AM, Kuninori Morimoto wrote:
>
> Hi Lars
>
>> dmaengine_prep_slave_single() expects a enum dma_transfer_direction and not a
>> enum dma_data_direction. Since the integer representations of both DMA_TO_DEVICE
>> and DMA_MEM_TO_DEV aswell as DMA_FROM_DEVICE and DMA_DEV_TO_MEM have the same
>> value the code worked fine even though it was using the wrong type.
>>
>> Fixes the following warning from sparse:
>> sound/soc/sh/rcar/core.c:227:49: warning: mixing different enum types
>> sound/soc/sh/rcar/core.c:227:49: int enum dma_data_direction versus
>> sound/soc/sh/rcar/core.c:227:49: int enum dma_transfer_direction
>>
>> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
>> ---
>
> Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> Actually, ${LINUX}/sound/soc/sh/fsi.c :: fsi_dma_transfer()
> is using enum dma_data_direction to dmaengine_prep_dma_cyclic()
> Does it have same issue ?
Yes, but the fix for that should go in after your "ASoC: fsi: use
SNDRV_DMA_TYPE_DEV for sound buffer" patch, because otherwise the fix just
introduces a new warning because before that patch dir is also passed to
dma_sync_single_xxx() which wants a enum dma_data_direction.
- Lars
next prev parent reply other threads:[~2014-06-19 9:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-19 7:40 [PATCH 0/5] ASoC: Fix trival sparse warnings Lars-Peter Clausen
2014-06-19 7:40 ` [PATCH 1/5] ASoC: tlv320aic31xx: Remove duplicate const Lars-Peter Clausen
2014-06-21 19:57 ` Mark Brown
2014-06-19 7:40 ` [PATCH 2/5] ASoC: cs42xx8: Make of match table static Lars-Peter Clausen
2014-06-19 13:50 ` Brian Austin
2014-06-21 19:58 ` Mark Brown
2014-06-19 7:40 ` [PATCH 3/5] ASoC: omap-pcm: Include omap-pcm.h Lars-Peter Clausen
2014-06-21 20:00 ` Mark Brown
2014-06-30 16:48 ` Lars-Peter Clausen
2014-06-30 21:54 ` Mark Brown
2014-07-01 5:57 ` Lars-Peter Clausen
2014-06-19 7:40 ` [PATCH 4/5] ASoC: rcar: Fix dma direction type Lars-Peter Clausen
2014-06-19 9:12 ` Kuninori Morimoto
2014-06-19 9:24 ` Lars-Peter Clausen [this message]
2014-06-19 9:38 ` Kuninori Morimoto
2014-06-21 20:00 ` Mark Brown
2014-06-19 7:40 ` [PATCH 5/5] ASoC: sh/fsi: Make one-bit bitfields unsigned Lars-Peter Clausen
2014-06-19 9:12 ` Kuninori Morimoto
2014-06-21 20:02 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A2AC69.6080508@metafoo.de \
--to=lars@metafoo.de \
--cc=Paul.Handrigan@cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=brian.austin@cirrus.com \
--cc=broonie@kernel.org \
--cc=jarkko.nikula@bitmer.com \
--cc=jsarha@ti.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.