* Re: [PATCH v3] ARM: shmobile: Mark all SoCs in shmobile as CPUFreq, capable
2014-06-05 3:49 [PATCH v3] ARM: shmobile: Mark all SoCs in shmobile as CPUFreq, capable Gaku Inami
@ 2014-06-05 4:09 ` Simon Horman
2014-06-19 7:49 ` Paul Bolle
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Simon Horman @ 2014-06-05 4:09 UTC (permalink / raw)
To: linux-sh
On Thu, Jun 05, 2014 at 12:49:44PM +0900, Gaku Inami wrote:
> From: Benoit Cousson <bcousson@baylibre.com>
>
> Mark all SoCs in shmobile as CPUFreq capable
> on multiplatform build only.
>
> Signed-off-by: Benoit Cousson <bcousson@baylibre.com>
> [gaku.inami.xw@bp.renesas.com: Move the definition of cpufreq capable]
> Signed-off-by: Gaku Inami <gaku.inami.xw@bp.renesas.com>
Thanks, I have queued this up.
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v3] ARM: shmobile: Mark all SoCs in shmobile as CPUFreq, capable
2014-06-05 3:49 [PATCH v3] ARM: shmobile: Mark all SoCs in shmobile as CPUFreq, capable Gaku Inami
2014-06-05 4:09 ` Simon Horman
@ 2014-06-19 7:49 ` Paul Bolle
2014-06-19 8:09 ` Simon Horman
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Paul Bolle @ 2014-06-19 7:49 UTC (permalink / raw)
To: linux-sh
On Thu, 2014-06-05 at 12:49 +0900, Gaku Inami wrote:
> From: Benoit Cousson <bcousson@baylibre.com>
>
> Mark all SoCs in shmobile as CPUFreq capable
> on multiplatform build only.
>
> Signed-off-by: Benoit Cousson <bcousson@baylibre.com>
> [gaku.inami.xw@bp.renesas.com: Move the definition of cpufreq capable]
> Signed-off-by: Gaku Inami <gaku.inami.xw@bp.renesas.com>
> ---
This patch landed in next-20140619.
> Changes since version 1:
> - changed "Signed-off-by" and "From" correctly.
> - fixed typo.
>
> Changes since version 2:
> - moved the definition of cpufreq capable for shmobile.
> - reworked based on renesas-devel-v3.15-rc8-20140605.
>
> arch/arm/mach-shmobile/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/mach-shmobile/Kconfig b/arch/arm/mach-shmobile/Kconfig
> index 2a7712b..3b28bd8 100644
> --- a/arch/arm/mach-shmobile/Kconfig
> +++ b/arch/arm/mach-shmobile/Kconfig
> @@ -13,6 +13,8 @@ config ARCH_SHMOBILE_MULTI
> select NO_IOPORT_MAP
> select PINCTRL
> select ARCH_REQUIRE_GPIOLIB
> + select ARCH_HAS_CPUFREQ
The symbol ARCH_HAS_CPUFREQ was just removed in next-20140616, see
commit e49d9b375628 ("ARM: Remove ARCH_HAS_CPUFREQ config option"). So
selecting that became a nop.
Is the trivial patch to drop this select statement queued somewhere?
(Grepping for CPU_FREQ and CPUFREQ in arch/arm/mach-shmobile suggests
that this trivial patch is all that is needed at this point.)
> + select ARCH_HAS_OPP
>
> if ARCH_SHMOBILE_MULTI
>
Paul Bolle
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v3] ARM: shmobile: Mark all SoCs in shmobile as CPUFreq, capable
2014-06-05 3:49 [PATCH v3] ARM: shmobile: Mark all SoCs in shmobile as CPUFreq, capable Gaku Inami
2014-06-05 4:09 ` Simon Horman
2014-06-19 7:49 ` Paul Bolle
@ 2014-06-19 8:09 ` Simon Horman
2014-06-19 9:16 ` Gaku Inami
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Simon Horman @ 2014-06-19 8:09 UTC (permalink / raw)
To: linux-sh
On Thu, Jun 19, 2014 at 09:49:35AM +0200, Paul Bolle wrote:
> On Thu, 2014-06-05 at 12:49 +0900, Gaku Inami wrote:
> > From: Benoit Cousson <bcousson@baylibre.com>
> >
> > Mark all SoCs in shmobile as CPUFreq capable
> > on multiplatform build only.
> >
> > Signed-off-by: Benoit Cousson <bcousson@baylibre.com>
> > [gaku.inami.xw@bp.renesas.com: Move the definition of cpufreq capable]
> > Signed-off-by: Gaku Inami <gaku.inami.xw@bp.renesas.com>
> > ---
>
> This patch landed in next-20140619.
>
> > Changes since version 1:
> > - changed "Signed-off-by" and "From" correctly.
> > - fixed typo.
> >
> > Changes since version 2:
> > - moved the definition of cpufreq capable for shmobile.
> > - reworked based on renesas-devel-v3.15-rc8-20140605.
> >
> > arch/arm/mach-shmobile/Kconfig | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm/mach-shmobile/Kconfig b/arch/arm/mach-shmobile/Kconfig
> > index 2a7712b..3b28bd8 100644
> > --- a/arch/arm/mach-shmobile/Kconfig
> > +++ b/arch/arm/mach-shmobile/Kconfig
> > @@ -13,6 +13,8 @@ config ARCH_SHMOBILE_MULTI
> > select NO_IOPORT_MAP
> > select PINCTRL
> > select ARCH_REQUIRE_GPIOLIB
> > + select ARCH_HAS_CPUFREQ
>
> The symbol ARCH_HAS_CPUFREQ was just removed in next-20140616, see
> commit e49d9b375628 ("ARM: Remove ARCH_HAS_CPUFREQ config option"). So
> selecting that became a nop.
>
> Is the trivial patch to drop this select statement queued somewhere?
>
> (Grepping for CPU_FREQ and CPUFREQ in arch/arm/mach-shmobile suggests
> that this trivial patch is all that is needed at this point.)
>
> > + select ARCH_HAS_OPP
> >
> > if ARCH_SHMOBILE_MULTI
Thanks for the follow-up Paul.
Inami-san, could you please make an appropriate patch?
Please note the dependency on the patch that Paul has noted,
hopefully it will be included in v3.16-rc2.
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v3] ARM: shmobile: Mark all SoCs in shmobile as CPUFreq, capable
2014-06-05 3:49 [PATCH v3] ARM: shmobile: Mark all SoCs in shmobile as CPUFreq, capable Gaku Inami
` (2 preceding siblings ...)
2014-06-19 8:09 ` Simon Horman
@ 2014-06-19 9:16 ` Gaku Inami
2014-06-20 1:18 ` Simon Horman
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Gaku Inami @ 2014-06-19 9:16 UTC (permalink / raw)
To: linux-sh
Hi Simon-san,
(2014/06/19 17:09), Simon Horman wrote:
>
> Inami-san, could you please make an appropriate patch?
>
> Please note the dependency on the patch that Paul has noted,
> hopefully it will be included in v3.16-rc2.
I understand. I will fix it and send again.
Regards,
Inami
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v3] ARM: shmobile: Mark all SoCs in shmobile as CPUFreq, capable
2014-06-05 3:49 [PATCH v3] ARM: shmobile: Mark all SoCs in shmobile as CPUFreq, capable Gaku Inami
` (3 preceding siblings ...)
2014-06-19 9:16 ` Gaku Inami
@ 2014-06-20 1:18 ` Simon Horman
2014-06-20 4:40 ` Gaku Inami
2014-06-20 5:04 ` Simon Horman
6 siblings, 0 replies; 8+ messages in thread
From: Simon Horman @ 2014-06-20 1:18 UTC (permalink / raw)
To: linux-sh
On Thu, Jun 19, 2014 at 06:16:13PM +0900, Gaku Inami wrote:
> Hi Simon-san,
>
> (2014/06/19 17:09), Simon Horman wrote:
> >
> > Inami-san, could you please make an appropriate patch?
> >
> > Please note the dependency on the patch that Paul has noted,
> > hopefully it will be included in v3.16-rc2.
>
> I understand. I will fix it and send again.
Please just send an (probably small) incremental patch that applies
on top of my current devel branch. There is no need to rework
your patches that I have already queued up.
Thanks
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v3] ARM: shmobile: Mark all SoCs in shmobile as CPUFreq, capable
2014-06-05 3:49 [PATCH v3] ARM: shmobile: Mark all SoCs in shmobile as CPUFreq, capable Gaku Inami
` (4 preceding siblings ...)
2014-06-20 1:18 ` Simon Horman
@ 2014-06-20 4:40 ` Gaku Inami
2014-06-20 5:04 ` Simon Horman
6 siblings, 0 replies; 8+ messages in thread
From: Gaku Inami @ 2014-06-20 4:40 UTC (permalink / raw)
To: linux-sh
Hi Simon-san,
(2014/06/20 10:18), Simon Horman wrote:
> On Thu, Jun 19, 2014 at 06:16:13PM +0900, Gaku Inami wrote:
>> Hi Simon-san,
>>
>> (2014/06/19 17:09), Simon Horman wrote:
>>> Inami-san, could you please make an appropriate patch?
>>>
>>> Please note the dependency on the patch that Paul has noted,
>>> hopefully it will be included in v3.16-rc2.
>> I understand. I will fix it and send again.
> Please just send an (probably small) incremental patch that applies
> on top of my current devel branch. There is no need to rework
> your patches that I have already queued up.
I'm sorry, my reply was not appropriate.
I posted a new patch(no rework patch from patch v3).
Please find the following commit:
http://marc.info/?l=linux-sh&m\x140317622532328&w=2
This patch can be applied to the top of renesas-devel.
(tag:renesas-devel-v3.16-rc1-20140618)
Also, this patch can be applied to linux-next(next-20140619).
Regards,
Inami
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v3] ARM: shmobile: Mark all SoCs in shmobile as CPUFreq, capable
2014-06-05 3:49 [PATCH v3] ARM: shmobile: Mark all SoCs in shmobile as CPUFreq, capable Gaku Inami
` (5 preceding siblings ...)
2014-06-20 4:40 ` Gaku Inami
@ 2014-06-20 5:04 ` Simon Horman
6 siblings, 0 replies; 8+ messages in thread
From: Simon Horman @ 2014-06-20 5:04 UTC (permalink / raw)
To: linux-sh
On Fri, Jun 20, 2014 at 01:40:15PM +0900, Gaku Inami wrote:
> Hi Simon-san,
>
> (2014/06/20 10:18), Simon Horman wrote:
> > On Thu, Jun 19, 2014 at 06:16:13PM +0900, Gaku Inami wrote:
> >> Hi Simon-san,
> >>
> >> (2014/06/19 17:09), Simon Horman wrote:
> >>> Inami-san, could you please make an appropriate patch?
> >>>
> >>> Please note the dependency on the patch that Paul has noted,
> >>> hopefully it will be included in v3.16-rc2.
> >> I understand. I will fix it and send again.
> > Please just send an (probably small) incremental patch that applies
> > on top of my current devel branch. There is no need to rework
> > your patches that I have already queued up.
>
> I'm sorry, my reply was not appropriate.
>
> I posted a new patch(no rework patch from patch v3).
> Please find the following commit:
> http://marc.info/?l=linux-sh&m\x140317622532328&w=2
>
> This patch can be applied to the top of renesas-devel.
> (tag:renesas-devel-v3.16-rc1-20140618)
> Also, this patch can be applied to linux-next(next-20140619).
Thanks, it looks good.
^ permalink raw reply [flat|nested] 8+ messages in thread