All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH nftables 1/3] meta: Add support for SKPID and SKSID meta keys
@ 2014-06-05 14:19 Yuxuan Shui
  2014-06-05 14:19 ` [PATCH libnftnl 2/3] " Yuxuan Shui
  2014-06-05 14:19 ` [PATCH 3/3] netfilter: Add " Yuxuan Shui
  0 siblings, 2 replies; 9+ messages in thread
From: Yuxuan Shui @ 2014-06-05 14:19 UTC (permalink / raw)
  To: netfilter-devel; +Cc: Yuxuan Shui

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
---
 include/datatype.h                  |  4 +++
 include/linux/netfilter/nf_tables.h |  4 +++
 src/meta.c                          | 55 +++++++++++++++++++++++++++++++++++++
 src/parser.y                        |  6 +++-
 src/scanner.l                       |  2 ++
 5 files changed, 70 insertions(+), 1 deletion(-)

diff --git a/include/datatype.h b/include/datatype.h
index 2c66e9d..73b8cc5 100644
--- a/include/datatype.h
+++ b/include/datatype.h
@@ -35,6 +35,8 @@
  * @TYPE_CT_STATUS:	conntrack status (bitmask subtype)
  * @TYPE_ICMP6_TYPE:	ICMPv6 type codes (integer subtype)
  * @TYPE_CT_LABEL:	Conntrack Label (bitmask subtype)
+ * @TYPE_PID:		process ID (integer subtype)
+ * @TYPE_SID:		process session ID (integer subtype)
  */
 enum datatypes {
 	TYPE_INVALID,
@@ -68,6 +70,8 @@ enum datatypes {
 	TYPE_CT_STATUS,
 	TYPE_ICMP6_TYPE,
 	TYPE_CT_LABEL,
+	TYPE_PID,
+	TYPE_SID,
 	__TYPE_MAX
 };
 #define TYPE_MAX		(__TYPE_MAX - 1)
diff --git a/include/linux/netfilter/nf_tables.h b/include/linux/netfilter/nf_tables.h
index a5f8ec0..dfdb251 100644
--- a/include/linux/netfilter/nf_tables.h
+++ b/include/linux/netfilter/nf_tables.h
@@ -535,6 +535,8 @@ enum nft_exthdr_attributes {
  * @NFT_META_L4PROTO: layer 4 protocol number
  * @NFT_META_BRI_IIFNAME: packet input bridge interface name
  * @NFT_META_BRI_OIFNAME: packet output bridge interface name
+ * @NFT_META_SKPID: origination socket owner PID
+ * @NFT_META_SKSID: origination socket owner SID
  */
 enum nft_meta_keys {
 	NFT_META_LEN,
@@ -556,6 +558,8 @@ enum nft_meta_keys {
 	NFT_META_L4PROTO,
 	NFT_META_BRI_IIFNAME,
 	NFT_META_BRI_OIFNAME,
+	NFT_META_SKPID,
+	NFT_META_SKSID,
 };
 
 /**
diff --git a/src/meta.c b/src/meta.c
index 80f88ff..957157e 100644
--- a/src/meta.c
+++ b/src/meta.c
@@ -297,6 +297,57 @@ static const struct datatype gid_type = {
 	.parse		= gid_type_parse,
 };
 
+static void pid_type_print(const struct expr *expr)
+{
+	if (numeric_output < NUMERIC_ALL) {
+		uint32_t pid = mpz_get_uint32(expr->value);
+
+		printf("%d", pid);
+		return;
+	}
+	expr_basetype(expr)->print(expr);
+}
+
+static struct error_record *pid_type_parse(const struct expr *sym,
+					   struct expr **res)
+{
+	uint64_t pid;
+	char *endptr = NULL;
+
+	pid = strtoull(sym->identifier, &endptr, 10);
+	if (pid > UINT32_MAX)
+		return error(&sym->location, "Value too large");
+	else if (*endptr)
+		return error(&sym->location, "Process does not exist");
+
+	*res = constant_expr_alloc(&sym->location, sym->dtype,
+				   BYTEORDER_HOST_ENDIAN,
+				   sizeof(pid) * BITS_PER_BYTE, &pid);
+	return NULL;
+}
+
+static const struct datatype pid_type = {
+	.type		= TYPE_PID,
+	.name		= "pid",
+	.desc		= "process ID",
+	.byteorder	= BYTEORDER_HOST_ENDIAN,
+	.size		= sizeof(pid_t) * BITS_PER_BYTE,
+	.basetype	= &integer_type,
+	.print		= pid_type_print,
+	.parse		= pid_type_parse,
+};
+
+static const struct datatype sid_type = {
+	.type		= TYPE_SID,
+	.name		= "sid",
+	.desc		= "process session ID",
+	.byteorder	= BYTEORDER_HOST_ENDIAN,
+	.size		= sizeof(pid_t) * BITS_PER_BYTE,
+	.basetype	= &integer_type,
+	.print		= pid_type_print,
+	.parse		= pid_type_parse,
+};
+
 static const struct meta_template meta_templates[] = {
 	[NFT_META_LEN]		= META_TEMPLATE("length",    &integer_type,
 						4 * 8, BYTEORDER_HOST_ENDIAN),
@@ -338,6 +389,10 @@ static const struct meta_template meta_templates[] = {
 	[NFT_META_BRI_OIFNAME]	= META_TEMPLATE("obriport",  &string_type,
 						IFNAMSIZ * BITS_PER_BYTE,
 						BYTEORDER_HOST_ENDIAN),
+	[NFT_META_SKPID]	= META_TEMPLATE("skpid",     &pid_type,
+						4 * 8, BYTEORDER_HOST_ENDIAN),
+	[NFT_META_SKSID]	= META_TEMPLATE("sksid",     &sid_type,
+						4 * 8, BYTEORDER_HOST_ENDIAN),
 };
 
 static void meta_expr_print(const struct expr *expr)
diff --git a/src/parser.y b/src/parser.y
index 9c20737..1355cab 100644
--- a/src/parser.y
+++ b/src/parser.y
@@ -307,6 +307,8 @@ static void location_update(struct location *loc, struct location *rhs, int n)
 %token OIFTYPE			"oiftype"
 %token SKUID			"skuid"
 %token SKGID			"skgid"
+%token SKPID			"skpid"
+%token SKSID			"sksid"
 %token NFTRACE			"nftrace"
 %token RTCLASSID		"rtclassid"
 %token IBRIPORT			"ibriport"
@@ -1650,7 +1652,9 @@ meta_key_unqualified	:	MARK		{ $$ = NFT_META_MARK; }
 			|	NFTRACE		{ $$ = NFT_META_NFTRACE; }
 			|	RTCLASSID	{ $$ = NFT_META_RTCLASSID; }
 			|	IBRIPORT	{ $$ = NFT_META_BRI_IIFNAME; }
-			|       OBRIPORT	{ $$ = NFT_META_BRI_OIFNAME; }
+			|	OBRIPORT	{ $$ = NFT_META_BRI_OIFNAME; }
+			|	SKPID		{ $$ = NFT_META_SKPID; }
+			|	SKSID		{ $$ = NFT_META_SKSID; }
 			;
 
 meta_stmt		:	META	meta_key	SET	expr
diff --git a/src/scanner.l b/src/scanner.l
index 801c030..24297d7 100644
--- a/src/scanner.l
+++ b/src/scanner.l
@@ -405,6 +405,8 @@ addrstring	({macaddr}|{ip4addr}|{ip6addr})
 "oiftype"		{ return OIFTYPE; }
 "skuid"			{ return SKUID; }
 "skgid"			{ return SKGID; }
+"skpid"			{ return SKPID; }
+"sksid"			{ return SKSID; }
 "nftrace"		{ return NFTRACE; }
 "rtclassid"		{ return RTCLASSID; }
 "ibriport"		{ return IBRIPORT; }
-- 
1.9.3


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH libnftnl 2/3] meta: Add support for SKPID and SKSID meta keys
  2014-06-05 14:19 [PATCH nftables 1/3] meta: Add support for SKPID and SKSID meta keys Yuxuan Shui
@ 2014-06-05 14:19 ` Yuxuan Shui
  2014-06-05 14:19 ` [PATCH 3/3] netfilter: Add " Yuxuan Shui
  1 sibling, 0 replies; 9+ messages in thread
From: Yuxuan Shui @ 2014-06-05 14:19 UTC (permalink / raw)
  To: netfilter-devel; +Cc: Yuxuan Shui

Add SKPID and SKSID meta keys so we can implement PID and SID matching
rules in nft.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
---
 include/linux/netfilter/nf_tables.h | 4 ++++
 src/expr/meta.c                     | 4 +++-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/include/linux/netfilter/nf_tables.h b/include/linux/netfilter/nf_tables.h
index 2a88f64..cea17d4 100644
--- a/include/linux/netfilter/nf_tables.h
+++ b/include/linux/netfilter/nf_tables.h
@@ -571,6 +571,8 @@ enum nft_exthdr_attributes {
  * @NFT_META_L4PROTO: layer 4 protocol number
  * @NFT_META_BRI_IIFNAME: packet input bridge interface name
  * @NFT_META_BRI_OIFNAME: packet output bridge interface name
+ * @NFT_META_SKPID: origination socket owner PID
+ * @NFT_META_SKSID: origination socket owner SID
  */
 enum nft_meta_keys {
 	NFT_META_LEN,
@@ -592,6 +594,8 @@ enum nft_meta_keys {
 	NFT_META_L4PROTO,
 	NFT_META_BRI_IIFNAME,
 	NFT_META_BRI_OIFNAME,
+	NFT_META_SKPID,
+	NFT_META_SKSID,
 };
 
 /**
diff --git a/src/expr/meta.c b/src/expr/meta.c
index fb945f0..1568544 100644
--- a/src/expr/meta.c
+++ b/src/expr/meta.c
@@ -23,7 +23,7 @@
 #include "expr_ops.h"
 
 #ifndef NFT_META_MAX
-#define NFT_META_MAX (NFT_META_BRI_OIFNAME + 1)
+#define NFT_META_MAX (NFT_META_SKSID + 1)
 #endif
 
 struct nft_expr_meta {
@@ -155,6 +155,8 @@ static const char *meta_key2str_array[NFT_META_MAX] = {
 	[NFT_META_SECMARK]	= "secmark",
 	[NFT_META_BRI_IIFNAME]	= "bri_iifname",
 	[NFT_META_BRI_OIFNAME]	= "bri_oifname",
+	[NFT_META_SKPID]	= "skpid",
+	[NFT_META_SKSID]	= "sksid",
 };
 
 static const char *meta_key2str(uint8_t key)
-- 
1.9.3


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 3/3] netfilter: Add SKPID and SKSID meta keys
  2014-06-05 14:19 [PATCH nftables 1/3] meta: Add support for SKPID and SKSID meta keys Yuxuan Shui
  2014-06-05 14:19 ` [PATCH libnftnl 2/3] " Yuxuan Shui
@ 2014-06-05 14:19 ` Yuxuan Shui
  2014-06-05 14:25   ` Florian Westphal
                     ` (2 more replies)
  1 sibling, 3 replies; 9+ messages in thread
From: Yuxuan Shui @ 2014-06-05 14:19 UTC (permalink / raw)
  To: netfilter-devel; +Cc: Yuxuan Shui

Add SKPID and SKSID meta keys so we can implement PID and SID matching
rules in userspace nft tool.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
---
 include/uapi/linux/netfilter/nf_tables.h |  4 ++++
 net/netfilter/nft_meta.c                 | 25 +++++++++++++++++++++++++
 2 files changed, 29 insertions(+)

diff --git a/include/uapi/linux/netfilter/nf_tables.h b/include/uapi/linux/netfilter/nf_tables.h
index 7d6433f..d41880f 100644
--- a/include/uapi/linux/netfilter/nf_tables.h
+++ b/include/uapi/linux/netfilter/nf_tables.h
@@ -565,6 +565,8 @@ enum nft_exthdr_attributes {
  * @NFT_META_L4PROTO: layer 4 protocol number
  * @NFT_META_BRI_IIFNAME: packet input bridge interface name
  * @NFT_META_BRI_OIFNAME: packet output bridge interface name
+ * @NFT_META_SKPID: origination socket owner PID
+ * @NFT_META_SKSID: origination socket owner SID
  */
 enum nft_meta_keys {
 	NFT_META_LEN,
@@ -586,6 +588,8 @@ enum nft_meta_keys {
 	NFT_META_L4PROTO,
 	NFT_META_BRI_IIFNAME,
 	NFT_META_BRI_OIFNAME,
+	NFT_META_SKPID,
+	NFT_META_SKSID,
 };
 
 /**
diff --git a/net/netfilter/nft_meta.c b/net/netfilter/nft_meta.c
index 852b178..777ed53 100644
--- a/net/netfilter/nft_meta.c
+++ b/net/netfilter/nft_meta.c
@@ -14,6 +14,7 @@
 #include <linux/netlink.h>
 #include <linux/netfilter.h>
 #include <linux/netfilter/nf_tables.h>
+#include <linux/pid.h>
 #include <net/dst.h>
 #include <net/sock.h>
 #include <net/tcp_states.h> /* for TCP_TIME_WAIT */
@@ -27,6 +28,8 @@ void nft_meta_get_eval(const struct nft_expr *expr,
 	const struct nft_meta *priv = nft_expr_priv(expr);
 	const struct sk_buff *skb = pkt->skb;
 	const struct net_device *in = pkt->in, *out = pkt->out;
+	const struct task_struct *task;
+	const struct pid *sid;
 	struct nft_data *dest = &data[priv->dreg];
 
 	switch (priv->key) {
@@ -109,6 +112,26 @@ void nft_meta_get_eval(const struct nft_expr *expr,
 				 skb->sk->sk_socket->file->f_cred->fsgid);
 		read_unlock_bh(&skb->sk->sk_callback_lock);
 		break;
+	case NFT_META_SKPID:
+		if (skb->sk == NULL || skb->sk->sk_state == TCP_TIME_WAIT)
+			goto err;
+
+		read_lock_bh(&skb->sk->sk_callback_lock);
+		dest->data[0] = pid_nr(skb->sk->sk_peer_pid);
+		read_unlock_bh(&skb->sk->sk_callback_lock);
+		break;
+	case NFT_META_SKSID:
+		if (skb->sk == NULL || skb->sk->sk_state == TCP_TIME_WAIT)
+			goto err;
+
+		read_lock_bh(&skb->sk->sk_callback_lock);
+		task = get_pid_task(skb->sk->sk_peer_pid, PIDTYPE_PID);
+		sid = task_session(task);
+		if (!sid)
+			goto err;
+		dest->data[0] = pid_nr(sid);
+		read_unlock_bh(&skb->sk->sk_callback_lock);
+		break;
 #ifdef CONFIG_IP_ROUTE_CLASSID
 	case NFT_META_RTCLASSID: {
 		const struct dst_entry *dst = skb_dst(skb);
@@ -189,6 +212,8 @@ int nft_meta_get_init(const struct nft_ctx *ctx,
 	case NFT_META_OIFTYPE:
 	case NFT_META_SKUID:
 	case NFT_META_SKGID:
+	case NFT_META_PID:
+	case NFT_META_SID:
 #ifdef CONFIG_IP_ROUTE_CLASSID
 	case NFT_META_RTCLASSID:
 #endif
-- 
1.9.3


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH 3/3] netfilter: Add SKPID and SKSID meta keys
  2014-06-05 14:19 ` [PATCH 3/3] netfilter: Add " Yuxuan Shui
@ 2014-06-05 14:25   ` Florian Westphal
  2014-06-10 11:01   ` Pablo Neira Ayuso
  2014-06-21 14:40   ` [PATCH v2] " Yuxuan Shui
  2 siblings, 0 replies; 9+ messages in thread
From: Florian Westphal @ 2014-06-05 14:25 UTC (permalink / raw)
  To: Yuxuan Shui; +Cc: netfilter-devel

Yuxuan Shui <yshuiv7@gmail.com> wrote:
 +	case NFT_META_SKPID:
> +		if (skb->sk == NULL || skb->sk->sk_state == TCP_TIME_WAIT)
> +			goto err;
> +
> +		read_lock_bh(&skb->sk->sk_callback_lock);
> +		dest->data[0] = pid_nr(skb->sk->sk_peer_pid);
> +		read_unlock_bh(&skb->sk->sk_callback_lock);
> +		break;
> +	case NFT_META_SKSID:
> +		if (skb->sk == NULL || skb->sk->sk_state == TCP_TIME_WAIT)
> +			goto err;
> +
> +		read_lock_bh(&skb->sk->sk_callback_lock);
> +		task = get_pid_task(skb->sk->sk_peer_pid, PIDTYPE_PID);
> +		sid = task_session(task);
> +		if (!sid)

looks like you need to unlock here.

> +			goto err;

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 3/3] netfilter: Add SKPID and SKSID meta keys
  2014-06-05 14:19 ` [PATCH 3/3] netfilter: Add " Yuxuan Shui
  2014-06-05 14:25   ` Florian Westphal
@ 2014-06-10 11:01   ` Pablo Neira Ayuso
  2014-06-19 10:16     ` Tomasz Bursztyka
  2014-06-21 14:40   ` [PATCH v2] " Yuxuan Shui
  2 siblings, 1 reply; 9+ messages in thread
From: Pablo Neira Ayuso @ 2014-06-10 11:01 UTC (permalink / raw)
  To: Yuxuan Shui; +Cc: netfilter-devel, Tomasz Bursztyka

On Thu, Jun 05, 2014 at 10:19:16PM +0800, Yuxuan Shui wrote:
> Add SKPID and SKSID meta keys so we can implement PID and SID matching
> rules in userspace nft tool.

I would like to have some use case in the patch description that
justifies how this can be useful to everyone.

I don't want add more selectors just because we can make it, they
should allow to perform some useful action.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 3/3] netfilter: Add SKPID and SKSID meta keys
  2014-06-10 11:01   ` Pablo Neira Ayuso
@ 2014-06-19 10:16     ` Tomasz Bursztyka
  2014-06-19 10:19       ` Pablo Neira Ayuso
  0 siblings, 1 reply; 9+ messages in thread
From: Tomasz Bursztyka @ 2014-06-19 10:16 UTC (permalink / raw)
  To: Pablo Neira Ayuso, Yuxuan Shui; +Cc: netfilter-devel

Hi Pablo,

>> Add SKPID and SKSID meta keys so we can implement PID and SID matching
>> >rules in userspace nft tool.
> I would like to have some use case in the patch description that
> justifies how this can be useful to everyone.
>
> I don't want add more selectors just because we can make it, they
> should allow to perform some useful action.

To mimic xtables libxt_owner extension, would that be sufficient?

Tomasz

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 3/3] netfilter: Add SKPID and SKSID meta keys
  2014-06-19 10:16     ` Tomasz Bursztyka
@ 2014-06-19 10:19       ` Pablo Neira Ayuso
  2014-06-19 10:25         ` Tomasz Bursztyka
  0 siblings, 1 reply; 9+ messages in thread
From: Pablo Neira Ayuso @ 2014-06-19 10:19 UTC (permalink / raw)
  To: Tomasz Bursztyka; +Cc: Yuxuan Shui, netfilter-devel

On Thu, Jun 19, 2014 at 01:16:55PM +0300, Tomasz Bursztyka wrote:
> Hi Pablo,
> 
> >>Add SKPID and SKSID meta keys so we can implement PID and SID matching
> >>>rules in userspace nft tool.
> >I would like to have some use case in the patch description that
> >justifies how this can be useful to everyone.
> >
> >I don't want add more selectors just because we can make it, they
> >should allow to perform some useful action.
> 
> To mimic xtables libxt_owner extension, would that be sufficient?

That is already achieved through skuid and skgid.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 3/3] netfilter: Add SKPID and SKSID meta keys
  2014-06-19 10:19       ` Pablo Neira Ayuso
@ 2014-06-19 10:25         ` Tomasz Bursztyka
  0 siblings, 0 replies; 9+ messages in thread
From: Tomasz Bursztyka @ 2014-06-19 10:25 UTC (permalink / raw)
  To: Pablo Neira Ayuso; +Cc: Yuxuan Shui, netfilter-devel


>> To mimic xtables libxt_owner extension, would that be sufficient?
> That is already achieved through skuid and skgid.

What about:

[!] --pid-owner processid    Match local PID
[!] --sid-owner sessionid    Match local SID

Though in kernel side, I could not find any handlers for those... Unless 
I missed something.

Tomasz


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH v2] netfilter: Add SKPID and SKSID meta keys
  2014-06-05 14:19 ` [PATCH 3/3] netfilter: Add " Yuxuan Shui
  2014-06-05 14:25   ` Florian Westphal
  2014-06-10 11:01   ` Pablo Neira Ayuso
@ 2014-06-21 14:40   ` Yuxuan Shui
  2 siblings, 0 replies; 9+ messages in thread
From: Yuxuan Shui @ 2014-06-21 14:40 UTC (permalink / raw)
  To: netfilter-devel; +Cc: Yuxuan Shui

Add SKPID and SKSID meta keys so we can implement PID and SID matching
rules in userspace nft tool.

v2: Fix compiler warnings.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
---
 include/uapi/linux/netfilter/nf_tables.h |  4 ++++
 net/netfilter/nft_meta.c                 | 27 +++++++++++++++++++++++++++
 2 files changed, 31 insertions(+)

diff --git a/include/uapi/linux/netfilter/nf_tables.h b/include/uapi/linux/netfilter/nf_tables.h
index 7d6433f..d41880f 100644
--- a/include/uapi/linux/netfilter/nf_tables.h
+++ b/include/uapi/linux/netfilter/nf_tables.h
@@ -565,6 +565,8 @@ enum nft_exthdr_attributes {
  * @NFT_META_L4PROTO: layer 4 protocol number
  * @NFT_META_BRI_IIFNAME: packet input bridge interface name
  * @NFT_META_BRI_OIFNAME: packet output bridge interface name
+ * @NFT_META_SKPID: origination socket owner PID
+ * @NFT_META_SKSID: origination socket owner SID
  */
 enum nft_meta_keys {
 	NFT_META_LEN,
@@ -586,6 +588,8 @@ enum nft_meta_keys {
 	NFT_META_L4PROTO,
 	NFT_META_BRI_IIFNAME,
 	NFT_META_BRI_OIFNAME,
+	NFT_META_SKPID,
+	NFT_META_SKSID,
 };
 
 /**
diff --git a/net/netfilter/nft_meta.c b/net/netfilter/nft_meta.c
index 852b178..cb0b067 100644
--- a/net/netfilter/nft_meta.c
+++ b/net/netfilter/nft_meta.c
@@ -14,6 +14,7 @@
 #include <linux/netlink.h>
 #include <linux/netfilter.h>
 #include <linux/netfilter/nf_tables.h>
+#include <linux/pid.h>
 #include <net/dst.h>
 #include <net/sock.h>
 #include <net/tcp_states.h> /* for TCP_TIME_WAIT */
@@ -27,7 +28,9 @@ void nft_meta_get_eval(const struct nft_expr *expr,
 	const struct nft_meta *priv = nft_expr_priv(expr);
 	const struct sk_buff *skb = pkt->skb;
 	const struct net_device *in = pkt->in, *out = pkt->out;
+	struct pid *sid;
 	struct nft_data *dest = &data[priv->dreg];
+	struct task_struct *task;
 
 	switch (priv->key) {
 	case NFT_META_LEN:
@@ -109,6 +112,28 @@ void nft_meta_get_eval(const struct nft_expr *expr,
 				 skb->sk->sk_socket->file->f_cred->fsgid);
 		read_unlock_bh(&skb->sk->sk_callback_lock);
 		break;
+	case NFT_META_SKPID:
+		if (skb->sk == NULL || skb->sk->sk_state == TCP_TIME_WAIT)
+			goto err;
+
+		read_lock_bh(&skb->sk->sk_callback_lock);
+		dest->data[0] = pid_nr(skb->sk->sk_peer_pid);
+		read_unlock_bh(&skb->sk->sk_callback_lock);
+		break;
+	case NFT_META_SKSID:
+		if (skb->sk == NULL || skb->sk->sk_state == TCP_TIME_WAIT)
+			goto err;
+
+		read_lock_bh(&skb->sk->sk_callback_lock);
+		task = get_pid_task(skb->sk->sk_peer_pid, PIDTYPE_PID);
+		sid = task_session(task);
+		if (!sid) {
+			read_unlock_bh(&skb->sk->sk_callback_lock);
+			goto err;
+		}
+		dest->data[0] = pid_nr(sid);
+		read_unlock_bh(&skb->sk->sk_callback_lock);
+		break;
 #ifdef CONFIG_IP_ROUTE_CLASSID
 	case NFT_META_RTCLASSID: {
 		const struct dst_entry *dst = skb_dst(skb);
@@ -189,6 +214,8 @@ int nft_meta_get_init(const struct nft_ctx *ctx,
 	case NFT_META_OIFTYPE:
 	case NFT_META_SKUID:
 	case NFT_META_SKGID:
+	case NFT_META_SKPID:
+	case NFT_META_SKSID:
 #ifdef CONFIG_IP_ROUTE_CLASSID
 	case NFT_META_RTCLASSID:
 #endif
-- 
2.0.0


^ permalink raw reply related	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2014-06-21 14:40 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-05 14:19 [PATCH nftables 1/3] meta: Add support for SKPID and SKSID meta keys Yuxuan Shui
2014-06-05 14:19 ` [PATCH libnftnl 2/3] " Yuxuan Shui
2014-06-05 14:19 ` [PATCH 3/3] netfilter: Add " Yuxuan Shui
2014-06-05 14:25   ` Florian Westphal
2014-06-10 11:01   ` Pablo Neira Ayuso
2014-06-19 10:16     ` Tomasz Bursztyka
2014-06-19 10:19       ` Pablo Neira Ayuso
2014-06-19 10:25         ` Tomasz Bursztyka
2014-06-21 14:40   ` [PATCH v2] " Yuxuan Shui

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.