All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] mx6sabresd: Disable PCI driver
@ 2014-06-20 17:00 Fabio Estevam
  2014-06-20 21:41 ` Marek Vasut
  0 siblings, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2014-06-20 17:00 UTC (permalink / raw)
  To: u-boot

From: Fabio Estevam <fabio.estevam@freescale.com>

Currently we have a kernel hang when U-boot PCI driver is enabled.

Disable it until a better solution is found.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 include/configs/mx6sabresd.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/include/configs/mx6sabresd.h b/include/configs/mx6sabresd.h
index e666ebb..d227f44 100644
--- a/include/configs/mx6sabresd.h
+++ b/include/configs/mx6sabresd.h
@@ -49,7 +49,6 @@
 #define CONFIG_IMX_HDMI
 #define CONFIG_IMX_VIDEO_SKIP
 
-#define CONFIG_CMD_PCI
 #ifdef CONFIG_CMD_PCI
 #define CONFIG_PCI
 #define CONFIG_PCI_PNP
-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] mx6sabresd: Disable PCI driver
  2014-06-20 17:00 [U-Boot] [PATCH] mx6sabresd: Disable PCI driver Fabio Estevam
@ 2014-06-20 21:41 ` Marek Vasut
  2014-06-21 14:00   ` Fabio Estevam
  0 siblings, 1 reply; 4+ messages in thread
From: Marek Vasut @ 2014-06-20 21:41 UTC (permalink / raw)
  To: u-boot

On Friday, June 20, 2014 at 07:00:28 PM, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Currently we have a kernel hang when U-boot PCI driver is enabled.
> 
> Disable it until a better solution is found.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

This looks like solving a bug on a wrong end. It is the kernel that needs to be 
fixed, not U-Boot.

Best regards,
Marek Vasut

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] mx6sabresd: Disable PCI driver
  2014-06-20 21:41 ` Marek Vasut
@ 2014-06-21 14:00   ` Fabio Estevam
  2014-06-21 20:38     ` Jeroen Hofstee
  0 siblings, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2014-06-21 14:00 UTC (permalink / raw)
  To: u-boot

On Fri, Jun 20, 2014 at 6:41 PM, Marek Vasut <marex@denx.de> wrote:
> On Friday, June 20, 2014 at 07:00:28 PM, Fabio Estevam wrote:
>> From: Fabio Estevam <fabio.estevam@freescale.com>
>>
>> Currently we have a kernel hang when U-boot PCI driver is enabled.
>>
>> Disable it until a better solution is found.
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>
> This looks like solving a bug on a wrong end. It is the kernel that needs to be
> fixed, not U-Boot.

Since there is no fix in the kernel I prefer to remove this from
U-boot from the time being to avoid the kernel hang.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] mx6sabresd: Disable PCI driver
  2014-06-21 14:00   ` Fabio Estevam
@ 2014-06-21 20:38     ` Jeroen Hofstee
  0 siblings, 0 replies; 4+ messages in thread
From: Jeroen Hofstee @ 2014-06-21 20:38 UTC (permalink / raw)
  To: u-boot

On za, 2014-06-21 at 11:00 -0300, Fabio Estevam wrote:
> On Fri, Jun 20, 2014 at 6:41 PM, Marek Vasut <marex@denx.de> wrote:
> > On Friday, June 20, 2014 at 07:00:28 PM, Fabio Estevam wrote:
> >> From: Fabio Estevam <fabio.estevam@freescale.com>
> >>
> >> Currently we have a kernel hang when U-boot PCI driver is enabled.
> >>
> >> Disable it until a better solution is found.
> >>
> >> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> >
> > This looks like solving a bug on a wrong end. It is the kernel that needs to be
> > fixed, not U-Boot.
> 
> Since there is no fix in the kernel I prefer to remove this from
> U-boot from the time being to avoid the kernel hang.

this sounds evil, just fix/workaround it in your linux version.

Regards,
Jeroen

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-06-21 20:38 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-20 17:00 [U-Boot] [PATCH] mx6sabresd: Disable PCI driver Fabio Estevam
2014-06-20 21:41 ` Marek Vasut
2014-06-21 14:00   ` Fabio Estevam
2014-06-21 20:38     ` Jeroen Hofstee

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.