* [PATCH] Documentation: Update remove_from_page_cache with delete_from_page_cache
@ 2014-06-23 9:11 Lei Li
[not found] ` <20140623092305.GF9743@dhcp22.suse.cz>
0 siblings, 1 reply; 6+ messages in thread
From: Lei Li @ 2014-06-23 9:11 UTC (permalink / raw)
To: linux-mm@kvack.org.linux-kernel@vger.kernel.org.cgroups
Cc: hannes, mhocko, tj, akpm, Lei Li
remove_from_page_cache has been renamed to delete_from_page_cache
since Commit 702cfbf9 ("mm: goodbye remove_from_page_cache()"), adapt
to it in Memcg documentation.
Signed-off-by: Lei Li <lilei@linux.vnet.ibm.com>
---
Documentation/cgroups/memcg_test.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/cgroups/memcg_test.txt b/Documentation/cgroups/memcg_test.txt
index 80ac454..b2d6ccc 100644
--- a/Documentation/cgroups/memcg_test.txt
+++ b/Documentation/cgroups/memcg_test.txt
@@ -171,10 +171,10 @@ Under below explanation, we assume CONFIG_MEM_RES_CTRL_SWAP=y.
- add_to_page_cache_locked().
uncharged at
- - __remove_from_page_cache().
+ - __delete_from_page_cache().
The logic is very clear. (About migration, see below)
- Note: __remove_from_page_cache() is called by remove_from_page_cache()
+ Note: __delete_from_page_cache() is called by delete_from_page_cache()
and __remove_mapping().
6. Shmem(tmpfs) Page Cache
--
1.8.5.3
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Documentation: Update remove_from_page_cache with delete_from_page_cache
[not found] ` <20140623092305.GF9743@dhcp22.suse.cz>
@ 2014-06-24 7:35 ` Lei Li
0 siblings, 0 replies; 6+ messages in thread
From: Lei Li @ 2014-06-24 7:35 UTC (permalink / raw)
To: Michal Hocko; +Cc: hannes, tj, akpm, linux-mm, linux-kernel, cgroups
On 06/23/2014 05:23 PM, Michal Hocko wrote:
> On Mon 23-06-14 17:11:19, Lei Li wrote:
>> remove_from_page_cache has been renamed to delete_from_page_cache
>> since Commit 702cfbf9 ("mm: goodbye remove_from_page_cache()"), adapt
>> to it in Memcg documentation.
>>
>> Signed-off-by: Lei Li <lilei@linux.vnet.ibm.com>
> This conflicts with the current mmotm tree because of Johannes' {un}charge rewrite.
> Anyway the comment is not up-to-date anyway. __delete_from_page_cache is
> called from more places and I do not see quite a good reason why to keep
> this in the documentation.
> I would just remove this note as it doesn't serve any useful purpose.
Thanks for your reply.
Just take a quick look at Johannes' patch of rewriting uncharge API. I'll
resend a patch with the note removed.
Thanks,
Lei
>
>> ---
>> Documentation/cgroups/memcg_test.txt | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/cgroups/memcg_test.txt b/Documentation/cgroups/memcg_test.txt
>> index 80ac454..b2d6ccc 100644
>> --- a/Documentation/cgroups/memcg_test.txt
>> +++ b/Documentation/cgroups/memcg_test.txt
>> @@ -171,10 +171,10 @@ Under below explanation, we assume CONFIG_MEM_RES_CTRL_SWAP=y.
>> - add_to_page_cache_locked().
>>
>> uncharged at
>> - - __remove_from_page_cache().
>> + - __delete_from_page_cache().
>>
>> The logic is very clear. (About migration, see below)
>> - Note: __remove_from_page_cache() is called by remove_from_page_cache()
>> + Note: __delete_from_page_cache() is called by delete_from_page_cache()
>> and __remove_mapping().
>>
>> 6. Shmem(tmpfs) Page Cache
>> --
>> 1.8.5.3
>>
>> --
>> To unsubscribe, send a message with 'unsubscribe linux-mm' in
>> the body to majordomo@kvack.org. For more info on Linux MM,
>> see: http://www.linux-mm.org/ .
>> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Documentation: Update remove_from_page_cache with delete_from_page_cache
@ 2014-06-24 7:35 ` Lei Li
0 siblings, 0 replies; 6+ messages in thread
From: Lei Li @ 2014-06-24 7:35 UTC (permalink / raw)
To: Michal Hocko; +Cc: hannes, tj, akpm, linux-mm, linux-kernel, cgroups
On 06/23/2014 05:23 PM, Michal Hocko wrote:
> On Mon 23-06-14 17:11:19, Lei Li wrote:
>> remove_from_page_cache has been renamed to delete_from_page_cache
>> since Commit 702cfbf9 ("mm: goodbye remove_from_page_cache()"), adapt
>> to it in Memcg documentation.
>>
>> Signed-off-by: Lei Li <lilei@linux.vnet.ibm.com>
> This conflicts with the current mmotm tree because of Johannes' {un}charge rewrite.
> Anyway the comment is not up-to-date anyway. __delete_from_page_cache is
> called from more places and I do not see quite a good reason why to keep
> this in the documentation.
> I would just remove this note as it doesn't serve any useful purpose.
Thanks for your reply.
Just take a quick look at Johannes' patch of rewriting uncharge API. I'll
resend a patch with the note removed.
Thanks,
Lei
>
>> ---
>> Documentation/cgroups/memcg_test.txt | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/cgroups/memcg_test.txt b/Documentation/cgroups/memcg_test.txt
>> index 80ac454..b2d6ccc 100644
>> --- a/Documentation/cgroups/memcg_test.txt
>> +++ b/Documentation/cgroups/memcg_test.txt
>> @@ -171,10 +171,10 @@ Under below explanation, we assume CONFIG_MEM_RES_CTRL_SWAP=y.
>> - add_to_page_cache_locked().
>>
>> uncharged at
>> - - __remove_from_page_cache().
>> + - __delete_from_page_cache().
>>
>> The logic is very clear. (About migration, see below)
>> - Note: __remove_from_page_cache() is called by remove_from_page_cache()
>> + Note: __delete_from_page_cache() is called by delete_from_page_cache()
>> and __remove_mapping().
>>
>> 6. Shmem(tmpfs) Page Cache
>> --
>> 1.8.5.3
>>
>> --
>> To unsubscribe, send a message with 'unsubscribe linux-mm' in
>> the body to majordomo@kvack.org. For more info on Linux MM,
>> see: http://www.linux-mm.org/ .
>> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] Documentation: Update remove_from_page_cache with delete_from_page_cache
@ 2014-06-19 6:32 ` Lei Li
0 siblings, 0 replies; 6+ messages in thread
From: Lei Li @ 2014-06-19 6:32 UTC (permalink / raw)
To: linux-kernel; +Cc: cgroups, linux-mm, mhocko, Lei Li
remove_from_page_cache has been renamed to delete_from_page_cache
since Commit 702cfbf9 ("mm: goodbye remove_from_page_cache()"), adapt
to it in Memcg documentation.
Signed-off-by: Lei Li <lilei@linux.vnet.ibm.com>
---
Documentation/cgroups/memcg_test.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/cgroups/memcg_test.txt b/Documentation/cgroups/memcg_test.txt
index 80ac454..b2d6ccc 100644
--- a/Documentation/cgroups/memcg_test.txt
+++ b/Documentation/cgroups/memcg_test.txt
@@ -171,10 +171,10 @@ Under below explanation, we assume CONFIG_MEM_RES_CTRL_SWAP=y.
- add_to_page_cache_locked().
uncharged at
- - __remove_from_page_cache().
+ - __delete_from_page_cache().
The logic is very clear. (About migration, see below)
- Note: __remove_from_page_cache() is called by remove_from_page_cache()
+ Note: __delete_from_page_cache() is called by delete_from_page_cache()
and __remove_mapping().
6. Shmem(tmpfs) Page Cache
--
1.8.5.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] Documentation: Update remove_from_page_cache with delete_from_page_cache
@ 2014-06-19 6:32 ` Lei Li
0 siblings, 0 replies; 6+ messages in thread
From: Lei Li @ 2014-06-19 6:32 UTC (permalink / raw)
To: linux-kernel; +Cc: cgroups, linux-mm, mhocko, Lei Li
remove_from_page_cache has been renamed to delete_from_page_cache
since Commit 702cfbf9 ("mm: goodbye remove_from_page_cache()"), adapt
to it in Memcg documentation.
Signed-off-by: Lei Li <lilei@linux.vnet.ibm.com>
---
Documentation/cgroups/memcg_test.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/cgroups/memcg_test.txt b/Documentation/cgroups/memcg_test.txt
index 80ac454..b2d6ccc 100644
--- a/Documentation/cgroups/memcg_test.txt
+++ b/Documentation/cgroups/memcg_test.txt
@@ -171,10 +171,10 @@ Under below explanation, we assume CONFIG_MEM_RES_CTRL_SWAP=y.
- add_to_page_cache_locked().
uncharged at
- - __remove_from_page_cache().
+ - __delete_from_page_cache().
The logic is very clear. (About migration, see below)
- Note: __remove_from_page_cache() is called by remove_from_page_cache()
+ Note: __delete_from_page_cache() is called by delete_from_page_cache()
and __remove_mapping().
6. Shmem(tmpfs) Page Cache
--
1.8.5.3
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] Documentation: Update remove_from_page_cache with delete_from_page_cache
@ 2014-06-19 6:32 ` Lei Li
0 siblings, 0 replies; 6+ messages in thread
From: Lei Li @ 2014-06-19 6:32 UTC (permalink / raw)
To: linux-kernel-u79uwXL29TY76Z2rM5mHXA
Cc: cgroups-u79uwXL29TY76Z2rM5mHXA, linux-mm-Bw31MaZKKs3YtjvyW6yDsg,
mhocko-AlSwsSmVLrQ, Lei Li
remove_from_page_cache has been renamed to delete_from_page_cache
since Commit 702cfbf9 ("mm: goodbye remove_from_page_cache()"), adapt
to it in Memcg documentation.
Signed-off-by: Lei Li <lilei-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
---
Documentation/cgroups/memcg_test.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/cgroups/memcg_test.txt b/Documentation/cgroups/memcg_test.txt
index 80ac454..b2d6ccc 100644
--- a/Documentation/cgroups/memcg_test.txt
+++ b/Documentation/cgroups/memcg_test.txt
@@ -171,10 +171,10 @@ Under below explanation, we assume CONFIG_MEM_RES_CTRL_SWAP=y.
- add_to_page_cache_locked().
uncharged at
- - __remove_from_page_cache().
+ - __delete_from_page_cache().
The logic is very clear. (About migration, see below)
- Note: __remove_from_page_cache() is called by remove_from_page_cache()
+ Note: __delete_from_page_cache() is called by delete_from_page_cache()
and __remove_mapping().
6. Shmem(tmpfs) Page Cache
--
1.8.5.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-06-24 7:36 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-23 9:11 [PATCH] Documentation: Update remove_from_page_cache with delete_from_page_cache Lei Li
[not found] ` <20140623092305.GF9743@dhcp22.suse.cz>
2014-06-24 7:35 ` Lei Li
2014-06-24 7:35 ` Lei Li
-- strict thread matches above, loose matches on Subject: below --
2014-06-19 6:32 Lei Li
2014-06-19 6:32 ` Lei Li
2014-06-19 6:32 ` Lei Li
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.