From: Deng-Cheng Zhu <dengcheng.zhu@imgtec.com>
To: <pbonzini@redhat.com>
Cc: <gleb@kernel.org>, <kvm@vger.kernel.org>, <sanjayl@kymasys.com>,
<james.hogan@imgtec.com>, <ralf@linux-mips.org>,
<linux-mips@linux-mips.org>, <dengcheng.zhu@imgtec.com>
Subject: [PATCH v3 8/9] MIPS: KVM: Skip memory cleaning in kvm_mips_commpage_init()
Date: Tue, 24 Jun 2014 10:31:09 -0700 [thread overview]
Message-ID: <1403631071-6012-9-git-send-email-dengcheng.zhu@imgtec.com> (raw)
In-Reply-To: <1403631071-6012-1-git-send-email-dengcheng.zhu@imgtec.com>
From: Deng-Cheng Zhu <dengcheng.zhu@imgtec.com>
The commpage is allocated using kzalloc(), so there's no need of cleaning
the memory of the kvm_mips_commpage struct and its internal mips_coproc.
Signed-off-by: Deng-Cheng Zhu <dengcheng.zhu@imgtec.com>
---
arch/mips/kvm/commpage.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/mips/kvm/commpage.c b/arch/mips/kvm/commpage.c
index 61b9c04..2d6e976 100644
--- a/arch/mips/kvm/commpage.c
+++ b/arch/mips/kvm/commpage.c
@@ -28,9 +28,6 @@ void kvm_mips_commpage_init(struct kvm_vcpu *vcpu)
{
struct kvm_mips_commpage *page = vcpu->arch.kseg0_commpage;
- memset(page, 0, sizeof(struct kvm_mips_commpage));
-
/* Specific init values for fields */
vcpu->arch.cop0 = &page->cop0;
- memset(vcpu->arch.cop0, 0, sizeof(struct mips_coproc));
}
--
1.8.5.3
WARNING: multiple messages have this Message-ID (diff)
From: Deng-Cheng Zhu <dengcheng.zhu@imgtec.com>
To: pbonzini@redhat.com
Cc: gleb@kernel.org, kvm@vger.kernel.org, sanjayl@kymasys.com,
james.hogan@imgtec.com, ralf@linux-mips.org,
linux-mips@linux-mips.org, dengcheng.zhu@imgtec.com
Subject: [PATCH v3 8/9] MIPS: KVM: Skip memory cleaning in kvm_mips_commpage_init()
Date: Tue, 24 Jun 2014 10:31:09 -0700 [thread overview]
Message-ID: <1403631071-6012-9-git-send-email-dengcheng.zhu@imgtec.com> (raw)
Message-ID: <20140624173109.7j1Ch9LjEBC5U2Soy6RTbyw_fmgL6Rhriv5EegF6L3Q@z> (raw)
In-Reply-To: <1403631071-6012-1-git-send-email-dengcheng.zhu@imgtec.com>
From: Deng-Cheng Zhu <dengcheng.zhu@imgtec.com>
The commpage is allocated using kzalloc(), so there's no need of cleaning
the memory of the kvm_mips_commpage struct and its internal mips_coproc.
Signed-off-by: Deng-Cheng Zhu <dengcheng.zhu@imgtec.com>
---
arch/mips/kvm/commpage.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/mips/kvm/commpage.c b/arch/mips/kvm/commpage.c
index 61b9c04..2d6e976 100644
--- a/arch/mips/kvm/commpage.c
+++ b/arch/mips/kvm/commpage.c
@@ -28,9 +28,6 @@ void kvm_mips_commpage_init(struct kvm_vcpu *vcpu)
{
struct kvm_mips_commpage *page = vcpu->arch.kseg0_commpage;
- memset(page, 0, sizeof(struct kvm_mips_commpage));
-
/* Specific init values for fields */
vcpu->arch.cop0 = &page->cop0;
- memset(vcpu->arch.cop0, 0, sizeof(struct mips_coproc));
}
--
1.8.5.3
next prev parent reply other threads:[~2014-06-24 17:35 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-24 17:31 [PATCH v3 0/9] MIPS: KVM: Bugfixes and cleanups Deng-Cheng Zhu
2014-06-24 17:31 ` Deng-Cheng Zhu
2014-06-24 17:31 ` [PATCH v3 1/9] MIPS: KVM: Reformat code and comments Deng-Cheng Zhu
2014-06-24 17:31 ` Deng-Cheng Zhu
2014-06-24 23:13 ` James Hogan
2014-06-24 17:31 ` [PATCH v3 2/9] MIPS: KVM: Use KVM internal logger Deng-Cheng Zhu
2014-06-24 17:31 ` Deng-Cheng Zhu
2014-06-25 8:59 ` James Hogan
2014-06-25 8:59 ` James Hogan
2014-06-24 17:31 ` [PATCH v3 3/9] MIPS: KVM: Simplify functions by removing redundancy Deng-Cheng Zhu
2014-06-24 17:31 ` Deng-Cheng Zhu
2014-06-25 9:09 ` James Hogan
2014-06-25 9:09 ` James Hogan
2014-06-24 17:31 ` [PATCH v3 4/9] MIPS: KVM: Remove unneeded volatile Deng-Cheng Zhu
2014-06-24 17:31 ` Deng-Cheng Zhu
2014-06-25 9:09 ` James Hogan
2014-06-25 9:09 ` James Hogan
2014-06-24 17:31 ` [PATCH v3 5/9] MIPS: KVM: Rename files to remove the prefix "kvm_" and "kvm_mips_" Deng-Cheng Zhu
2014-06-24 17:31 ` Deng-Cheng Zhu
2014-06-25 9:11 ` James Hogan
2014-06-25 9:11 ` James Hogan
2014-06-24 17:31 ` [PATCH v3 6/9] MIPS: KVM: Restore correct value for WIRED at TLB uninit Deng-Cheng Zhu
2014-06-24 17:31 ` Deng-Cheng Zhu
2014-06-25 9:24 ` James Hogan
2014-06-25 9:24 ` James Hogan
2014-06-24 17:31 ` [PATCH v3 7/9] MIPS: KVM: Fix memory leak on VCPU Deng-Cheng Zhu
2014-06-24 17:31 ` Deng-Cheng Zhu
2014-06-25 9:28 ` James Hogan
2014-06-25 9:28 ` James Hogan
2014-06-25 12:17 ` Paolo Bonzini
2014-06-27 23:47 ` Deng-Cheng Zhu
2014-06-27 23:47 ` Deng-Cheng Zhu
2014-06-24 17:31 ` Deng-Cheng Zhu [this message]
2014-06-24 17:31 ` [PATCH v3 8/9] MIPS: KVM: Skip memory cleaning in kvm_mips_commpage_init() Deng-Cheng Zhu
2014-06-25 9:31 ` James Hogan
2014-06-25 9:31 ` James Hogan
2014-06-24 17:31 ` [PATCH v3 9/9] MIPS: KVM: Remove dead code of TLB index error in kvm_mips_emul_tlbwr() Deng-Cheng Zhu
2014-06-24 17:31 ` Deng-Cheng Zhu
2014-06-25 12:18 ` [PATCH v3 0/9] MIPS: KVM: Bugfixes and cleanups Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403631071-6012-9-git-send-email-dengcheng.zhu@imgtec.com \
--to=dengcheng.zhu@imgtec.com \
--cc=gleb@kernel.org \
--cc=james.hogan@imgtec.com \
--cc=kvm@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=pbonzini@redhat.com \
--cc=ralf@linux-mips.org \
--cc=sanjayl@kymasys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.