[RFC PATCH] checkpatch: Warn on unnecessary parentheses around references of foo->bar

[RFC PATCH] checkpatch: Warn on unnecessary parentheses around references of foo->bar

[Joe Perches]

Parentheses around  &(foo->bar) and *(foo->bar) are unnecessary.
Emit a --strict only message on these uses.

Signed-off-by: Joe Perches <joe@perches.com>
---
lk sources by far use &foo->bar over &(foo->bar).
(a rough count shows about 25:1)

 scripts/checkpatch.pl | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 538105a..8feaee2 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3462,6 +3462,14 @@ sub process {
 			}
 		}
 
+# check unnecessary parentheses around addressof/dereference single $Lvals
+# ie: &(foo->bar) should be &foo->bar and *(foo->bar) should be *foo->bar
+
+		while ($line =~ /(?:[^&]&\s*|\*)\(\s*($Ident\s*(?:$Member\s*)+)\s*\)/g) {
+			CHK("UNNECESSARY_PARENTHESES",
+			    "Unnecessary parentheses around $1\n" . $herecurr);
+		    }
+
 #goto labels aren't indented, allow a single space however
 		if ($line=~/^.\s+[A-Za-z\d_]+:(?![0-9]+)/ and
 		   !($line=~/^. [A-Za-z\d_]+:/) and !($line=~/^.\s+default:/)) {