All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/4 v2] hwmon: ntc_thermistor: prepose vendor prefix change
@ 2014-06-25  6:29 ` Naveen Krishna Chatradhi
  0 siblings, 0 replies; 50+ messages in thread
From: Naveen Krishna Chatradhi @ 2014-06-25  6:29 UTC (permalink / raw)
  To: linux-samsung-soc, linux-iio
  Cc: naveenkrishna.ch, kgene.kim, linux-arm-kernel, cpgs, devicetree, lars

As Murata is the manufacturer of the NTC (Negative Temperature coefficient)
based Thermistors. ntc_thermistor driver extensively used the prefix "ntc".
But, vendor-prefix should be "murata" instead of "ntc".

This patchset
1. Updates the vendor-prefix, DT bindings and Documentation,
   where ever necessary.
2. Adds thermistor nodes to Exynos5420 based Peach PIT board.

Patches:
1/4. devicetree: bindings: Document murata vendor prefix
     Adds the vendor prefix "murata" to vendor-prefixes.txt.
2/4. hwmon: ntc_thermistor: Use the manufacturer name properly
     Updates the driver, Kconfig, device tree bindings and Documentation
     with the Manufacturer/vendor information.
     Keeps the old bindings marked as <DEPRECATED> in code and Documentation
3/4. ARM: DTS: use new compatible string as per the documentation
     Updates the device node in Exynos4412 based Trats2 board
     with the new device tree bindings.
4/4. ARM: DTS: Add NTC thermistor nodes as child nodes to ADC
     Adds Thermistor nodes to Exynos5420 based Peach PIT board.

This patchset
Naveen Krishna Chatradhi (4):
  devicetree: bindings: Document murata vendor prefix
  hwmon: ntc_thermistor: Use the manufacturer name properly
  ARM: DTS: use new compatible string as per the documentation
  ARM: DTS: Add NTC thermistor nodes to Exynos5420 based Peach_PIT

 .../devicetree/bindings/arm/samsung/exynos-adc.txt |    2 +-
 .../devicetree/bindings/hwmon/ntc_thermistor.txt   |   20 ++++++++----
 .../devicetree/bindings/vendor-prefixes.txt        |    1 +
 Documentation/hwmon/ntc_thermistor                 |    8 ++---
 arch/arm/boot/dts/exynos4412-trats2.dts            |    4 +--
 arch/arm/boot/dts/exynos5420-peach-pit.dts         |   34 ++++++++++++++++++++
 drivers/hwmon/Kconfig                              |    5 +--
 drivers/hwmon/ntc_thermistor.c                     |   14 +++++++-
 8 files changed, 72 insertions(+), 16 deletions(-)

-- 
1.7.9.5

^ permalink raw reply	[flat|nested] 50+ messages in thread

* [PATCH 0/4 v2] hwmon: ntc_thermistor: prepose vendor prefix change
@ 2014-06-25  6:29 ` Naveen Krishna Chatradhi
  0 siblings, 0 replies; 50+ messages in thread
From: Naveen Krishna Chatradhi @ 2014-06-25  6:29 UTC (permalink / raw)
  To: linux-arm-kernel

As Murata is the manufacturer of the NTC (Negative Temperature coefficient)
based Thermistors. ntc_thermistor driver extensively used the prefix "ntc".
But, vendor-prefix should be "murata" instead of "ntc".

This patchset
1. Updates the vendor-prefix, DT bindings and Documentation,
   where ever necessary.
2. Adds thermistor nodes to Exynos5420 based Peach PIT board.

Patches:
1/4. devicetree: bindings: Document murata vendor prefix
     Adds the vendor prefix "murata" to vendor-prefixes.txt.
2/4. hwmon: ntc_thermistor: Use the manufacturer name properly
     Updates the driver, Kconfig, device tree bindings and Documentation
     with the Manufacturer/vendor information.
     Keeps the old bindings marked as <DEPRECATED> in code and Documentation
3/4. ARM: DTS: use new compatible string as per the documentation
     Updates the device node in Exynos4412 based Trats2 board
     with the new device tree bindings.
4/4. ARM: DTS: Add NTC thermistor nodes as child nodes to ADC
     Adds Thermistor nodes to Exynos5420 based Peach PIT board.

This patchset
Naveen Krishna Chatradhi (4):
  devicetree: bindings: Document murata vendor prefix
  hwmon: ntc_thermistor: Use the manufacturer name properly
  ARM: DTS: use new compatible string as per the documentation
  ARM: DTS: Add NTC thermistor nodes to Exynos5420 based Peach_PIT

 .../devicetree/bindings/arm/samsung/exynos-adc.txt |    2 +-
 .../devicetree/bindings/hwmon/ntc_thermistor.txt   |   20 ++++++++----
 .../devicetree/bindings/vendor-prefixes.txt        |    1 +
 Documentation/hwmon/ntc_thermistor                 |    8 ++---
 arch/arm/boot/dts/exynos4412-trats2.dts            |    4 +--
 arch/arm/boot/dts/exynos5420-peach-pit.dts         |   34 ++++++++++++++++++++
 drivers/hwmon/Kconfig                              |    5 +--
 drivers/hwmon/ntc_thermistor.c                     |   14 +++++++-
 8 files changed, 72 insertions(+), 16 deletions(-)

-- 
1.7.9.5

^ permalink raw reply	[flat|nested] 50+ messages in thread

* [PATCH 1/4 v2] devicetree: bindings: Document murata vendor prefix
  2014-06-25  6:29 ` Naveen Krishna Chatradhi
  (?)
@ 2014-06-25  6:29     ` Naveen Krishna Chatradhi
  -1 siblings, 0 replies; 50+ messages in thread
From: Naveen Krishna Chatradhi @ 2014-06-25  6:29 UTC (permalink / raw)
  To: linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
	linux-iio-u79uwXL29TY76Z2rM5mHXA
  Cc: naveenkrishna.ch-Re5JQEeQqe8AvxtiuMwx3w,
	kgene.kim-Sze3O3UU22JBDgjK7y7TUQ,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	cpgs-Sze3O3UU22JBDgjK7y7TUQ, devicetree-u79uwXL29TY76Z2rM5mHXA,
	lars-Qo5EllUWu/uELgA04lAiVw, Guenter Roeck

Add Murata Manufacturing Co., Ltd. to the list of device tree
vendor prefixes.

Murata manufactures NTC (Negative Temperature Coefficient) based
Thermistors for small scale applications like Mobiles and PDAs.

Signed-off-by: Naveen Krishna Chatradhi <ch.naveen-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Acked-by: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
Cc: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
---
Changes since v1:
1. Rearranged vendor-prefix alphabetically
2. Added Acked-by from Mark Rutland

 .../devicetree/bindings/vendor-prefixes.txt        |    1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
index 4d7f375..46a311e 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -83,6 +83,7 @@ mosaixtech	Mosaix Technologies, Inc.
 moxa	Moxa
 mpl	MPL AG
 mundoreader	Mundo Reader S.L.
+murata	Murata Manufacturing Co., Ltd.
 mxicy	Macronix International Co., Ltd.
 national	National Semiconductor
 neonode		Neonode Inc.
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 50+ messages in thread

* [PATCH 1/4 v2] devicetree: bindings: Document murata vendor prefix
@ 2014-06-25  6:29     ` Naveen Krishna Chatradhi
  0 siblings, 0 replies; 50+ messages in thread
From: Naveen Krishna Chatradhi @ 2014-06-25  6:29 UTC (permalink / raw)
  To: linux-samsung-soc, linux-iio
  Cc: naveenkrishna.ch, kgene.kim, linux-arm-kernel, cpgs, devicetree,
	lars, Guenter Roeck

Add Murata Manufacturing Co., Ltd. to the list of device tree
vendor prefixes.

Murata manufactures NTC (Negative Temperature Coefficient) based
Thermistors for small scale applications like Mobiles and PDAs.

Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
Acked-by: Mark Rutland <mark.rutland@arm.com>
Cc: Guenter Roeck <linux@roeck-us.net>
---
Changes since v1:
1. Rearranged vendor-prefix alphabetically
2. Added Acked-by from Mark Rutland

 .../devicetree/bindings/vendor-prefixes.txt        |    1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
index 4d7f375..46a311e 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -83,6 +83,7 @@ mosaixtech	Mosaix Technologies, Inc.
 moxa	Moxa
 mpl	MPL AG
 mundoreader	Mundo Reader S.L.
+murata	Murata Manufacturing Co., Ltd.
 mxicy	Macronix International Co., Ltd.
 national	National Semiconductor
 neonode		Neonode Inc.
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 50+ messages in thread

* [PATCH 1/4 v2] devicetree: bindings: Document murata vendor prefix
@ 2014-06-25  6:29     ` Naveen Krishna Chatradhi
  0 siblings, 0 replies; 50+ messages in thread
From: Naveen Krishna Chatradhi @ 2014-06-25  6:29 UTC (permalink / raw)
  To: linux-arm-kernel

Add Murata Manufacturing Co., Ltd. to the list of device tree
vendor prefixes.

Murata manufactures NTC (Negative Temperature Coefficient) based
Thermistors for small scale applications like Mobiles and PDAs.

Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
Acked-by: Mark Rutland <mark.rutland@arm.com>
Cc: Guenter Roeck <linux@roeck-us.net>
---
Changes since v1:
1. Rearranged vendor-prefix alphabetically
2. Added Acked-by from Mark Rutland

 .../devicetree/bindings/vendor-prefixes.txt        |    1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
index 4d7f375..46a311e 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -83,6 +83,7 @@ mosaixtech	Mosaix Technologies, Inc.
 moxa	Moxa
 mpl	MPL AG
 mundoreader	Mundo Reader S.L.
+murata	Murata Manufacturing Co., Ltd.
 mxicy	Macronix International Co., Ltd.
 national	National Semiconductor
 neonode		Neonode Inc.
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 50+ messages in thread

* [PATCH 2/4 v2] hwmon: ntc_thermistor: Use the manufacturer name properly
  2014-06-25  6:29 ` Naveen Krishna Chatradhi
@ 2014-06-25  6:29   ` Naveen Krishna Chatradhi
  -1 siblings, 0 replies; 50+ messages in thread
From: Naveen Krishna Chatradhi @ 2014-06-25  6:29 UTC (permalink / raw)
  To: linux-samsung-soc, linux-iio
  Cc: naveenkrishna.ch, kgene.kim, linux-arm-kernel, cpgs, devicetree,
	lars, Guenter Roeck

Murata Manufacturing Co., Ltd is the vendor for
NTC (Negative Temperature coefficient) based Thermistors.
But, the driver extensively uses "NTC" as the vendor name.

This patch corrects the vendor name also updates the
compatibility strings according to the vendor-prefix.txt

Note: Drivers continue to support the previous compatible strings
but further addition of these compatible strings in device tree
is deprecated.

Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
Cc: Guenter Roeck <linux@roeck-us.net>
---
Changes since v1:
1. Kept the old compatible string marked as <DEPRECATED> in code and
   in the Documentation.

 .../devicetree/bindings/arm/samsung/exynos-adc.txt |    2 +-
 .../devicetree/bindings/hwmon/ntc_thermistor.txt   |   20 ++++++++++++++------
 Documentation/hwmon/ntc_thermistor                 |    8 ++++----
 drivers/hwmon/Kconfig                              |    5 +++--
 drivers/hwmon/ntc_thermistor.c                     |   14 +++++++++++++-
 5 files changed, 35 insertions(+), 14 deletions(-)

diff --git a/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt b/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt
index 5d49f2b..832fe8c 100644
--- a/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt
+++ b/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt
@@ -48,7 +48,7 @@ adc@12D10000 {
 
 	/* NTC thermistor is a hwmon device */
 	ncp15wb473@0 {
-		compatible = "ntc,ncp15wb473";
+		compatible = "murata,ncp15wb473";
 		pullup-uv = <1800000>;
 		pullup-ohm = <47000>;
 		pulldown-ohm = <0>;
diff --git a/Documentation/devicetree/bindings/hwmon/ntc_thermistor.txt b/Documentation/devicetree/bindings/hwmon/ntc_thermistor.txt
index c6f6667..b117b2e 100644
--- a/Documentation/devicetree/bindings/hwmon/ntc_thermistor.txt
+++ b/Documentation/devicetree/bindings/hwmon/ntc_thermistor.txt
@@ -3,11 +3,19 @@ NTC Thermistor hwmon sensors
 
 Requires node properties:
 - "compatible" value : one of
-	"ntc,ncp15wb473"
-	"ntc,ncp18wb473"
-	"ntc,ncp21wb473"
-	"ntc,ncp03wb473"
-	"ntc,ncp15wl333"
+	"murata,ncp15wb473"
+	"murata,ncp18wb473"
+	"murata,ncp21wb473"
+	"murata,ncp03wb473"
+	"murata,ncp15wl333"
+
+/* Usage of vendor name "ntc" is deprecated */
+<DEPRECATED>	"ntc,ncp15wb473"
+<DEPRECATED>	"ntc,ncp18wb473"
+<DEPRECATED>	"ntc,ncp21wb473"
+<DEPRECATED>	"ntc,ncp03wb473"
+<DEPRECATED>	"ntc,ncp15wl333"
+
 - "pullup-uv"	Pull up voltage in micro volts
 - "pullup-ohm"	Pull up resistor value in ohms
 - "pulldown-ohm" Pull down resistor value in ohms
@@ -21,7 +29,7 @@ Read more about iio bindings at
 
 Example:
 	ncp15wb473@0 {
-		compatible = "ntc,ncp15wb473";
+		compatible = "murata,ncp15wb473";
 		pullup-uv = <1800000>;
 		pullup-ohm = <47000>;
 		pulldown-ohm = <0>;
diff --git a/Documentation/hwmon/ntc_thermistor b/Documentation/hwmon/ntc_thermistor
index 3bfda94..057b770 100644
--- a/Documentation/hwmon/ntc_thermistor
+++ b/Documentation/hwmon/ntc_thermistor
@@ -1,7 +1,7 @@
 Kernel driver ntc_thermistor
 =================
 
-Supported thermistors:
+Supported thermistors from Murata:
 * Murata NTC Thermistors NCP15WB473, NCP18WB473, NCP21WB473, NCP03WB473, NCP15WL333
   Prefixes: 'ncp15wb473', 'ncp18wb473', 'ncp21wb473', 'ncp03wb473', 'ncp15wl333'
   Datasheet: Publicly available at Murata
@@ -15,9 +15,9 @@ Authors:
 Description
 -----------
 
-The NTC thermistor is a simple thermistor that requires users to provide the
-resistance and lookup the corresponding compensation table to get the
-temperature input.
+The NTC (Negative Temperature Coefficient) thermistor is a simple thermistor
+that requires users to provide the resistance and lookup the corresponding
+compensation table to get the temperature input.
 
 The NTC driver provides lookup tables with a linear approximation function
 and four circuit models with an option not to use any of the four models.
diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
index 08531a1..154851b 100644
--- a/drivers/hwmon/Kconfig
+++ b/drivers/hwmon/Kconfig
@@ -1052,7 +1052,7 @@ config SENSORS_PC87427
 	  will be called pc87427.
 
 config SENSORS_NTC_THERMISTOR
-	tristate "NTC thermistor support"
+	tristate "NTC thermistor support from Murata"
 	depends on !OF || IIO=n || IIO
 	help
 	  This driver supports NTC thermistors sensor reading and its
@@ -1060,7 +1060,8 @@ config SENSORS_NTC_THERMISTOR
 	  send notifications about the temperature.
 
 	  Currently, this driver supports
-	  NCP15WB473, NCP18WB473, NCP21WB473, NCP03WB473, and NCP15WL333.
+	  NCP15WB473, NCP18WB473, NCP21WB473, NCP03WB473, and NCP15WL333
+	  from Murata.
 
 	  This driver can also be built as a module.  If so, the module
 	  will be called ntc-thermistor.
diff --git a/drivers/hwmon/ntc_thermistor.c b/drivers/hwmon/ntc_thermistor.c
index e76feb86..bdfbe91 100644
--- a/drivers/hwmon/ntc_thermistor.c
+++ b/drivers/hwmon/ntc_thermistor.c
@@ -163,6 +163,18 @@ static int ntc_adc_iio_read(struct ntc_thermistor_platform_data *pdata)
 }
 
 static const struct of_device_id ntc_match[] = {
+	{ .compatible = "murata,ncp15wb473",
+		.data = &ntc_thermistor_id[0] },
+	{ .compatible = "murata,ncp18wb473",
+		.data = &ntc_thermistor_id[1] },
+	{ .compatible = "murata,ncp21wb473",
+		.data = &ntc_thermistor_id[2] },
+	{ .compatible = "murata,ncp03wb473",
+		.data = &ntc_thermistor_id[3] },
+	{ .compatible = "murata,ncp15wl333",
+		.data = &ntc_thermistor_id[4] },
+
+	/* Usage of vendor name "ntc" is deprecated */
 	{ .compatible = "ntc,ncp15wb473",
 		.data = &ntc_thermistor_id[0] },
 	{ .compatible = "ntc,ncp18wb473",
@@ -534,7 +546,7 @@ static struct platform_driver ntc_thermistor_driver = {
 
 module_platform_driver(ntc_thermistor_driver);
 
-MODULE_DESCRIPTION("NTC Thermistor Driver");
+MODULE_DESCRIPTION("NTC Thermistor Driver from Murata");
 MODULE_AUTHOR("MyungJoo Ham <myungjoo.ham@samsung.com>");
 MODULE_LICENSE("GPL");
 MODULE_ALIAS("platform:ntc-thermistor");
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 50+ messages in thread

* [PATCH 2/4 v2] hwmon: ntc_thermistor: Use the manufacturer name properly
@ 2014-06-25  6:29   ` Naveen Krishna Chatradhi
  0 siblings, 0 replies; 50+ messages in thread
From: Naveen Krishna Chatradhi @ 2014-06-25  6:29 UTC (permalink / raw)
  To: linux-arm-kernel

Murata Manufacturing Co., Ltd is the vendor for
NTC (Negative Temperature coefficient) based Thermistors.
But, the driver extensively uses "NTC" as the vendor name.

This patch corrects the vendor name also updates the
compatibility strings according to the vendor-prefix.txt

Note: Drivers continue to support the previous compatible strings
but further addition of these compatible strings in device tree
is deprecated.

Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
Cc: Guenter Roeck <linux@roeck-us.net>
---
Changes since v1:
1. Kept the old compatible string marked as <DEPRECATED> in code and
   in the Documentation.

 .../devicetree/bindings/arm/samsung/exynos-adc.txt |    2 +-
 .../devicetree/bindings/hwmon/ntc_thermistor.txt   |   20 ++++++++++++++------
 Documentation/hwmon/ntc_thermistor                 |    8 ++++----
 drivers/hwmon/Kconfig                              |    5 +++--
 drivers/hwmon/ntc_thermistor.c                     |   14 +++++++++++++-
 5 files changed, 35 insertions(+), 14 deletions(-)

diff --git a/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt b/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt
index 5d49f2b..832fe8c 100644
--- a/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt
+++ b/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt
@@ -48,7 +48,7 @@ adc at 12D10000 {
 
 	/* NTC thermistor is a hwmon device */
 	ncp15wb473 at 0 {
-		compatible = "ntc,ncp15wb473";
+		compatible = "murata,ncp15wb473";
 		pullup-uv = <1800000>;
 		pullup-ohm = <47000>;
 		pulldown-ohm = <0>;
diff --git a/Documentation/devicetree/bindings/hwmon/ntc_thermistor.txt b/Documentation/devicetree/bindings/hwmon/ntc_thermistor.txt
index c6f6667..b117b2e 100644
--- a/Documentation/devicetree/bindings/hwmon/ntc_thermistor.txt
+++ b/Documentation/devicetree/bindings/hwmon/ntc_thermistor.txt
@@ -3,11 +3,19 @@ NTC Thermistor hwmon sensors
 
 Requires node properties:
 - "compatible" value : one of
-	"ntc,ncp15wb473"
-	"ntc,ncp18wb473"
-	"ntc,ncp21wb473"
-	"ntc,ncp03wb473"
-	"ntc,ncp15wl333"
+	"murata,ncp15wb473"
+	"murata,ncp18wb473"
+	"murata,ncp21wb473"
+	"murata,ncp03wb473"
+	"murata,ncp15wl333"
+
+/* Usage of vendor name "ntc" is deprecated */
+<DEPRECATED>	"ntc,ncp15wb473"
+<DEPRECATED>	"ntc,ncp18wb473"
+<DEPRECATED>	"ntc,ncp21wb473"
+<DEPRECATED>	"ntc,ncp03wb473"
+<DEPRECATED>	"ntc,ncp15wl333"
+
 - "pullup-uv"	Pull up voltage in micro volts
 - "pullup-ohm"	Pull up resistor value in ohms
 - "pulldown-ohm" Pull down resistor value in ohms
@@ -21,7 +29,7 @@ Read more about iio bindings at
 
 Example:
 	ncp15wb473 at 0 {
-		compatible = "ntc,ncp15wb473";
+		compatible = "murata,ncp15wb473";
 		pullup-uv = <1800000>;
 		pullup-ohm = <47000>;
 		pulldown-ohm = <0>;
diff --git a/Documentation/hwmon/ntc_thermistor b/Documentation/hwmon/ntc_thermistor
index 3bfda94..057b770 100644
--- a/Documentation/hwmon/ntc_thermistor
+++ b/Documentation/hwmon/ntc_thermistor
@@ -1,7 +1,7 @@
 Kernel driver ntc_thermistor
 =================
 
-Supported thermistors:
+Supported thermistors from Murata:
 * Murata NTC Thermistors NCP15WB473, NCP18WB473, NCP21WB473, NCP03WB473, NCP15WL333
   Prefixes: 'ncp15wb473', 'ncp18wb473', 'ncp21wb473', 'ncp03wb473', 'ncp15wl333'
   Datasheet: Publicly available at Murata
@@ -15,9 +15,9 @@ Authors:
 Description
 -----------
 
-The NTC thermistor is a simple thermistor that requires users to provide the
-resistance and lookup the corresponding compensation table to get the
-temperature input.
+The NTC (Negative Temperature Coefficient) thermistor is a simple thermistor
+that requires users to provide the resistance and lookup the corresponding
+compensation table to get the temperature input.
 
 The NTC driver provides lookup tables with a linear approximation function
 and four circuit models with an option not to use any of the four models.
diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
index 08531a1..154851b 100644
--- a/drivers/hwmon/Kconfig
+++ b/drivers/hwmon/Kconfig
@@ -1052,7 +1052,7 @@ config SENSORS_PC87427
 	  will be called pc87427.
 
 config SENSORS_NTC_THERMISTOR
-	tristate "NTC thermistor support"
+	tristate "NTC thermistor support from Murata"
 	depends on !OF || IIO=n || IIO
 	help
 	  This driver supports NTC thermistors sensor reading and its
@@ -1060,7 +1060,8 @@ config SENSORS_NTC_THERMISTOR
 	  send notifications about the temperature.
 
 	  Currently, this driver supports
-	  NCP15WB473, NCP18WB473, NCP21WB473, NCP03WB473, and NCP15WL333.
+	  NCP15WB473, NCP18WB473, NCP21WB473, NCP03WB473, and NCP15WL333
+	  from Murata.
 
 	  This driver can also be built as a module.  If so, the module
 	  will be called ntc-thermistor.
diff --git a/drivers/hwmon/ntc_thermistor.c b/drivers/hwmon/ntc_thermistor.c
index e76feb86..bdfbe91 100644
--- a/drivers/hwmon/ntc_thermistor.c
+++ b/drivers/hwmon/ntc_thermistor.c
@@ -163,6 +163,18 @@ static int ntc_adc_iio_read(struct ntc_thermistor_platform_data *pdata)
 }
 
 static const struct of_device_id ntc_match[] = {
+	{ .compatible = "murata,ncp15wb473",
+		.data = &ntc_thermistor_id[0] },
+	{ .compatible = "murata,ncp18wb473",
+		.data = &ntc_thermistor_id[1] },
+	{ .compatible = "murata,ncp21wb473",
+		.data = &ntc_thermistor_id[2] },
+	{ .compatible = "murata,ncp03wb473",
+		.data = &ntc_thermistor_id[3] },
+	{ .compatible = "murata,ncp15wl333",
+		.data = &ntc_thermistor_id[4] },
+
+	/* Usage of vendor name "ntc" is deprecated */
 	{ .compatible = "ntc,ncp15wb473",
 		.data = &ntc_thermistor_id[0] },
 	{ .compatible = "ntc,ncp18wb473",
@@ -534,7 +546,7 @@ static struct platform_driver ntc_thermistor_driver = {
 
 module_platform_driver(ntc_thermistor_driver);
 
-MODULE_DESCRIPTION("NTC Thermistor Driver");
+MODULE_DESCRIPTION("NTC Thermistor Driver from Murata");
 MODULE_AUTHOR("MyungJoo Ham <myungjoo.ham@samsung.com>");
 MODULE_LICENSE("GPL");
 MODULE_ALIAS("platform:ntc-thermistor");
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 50+ messages in thread

* [PATCH 3/4 v2] ARM: DTS: use new compatible string for thermistors in trats2
  2014-06-25  6:29 ` Naveen Krishna Chatradhi
  (?)
@ 2014-06-25  6:29     ` Naveen Krishna Chatradhi
  -1 siblings, 0 replies; 50+ messages in thread
From: Naveen Krishna Chatradhi @ 2014-06-25  6:29 UTC (permalink / raw)
  To: linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
	linux-iio-u79uwXL29TY76Z2rM5mHXA
  Cc: naveenkrishna.ch-Re5JQEeQqe8AvxtiuMwx3w,
	kgene.kim-Sze3O3UU22JBDgjK7y7TUQ,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	cpgs-Sze3O3UU22JBDgjK7y7TUQ, devicetree-u79uwXL29TY76Z2rM5mHXA,
	lars-Qo5EllUWu/uELgA04lAiVw, Chanwoo Choi

As Murata Manufactures the NTC based thermistors. The vendor
name in the compatibility is preposed to change to "murata"

This patch uses the new compatibility string in exynos4412 based
Trats2 board.

Signed-off-by: Naveen Krishna Chatradhi <ch.naveen-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Cc: Chanwoo Choi <cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
---
Changes since v1:
None

 arch/arm/boot/dts/exynos4412-trats2.dts |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts b/arch/arm/boot/dts/exynos4412-trats2.dts
index 11967f4..d35755a 100644
--- a/arch/arm/boot/dts/exynos4412-trats2.dts
+++ b/arch/arm/boot/dts/exynos4412-trats2.dts
@@ -771,7 +771,7 @@
 	};
 
 	thermistor-ap@0 {
-		compatible = "ntc,ncp15wb473";
+		compatible = "murata,ncp15wb473";
 		pullup-uv = <1800000>;	 /* VCC_1.8V_AP */
 		pullup-ohm = <100000>;	 /* 100K */
 		pulldown-ohm = <100000>; /* 100K */
@@ -779,7 +779,7 @@
 	};
 
 	thermistor-battery@1 {
-		compatible = "ntc,ncp15wb473";
+		compatible = "murata,ncp15wb473";
 		pullup-uv = <1800000>;	 /* VCC_1.8V_AP */
 		pullup-ohm = <100000>;	 /* 100K */
 		pulldown-ohm = <100000>; /* 100K */
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 50+ messages in thread

* [PATCH 3/4 v2] ARM: DTS: use new compatible string for thermistors in trats2
@ 2014-06-25  6:29     ` Naveen Krishna Chatradhi
  0 siblings, 0 replies; 50+ messages in thread
From: Naveen Krishna Chatradhi @ 2014-06-25  6:29 UTC (permalink / raw)
  To: linux-samsung-soc, linux-iio
  Cc: naveenkrishna.ch, kgene.kim, linux-arm-kernel, cpgs, devicetree,
	lars, Chanwoo Choi

As Murata Manufactures the NTC based thermistors. The vendor
name in the compatibility is preposed to change to "murata"

This patch uses the new compatibility string in exynos4412 based
Trats2 board.

Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>
---
Changes since v1:
None

 arch/arm/boot/dts/exynos4412-trats2.dts |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts b/arch/arm/boot/dts/exynos4412-trats2.dts
index 11967f4..d35755a 100644
--- a/arch/arm/boot/dts/exynos4412-trats2.dts
+++ b/arch/arm/boot/dts/exynos4412-trats2.dts
@@ -771,7 +771,7 @@
 	};
 
 	thermistor-ap@0 {
-		compatible = "ntc,ncp15wb473";
+		compatible = "murata,ncp15wb473";
 		pullup-uv = <1800000>;	 /* VCC_1.8V_AP */
 		pullup-ohm = <100000>;	 /* 100K */
 		pulldown-ohm = <100000>; /* 100K */
@@ -779,7 +779,7 @@
 	};
 
 	thermistor-battery@1 {
-		compatible = "ntc,ncp15wb473";
+		compatible = "murata,ncp15wb473";
 		pullup-uv = <1800000>;	 /* VCC_1.8V_AP */
 		pullup-ohm = <100000>;	 /* 100K */
 		pulldown-ohm = <100000>; /* 100K */
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 50+ messages in thread

* [PATCH 3/4 v2] ARM: DTS: use new compatible string for thermistors in trats2
@ 2014-06-25  6:29     ` Naveen Krishna Chatradhi
  0 siblings, 0 replies; 50+ messages in thread
From: Naveen Krishna Chatradhi @ 2014-06-25  6:29 UTC (permalink / raw)
  To: linux-arm-kernel

As Murata Manufactures the NTC based thermistors. The vendor
name in the compatibility is preposed to change to "murata"

This patch uses the new compatibility string in exynos4412 based
Trats2 board.

Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>
---
Changes since v1:
None

 arch/arm/boot/dts/exynos4412-trats2.dts |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts b/arch/arm/boot/dts/exynos4412-trats2.dts
index 11967f4..d35755a 100644
--- a/arch/arm/boot/dts/exynos4412-trats2.dts
+++ b/arch/arm/boot/dts/exynos4412-trats2.dts
@@ -771,7 +771,7 @@
 	};
 
 	thermistor-ap at 0 {
-		compatible = "ntc,ncp15wb473";
+		compatible = "murata,ncp15wb473";
 		pullup-uv = <1800000>;	 /* VCC_1.8V_AP */
 		pullup-ohm = <100000>;	 /* 100K */
 		pulldown-ohm = <100000>; /* 100K */
@@ -779,7 +779,7 @@
 	};
 
 	thermistor-battery at 1 {
-		compatible = "ntc,ncp15wb473";
+		compatible = "murata,ncp15wb473";
 		pullup-uv = <1800000>;	 /* VCC_1.8V_AP */
 		pullup-ohm = <100000>;	 /* 100K */
 		pulldown-ohm = <100000>; /* 100K */
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 50+ messages in thread

* [PATCH 4/4 v2] ARM: DTS: Add NTC thermistor nodes to Exynos5420 based Peach_PIT
  2014-06-25  6:29 ` Naveen Krishna Chatradhi
@ 2014-06-25  6:29   ` Naveen Krishna Chatradhi
  -1 siblings, 0 replies; 50+ messages in thread
From: Naveen Krishna Chatradhi @ 2014-06-25  6:29 UTC (permalink / raw)
  To: linux-samsung-soc, linux-iio
  Cc: naveenkrishna.ch, kgene.kim, linux-arm-kernel, cpgs, devicetree,
	lars, Doug Anderson

Exynos5420 based Peach PIT board has 4 NTC thermistors to measure
temperatures at various points on the board.

IIO based ADC becomes the parent and NTC thermistors are the childs,
via the HWMON interface.

Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
Cc: Doug Anderson <dianders@chromium.org>
---
Changes since v1:
1. Arranged the ADC node alphabetical
2. Added "status = "okay"" to the ADC node

This patch needs
1. MAX77802 PMIC device tree nodes (for ldo9)
   https://www.mail-archive.com/devicetree@vger.kernel.org/msg31430.html
2. Uses the DT documentation for NTC thermistors updated with vendor-prefix

This patch set is tested
1. On Peach PIT board via sysfs entry exposed by hwmon
localhost ~ # cat /sys/class/hwmon/hwmon*/device/temp1_input                                                                                                                                          
37436
36449
38560
38059

2. Backward compatibility is tested by replacing "murata" with "ntc"
   in the dts nodes and running the above test.

 arch/arm/boot/dts/exynos5420-peach-pit.dts |   34 ++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
index b96a66a..19d733d 100644
--- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
+++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
@@ -101,6 +101,40 @@
 	};
 };
 
+&adc {
+	status = "okay";
+	vdd-supply = <&ldo9_reg>;
+
+	ncp15wb473@3 {
+		compatible = "murata,ncp15wb473";
+		pullup-uv = <1800000>;
+		pullup-ohm = <47000>;
+		pulldown-ohm = <0>;
+		io-channels = <&adc 3>;
+	};
+	ncp15wb473@4 {
+		compatible = "murata,ncp15wb473";
+		pullup-uv = <1800000>;
+		pullup-ohm = <47000>;
+		pulldown-ohm = <0>;
+		io-channels = <&adc 4>;
+	};
+	ncp15wb473@5 {
+		compatible = "murata,ncp15wb473";
+		pullup-uv = <1800000>;
+		pullup-ohm = <47000>;
+		pulldown-ohm = <0>;
+		io-channels = <&adc 5>;
+	};
+	ncp15wb473@6 {
+		compatible = "murata,ncp15wb473";
+		pullup-uv = <1800000>;
+		pullup-ohm = <47000>;
+		pulldown-ohm = <0>;
+		io-channels = <&adc 6>;
+	};
+};
+
 &dp {
 	status = "okay";
 	pinctrl-names = "default";
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 50+ messages in thread

* [PATCH 4/4 v2] ARM: DTS: Add NTC thermistor nodes to Exynos5420 based Peach_PIT
@ 2014-06-25  6:29   ` Naveen Krishna Chatradhi
  0 siblings, 0 replies; 50+ messages in thread
From: Naveen Krishna Chatradhi @ 2014-06-25  6:29 UTC (permalink / raw)
  To: linux-arm-kernel

Exynos5420 based Peach PIT board has 4 NTC thermistors to measure
temperatures at various points on the board.

IIO based ADC becomes the parent and NTC thermistors are the childs,
via the HWMON interface.

Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
Cc: Doug Anderson <dianders@chromium.org>
---
Changes since v1:
1. Arranged the ADC node alphabetical
2. Added "status = "okay"" to the ADC node

This patch needs
1. MAX77802 PMIC device tree nodes (for ldo9)
   https://www.mail-archive.com/devicetree at vger.kernel.org/msg31430.html
2. Uses the DT documentation for NTC thermistors updated with vendor-prefix

This patch set is tested
1. On Peach PIT board via sysfs entry exposed by hwmon
localhost ~ # cat /sys/class/hwmon/hwmon*/device/temp1_input                                                                                                                                          
37436
36449
38560
38059

2. Backward compatibility is tested by replacing "murata" with "ntc"
   in the dts nodes and running the above test.

 arch/arm/boot/dts/exynos5420-peach-pit.dts |   34 ++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
index b96a66a..19d733d 100644
--- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
+++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
@@ -101,6 +101,40 @@
 	};
 };
 
+&adc {
+	status = "okay";
+	vdd-supply = <&ldo9_reg>;
+
+	ncp15wb473 at 3 {
+		compatible = "murata,ncp15wb473";
+		pullup-uv = <1800000>;
+		pullup-ohm = <47000>;
+		pulldown-ohm = <0>;
+		io-channels = <&adc 3>;
+	};
+	ncp15wb473 at 4 {
+		compatible = "murata,ncp15wb473";
+		pullup-uv = <1800000>;
+		pullup-ohm = <47000>;
+		pulldown-ohm = <0>;
+		io-channels = <&adc 4>;
+	};
+	ncp15wb473 at 5 {
+		compatible = "murata,ncp15wb473";
+		pullup-uv = <1800000>;
+		pullup-ohm = <47000>;
+		pulldown-ohm = <0>;
+		io-channels = <&adc 5>;
+	};
+	ncp15wb473 at 6 {
+		compatible = "murata,ncp15wb473";
+		pullup-uv = <1800000>;
+		pullup-ohm = <47000>;
+		pulldown-ohm = <0>;
+		io-channels = <&adc 6>;
+	};
+};
+
 &dp {
 	status = "okay";
 	pinctrl-names = "default";
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 50+ messages in thread

* Re: [PATCH 3/4 v2] ARM: DTS: use new compatible string for thermistors in trats2
  2014-06-25  6:29     ` Naveen Krishna Chatradhi
  (?)
@ 2014-06-25  6:35         ` Chanwoo Choi
  -1 siblings, 0 replies; 50+ messages in thread
From: Chanwoo Choi @ 2014-06-25  6:35 UTC (permalink / raw)
  To: Naveen Krishna Chatradhi
  Cc: linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
	linux-iio-u79uwXL29TY76Z2rM5mHXA,
	naveenkrishna.ch-Re5JQEeQqe8AvxtiuMwx3w,
	kgene.kim-Sze3O3UU22JBDgjK7y7TUQ,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	cpgs-Sze3O3UU22JBDgjK7y7TUQ, devicetree-u79uwXL29TY76Z2rM5mHXA,
	lars-Qo5EllUWu/uELgA04lAiVw

On 06/25/2014 03:29 PM, Naveen Krishna Chatradhi wrote:
> As Murata Manufactures the NTC based thermistors. The vendor
> name in the compatibility is preposed to change to "murata"
> 
> This patch uses the new compatibility string in exynos4412 based
> Trats2 board.
> 
> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> Cc: Chanwoo Choi <cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> ---
> Changes since v1:
> None
> 
>  arch/arm/boot/dts/exynos4412-trats2.dts |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts b/arch/arm/boot/dts/exynos4412-trats2.dts
> index 11967f4..d35755a 100644
> --- a/arch/arm/boot/dts/exynos4412-trats2.dts
> +++ b/arch/arm/boot/dts/exynos4412-trats2.dts
> @@ -771,7 +771,7 @@
>  	};
>  
>  	thermistor-ap@0 {
> -		compatible = "ntc,ncp15wb473";
> +		compatible = "murata,ncp15wb473";
>  		pullup-uv = <1800000>;	 /* VCC_1.8V_AP */
>  		pullup-ohm = <100000>;	 /* 100K */
>  		pulldown-ohm = <100000>; /* 100K */
> @@ -779,7 +779,7 @@
>  	};
>  
>  	thermistor-battery@1 {
> -		compatible = "ntc,ncp15wb473";
> +		compatible = "murata,ncp15wb473";
>  		pullup-uv = <1800000>;	 /* VCC_1.8V_AP */
>  		pullup-ohm = <100000>;	 /* 100K */
>  		pulldown-ohm = <100000>; /* 100K */
> 

Looks good to me.

Reviewed-by: Chanwoo Choi <cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>

Thanks,
Chanwoo Choi

^ permalink raw reply	[flat|nested] 50+ messages in thread

* Re: [PATCH 3/4 v2] ARM: DTS: use new compatible string for thermistors in trats2
@ 2014-06-25  6:35         ` Chanwoo Choi
  0 siblings, 0 replies; 50+ messages in thread
From: Chanwoo Choi @ 2014-06-25  6:35 UTC (permalink / raw)
  To: Naveen Krishna Chatradhi
  Cc: linux-samsung-soc, linux-iio, naveenkrishna.ch, kgene.kim,
	linux-arm-kernel, cpgs, devicetree, lars

On 06/25/2014 03:29 PM, Naveen Krishna Chatradhi wrote:
> As Murata Manufactures the NTC based thermistors. The vendor
> name in the compatibility is preposed to change to "murata"
> 
> This patch uses the new compatibility string in exynos4412 based
> Trats2 board.
> 
> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
> Cc: Chanwoo Choi <cw00.choi@samsung.com>
> ---
> Changes since v1:
> None
> 
>  arch/arm/boot/dts/exynos4412-trats2.dts |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts b/arch/arm/boot/dts/exynos4412-trats2.dts
> index 11967f4..d35755a 100644
> --- a/arch/arm/boot/dts/exynos4412-trats2.dts
> +++ b/arch/arm/boot/dts/exynos4412-trats2.dts
> @@ -771,7 +771,7 @@
>  	};
>  
>  	thermistor-ap@0 {
> -		compatible = "ntc,ncp15wb473";
> +		compatible = "murata,ncp15wb473";
>  		pullup-uv = <1800000>;	 /* VCC_1.8V_AP */
>  		pullup-ohm = <100000>;	 /* 100K */
>  		pulldown-ohm = <100000>; /* 100K */
> @@ -779,7 +779,7 @@
>  	};
>  
>  	thermistor-battery@1 {
> -		compatible = "ntc,ncp15wb473";
> +		compatible = "murata,ncp15wb473";
>  		pullup-uv = <1800000>;	 /* VCC_1.8V_AP */
>  		pullup-ohm = <100000>;	 /* 100K */
>  		pulldown-ohm = <100000>; /* 100K */
> 

Looks good to me.

Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>

Thanks,
Chanwoo Choi

^ permalink raw reply	[flat|nested] 50+ messages in thread

* [PATCH 3/4 v2] ARM: DTS: use new compatible string for thermistors in trats2
@ 2014-06-25  6:35         ` Chanwoo Choi
  0 siblings, 0 replies; 50+ messages in thread
From: Chanwoo Choi @ 2014-06-25  6:35 UTC (permalink / raw)
  To: linux-arm-kernel

On 06/25/2014 03:29 PM, Naveen Krishna Chatradhi wrote:
> As Murata Manufactures the NTC based thermistors. The vendor
> name in the compatibility is preposed to change to "murata"
> 
> This patch uses the new compatibility string in exynos4412 based
> Trats2 board.
> 
> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
> Cc: Chanwoo Choi <cw00.choi@samsung.com>
> ---
> Changes since v1:
> None
> 
>  arch/arm/boot/dts/exynos4412-trats2.dts |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts b/arch/arm/boot/dts/exynos4412-trats2.dts
> index 11967f4..d35755a 100644
> --- a/arch/arm/boot/dts/exynos4412-trats2.dts
> +++ b/arch/arm/boot/dts/exynos4412-trats2.dts
> @@ -771,7 +771,7 @@
>  	};
>  
>  	thermistor-ap at 0 {
> -		compatible = "ntc,ncp15wb473";
> +		compatible = "murata,ncp15wb473";
>  		pullup-uv = <1800000>;	 /* VCC_1.8V_AP */
>  		pullup-ohm = <100000>;	 /* 100K */
>  		pulldown-ohm = <100000>; /* 100K */
> @@ -779,7 +779,7 @@
>  	};
>  
>  	thermistor-battery at 1 {
> -		compatible = "ntc,ncp15wb473";
> +		compatible = "murata,ncp15wb473";
>  		pullup-uv = <1800000>;	 /* VCC_1.8V_AP */
>  		pullup-ohm = <100000>;	 /* 100K */
>  		pulldown-ohm = <100000>; /* 100K */
> 

Looks good to me.

Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>

Thanks,
Chanwoo Choi

^ permalink raw reply	[flat|nested] 50+ messages in thread

* Re: [PATCH 2/4 v2] hwmon: ntc_thermistor: Use the manufacturer name properly
  2014-06-25  6:29   ` Naveen Krishna Chatradhi
  (?)
@ 2014-06-25 10:36       ` Javier Martinez Canillas
  -1 siblings, 0 replies; 50+ messages in thread
From: Javier Martinez Canillas @ 2014-06-25 10:36 UTC (permalink / raw)
  To: Naveen Krishna Chatradhi
  Cc: linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA, linux-iio,
	Naveen Krishna Ch, Kukjin Kim,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, cpgs .,
	devicetree-u79uwXL29TY76Z2rM5mHXA, Lars-Peter Clausen,
	Guenter Roeck

Hello Naveen,

On Wed, Jun 25, 2014 at 8:29 AM, Naveen Krishna Chatradhi
<ch.naveen-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
> Murata Manufacturing Co., Ltd is the vendor for
> NTC (Negative Temperature coefficient) based Thermistors.
> But, the driver extensively uses "NTC" as the vendor name.
>
> This patch corrects the vendor name also updates the
> compatibility strings according to the vendor-prefix.txt
>
> Note: Drivers continue to support the previous compatible strings
> but further addition of these compatible strings in device tree
> is deprecated.
>
> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> Cc: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
> ---
> Changes since v1:
> 1. Kept the old compatible string marked as <DEPRECATED> in code and
>    in the Documentation.
>
>  .../devicetree/bindings/arm/samsung/exynos-adc.txt |    2 +-
>  .../devicetree/bindings/hwmon/ntc_thermistor.txt   |   20 ++++++++++++++------
>  Documentation/hwmon/ntc_thermistor                 |    8 ++++----
>  drivers/hwmon/Kconfig                              |    5 +++--
>  drivers/hwmon/ntc_thermistor.c                     |   14 +++++++++++++-
>  5 files changed, 35 insertions(+), 14 deletions(-)
>

Looks good to me.

Reviewed-by: Javier Martinez Canillas <javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>

> diff --git a/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt b/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt
> index 5d49f2b..832fe8c 100644
> --- a/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt
> +++ b/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt
> @@ -48,7 +48,7 @@ adc@12D10000 {
>
>         /* NTC thermistor is a hwmon device */
>         ncp15wb473@0 {
> -               compatible = "ntc,ncp15wb473";
> +               compatible = "murata,ncp15wb473";
>                 pullup-uv = <1800000>;
>                 pullup-ohm = <47000>;
>                 pulldown-ohm = <0>;
> diff --git a/Documentation/devicetree/bindings/hwmon/ntc_thermistor.txt b/Documentation/devicetree/bindings/hwmon/ntc_thermistor.txt
> index c6f6667..b117b2e 100644
> --- a/Documentation/devicetree/bindings/hwmon/ntc_thermistor.txt
> +++ b/Documentation/devicetree/bindings/hwmon/ntc_thermistor.txt
> @@ -3,11 +3,19 @@ NTC Thermistor hwmon sensors
>
>  Requires node properties:
>  - "compatible" value : one of
> -       "ntc,ncp15wb473"
> -       "ntc,ncp18wb473"
> -       "ntc,ncp21wb473"
> -       "ntc,ncp03wb473"
> -       "ntc,ncp15wl333"
> +       "murata,ncp15wb473"
> +       "murata,ncp18wb473"
> +       "murata,ncp21wb473"
> +       "murata,ncp03wb473"
> +       "murata,ncp15wl333"
> +
> +/* Usage of vendor name "ntc" is deprecated */
> +<DEPRECATED>   "ntc,ncp15wb473"
> +<DEPRECATED>   "ntc,ncp18wb473"
> +<DEPRECATED>   "ntc,ncp21wb473"
> +<DEPRECATED>   "ntc,ncp03wb473"
> +<DEPRECATED>   "ntc,ncp15wl333"
> +
>  - "pullup-uv"  Pull up voltage in micro volts
>  - "pullup-ohm" Pull up resistor value in ohms
>  - "pulldown-ohm" Pull down resistor value in ohms
> @@ -21,7 +29,7 @@ Read more about iio bindings at
>
>  Example:
>         ncp15wb473@0 {
> -               compatible = "ntc,ncp15wb473";
> +               compatible = "murata,ncp15wb473";
>                 pullup-uv = <1800000>;
>                 pullup-ohm = <47000>;
>                 pulldown-ohm = <0>;
> diff --git a/Documentation/hwmon/ntc_thermistor b/Documentation/hwmon/ntc_thermistor
> index 3bfda94..057b770 100644
> --- a/Documentation/hwmon/ntc_thermistor
> +++ b/Documentation/hwmon/ntc_thermistor
> @@ -1,7 +1,7 @@
>  Kernel driver ntc_thermistor
>  =================
>
> -Supported thermistors:
> +Supported thermistors from Murata:
>  * Murata NTC Thermistors NCP15WB473, NCP18WB473, NCP21WB473, NCP03WB473, NCP15WL333
>    Prefixes: 'ncp15wb473', 'ncp18wb473', 'ncp21wb473', 'ncp03wb473', 'ncp15wl333'
>    Datasheet: Publicly available at Murata
> @@ -15,9 +15,9 @@ Authors:
>  Description
>  -----------
>
> -The NTC thermistor is a simple thermistor that requires users to provide the
> -resistance and lookup the corresponding compensation table to get the
> -temperature input.
> +The NTC (Negative Temperature Coefficient) thermistor is a simple thermistor
> +that requires users to provide the resistance and lookup the corresponding
> +compensation table to get the temperature input.
>
>  The NTC driver provides lookup tables with a linear approximation function
>  and four circuit models with an option not to use any of the four models.
> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> index 08531a1..154851b 100644
> --- a/drivers/hwmon/Kconfig
> +++ b/drivers/hwmon/Kconfig
> @@ -1052,7 +1052,7 @@ config SENSORS_PC87427
>           will be called pc87427.
>
>  config SENSORS_NTC_THERMISTOR
> -       tristate "NTC thermistor support"
> +       tristate "NTC thermistor support from Murata"
>         depends on !OF || IIO=n || IIO
>         help
>           This driver supports NTC thermistors sensor reading and its
> @@ -1060,7 +1060,8 @@ config SENSORS_NTC_THERMISTOR
>           send notifications about the temperature.
>
>           Currently, this driver supports
> -         NCP15WB473, NCP18WB473, NCP21WB473, NCP03WB473, and NCP15WL333.
> +         NCP15WB473, NCP18WB473, NCP21WB473, NCP03WB473, and NCP15WL333
> +         from Murata.
>
>           This driver can also be built as a module.  If so, the module
>           will be called ntc-thermistor.
> diff --git a/drivers/hwmon/ntc_thermistor.c b/drivers/hwmon/ntc_thermistor.c
> index e76feb86..bdfbe91 100644
> --- a/drivers/hwmon/ntc_thermistor.c
> +++ b/drivers/hwmon/ntc_thermistor.c
> @@ -163,6 +163,18 @@ static int ntc_adc_iio_read(struct ntc_thermistor_platform_data *pdata)
>  }
>
>  static const struct of_device_id ntc_match[] = {
> +       { .compatible = "murata,ncp15wb473",
> +               .data = &ntc_thermistor_id[0] },
> +       { .compatible = "murata,ncp18wb473",
> +               .data = &ntc_thermistor_id[1] },
> +       { .compatible = "murata,ncp21wb473",
> +               .data = &ntc_thermistor_id[2] },
> +       { .compatible = "murata,ncp03wb473",
> +               .data = &ntc_thermistor_id[3] },
> +       { .compatible = "murata,ncp15wl333",
> +               .data = &ntc_thermistor_id[4] },
> +
> +       /* Usage of vendor name "ntc" is deprecated */
>         { .compatible = "ntc,ncp15wb473",
>                 .data = &ntc_thermistor_id[0] },
>         { .compatible = "ntc,ncp18wb473",
> @@ -534,7 +546,7 @@ static struct platform_driver ntc_thermistor_driver = {
>
>  module_platform_driver(ntc_thermistor_driver);
>
> -MODULE_DESCRIPTION("NTC Thermistor Driver");
> +MODULE_DESCRIPTION("NTC Thermistor Driver from Murata");
>  MODULE_AUTHOR("MyungJoo Ham <myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>");
>  MODULE_LICENSE("GPL");
>  MODULE_ALIAS("platform:ntc-thermistor");
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 50+ messages in thread

* Re: [PATCH 2/4 v2] hwmon: ntc_thermistor: Use the manufacturer name properly
@ 2014-06-25 10:36       ` Javier Martinez Canillas
  0 siblings, 0 replies; 50+ messages in thread
From: Javier Martinez Canillas @ 2014-06-25 10:36 UTC (permalink / raw)
  To: Naveen Krishna Chatradhi
  Cc: linux-samsung-soc, linux-iio, Naveen Krishna Ch, Kukjin Kim,
	linux-arm-kernel, cpgs .,
	devicetree, Lars-Peter Clausen, Guenter Roeck

Hello Naveen,

On Wed, Jun 25, 2014 at 8:29 AM, Naveen Krishna Chatradhi
<ch.naveen@samsung.com> wrote:
> Murata Manufacturing Co., Ltd is the vendor for
> NTC (Negative Temperature coefficient) based Thermistors.
> But, the driver extensively uses "NTC" as the vendor name.
>
> This patch corrects the vendor name also updates the
> compatibility strings according to the vendor-prefix.txt
>
> Note: Drivers continue to support the previous compatible strings
> but further addition of these compatible strings in device tree
> is deprecated.
>
> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
> Cc: Guenter Roeck <linux@roeck-us.net>
> ---
> Changes since v1:
> 1. Kept the old compatible string marked as <DEPRECATED> in code and
>    in the Documentation.
>
>  .../devicetree/bindings/arm/samsung/exynos-adc.txt |    2 +-
>  .../devicetree/bindings/hwmon/ntc_thermistor.txt   |   20 ++++++++++++++------
>  Documentation/hwmon/ntc_thermistor                 |    8 ++++----
>  drivers/hwmon/Kconfig                              |    5 +++--
>  drivers/hwmon/ntc_thermistor.c                     |   14 +++++++++++++-
>  5 files changed, 35 insertions(+), 14 deletions(-)
>

Looks good to me.

Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>

> diff --git a/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt b/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt
> index 5d49f2b..832fe8c 100644
> --- a/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt
> +++ b/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt
> @@ -48,7 +48,7 @@ adc@12D10000 {
>
>         /* NTC thermistor is a hwmon device */
>         ncp15wb473@0 {
> -               compatible = "ntc,ncp15wb473";
> +               compatible = "murata,ncp15wb473";
>                 pullup-uv = <1800000>;
>                 pullup-ohm = <47000>;
>                 pulldown-ohm = <0>;
> diff --git a/Documentation/devicetree/bindings/hwmon/ntc_thermistor.txt b/Documentation/devicetree/bindings/hwmon/ntc_thermistor.txt
> index c6f6667..b117b2e 100644
> --- a/Documentation/devicetree/bindings/hwmon/ntc_thermistor.txt
> +++ b/Documentation/devicetree/bindings/hwmon/ntc_thermistor.txt
> @@ -3,11 +3,19 @@ NTC Thermistor hwmon sensors
>
>  Requires node properties:
>  - "compatible" value : one of
> -       "ntc,ncp15wb473"
> -       "ntc,ncp18wb473"
> -       "ntc,ncp21wb473"
> -       "ntc,ncp03wb473"
> -       "ntc,ncp15wl333"
> +       "murata,ncp15wb473"
> +       "murata,ncp18wb473"
> +       "murata,ncp21wb473"
> +       "murata,ncp03wb473"
> +       "murata,ncp15wl333"
> +
> +/* Usage of vendor name "ntc" is deprecated */
> +<DEPRECATED>   "ntc,ncp15wb473"
> +<DEPRECATED>   "ntc,ncp18wb473"
> +<DEPRECATED>   "ntc,ncp21wb473"
> +<DEPRECATED>   "ntc,ncp03wb473"
> +<DEPRECATED>   "ntc,ncp15wl333"
> +
>  - "pullup-uv"  Pull up voltage in micro volts
>  - "pullup-ohm" Pull up resistor value in ohms
>  - "pulldown-ohm" Pull down resistor value in ohms
> @@ -21,7 +29,7 @@ Read more about iio bindings at
>
>  Example:
>         ncp15wb473@0 {
> -               compatible = "ntc,ncp15wb473";
> +               compatible = "murata,ncp15wb473";
>                 pullup-uv = <1800000>;
>                 pullup-ohm = <47000>;
>                 pulldown-ohm = <0>;
> diff --git a/Documentation/hwmon/ntc_thermistor b/Documentation/hwmon/ntc_thermistor
> index 3bfda94..057b770 100644
> --- a/Documentation/hwmon/ntc_thermistor
> +++ b/Documentation/hwmon/ntc_thermistor
> @@ -1,7 +1,7 @@
>  Kernel driver ntc_thermistor
>  =================
>
> -Supported thermistors:
> +Supported thermistors from Murata:
>  * Murata NTC Thermistors NCP15WB473, NCP18WB473, NCP21WB473, NCP03WB473, NCP15WL333
>    Prefixes: 'ncp15wb473', 'ncp18wb473', 'ncp21wb473', 'ncp03wb473', 'ncp15wl333'
>    Datasheet: Publicly available at Murata
> @@ -15,9 +15,9 @@ Authors:
>  Description
>  -----------
>
> -The NTC thermistor is a simple thermistor that requires users to provide the
> -resistance and lookup the corresponding compensation table to get the
> -temperature input.
> +The NTC (Negative Temperature Coefficient) thermistor is a simple thermistor
> +that requires users to provide the resistance and lookup the corresponding
> +compensation table to get the temperature input.
>
>  The NTC driver provides lookup tables with a linear approximation function
>  and four circuit models with an option not to use any of the four models.
> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> index 08531a1..154851b 100644
> --- a/drivers/hwmon/Kconfig
> +++ b/drivers/hwmon/Kconfig
> @@ -1052,7 +1052,7 @@ config SENSORS_PC87427
>           will be called pc87427.
>
>  config SENSORS_NTC_THERMISTOR
> -       tristate "NTC thermistor support"
> +       tristate "NTC thermistor support from Murata"
>         depends on !OF || IIO=n || IIO
>         help
>           This driver supports NTC thermistors sensor reading and its
> @@ -1060,7 +1060,8 @@ config SENSORS_NTC_THERMISTOR
>           send notifications about the temperature.
>
>           Currently, this driver supports
> -         NCP15WB473, NCP18WB473, NCP21WB473, NCP03WB473, and NCP15WL333.
> +         NCP15WB473, NCP18WB473, NCP21WB473, NCP03WB473, and NCP15WL333
> +         from Murata.
>
>           This driver can also be built as a module.  If so, the module
>           will be called ntc-thermistor.
> diff --git a/drivers/hwmon/ntc_thermistor.c b/drivers/hwmon/ntc_thermistor.c
> index e76feb86..bdfbe91 100644
> --- a/drivers/hwmon/ntc_thermistor.c
> +++ b/drivers/hwmon/ntc_thermistor.c
> @@ -163,6 +163,18 @@ static int ntc_adc_iio_read(struct ntc_thermistor_platform_data *pdata)
>  }
>
>  static const struct of_device_id ntc_match[] = {
> +       { .compatible = "murata,ncp15wb473",
> +               .data = &ntc_thermistor_id[0] },
> +       { .compatible = "murata,ncp18wb473",
> +               .data = &ntc_thermistor_id[1] },
> +       { .compatible = "murata,ncp21wb473",
> +               .data = &ntc_thermistor_id[2] },
> +       { .compatible = "murata,ncp03wb473",
> +               .data = &ntc_thermistor_id[3] },
> +       { .compatible = "murata,ncp15wl333",
> +               .data = &ntc_thermistor_id[4] },
> +
> +       /* Usage of vendor name "ntc" is deprecated */
>         { .compatible = "ntc,ncp15wb473",
>                 .data = &ntc_thermistor_id[0] },
>         { .compatible = "ntc,ncp18wb473",
> @@ -534,7 +546,7 @@ static struct platform_driver ntc_thermistor_driver = {
>
>  module_platform_driver(ntc_thermistor_driver);
>
> -MODULE_DESCRIPTION("NTC Thermistor Driver");
> +MODULE_DESCRIPTION("NTC Thermistor Driver from Murata");
>  MODULE_AUTHOR("MyungJoo Ham <myungjoo.ham@samsung.com>");
>  MODULE_LICENSE("GPL");
>  MODULE_ALIAS("platform:ntc-thermistor");
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 50+ messages in thread

* [PATCH 2/4 v2] hwmon: ntc_thermistor: Use the manufacturer name properly
@ 2014-06-25 10:36       ` Javier Martinez Canillas
  0 siblings, 0 replies; 50+ messages in thread
From: Javier Martinez Canillas @ 2014-06-25 10:36 UTC (permalink / raw)
  To: linux-arm-kernel

Hello Naveen,

On Wed, Jun 25, 2014 at 8:29 AM, Naveen Krishna Chatradhi
<ch.naveen@samsung.com> wrote:
> Murata Manufacturing Co., Ltd is the vendor for
> NTC (Negative Temperature coefficient) based Thermistors.
> But, the driver extensively uses "NTC" as the vendor name.
>
> This patch corrects the vendor name also updates the
> compatibility strings according to the vendor-prefix.txt
>
> Note: Drivers continue to support the previous compatible strings
> but further addition of these compatible strings in device tree
> is deprecated.
>
> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
> Cc: Guenter Roeck <linux@roeck-us.net>
> ---
> Changes since v1:
> 1. Kept the old compatible string marked as <DEPRECATED> in code and
>    in the Documentation.
>
>  .../devicetree/bindings/arm/samsung/exynos-adc.txt |    2 +-
>  .../devicetree/bindings/hwmon/ntc_thermistor.txt   |   20 ++++++++++++++------
>  Documentation/hwmon/ntc_thermistor                 |    8 ++++----
>  drivers/hwmon/Kconfig                              |    5 +++--
>  drivers/hwmon/ntc_thermistor.c                     |   14 +++++++++++++-
>  5 files changed, 35 insertions(+), 14 deletions(-)
>

Looks good to me.

Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>

> diff --git a/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt b/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt
> index 5d49f2b..832fe8c 100644
> --- a/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt
> +++ b/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt
> @@ -48,7 +48,7 @@ adc at 12D10000 {
>
>         /* NTC thermistor is a hwmon device */
>         ncp15wb473 at 0 {
> -               compatible = "ntc,ncp15wb473";
> +               compatible = "murata,ncp15wb473";
>                 pullup-uv = <1800000>;
>                 pullup-ohm = <47000>;
>                 pulldown-ohm = <0>;
> diff --git a/Documentation/devicetree/bindings/hwmon/ntc_thermistor.txt b/Documentation/devicetree/bindings/hwmon/ntc_thermistor.txt
> index c6f6667..b117b2e 100644
> --- a/Documentation/devicetree/bindings/hwmon/ntc_thermistor.txt
> +++ b/Documentation/devicetree/bindings/hwmon/ntc_thermistor.txt
> @@ -3,11 +3,19 @@ NTC Thermistor hwmon sensors
>
>  Requires node properties:
>  - "compatible" value : one of
> -       "ntc,ncp15wb473"
> -       "ntc,ncp18wb473"
> -       "ntc,ncp21wb473"
> -       "ntc,ncp03wb473"
> -       "ntc,ncp15wl333"
> +       "murata,ncp15wb473"
> +       "murata,ncp18wb473"
> +       "murata,ncp21wb473"
> +       "murata,ncp03wb473"
> +       "murata,ncp15wl333"
> +
> +/* Usage of vendor name "ntc" is deprecated */
> +<DEPRECATED>   "ntc,ncp15wb473"
> +<DEPRECATED>   "ntc,ncp18wb473"
> +<DEPRECATED>   "ntc,ncp21wb473"
> +<DEPRECATED>   "ntc,ncp03wb473"
> +<DEPRECATED>   "ntc,ncp15wl333"
> +
>  - "pullup-uv"  Pull up voltage in micro volts
>  - "pullup-ohm" Pull up resistor value in ohms
>  - "pulldown-ohm" Pull down resistor value in ohms
> @@ -21,7 +29,7 @@ Read more about iio bindings at
>
>  Example:
>         ncp15wb473 at 0 {
> -               compatible = "ntc,ncp15wb473";
> +               compatible = "murata,ncp15wb473";
>                 pullup-uv = <1800000>;
>                 pullup-ohm = <47000>;
>                 pulldown-ohm = <0>;
> diff --git a/Documentation/hwmon/ntc_thermistor b/Documentation/hwmon/ntc_thermistor
> index 3bfda94..057b770 100644
> --- a/Documentation/hwmon/ntc_thermistor
> +++ b/Documentation/hwmon/ntc_thermistor
> @@ -1,7 +1,7 @@
>  Kernel driver ntc_thermistor
>  =================
>
> -Supported thermistors:
> +Supported thermistors from Murata:
>  * Murata NTC Thermistors NCP15WB473, NCP18WB473, NCP21WB473, NCP03WB473, NCP15WL333
>    Prefixes: 'ncp15wb473', 'ncp18wb473', 'ncp21wb473', 'ncp03wb473', 'ncp15wl333'
>    Datasheet: Publicly available at Murata
> @@ -15,9 +15,9 @@ Authors:
>  Description
>  -----------
>
> -The NTC thermistor is a simple thermistor that requires users to provide the
> -resistance and lookup the corresponding compensation table to get the
> -temperature input.
> +The NTC (Negative Temperature Coefficient) thermistor is a simple thermistor
> +that requires users to provide the resistance and lookup the corresponding
> +compensation table to get the temperature input.
>
>  The NTC driver provides lookup tables with a linear approximation function
>  and four circuit models with an option not to use any of the four models.
> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> index 08531a1..154851b 100644
> --- a/drivers/hwmon/Kconfig
> +++ b/drivers/hwmon/Kconfig
> @@ -1052,7 +1052,7 @@ config SENSORS_PC87427
>           will be called pc87427.
>
>  config SENSORS_NTC_THERMISTOR
> -       tristate "NTC thermistor support"
> +       tristate "NTC thermistor support from Murata"
>         depends on !OF || IIO=n || IIO
>         help
>           This driver supports NTC thermistors sensor reading and its
> @@ -1060,7 +1060,8 @@ config SENSORS_NTC_THERMISTOR
>           send notifications about the temperature.
>
>           Currently, this driver supports
> -         NCP15WB473, NCP18WB473, NCP21WB473, NCP03WB473, and NCP15WL333.
> +         NCP15WB473, NCP18WB473, NCP21WB473, NCP03WB473, and NCP15WL333
> +         from Murata.
>
>           This driver can also be built as a module.  If so, the module
>           will be called ntc-thermistor.
> diff --git a/drivers/hwmon/ntc_thermistor.c b/drivers/hwmon/ntc_thermistor.c
> index e76feb86..bdfbe91 100644
> --- a/drivers/hwmon/ntc_thermistor.c
> +++ b/drivers/hwmon/ntc_thermistor.c
> @@ -163,6 +163,18 @@ static int ntc_adc_iio_read(struct ntc_thermistor_platform_data *pdata)
>  }
>
>  static const struct of_device_id ntc_match[] = {
> +       { .compatible = "murata,ncp15wb473",
> +               .data = &ntc_thermistor_id[0] },
> +       { .compatible = "murata,ncp18wb473",
> +               .data = &ntc_thermistor_id[1] },
> +       { .compatible = "murata,ncp21wb473",
> +               .data = &ntc_thermistor_id[2] },
> +       { .compatible = "murata,ncp03wb473",
> +               .data = &ntc_thermistor_id[3] },
> +       { .compatible = "murata,ncp15wl333",
> +               .data = &ntc_thermistor_id[4] },
> +
> +       /* Usage of vendor name "ntc" is deprecated */
>         { .compatible = "ntc,ncp15wb473",
>                 .data = &ntc_thermistor_id[0] },
>         { .compatible = "ntc,ncp18wb473",
> @@ -534,7 +546,7 @@ static struct platform_driver ntc_thermistor_driver = {
>
>  module_platform_driver(ntc_thermistor_driver);
>
> -MODULE_DESCRIPTION("NTC Thermistor Driver");
> +MODULE_DESCRIPTION("NTC Thermistor Driver from Murata");
>  MODULE_AUTHOR("MyungJoo Ham <myungjoo.ham@samsung.com>");
>  MODULE_LICENSE("GPL");
>  MODULE_ALIAS("platform:ntc-thermistor");
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 50+ messages in thread

* Re: [PATCH 4/4 v2] ARM: DTS: Add NTC thermistor nodes to Exynos5420 based Peach_PIT
  2014-06-25  6:29   ` Naveen Krishna Chatradhi
  (?)
@ 2014-06-25 10:38       ` Javier Martinez Canillas
  -1 siblings, 0 replies; 50+ messages in thread
From: Javier Martinez Canillas @ 2014-06-25 10:38 UTC (permalink / raw)
  To: Naveen Krishna Chatradhi
  Cc: linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA, linux-iio,
	Naveen Krishna, Kukjin Kim,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, cpgs .,
	devicetree-u79uwXL29TY76Z2rM5mHXA, Lars-Peter Clausen,
	Doug Anderson

Hello Naveen,

On Wed, Jun 25, 2014 at 8:29 AM, Naveen Krishna Chatradhi
<ch.naveen-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
> Exynos5420 based Peach PIT board has 4 NTC thermistors to measure
> temperatures at various points on the board.
>
> IIO based ADC becomes the parent and NTC thermistors are the childs,
> via the HWMON interface.
>
> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> Cc: Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> ---
> Changes since v1:
> 1. Arranged the ADC node alphabetical
> 2. Added "status = "okay"" to the ADC node
>
> This patch needs
> 1. MAX77802 PMIC device tree nodes (for ldo9)
>    https://www.mail-archive.com/devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org/msg31430.html
> 2. Uses the DT documentation for NTC thermistors updated with vendor-prefix
>
> This patch set is tested
> 1. On Peach PIT board via sysfs entry exposed by hwmon
> localhost ~ # cat /sys/class/hwmon/hwmon*/device/temp1_input
> 37436
> 36449
> 38560
> 38059
>
> 2. Backward compatibility is tested by replacing "murata" with "ntc"
>    in the dts nodes and running the above test.
>
>  arch/arm/boot/dts/exynos5420-peach-pit.dts |   34 ++++++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
> index b96a66a..19d733d 100644
> --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
> +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
> @@ -101,6 +101,40 @@
>         };
>  };
>
> +&adc {
> +       status = "okay";
> +       vdd-supply = <&ldo9_reg>;
> +
> +       ncp15wb473@3 {
> +               compatible = "murata,ncp15wb473";
> +               pullup-uv = <1800000>;
> +               pullup-ohm = <47000>;
> +               pulldown-ohm = <0>;
> +               io-channels = <&adc 3>;
> +       };
> +       ncp15wb473@4 {
> +               compatible = "murata,ncp15wb473";
> +               pullup-uv = <1800000>;
> +               pullup-ohm = <47000>;
> +               pulldown-ohm = <0>;
> +               io-channels = <&adc 4>;
> +       };
> +       ncp15wb473@5 {
> +               compatible = "murata,ncp15wb473";
> +               pullup-uv = <1800000>;
> +               pullup-ohm = <47000>;
> +               pulldown-ohm = <0>;
> +               io-channels = <&adc 5>;
> +       };
> +       ncp15wb473@6 {
> +               compatible = "murata,ncp15wb473";
> +               pullup-uv = <1800000>;
> +               pullup-ohm = <47000>;
> +               pulldown-ohm = <0>;
> +               io-channels = <&adc 6>;
> +       };
> +};
> +
>  &dp {
>         status = "okay";
>         pinctrl-names = "default";
> --
> 1.7.9.5
>

Tested-by: Javier Martinez Canillas <javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>

^ permalink raw reply	[flat|nested] 50+ messages in thread

* Re: [PATCH 4/4 v2] ARM: DTS: Add NTC thermistor nodes to Exynos5420 based Peach_PIT
@ 2014-06-25 10:38       ` Javier Martinez Canillas
  0 siblings, 0 replies; 50+ messages in thread
From: Javier Martinez Canillas @ 2014-06-25 10:38 UTC (permalink / raw)
  To: Naveen Krishna Chatradhi
  Cc: linux-samsung-soc, linux-iio, Naveen Krishna, Kukjin Kim,
	linux-arm-kernel, cpgs .,
	devicetree, Lars-Peter Clausen, Doug Anderson

Hello Naveen,

On Wed, Jun 25, 2014 at 8:29 AM, Naveen Krishna Chatradhi
<ch.naveen@samsung.com> wrote:
> Exynos5420 based Peach PIT board has 4 NTC thermistors to measure
> temperatures at various points on the board.
>
> IIO based ADC becomes the parent and NTC thermistors are the childs,
> via the HWMON interface.
>
> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
> Cc: Doug Anderson <dianders@chromium.org>
> ---
> Changes since v1:
> 1. Arranged the ADC node alphabetical
> 2. Added "status = "okay"" to the ADC node
>
> This patch needs
> 1. MAX77802 PMIC device tree nodes (for ldo9)
>    https://www.mail-archive.com/devicetree@vger.kernel.org/msg31430.html
> 2. Uses the DT documentation for NTC thermistors updated with vendor-prefix
>
> This patch set is tested
> 1. On Peach PIT board via sysfs entry exposed by hwmon
> localhost ~ # cat /sys/class/hwmon/hwmon*/device/temp1_input
> 37436
> 36449
> 38560
> 38059
>
> 2. Backward compatibility is tested by replacing "murata" with "ntc"
>    in the dts nodes and running the above test.
>
>  arch/arm/boot/dts/exynos5420-peach-pit.dts |   34 ++++++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
> index b96a66a..19d733d 100644
> --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
> +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
> @@ -101,6 +101,40 @@
>         };
>  };
>
> +&adc {
> +       status = "okay";
> +       vdd-supply = <&ldo9_reg>;
> +
> +       ncp15wb473@3 {
> +               compatible = "murata,ncp15wb473";
> +               pullup-uv = <1800000>;
> +               pullup-ohm = <47000>;
> +               pulldown-ohm = <0>;
> +               io-channels = <&adc 3>;
> +       };
> +       ncp15wb473@4 {
> +               compatible = "murata,ncp15wb473";
> +               pullup-uv = <1800000>;
> +               pullup-ohm = <47000>;
> +               pulldown-ohm = <0>;
> +               io-channels = <&adc 4>;
> +       };
> +       ncp15wb473@5 {
> +               compatible = "murata,ncp15wb473";
> +               pullup-uv = <1800000>;
> +               pullup-ohm = <47000>;
> +               pulldown-ohm = <0>;
> +               io-channels = <&adc 5>;
> +       };
> +       ncp15wb473@6 {
> +               compatible = "murata,ncp15wb473";
> +               pullup-uv = <1800000>;
> +               pullup-ohm = <47000>;
> +               pulldown-ohm = <0>;
> +               io-channels = <&adc 6>;
> +       };
> +};
> +
>  &dp {
>         status = "okay";
>         pinctrl-names = "default";
> --
> 1.7.9.5
>

Tested-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>

^ permalink raw reply	[flat|nested] 50+ messages in thread

* [PATCH 4/4 v2] ARM: DTS: Add NTC thermistor nodes to Exynos5420 based Peach_PIT
@ 2014-06-25 10:38       ` Javier Martinez Canillas
  0 siblings, 0 replies; 50+ messages in thread
From: Javier Martinez Canillas @ 2014-06-25 10:38 UTC (permalink / raw)
  To: linux-arm-kernel

Hello Naveen,

On Wed, Jun 25, 2014 at 8:29 AM, Naveen Krishna Chatradhi
<ch.naveen@samsung.com> wrote:
> Exynos5420 based Peach PIT board has 4 NTC thermistors to measure
> temperatures at various points on the board.
>
> IIO based ADC becomes the parent and NTC thermistors are the childs,
> via the HWMON interface.
>
> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
> Cc: Doug Anderson <dianders@chromium.org>
> ---
> Changes since v1:
> 1. Arranged the ADC node alphabetical
> 2. Added "status = "okay"" to the ADC node
>
> This patch needs
> 1. MAX77802 PMIC device tree nodes (for ldo9)
>    https://www.mail-archive.com/devicetree at vger.kernel.org/msg31430.html
> 2. Uses the DT documentation for NTC thermistors updated with vendor-prefix
>
> This patch set is tested
> 1. On Peach PIT board via sysfs entry exposed by hwmon
> localhost ~ # cat /sys/class/hwmon/hwmon*/device/temp1_input
> 37436
> 36449
> 38560
> 38059
>
> 2. Backward compatibility is tested by replacing "murata" with "ntc"
>    in the dts nodes and running the above test.
>
>  arch/arm/boot/dts/exynos5420-peach-pit.dts |   34 ++++++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
> index b96a66a..19d733d 100644
> --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
> +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
> @@ -101,6 +101,40 @@
>         };
>  };
>
> +&adc {
> +       status = "okay";
> +       vdd-supply = <&ldo9_reg>;
> +
> +       ncp15wb473 at 3 {
> +               compatible = "murata,ncp15wb473";
> +               pullup-uv = <1800000>;
> +               pullup-ohm = <47000>;
> +               pulldown-ohm = <0>;
> +               io-channels = <&adc 3>;
> +       };
> +       ncp15wb473 at 4 {
> +               compatible = "murata,ncp15wb473";
> +               pullup-uv = <1800000>;
> +               pullup-ohm = <47000>;
> +               pulldown-ohm = <0>;
> +               io-channels = <&adc 4>;
> +       };
> +       ncp15wb473 at 5 {
> +               compatible = "murata,ncp15wb473";
> +               pullup-uv = <1800000>;
> +               pullup-ohm = <47000>;
> +               pulldown-ohm = <0>;
> +               io-channels = <&adc 5>;
> +       };
> +       ncp15wb473 at 6 {
> +               compatible = "murata,ncp15wb473";
> +               pullup-uv = <1800000>;
> +               pullup-ohm = <47000>;
> +               pulldown-ohm = <0>;
> +               io-channels = <&adc 6>;
> +       };
> +};
> +
>  &dp {
>         status = "okay";
>         pinctrl-names = "default";
> --
> 1.7.9.5
>

Tested-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>

^ permalink raw reply	[flat|nested] 50+ messages in thread

* Re: [PATCH 2/4 v2] hwmon: ntc_thermistor: Use the manufacturer name properly
  2014-06-25 10:36       ` Javier Martinez Canillas
@ 2014-06-25 10:42         ` Naveen Krishna Ch
  -1 siblings, 0 replies; 50+ messages in thread
From: Naveen Krishna Ch @ 2014-06-25 10:42 UTC (permalink / raw)
  To: Javier Martinez Canillas
  Cc: Naveen Krishna Chatradhi, linux-samsung-soc, linux-iio,
	Kukjin Kim, linux-arm-kernel, cpgs .,
	devicetree, Lars-Peter Clausen, Guenter Roeck

Hello Javier,

On 25 June 2014 16:06, Javier Martinez Canillas <javier@dowhile0.org> wrote:
> Hello Naveen,
>
> On Wed, Jun 25, 2014 at 8:29 AM, Naveen Krishna Chatradhi
> <ch.naveen@samsung.com> wrote:
>> Murata Manufacturing Co., Ltd is the vendor for
>> NTC (Negative Temperature coefficient) based Thermistors.
>> But, the driver extensively uses "NTC" as the vendor name.
>>
>> This patch corrects the vendor name also updates the
>> compatibility strings according to the vendor-prefix.txt
>>
>> Note: Drivers continue to support the previous compatible strings
>> but further addition of these compatible strings in device tree
>> is deprecated.
>>
>> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
>> Cc: Guenter Roeck <linux@roeck-us.net>
>> ---
>> Changes since v1:
>> 1. Kept the old compatible string marked as <DEPRECATED> in code and
>>    in the Documentation.
>>
>>  .../devicetree/bindings/arm/samsung/exynos-adc.txt |    2 +-
>>  .../devicetree/bindings/hwmon/ntc_thermistor.txt   |   20 ++++++++++++++------
>>  Documentation/hwmon/ntc_thermistor                 |    8 ++++----
>>  drivers/hwmon/Kconfig                              |    5 +++--
>>  drivers/hwmon/ntc_thermistor.c                     |   14 +++++++++++++-
>>  5 files changed, 35 insertions(+), 14 deletions(-)
>>
>
> Looks good to me.
>
> Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Thanks for the review.
>
>> diff --git a/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt b/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt
>> index 5d49f2b..832fe8c 100644
>> --- a/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt
>> +++ b/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt
>> @@ -48,7 +48,7 @@ adc@12D10000 {
>>
>>         /* NTC thermistor is a hwmon device */
>>         ncp15wb473@0 {
>> -               compatible = "ntc,ncp15wb473";
>> +               compatible = "murata,ncp15wb473";
>>                 pullup-uv = <1800000>;
>>                 pullup-ohm = <47000>;
>>                 pulldown-ohm = <0>;
>> diff --git a/Documentation/devicetree/bindings/hwmon/ntc_thermistor.txt b/Documentation/devicetree/bindings/hwmon/ntc_thermistor.txt
>> index c6f6667..b117b2e 100644
>> --- a/Documentation/devicetree/bindings/hwmon/ntc_thermistor.txt
>> +++ b/Documentation/devicetree/bindings/hwmon/ntc_thermistor.txt
>> @@ -3,11 +3,19 @@ NTC Thermistor hwmon sensors
>>
>>  Requires node properties:
>>  - "compatible" value : one of
>> -       "ntc,ncp15wb473"
>> -       "ntc,ncp18wb473"
>> -       "ntc,ncp21wb473"
>> -       "ntc,ncp03wb473"
>> -       "ntc,ncp15wl333"
>> +       "murata,ncp15wb473"
>> +       "murata,ncp18wb473"
>> +       "murata,ncp21wb473"
>> +       "murata,ncp03wb473"
>> +       "murata,ncp15wl333"
>> +
>> +/* Usage of vendor name "ntc" is deprecated */
>> +<DEPRECATED>   "ntc,ncp15wb473"
>> +<DEPRECATED>   "ntc,ncp18wb473"
>> +<DEPRECATED>   "ntc,ncp21wb473"
>> +<DEPRECATED>   "ntc,ncp03wb473"
>> +<DEPRECATED>   "ntc,ncp15wl333"
>> +
>>  - "pullup-uv"  Pull up voltage in micro volts
>>  - "pullup-ohm" Pull up resistor value in ohms
>>  - "pulldown-ohm" Pull down resistor value in ohms
>> @@ -21,7 +29,7 @@ Read more about iio bindings at
>>
>>  Example:
>>         ncp15wb473@0 {
>> -               compatible = "ntc,ncp15wb473";
>> +               compatible = "murata,ncp15wb473";
>>                 pullup-uv = <1800000>;
>>                 pullup-ohm = <47000>;
>>                 pulldown-ohm = <0>;
>> diff --git a/Documentation/hwmon/ntc_thermistor b/Documentation/hwmon/ntc_thermistor
>> index 3bfda94..057b770 100644
>> --- a/Documentation/hwmon/ntc_thermistor
>> +++ b/Documentation/hwmon/ntc_thermistor
>> @@ -1,7 +1,7 @@
>>  Kernel driver ntc_thermistor
>>  =================
>>
>> -Supported thermistors:
>> +Supported thermistors from Murata:
>>  * Murata NTC Thermistors NCP15WB473, NCP18WB473, NCP21WB473, NCP03WB473, NCP15WL333
>>    Prefixes: 'ncp15wb473', 'ncp18wb473', 'ncp21wb473', 'ncp03wb473', 'ncp15wl333'
>>    Datasheet: Publicly available at Murata
>> @@ -15,9 +15,9 @@ Authors:
>>  Description
>>  -----------
>>
>> -The NTC thermistor is a simple thermistor that requires users to provide the
>> -resistance and lookup the corresponding compensation table to get the
>> -temperature input.
>> +The NTC (Negative Temperature Coefficient) thermistor is a simple thermistor
>> +that requires users to provide the resistance and lookup the corresponding
>> +compensation table to get the temperature input.
>>
>>  The NTC driver provides lookup tables with a linear approximation function
>>  and four circuit models with an option not to use any of the four models.
>> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
>> index 08531a1..154851b 100644
>> --- a/drivers/hwmon/Kconfig
>> +++ b/drivers/hwmon/Kconfig
>> @@ -1052,7 +1052,7 @@ config SENSORS_PC87427
>>           will be called pc87427.
>>
>>  config SENSORS_NTC_THERMISTOR
>> -       tristate "NTC thermistor support"
>> +       tristate "NTC thermistor support from Murata"
>>         depends on !OF || IIO=n || IIO
>>         help
>>           This driver supports NTC thermistors sensor reading and its
>> @@ -1060,7 +1060,8 @@ config SENSORS_NTC_THERMISTOR
>>           send notifications about the temperature.
>>
>>           Currently, this driver supports
>> -         NCP15WB473, NCP18WB473, NCP21WB473, NCP03WB473, and NCP15WL333.
>> +         NCP15WB473, NCP18WB473, NCP21WB473, NCP03WB473, and NCP15WL333
>> +         from Murata.
>>
>>           This driver can also be built as a module.  If so, the module
>>           will be called ntc-thermistor.
>> diff --git a/drivers/hwmon/ntc_thermistor.c b/drivers/hwmon/ntc_thermistor.c
>> index e76feb86..bdfbe91 100644
>> --- a/drivers/hwmon/ntc_thermistor.c
>> +++ b/drivers/hwmon/ntc_thermistor.c
>> @@ -163,6 +163,18 @@ static int ntc_adc_iio_read(struct ntc_thermistor_platform_data *pdata)
>>  }
>>
>>  static const struct of_device_id ntc_match[] = {
>> +       { .compatible = "murata,ncp15wb473",
>> +               .data = &ntc_thermistor_id[0] },
>> +       { .compatible = "murata,ncp18wb473",
>> +               .data = &ntc_thermistor_id[1] },
>> +       { .compatible = "murata,ncp21wb473",
>> +               .data = &ntc_thermistor_id[2] },
>> +       { .compatible = "murata,ncp03wb473",
>> +               .data = &ntc_thermistor_id[3] },
>> +       { .compatible = "murata,ncp15wl333",
>> +               .data = &ntc_thermistor_id[4] },
>> +
>> +       /* Usage of vendor name "ntc" is deprecated */
>>         { .compatible = "ntc,ncp15wb473",
>>                 .data = &ntc_thermistor_id[0] },
>>         { .compatible = "ntc,ncp18wb473",
>> @@ -534,7 +546,7 @@ static struct platform_driver ntc_thermistor_driver = {
>>
>>  module_platform_driver(ntc_thermistor_driver);
>>
>> -MODULE_DESCRIPTION("NTC Thermistor Driver");
>> +MODULE_DESCRIPTION("NTC Thermistor Driver from Murata");
>>  MODULE_AUTHOR("MyungJoo Ham <myungjoo.ham@samsung.com>");
>>  MODULE_LICENSE("GPL");
>>  MODULE_ALIAS("platform:ntc-thermistor");
>> --
>> 1.7.9.5
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Shine bright,
(: Nav :)

^ permalink raw reply	[flat|nested] 50+ messages in thread

* [PATCH 2/4 v2] hwmon: ntc_thermistor: Use the manufacturer name properly
@ 2014-06-25 10:42         ` Naveen Krishna Ch
  0 siblings, 0 replies; 50+ messages in thread
From: Naveen Krishna Ch @ 2014-06-25 10:42 UTC (permalink / raw)
  To: linux-arm-kernel

Hello Javier,

On 25 June 2014 16:06, Javier Martinez Canillas <javier@dowhile0.org> wrote:
> Hello Naveen,
>
> On Wed, Jun 25, 2014 at 8:29 AM, Naveen Krishna Chatradhi
> <ch.naveen@samsung.com> wrote:
>> Murata Manufacturing Co., Ltd is the vendor for
>> NTC (Negative Temperature coefficient) based Thermistors.
>> But, the driver extensively uses "NTC" as the vendor name.
>>
>> This patch corrects the vendor name also updates the
>> compatibility strings according to the vendor-prefix.txt
>>
>> Note: Drivers continue to support the previous compatible strings
>> but further addition of these compatible strings in device tree
>> is deprecated.
>>
>> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
>> Cc: Guenter Roeck <linux@roeck-us.net>
>> ---
>> Changes since v1:
>> 1. Kept the old compatible string marked as <DEPRECATED> in code and
>>    in the Documentation.
>>
>>  .../devicetree/bindings/arm/samsung/exynos-adc.txt |    2 +-
>>  .../devicetree/bindings/hwmon/ntc_thermistor.txt   |   20 ++++++++++++++------
>>  Documentation/hwmon/ntc_thermistor                 |    8 ++++----
>>  drivers/hwmon/Kconfig                              |    5 +++--
>>  drivers/hwmon/ntc_thermistor.c                     |   14 +++++++++++++-
>>  5 files changed, 35 insertions(+), 14 deletions(-)
>>
>
> Looks good to me.
>
> Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Thanks for the review.
>
>> diff --git a/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt b/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt
>> index 5d49f2b..832fe8c 100644
>> --- a/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt
>> +++ b/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt
>> @@ -48,7 +48,7 @@ adc at 12D10000 {
>>
>>         /* NTC thermistor is a hwmon device */
>>         ncp15wb473 at 0 {
>> -               compatible = "ntc,ncp15wb473";
>> +               compatible = "murata,ncp15wb473";
>>                 pullup-uv = <1800000>;
>>                 pullup-ohm = <47000>;
>>                 pulldown-ohm = <0>;
>> diff --git a/Documentation/devicetree/bindings/hwmon/ntc_thermistor.txt b/Documentation/devicetree/bindings/hwmon/ntc_thermistor.txt
>> index c6f6667..b117b2e 100644
>> --- a/Documentation/devicetree/bindings/hwmon/ntc_thermistor.txt
>> +++ b/Documentation/devicetree/bindings/hwmon/ntc_thermistor.txt
>> @@ -3,11 +3,19 @@ NTC Thermistor hwmon sensors
>>
>>  Requires node properties:
>>  - "compatible" value : one of
>> -       "ntc,ncp15wb473"
>> -       "ntc,ncp18wb473"
>> -       "ntc,ncp21wb473"
>> -       "ntc,ncp03wb473"
>> -       "ntc,ncp15wl333"
>> +       "murata,ncp15wb473"
>> +       "murata,ncp18wb473"
>> +       "murata,ncp21wb473"
>> +       "murata,ncp03wb473"
>> +       "murata,ncp15wl333"
>> +
>> +/* Usage of vendor name "ntc" is deprecated */
>> +<DEPRECATED>   "ntc,ncp15wb473"
>> +<DEPRECATED>   "ntc,ncp18wb473"
>> +<DEPRECATED>   "ntc,ncp21wb473"
>> +<DEPRECATED>   "ntc,ncp03wb473"
>> +<DEPRECATED>   "ntc,ncp15wl333"
>> +
>>  - "pullup-uv"  Pull up voltage in micro volts
>>  - "pullup-ohm" Pull up resistor value in ohms
>>  - "pulldown-ohm" Pull down resistor value in ohms
>> @@ -21,7 +29,7 @@ Read more about iio bindings at
>>
>>  Example:
>>         ncp15wb473 at 0 {
>> -               compatible = "ntc,ncp15wb473";
>> +               compatible = "murata,ncp15wb473";
>>                 pullup-uv = <1800000>;
>>                 pullup-ohm = <47000>;
>>                 pulldown-ohm = <0>;
>> diff --git a/Documentation/hwmon/ntc_thermistor b/Documentation/hwmon/ntc_thermistor
>> index 3bfda94..057b770 100644
>> --- a/Documentation/hwmon/ntc_thermistor
>> +++ b/Documentation/hwmon/ntc_thermistor
>> @@ -1,7 +1,7 @@
>>  Kernel driver ntc_thermistor
>>  =================
>>
>> -Supported thermistors:
>> +Supported thermistors from Murata:
>>  * Murata NTC Thermistors NCP15WB473, NCP18WB473, NCP21WB473, NCP03WB473, NCP15WL333
>>    Prefixes: 'ncp15wb473', 'ncp18wb473', 'ncp21wb473', 'ncp03wb473', 'ncp15wl333'
>>    Datasheet: Publicly available at Murata
>> @@ -15,9 +15,9 @@ Authors:
>>  Description
>>  -----------
>>
>> -The NTC thermistor is a simple thermistor that requires users to provide the
>> -resistance and lookup the corresponding compensation table to get the
>> -temperature input.
>> +The NTC (Negative Temperature Coefficient) thermistor is a simple thermistor
>> +that requires users to provide the resistance and lookup the corresponding
>> +compensation table to get the temperature input.
>>
>>  The NTC driver provides lookup tables with a linear approximation function
>>  and four circuit models with an option not to use any of the four models.
>> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
>> index 08531a1..154851b 100644
>> --- a/drivers/hwmon/Kconfig
>> +++ b/drivers/hwmon/Kconfig
>> @@ -1052,7 +1052,7 @@ config SENSORS_PC87427
>>           will be called pc87427.
>>
>>  config SENSORS_NTC_THERMISTOR
>> -       tristate "NTC thermistor support"
>> +       tristate "NTC thermistor support from Murata"
>>         depends on !OF || IIO=n || IIO
>>         help
>>           This driver supports NTC thermistors sensor reading and its
>> @@ -1060,7 +1060,8 @@ config SENSORS_NTC_THERMISTOR
>>           send notifications about the temperature.
>>
>>           Currently, this driver supports
>> -         NCP15WB473, NCP18WB473, NCP21WB473, NCP03WB473, and NCP15WL333.
>> +         NCP15WB473, NCP18WB473, NCP21WB473, NCP03WB473, and NCP15WL333
>> +         from Murata.
>>
>>           This driver can also be built as a module.  If so, the module
>>           will be called ntc-thermistor.
>> diff --git a/drivers/hwmon/ntc_thermistor.c b/drivers/hwmon/ntc_thermistor.c
>> index e76feb86..bdfbe91 100644
>> --- a/drivers/hwmon/ntc_thermistor.c
>> +++ b/drivers/hwmon/ntc_thermistor.c
>> @@ -163,6 +163,18 @@ static int ntc_adc_iio_read(struct ntc_thermistor_platform_data *pdata)
>>  }
>>
>>  static const struct of_device_id ntc_match[] = {
>> +       { .compatible = "murata,ncp15wb473",
>> +               .data = &ntc_thermistor_id[0] },
>> +       { .compatible = "murata,ncp18wb473",
>> +               .data = &ntc_thermistor_id[1] },
>> +       { .compatible = "murata,ncp21wb473",
>> +               .data = &ntc_thermistor_id[2] },
>> +       { .compatible = "murata,ncp03wb473",
>> +               .data = &ntc_thermistor_id[3] },
>> +       { .compatible = "murata,ncp15wl333",
>> +               .data = &ntc_thermistor_id[4] },
>> +
>> +       /* Usage of vendor name "ntc" is deprecated */
>>         { .compatible = "ntc,ncp15wb473",
>>                 .data = &ntc_thermistor_id[0] },
>>         { .compatible = "ntc,ncp18wb473",
>> @@ -534,7 +546,7 @@ static struct platform_driver ntc_thermistor_driver = {
>>
>>  module_platform_driver(ntc_thermistor_driver);
>>
>> -MODULE_DESCRIPTION("NTC Thermistor Driver");
>> +MODULE_DESCRIPTION("NTC Thermistor Driver from Murata");
>>  MODULE_AUTHOR("MyungJoo Ham <myungjoo.ham@samsung.com>");
>>  MODULE_LICENSE("GPL");
>>  MODULE_ALIAS("platform:ntc-thermistor");
>> --
>> 1.7.9.5
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
>> the body of a message to majordomo at vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Shine bright,
(: Nav :)

^ permalink raw reply	[flat|nested] 50+ messages in thread

* RE: [PATCH 0/4 v2] hwmon: ntc_thermistor: prepose vendor prefix change
  2014-06-25  6:29 ` Naveen Krishna Chatradhi
@ 2014-06-25 10:57   ` Kukjin Kim
  -1 siblings, 0 replies; 50+ messages in thread
From: Kukjin Kim @ 2014-06-25 10:57 UTC (permalink / raw)
  To: 'Naveen Krishna Chatradhi',
	linux-samsung-soc, linux-iio, jdelvare, linux
  Cc: naveenkrishna.ch, linux-arm-kernel, devicetree, lars

Naveen Krishna Chatradhi wrote:
> 
+ Jean Delvare, Guenter Roeck

I'm adding maintainers for drivers/hwmon/ntc* but I'm not sure.

Hi,

This series looks good to me. I will take 3/4 and 4/4 for exynos DT changes once
hwmon/ntc maintainer pick the others.

Thanks,
Kukjin

> As Murata is the manufacturer of the NTC (Negative Temperature coefficient)
> based Thermistors. ntc_thermistor driver extensively used the prefix "ntc".
> But, vendor-prefix should be "murata" instead of "ntc".
> 
> This patchset
> 1. Updates the vendor-prefix, DT bindings and Documentation,
>    where ever necessary.
> 2. Adds thermistor nodes to Exynos5420 based Peach PIT board.
> 
> Patches:
> 1/4. devicetree: bindings: Document murata vendor prefix
>      Adds the vendor prefix "murata" to vendor-prefixes.txt.
> 2/4. hwmon: ntc_thermistor: Use the manufacturer name properly
>      Updates the driver, Kconfig, device tree bindings and Documentation
>      with the Manufacturer/vendor information.
>      Keeps the old bindings marked as <DEPRECATED> in code and Documentation
> 3/4. ARM: DTS: use new compatible string as per the documentation
>      Updates the device node in Exynos4412 based Trats2 board
>      with the new device tree bindings.
> 4/4. ARM: DTS: Add NTC thermistor nodes as child nodes to ADC
>      Adds Thermistor nodes to Exynos5420 based Peach PIT board.
> 
> This patchset
> Naveen Krishna Chatradhi (4):
>   devicetree: bindings: Document murata vendor prefix
>   hwmon: ntc_thermistor: Use the manufacturer name properly
>   ARM: DTS: use new compatible string as per the documentation
>   ARM: DTS: Add NTC thermistor nodes to Exynos5420 based Peach_PIT
> 
>  .../devicetree/bindings/arm/samsung/exynos-adc.txt |    2 +-
>  .../devicetree/bindings/hwmon/ntc_thermistor.txt   |   20 ++++++++----
>  .../devicetree/bindings/vendor-prefixes.txt        |    1 +
>  Documentation/hwmon/ntc_thermistor                 |    8 ++---
>  arch/arm/boot/dts/exynos4412-trats2.dts            |    4 +--
>  arch/arm/boot/dts/exynos5420-peach-pit.dts         |   34
++++++++++++++++++++
>  drivers/hwmon/Kconfig                              |    5 +--
>  drivers/hwmon/ntc_thermistor.c                     |   14 +++++++-
>  8 files changed, 72 insertions(+), 16 deletions(-)
> 
> --
> 1.7.9.5

^ permalink raw reply	[flat|nested] 50+ messages in thread

* [PATCH 0/4 v2] hwmon: ntc_thermistor: prepose vendor prefix change
@ 2014-06-25 10:57   ` Kukjin Kim
  0 siblings, 0 replies; 50+ messages in thread
From: Kukjin Kim @ 2014-06-25 10:57 UTC (permalink / raw)
  To: linux-arm-kernel

Naveen Krishna Chatradhi wrote:
> 
+ Jean Delvare, Guenter Roeck

I'm adding maintainers for drivers/hwmon/ntc* but I'm not sure.

Hi,

This series looks good to me. I will take 3/4 and 4/4 for exynos DT changes once
hwmon/ntc maintainer pick the others.

Thanks,
Kukjin

> As Murata is the manufacturer of the NTC (Negative Temperature coefficient)
> based Thermistors. ntc_thermistor driver extensively used the prefix "ntc".
> But, vendor-prefix should be "murata" instead of "ntc".
> 
> This patchset
> 1. Updates the vendor-prefix, DT bindings and Documentation,
>    where ever necessary.
> 2. Adds thermistor nodes to Exynos5420 based Peach PIT board.
> 
> Patches:
> 1/4. devicetree: bindings: Document murata vendor prefix
>      Adds the vendor prefix "murata" to vendor-prefixes.txt.
> 2/4. hwmon: ntc_thermistor: Use the manufacturer name properly
>      Updates the driver, Kconfig, device tree bindings and Documentation
>      with the Manufacturer/vendor information.
>      Keeps the old bindings marked as <DEPRECATED> in code and Documentation
> 3/4. ARM: DTS: use new compatible string as per the documentation
>      Updates the device node in Exynos4412 based Trats2 board
>      with the new device tree bindings.
> 4/4. ARM: DTS: Add NTC thermistor nodes as child nodes to ADC
>      Adds Thermistor nodes to Exynos5420 based Peach PIT board.
> 
> This patchset
> Naveen Krishna Chatradhi (4):
>   devicetree: bindings: Document murata vendor prefix
>   hwmon: ntc_thermistor: Use the manufacturer name properly
>   ARM: DTS: use new compatible string as per the documentation
>   ARM: DTS: Add NTC thermistor nodes to Exynos5420 based Peach_PIT
> 
>  .../devicetree/bindings/arm/samsung/exynos-adc.txt |    2 +-
>  .../devicetree/bindings/hwmon/ntc_thermistor.txt   |   20 ++++++++----
>  .../devicetree/bindings/vendor-prefixes.txt        |    1 +
>  Documentation/hwmon/ntc_thermistor                 |    8 ++---
>  arch/arm/boot/dts/exynos4412-trats2.dts            |    4 +--
>  arch/arm/boot/dts/exynos5420-peach-pit.dts         |   34
++++++++++++++++++++
>  drivers/hwmon/Kconfig                              |    5 +--
>  drivers/hwmon/ntc_thermistor.c                     |   14 +++++++-
>  8 files changed, 72 insertions(+), 16 deletions(-)
> 
> --
> 1.7.9.5

^ permalink raw reply	[flat|nested] 50+ messages in thread

* Re: [PATCH 1/4 v2] devicetree: bindings: Document murata vendor prefix
  2014-06-25  6:29     ` Naveen Krishna Chatradhi
  (?)
@ 2014-06-25 14:10         ` Guenter Roeck
  -1 siblings, 0 replies; 50+ messages in thread
From: Guenter Roeck @ 2014-06-25 14:10 UTC (permalink / raw)
  To: Naveen Krishna Chatradhi,
	linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
	linux-iio-u79uwXL29TY76Z2rM5mHXA
  Cc: naveenkrishna.ch-Re5JQEeQqe8AvxtiuMwx3w,
	kgene.kim-Sze3O3UU22JBDgjK7y7TUQ,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	cpgs-Sze3O3UU22JBDgjK7y7TUQ, devicetree-u79uwXL29TY76Z2rM5mHXA,
	lars-Qo5EllUWu/uELgA04lAiVw

On 06/24/2014 11:29 PM, Naveen Krishna Chatradhi wrote:
> Add Murata Manufacturing Co., Ltd. to the list of device tree
> vendor prefixes.
>
> Murata manufactures NTC (Negative Temperature Coefficient) based
> Thermistors for small scale applications like Mobiles and PDAs.
>
> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> Acked-by: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
> Cc: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>

Applied.

Thanks,
Guenter

^ permalink raw reply	[flat|nested] 50+ messages in thread

* Re: [PATCH 1/4 v2] devicetree: bindings: Document murata vendor prefix
@ 2014-06-25 14:10         ` Guenter Roeck
  0 siblings, 0 replies; 50+ messages in thread
From: Guenter Roeck @ 2014-06-25 14:10 UTC (permalink / raw)
  To: Naveen Krishna Chatradhi, linux-samsung-soc, linux-iio
  Cc: naveenkrishna.ch, kgene.kim, linux-arm-kernel, cpgs, devicetree, lars

On 06/24/2014 11:29 PM, Naveen Krishna Chatradhi wrote:
> Add Murata Manufacturing Co., Ltd. to the list of device tree
> vendor prefixes.
>
> Murata manufactures NTC (Negative Temperature Coefficient) based
> Thermistors for small scale applications like Mobiles and PDAs.
>
> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
> Acked-by: Mark Rutland <mark.rutland@arm.com>
> Cc: Guenter Roeck <linux@roeck-us.net>

Applied.

Thanks,
Guenter


^ permalink raw reply	[flat|nested] 50+ messages in thread

* [PATCH 1/4 v2] devicetree: bindings: Document murata vendor prefix
@ 2014-06-25 14:10         ` Guenter Roeck
  0 siblings, 0 replies; 50+ messages in thread
From: Guenter Roeck @ 2014-06-25 14:10 UTC (permalink / raw)
  To: linux-arm-kernel

On 06/24/2014 11:29 PM, Naveen Krishna Chatradhi wrote:
> Add Murata Manufacturing Co., Ltd. to the list of device tree
> vendor prefixes.
>
> Murata manufactures NTC (Negative Temperature Coefficient) based
> Thermistors for small scale applications like Mobiles and PDAs.
>
> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
> Acked-by: Mark Rutland <mark.rutland@arm.com>
> Cc: Guenter Roeck <linux@roeck-us.net>

Applied.

Thanks,
Guenter

^ permalink raw reply	[flat|nested] 50+ messages in thread

* Re: [PATCH 2/4 v2] hwmon: ntc_thermistor: Use the manufacturer name properly
  2014-06-25  6:29   ` Naveen Krishna Chatradhi
@ 2014-06-25 14:10     ` Guenter Roeck
  -1 siblings, 0 replies; 50+ messages in thread
From: Guenter Roeck @ 2014-06-25 14:10 UTC (permalink / raw)
  To: Naveen Krishna Chatradhi, linux-samsung-soc, linux-iio
  Cc: naveenkrishna.ch, kgene.kim, linux-arm-kernel, cpgs, devicetree, lars

On 06/24/2014 11:29 PM, Naveen Krishna Chatradhi wrote:
> Murata Manufacturing Co., Ltd is the vendor for
> NTC (Negative Temperature coefficient) based Thermistors.
> But, the driver extensively uses "NTC" as the vendor name.
>
> This patch corrects the vendor name also updates the
> compatibility strings according to the vendor-prefix.txt
>
> Note: Drivers continue to support the previous compatible strings
> but further addition of these compatible strings in device tree
> is deprecated.
>
> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
> Cc: Guenter Roeck <linux@roeck-us.net>

Applied.

Guenter

^ permalink raw reply	[flat|nested] 50+ messages in thread

* [PATCH 2/4 v2] hwmon: ntc_thermistor: Use the manufacturer name properly
@ 2014-06-25 14:10     ` Guenter Roeck
  0 siblings, 0 replies; 50+ messages in thread
From: Guenter Roeck @ 2014-06-25 14:10 UTC (permalink / raw)
  To: linux-arm-kernel

On 06/24/2014 11:29 PM, Naveen Krishna Chatradhi wrote:
> Murata Manufacturing Co., Ltd is the vendor for
> NTC (Negative Temperature coefficient) based Thermistors.
> But, the driver extensively uses "NTC" as the vendor name.
>
> This patch corrects the vendor name also updates the
> compatibility strings according to the vendor-prefix.txt
>
> Note: Drivers continue to support the previous compatible strings
> but further addition of these compatible strings in device tree
> is deprecated.
>
> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
> Cc: Guenter Roeck <linux@roeck-us.net>

Applied.

Guenter

^ permalink raw reply	[flat|nested] 50+ messages in thread

* Re: [PATCH 0/4 v2] hwmon: ntc_thermistor: prepose vendor prefix change
  2014-06-25 10:57   ` Kukjin Kim
@ 2014-06-25 14:12     ` Guenter Roeck
  -1 siblings, 0 replies; 50+ messages in thread
From: Guenter Roeck @ 2014-06-25 14:12 UTC (permalink / raw)
  To: Kukjin Kim, 'Naveen Krishna Chatradhi',
	linux-samsung-soc, linux-iio, jdelvare
  Cc: naveenkrishna.ch, linux-arm-kernel, devicetree, lars

On 06/25/2014 03:57 AM, Kukjin Kim wrote:
> Naveen Krishna Chatradhi wrote:
>>
> + Jean Delvare, Guenter Roeck
>
> I'm adding maintainers for drivers/hwmon/ntc* but I'm not sure.
>
> Hi,
>
> This series looks good to me. I will take 3/4 and 4/4 for exynos DT changes once
> hwmon/ntc maintainer pick the others.
>

I applied both patches. Currently going through my test cycle.
I'll send them to Linus Thursday or Friday.

Guenter

^ permalink raw reply	[flat|nested] 50+ messages in thread

* [PATCH 0/4 v2] hwmon: ntc_thermistor: prepose vendor prefix change
@ 2014-06-25 14:12     ` Guenter Roeck
  0 siblings, 0 replies; 50+ messages in thread
From: Guenter Roeck @ 2014-06-25 14:12 UTC (permalink / raw)
  To: linux-arm-kernel

On 06/25/2014 03:57 AM, Kukjin Kim wrote:
> Naveen Krishna Chatradhi wrote:
>>
> + Jean Delvare, Guenter Roeck
>
> I'm adding maintainers for drivers/hwmon/ntc* but I'm not sure.
>
> Hi,
>
> This series looks good to me. I will take 3/4 and 4/4 for exynos DT changes once
> hwmon/ntc maintainer pick the others.
>

I applied both patches. Currently going through my test cycle.
I'll send them to Linus Thursday or Friday.

Guenter

^ permalink raw reply	[flat|nested] 50+ messages in thread

* Re: [PATCH 4/4 v2] ARM: DTS: Add NTC thermistor nodes to Exynos5420 based Peach_PIT
  2014-06-25  6:29   ` Naveen Krishna Chatradhi
  (?)
@ 2014-06-25 20:40       ` Doug Anderson
  -1 siblings, 0 replies; 50+ messages in thread
From: Doug Anderson @ 2014-06-25 20:40 UTC (permalink / raw)
  To: Naveen Krishna Chatradhi
  Cc: linux-samsung-soc, linux-iio, Naveen Krishna, Kukjin Kim,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, cpgs .,
	devicetree-u79uwXL29TY76Z2rM5mHXA, Lars-Peter Clausen

Naveen,

On Tue, Jun 24, 2014 at 11:29 PM, Naveen Krishna Chatradhi
<ch.naveen-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
> Exynos5420 based Peach PIT board has 4 NTC thermistors to measure
> temperatures at various points on the board.
>
> IIO based ADC becomes the parent and NTC thermistors are the childs,
> via the HWMON interface.
>
> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> Cc: Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> ---
> Changes since v1:
> 1. Arranged the ADC node alphabetical
> 2. Added "status = "okay"" to the ADC node
>
> This patch needs
> 1. MAX77802 PMIC device tree nodes (for ldo9)
>    https://www.mail-archive.com/devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org/msg31430.html
> 2. Uses the DT documentation for NTC thermistors updated with vendor-prefix
>
> This patch set is tested
> 1. On Peach PIT board via sysfs entry exposed by hwmon
> localhost ~ # cat /sys/class/hwmon/hwmon*/device/temp1_input
> 37436
> 36449
> 38560
> 38059
>
> 2. Backward compatibility is tested by replacing "murata" with "ntc"
>    in the dts nodes and running the above test.
>
>  arch/arm/boot/dts/exynos5420-peach-pit.dts |   34 ++++++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)

Now that Javier has spun his patch, perhaps you can fold the "pi"
version in here too?

Reviewed-by: Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Tested-by: Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>

^ permalink raw reply	[flat|nested] 50+ messages in thread

* Re: [PATCH 4/4 v2] ARM: DTS: Add NTC thermistor nodes to Exynos5420 based Peach_PIT
@ 2014-06-25 20:40       ` Doug Anderson
  0 siblings, 0 replies; 50+ messages in thread
From: Doug Anderson @ 2014-06-25 20:40 UTC (permalink / raw)
  To: Naveen Krishna Chatradhi
  Cc: linux-samsung-soc, linux-iio, Naveen Krishna, Kukjin Kim,
	linux-arm-kernel, cpgs .,
	devicetree, Lars-Peter Clausen

Naveen,

On Tue, Jun 24, 2014 at 11:29 PM, Naveen Krishna Chatradhi
<ch.naveen@samsung.com> wrote:
> Exynos5420 based Peach PIT board has 4 NTC thermistors to measure
> temperatures at various points on the board.
>
> IIO based ADC becomes the parent and NTC thermistors are the childs,
> via the HWMON interface.
>
> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
> Cc: Doug Anderson <dianders@chromium.org>
> ---
> Changes since v1:
> 1. Arranged the ADC node alphabetical
> 2. Added "status = "okay"" to the ADC node
>
> This patch needs
> 1. MAX77802 PMIC device tree nodes (for ldo9)
>    https://www.mail-archive.com/devicetree@vger.kernel.org/msg31430.html
> 2. Uses the DT documentation for NTC thermistors updated with vendor-prefix
>
> This patch set is tested
> 1. On Peach PIT board via sysfs entry exposed by hwmon
> localhost ~ # cat /sys/class/hwmon/hwmon*/device/temp1_input
> 37436
> 36449
> 38560
> 38059
>
> 2. Backward compatibility is tested by replacing "murata" with "ntc"
>    in the dts nodes and running the above test.
>
>  arch/arm/boot/dts/exynos5420-peach-pit.dts |   34 ++++++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)

Now that Javier has spun his patch, perhaps you can fold the "pi"
version in here too?

Reviewed-by: Doug Anderson <dianders@chromium.org>
Tested-by: Doug Anderson <dianders@chromium.org>

^ permalink raw reply	[flat|nested] 50+ messages in thread

* [PATCH 4/4 v2] ARM: DTS: Add NTC thermistor nodes to Exynos5420 based Peach_PIT
@ 2014-06-25 20:40       ` Doug Anderson
  0 siblings, 0 replies; 50+ messages in thread
From: Doug Anderson @ 2014-06-25 20:40 UTC (permalink / raw)
  To: linux-arm-kernel

Naveen,

On Tue, Jun 24, 2014 at 11:29 PM, Naveen Krishna Chatradhi
<ch.naveen@samsung.com> wrote:
> Exynos5420 based Peach PIT board has 4 NTC thermistors to measure
> temperatures at various points on the board.
>
> IIO based ADC becomes the parent and NTC thermistors are the childs,
> via the HWMON interface.
>
> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
> Cc: Doug Anderson <dianders@chromium.org>
> ---
> Changes since v1:
> 1. Arranged the ADC node alphabetical
> 2. Added "status = "okay"" to the ADC node
>
> This patch needs
> 1. MAX77802 PMIC device tree nodes (for ldo9)
>    https://www.mail-archive.com/devicetree at vger.kernel.org/msg31430.html
> 2. Uses the DT documentation for NTC thermistors updated with vendor-prefix
>
> This patch set is tested
> 1. On Peach PIT board via sysfs entry exposed by hwmon
> localhost ~ # cat /sys/class/hwmon/hwmon*/device/temp1_input
> 37436
> 36449
> 38560
> 38059
>
> 2. Backward compatibility is tested by replacing "murata" with "ntc"
>    in the dts nodes and running the above test.
>
>  arch/arm/boot/dts/exynos5420-peach-pit.dts |   34 ++++++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)

Now that Javier has spun his patch, perhaps you can fold the "pi"
version in here too?

Reviewed-by: Doug Anderson <dianders@chromium.org>
Tested-by: Doug Anderson <dianders@chromium.org>

^ permalink raw reply	[flat|nested] 50+ messages in thread

* Re: [PATCH 4/4 v2] ARM: DTS: Add NTC thermistor nodes to Exynos5420 based Peach_PIT
  2014-06-25 20:40       ` Doug Anderson
  (?)
@ 2014-06-26  6:16           ` Naveen Krishna Ch
  -1 siblings, 0 replies; 50+ messages in thread
From: Naveen Krishna Ch @ 2014-06-26  6:16 UTC (permalink / raw)
  To: Doug Anderson
  Cc: Naveen Krishna Chatradhi, linux-samsung-soc, linux-iio,
	Kukjin Kim, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	cpgs .,
	devicetree-u79uwXL29TY76Z2rM5mHXA, Lars-Peter Clausen

Doug,

On 26 June 2014 02:10, Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> wrote:
> Naveen,
>
> On Tue, Jun 24, 2014 at 11:29 PM, Naveen Krishna Chatradhi
> <ch.naveen-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
>> Exynos5420 based Peach PIT board has 4 NTC thermistors to measure
>> temperatures at various points on the board.
>>
>> IIO based ADC becomes the parent and NTC thermistors are the childs,
>> via the HWMON interface.
>>
>> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
>> Cc: Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
>> ---
>> Changes since v1:
>> 1. Arranged the ADC node alphabetical
>> 2. Added "status = "okay"" to the ADC node
>>
>> This patch needs
>> 1. MAX77802 PMIC device tree nodes (for ldo9)
>>    https://www.mail-archive.com/devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org/msg31430.html
>> 2. Uses the DT documentation for NTC thermistors updated with vendor-prefix
>>
>> This patch set is tested
>> 1. On Peach PIT board via sysfs entry exposed by hwmon
>> localhost ~ # cat /sys/class/hwmon/hwmon*/device/temp1_input
>> 37436
>> 36449
>> 38560
>> 38059
>>
>> 2. Backward compatibility is tested by replacing "murata" with "ntc"
>>    in the dts nodes and running the above test.
>>
>>  arch/arm/boot/dts/exynos5420-peach-pit.dts |   34 ++++++++++++++++++++++++++++
>>  1 file changed, 34 insertions(+)
>
> Now that Javier has spun his patch, perhaps you can fold the "pi"
> version in here too?

Sure, thanks for the information.

Snow also needs the adc nodes.
Will try to implement an adc fragment for PIT, PI and Snow.

>
> Reviewed-by: Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> Tested-by: Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>



-- 
Shine bright,
(: Nav :)

^ permalink raw reply	[flat|nested] 50+ messages in thread

* Re: [PATCH 4/4 v2] ARM: DTS: Add NTC thermistor nodes to Exynos5420 based Peach_PIT
@ 2014-06-26  6:16           ` Naveen Krishna Ch
  0 siblings, 0 replies; 50+ messages in thread
From: Naveen Krishna Ch @ 2014-06-26  6:16 UTC (permalink / raw)
  To: Doug Anderson
  Cc: Naveen Krishna Chatradhi, linux-samsung-soc, linux-iio,
	Kukjin Kim, linux-arm-kernel, cpgs .,
	devicetree, Lars-Peter Clausen

Doug,

On 26 June 2014 02:10, Doug Anderson <dianders@chromium.org> wrote:
> Naveen,
>
> On Tue, Jun 24, 2014 at 11:29 PM, Naveen Krishna Chatradhi
> <ch.naveen@samsung.com> wrote:
>> Exynos5420 based Peach PIT board has 4 NTC thermistors to measure
>> temperatures at various points on the board.
>>
>> IIO based ADC becomes the parent and NTC thermistors are the childs,
>> via the HWMON interface.
>>
>> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
>> Cc: Doug Anderson <dianders@chromium.org>
>> ---
>> Changes since v1:
>> 1. Arranged the ADC node alphabetical
>> 2. Added "status = "okay"" to the ADC node
>>
>> This patch needs
>> 1. MAX77802 PMIC device tree nodes (for ldo9)
>>    https://www.mail-archive.com/devicetree@vger.kernel.org/msg31430.html
>> 2. Uses the DT documentation for NTC thermistors updated with vendor-prefix
>>
>> This patch set is tested
>> 1. On Peach PIT board via sysfs entry exposed by hwmon
>> localhost ~ # cat /sys/class/hwmon/hwmon*/device/temp1_input
>> 37436
>> 36449
>> 38560
>> 38059
>>
>> 2. Backward compatibility is tested by replacing "murata" with "ntc"
>>    in the dts nodes and running the above test.
>>
>>  arch/arm/boot/dts/exynos5420-peach-pit.dts |   34 ++++++++++++++++++++++++++++
>>  1 file changed, 34 insertions(+)
>
> Now that Javier has spun his patch, perhaps you can fold the "pi"
> version in here too?

Sure, thanks for the information.

Snow also needs the adc nodes.
Will try to implement an adc fragment for PIT, PI and Snow.

>
> Reviewed-by: Doug Anderson <dianders@chromium.org>
> Tested-by: Doug Anderson <dianders@chromium.org>



-- 
Shine bright,
(: Nav :)

^ permalink raw reply	[flat|nested] 50+ messages in thread

* [PATCH 4/4 v2] ARM: DTS: Add NTC thermistor nodes to Exynos5420 based Peach_PIT
@ 2014-06-26  6:16           ` Naveen Krishna Ch
  0 siblings, 0 replies; 50+ messages in thread
From: Naveen Krishna Ch @ 2014-06-26  6:16 UTC (permalink / raw)
  To: linux-arm-kernel

Doug,

On 26 June 2014 02:10, Doug Anderson <dianders@chromium.org> wrote:
> Naveen,
>
> On Tue, Jun 24, 2014 at 11:29 PM, Naveen Krishna Chatradhi
> <ch.naveen@samsung.com> wrote:
>> Exynos5420 based Peach PIT board has 4 NTC thermistors to measure
>> temperatures at various points on the board.
>>
>> IIO based ADC becomes the parent and NTC thermistors are the childs,
>> via the HWMON interface.
>>
>> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
>> Cc: Doug Anderson <dianders@chromium.org>
>> ---
>> Changes since v1:
>> 1. Arranged the ADC node alphabetical
>> 2. Added "status = "okay"" to the ADC node
>>
>> This patch needs
>> 1. MAX77802 PMIC device tree nodes (for ldo9)
>>    https://www.mail-archive.com/devicetree at vger.kernel.org/msg31430.html
>> 2. Uses the DT documentation for NTC thermistors updated with vendor-prefix
>>
>> This patch set is tested
>> 1. On Peach PIT board via sysfs entry exposed by hwmon
>> localhost ~ # cat /sys/class/hwmon/hwmon*/device/temp1_input
>> 37436
>> 36449
>> 38560
>> 38059
>>
>> 2. Backward compatibility is tested by replacing "murata" with "ntc"
>>    in the dts nodes and running the above test.
>>
>>  arch/arm/boot/dts/exynos5420-peach-pit.dts |   34 ++++++++++++++++++++++++++++
>>  1 file changed, 34 insertions(+)
>
> Now that Javier has spun his patch, perhaps you can fold the "pi"
> version in here too?

Sure, thanks for the information.

Snow also needs the adc nodes.
Will try to implement an adc fragment for PIT, PI and Snow.

>
> Reviewed-by: Doug Anderson <dianders@chromium.org>
> Tested-by: Doug Anderson <dianders@chromium.org>



-- 
Shine bright,
(: Nav :)

^ permalink raw reply	[flat|nested] 50+ messages in thread

* Re: [PATCH 4/4 v2] ARM: DTS: Add NTC thermistor nodes to Exynos5420 based Peach_PIT
  2014-06-26  6:16           ` Naveen Krishna Ch
  (?)
@ 2014-06-26  8:45               ` Naveen Krishna Ch
  -1 siblings, 0 replies; 50+ messages in thread
From: Naveen Krishna Ch @ 2014-06-26  8:45 UTC (permalink / raw)
  To: Doug Anderson
  Cc: Naveen Krishna Chatradhi, linux-samsung-soc, linux-iio,
	Kukjin Kim, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	cpgs .,
	devicetree-u79uwXL29TY76Z2rM5mHXA, Lars-Peter Clausen

Hello Doug, Kukjin,

On 26 June 2014 11:46, Naveen Krishna Ch <naveenkrishna.ch-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> Doug,
>
> On 26 June 2014 02:10, Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> wrote:
>> Naveen,
>>
>> On Tue, Jun 24, 2014 at 11:29 PM, Naveen Krishna Chatradhi
>> <ch.naveen-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
>>> Exynos5420 based Peach PIT board has 4 NTC thermistors to measure
>>> temperatures at various points on the board.
>>>
>>> IIO based ADC becomes the parent and NTC thermistors are the childs,
>>> via the HWMON interface.
>>>
>>> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
>>> Cc: Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
>>> ---
>>> Changes since v1:
>>> 1. Arranged the ADC node alphabetical
>>> 2. Added "status = "okay"" to the ADC node
>>>
>>> This patch needs
>>> 1. MAX77802 PMIC device tree nodes (for ldo9)
>>>    https://www.mail-archive.com/devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org/msg31430.html
>>> 2. Uses the DT documentation for NTC thermistors updated with vendor-prefix
>>>
>>> This patch set is tested
>>> 1. On Peach PIT board via sysfs entry exposed by hwmon
>>> localhost ~ # cat /sys/class/hwmon/hwmon*/device/temp1_input
>>> 37436
>>> 36449
>>> 38560
>>> 38059
>>>
>>> 2. Backward compatibility is tested by replacing "murata" with "ntc"
>>>    in the dts nodes and running the above test.
>>>
>>>  arch/arm/boot/dts/exynos5420-peach-pit.dts |   34 ++++++++++++++++++++++++++++
>>>  1 file changed, 34 insertions(+)
>>
>> Now that Javier has spun his patch, perhaps you can fold the "pi"
>> version in here too?
>
> Sure, thanks for the information.
>
> Snow also needs the adc nodes.
> Will try to implement an adc fragment for PIT, PI and Snow.

I just found out  https://lkml.org/lkml/2013/3/27/453

Adding ADC based Thermistor nodes to Exynos5250-snow.dts din't make it in.


>
>>
>> Reviewed-by: Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
>> Tested-by: Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
>
>
>
> --
> Shine bright,
> (: Nav :)



-- 
Shine bright,
(: Nav :)

^ permalink raw reply	[flat|nested] 50+ messages in thread

* Re: [PATCH 4/4 v2] ARM: DTS: Add NTC thermistor nodes to Exynos5420 based Peach_PIT
@ 2014-06-26  8:45               ` Naveen Krishna Ch
  0 siblings, 0 replies; 50+ messages in thread
From: Naveen Krishna Ch @ 2014-06-26  8:45 UTC (permalink / raw)
  To: Doug Anderson
  Cc: Naveen Krishna Chatradhi, linux-samsung-soc, linux-iio,
	Kukjin Kim, linux-arm-kernel, cpgs .,
	devicetree, Lars-Peter Clausen

Hello Doug, Kukjin,

On 26 June 2014 11:46, Naveen Krishna Ch <naveenkrishna.ch@gmail.com> wrote:
> Doug,
>
> On 26 June 2014 02:10, Doug Anderson <dianders@chromium.org> wrote:
>> Naveen,
>>
>> On Tue, Jun 24, 2014 at 11:29 PM, Naveen Krishna Chatradhi
>> <ch.naveen@samsung.com> wrote:
>>> Exynos5420 based Peach PIT board has 4 NTC thermistors to measure
>>> temperatures at various points on the board.
>>>
>>> IIO based ADC becomes the parent and NTC thermistors are the childs,
>>> via the HWMON interface.
>>>
>>> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
>>> Cc: Doug Anderson <dianders@chromium.org>
>>> ---
>>> Changes since v1:
>>> 1. Arranged the ADC node alphabetical
>>> 2. Added "status = "okay"" to the ADC node
>>>
>>> This patch needs
>>> 1. MAX77802 PMIC device tree nodes (for ldo9)
>>>    https://www.mail-archive.com/devicetree@vger.kernel.org/msg31430.html
>>> 2. Uses the DT documentation for NTC thermistors updated with vendor-prefix
>>>
>>> This patch set is tested
>>> 1. On Peach PIT board via sysfs entry exposed by hwmon
>>> localhost ~ # cat /sys/class/hwmon/hwmon*/device/temp1_input
>>> 37436
>>> 36449
>>> 38560
>>> 38059
>>>
>>> 2. Backward compatibility is tested by replacing "murata" with "ntc"
>>>    in the dts nodes and running the above test.
>>>
>>>  arch/arm/boot/dts/exynos5420-peach-pit.dts |   34 ++++++++++++++++++++++++++++
>>>  1 file changed, 34 insertions(+)
>>
>> Now that Javier has spun his patch, perhaps you can fold the "pi"
>> version in here too?
>
> Sure, thanks for the information.
>
> Snow also needs the adc nodes.
> Will try to implement an adc fragment for PIT, PI and Snow.

I just found out  https://lkml.org/lkml/2013/3/27/453

Adding ADC based Thermistor nodes to Exynos5250-snow.dts din't make it in.


>
>>
>> Reviewed-by: Doug Anderson <dianders@chromium.org>
>> Tested-by: Doug Anderson <dianders@chromium.org>
>
>
>
> --
> Shine bright,
> (: Nav :)



-- 
Shine bright,
(: Nav :)

^ permalink raw reply	[flat|nested] 50+ messages in thread

* [PATCH 4/4 v2] ARM: DTS: Add NTC thermistor nodes to Exynos5420 based Peach_PIT
@ 2014-06-26  8:45               ` Naveen Krishna Ch
  0 siblings, 0 replies; 50+ messages in thread
From: Naveen Krishna Ch @ 2014-06-26  8:45 UTC (permalink / raw)
  To: linux-arm-kernel

Hello Doug, Kukjin,

On 26 June 2014 11:46, Naveen Krishna Ch <naveenkrishna.ch@gmail.com> wrote:
> Doug,
>
> On 26 June 2014 02:10, Doug Anderson <dianders@chromium.org> wrote:
>> Naveen,
>>
>> On Tue, Jun 24, 2014 at 11:29 PM, Naveen Krishna Chatradhi
>> <ch.naveen@samsung.com> wrote:
>>> Exynos5420 based Peach PIT board has 4 NTC thermistors to measure
>>> temperatures at various points on the board.
>>>
>>> IIO based ADC becomes the parent and NTC thermistors are the childs,
>>> via the HWMON interface.
>>>
>>> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
>>> Cc: Doug Anderson <dianders@chromium.org>
>>> ---
>>> Changes since v1:
>>> 1. Arranged the ADC node alphabetical
>>> 2. Added "status = "okay"" to the ADC node
>>>
>>> This patch needs
>>> 1. MAX77802 PMIC device tree nodes (for ldo9)
>>>    https://www.mail-archive.com/devicetree at vger.kernel.org/msg31430.html
>>> 2. Uses the DT documentation for NTC thermistors updated with vendor-prefix
>>>
>>> This patch set is tested
>>> 1. On Peach PIT board via sysfs entry exposed by hwmon
>>> localhost ~ # cat /sys/class/hwmon/hwmon*/device/temp1_input
>>> 37436
>>> 36449
>>> 38560
>>> 38059
>>>
>>> 2. Backward compatibility is tested by replacing "murata" with "ntc"
>>>    in the dts nodes and running the above test.
>>>
>>>  arch/arm/boot/dts/exynos5420-peach-pit.dts |   34 ++++++++++++++++++++++++++++
>>>  1 file changed, 34 insertions(+)
>>
>> Now that Javier has spun his patch, perhaps you can fold the "pi"
>> version in here too?
>
> Sure, thanks for the information.
>
> Snow also needs the adc nodes.
> Will try to implement an adc fragment for PIT, PI and Snow.

I just found out  https://lkml.org/lkml/2013/3/27/453

Adding ADC based Thermistor nodes to Exynos5250-snow.dts din't make it in.


>
>>
>> Reviewed-by: Doug Anderson <dianders@chromium.org>
>> Tested-by: Doug Anderson <dianders@chromium.org>
>
>
>
> --
> Shine bright,
> (: Nav :)



-- 
Shine bright,
(: Nav :)

^ permalink raw reply	[flat|nested] 50+ messages in thread

* Re: [PATCH 4/4 v2] ARM: DTS: Add NTC thermistor nodes to Exynos5420 based Peach_PIT
  2014-06-26  6:16           ` Naveen Krishna Ch
  (?)
@ 2014-06-26 11:46               ` Naveen Krishna Ch
  -1 siblings, 0 replies; 50+ messages in thread
From: Naveen Krishna Ch @ 2014-06-26 11:46 UTC (permalink / raw)
  To: Doug Anderson
  Cc: Naveen Krishna Chatradhi, linux-samsung-soc, linux-iio,
	Kukjin Kim, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	cpgs .,
	devicetree-u79uwXL29TY76Z2rM5mHXA, Lars-Peter Clausen

Hello Kukjin,

On 26 June 2014 11:46, Naveen Krishna Ch <naveenkrishna.ch-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> Doug,
>
> On 26 June 2014 02:10, Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> wrote:
>> Naveen,
>>
>> On Tue, Jun 24, 2014 at 11:29 PM, Naveen Krishna Chatradhi
>> <ch.naveen-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
>>> Exynos5420 based Peach PIT board has 4 NTC thermistors to measure
>>> temperatures at various points on the board.
>>>
>>> IIO based ADC becomes the parent and NTC thermistors are the childs,
>>> via the HWMON interface.
>>>
>>> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
>>> Cc: Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
>>> ---
>>> Changes since v1:
>>> 1. Arranged the ADC node alphabetical
>>> 2. Added "status = "okay"" to the ADC node
>>>
>>> This patch needs
>>> 1. MAX77802 PMIC device tree nodes (for ldo9)
>>>    https://www.mail-archive.com/devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org/msg31430.html
>>> 2. Uses the DT documentation for NTC thermistors updated with vendor-prefix
>>>
>>> This patch set is tested
>>> 1. On Peach PIT board via sysfs entry exposed by hwmon
>>> localhost ~ # cat /sys/class/hwmon/hwmon*/device/temp1_input
>>> 37436
>>> 36449
>>> 38560
>>> 38059
>>>
>>> 2. Backward compatibility is tested by replacing "murata" with "ntc"
>>>    in the dts nodes and running the above test.
>>>
>>>  arch/arm/boot/dts/exynos5420-peach-pit.dts |   34 ++++++++++++++++++++++++++++
>>>  1 file changed, 34 insertions(+)
>>
>> Now that Javier has spun his patch, perhaps you can fold the "pi"
>> version in here too?
>
> Sure, thanks for the information.
>
> Snow also needs the adc nodes.
> Will try to implement an adc fragment for PIT, PI and Snow.

I've a plan to create a common file (cros-exynos-peach.dts) for
exynos5420-peach-pit.dts and exynos5800-peach-pi.dts
And add the ADC nodes directly into that.

In favor of the above, can you abandon the following patches

1. [PATCH 3/4 v2] ARM: DTS: use new compatible string for thermistors in trats2
    http://www.spinics.net/lists/linux-samsung-soc/msg33037.html

2. [PATCH 4/4 v2] ARM: DTS: Add NTC thermistor nodes to Exynos5420
based Peach_PIT
http://www.spinics.net/lists/linux-samsung-soc/msg33038.html

>
>>
>> Reviewed-by: Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
>> Tested-by: Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
>
>
>
> --
> Shine bright,
> (: Nav :)



-- 
Thanks,
(: Nav :)

^ permalink raw reply	[flat|nested] 50+ messages in thread

* Re: [PATCH 4/4 v2] ARM: DTS: Add NTC thermistor nodes to Exynos5420 based Peach_PIT
@ 2014-06-26 11:46               ` Naveen Krishna Ch
  0 siblings, 0 replies; 50+ messages in thread
From: Naveen Krishna Ch @ 2014-06-26 11:46 UTC (permalink / raw)
  To: Doug Anderson
  Cc: Naveen Krishna Chatradhi, linux-samsung-soc, linux-iio,
	Kukjin Kim, linux-arm-kernel, cpgs .,
	devicetree, Lars-Peter Clausen

Hello Kukjin,

On 26 June 2014 11:46, Naveen Krishna Ch <naveenkrishna.ch@gmail.com> wrote:
> Doug,
>
> On 26 June 2014 02:10, Doug Anderson <dianders@chromium.org> wrote:
>> Naveen,
>>
>> On Tue, Jun 24, 2014 at 11:29 PM, Naveen Krishna Chatradhi
>> <ch.naveen@samsung.com> wrote:
>>> Exynos5420 based Peach PIT board has 4 NTC thermistors to measure
>>> temperatures at various points on the board.
>>>
>>> IIO based ADC becomes the parent and NTC thermistors are the childs,
>>> via the HWMON interface.
>>>
>>> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
>>> Cc: Doug Anderson <dianders@chromium.org>
>>> ---
>>> Changes since v1:
>>> 1. Arranged the ADC node alphabetical
>>> 2. Added "status = "okay"" to the ADC node
>>>
>>> This patch needs
>>> 1. MAX77802 PMIC device tree nodes (for ldo9)
>>>    https://www.mail-archive.com/devicetree@vger.kernel.org/msg31430.html
>>> 2. Uses the DT documentation for NTC thermistors updated with vendor-prefix
>>>
>>> This patch set is tested
>>> 1. On Peach PIT board via sysfs entry exposed by hwmon
>>> localhost ~ # cat /sys/class/hwmon/hwmon*/device/temp1_input
>>> 37436
>>> 36449
>>> 38560
>>> 38059
>>>
>>> 2. Backward compatibility is tested by replacing "murata" with "ntc"
>>>    in the dts nodes and running the above test.
>>>
>>>  arch/arm/boot/dts/exynos5420-peach-pit.dts |   34 ++++++++++++++++++++++++++++
>>>  1 file changed, 34 insertions(+)
>>
>> Now that Javier has spun his patch, perhaps you can fold the "pi"
>> version in here too?
>
> Sure, thanks for the information.
>
> Snow also needs the adc nodes.
> Will try to implement an adc fragment for PIT, PI and Snow.

I've a plan to create a common file (cros-exynos-peach.dts) for
exynos5420-peach-pit.dts and exynos5800-peach-pi.dts
And add the ADC nodes directly into that.

In favor of the above, can you abandon the following patches

1. [PATCH 3/4 v2] ARM: DTS: use new compatible string for thermistors in trats2
    http://www.spinics.net/lists/linux-samsung-soc/msg33037.html

2. [PATCH 4/4 v2] ARM: DTS: Add NTC thermistor nodes to Exynos5420
based Peach_PIT
http://www.spinics.net/lists/linux-samsung-soc/msg33038.html

>
>>
>> Reviewed-by: Doug Anderson <dianders@chromium.org>
>> Tested-by: Doug Anderson <dianders@chromium.org>
>
>
>
> --
> Shine bright,
> (: Nav :)



-- 
Thanks,
(: Nav :)

^ permalink raw reply	[flat|nested] 50+ messages in thread

* [PATCH 4/4 v2] ARM: DTS: Add NTC thermistor nodes to Exynos5420 based Peach_PIT
@ 2014-06-26 11:46               ` Naveen Krishna Ch
  0 siblings, 0 replies; 50+ messages in thread
From: Naveen Krishna Ch @ 2014-06-26 11:46 UTC (permalink / raw)
  To: linux-arm-kernel

Hello Kukjin,

On 26 June 2014 11:46, Naveen Krishna Ch <naveenkrishna.ch@gmail.com> wrote:
> Doug,
>
> On 26 June 2014 02:10, Doug Anderson <dianders@chromium.org> wrote:
>> Naveen,
>>
>> On Tue, Jun 24, 2014 at 11:29 PM, Naveen Krishna Chatradhi
>> <ch.naveen@samsung.com> wrote:
>>> Exynos5420 based Peach PIT board has 4 NTC thermistors to measure
>>> temperatures at various points on the board.
>>>
>>> IIO based ADC becomes the parent and NTC thermistors are the childs,
>>> via the HWMON interface.
>>>
>>> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
>>> Cc: Doug Anderson <dianders@chromium.org>
>>> ---
>>> Changes since v1:
>>> 1. Arranged the ADC node alphabetical
>>> 2. Added "status = "okay"" to the ADC node
>>>
>>> This patch needs
>>> 1. MAX77802 PMIC device tree nodes (for ldo9)
>>>    https://www.mail-archive.com/devicetree at vger.kernel.org/msg31430.html
>>> 2. Uses the DT documentation for NTC thermistors updated with vendor-prefix
>>>
>>> This patch set is tested
>>> 1. On Peach PIT board via sysfs entry exposed by hwmon
>>> localhost ~ # cat /sys/class/hwmon/hwmon*/device/temp1_input
>>> 37436
>>> 36449
>>> 38560
>>> 38059
>>>
>>> 2. Backward compatibility is tested by replacing "murata" with "ntc"
>>>    in the dts nodes and running the above test.
>>>
>>>  arch/arm/boot/dts/exynos5420-peach-pit.dts |   34 ++++++++++++++++++++++++++++
>>>  1 file changed, 34 insertions(+)
>>
>> Now that Javier has spun his patch, perhaps you can fold the "pi"
>> version in here too?
>
> Sure, thanks for the information.
>
> Snow also needs the adc nodes.
> Will try to implement an adc fragment for PIT, PI and Snow.

I've a plan to create a common file (cros-exynos-peach.dts) for
exynos5420-peach-pit.dts and exynos5800-peach-pi.dts
And add the ADC nodes directly into that.

In favor of the above, can you abandon the following patches

1. [PATCH 3/4 v2] ARM: DTS: use new compatible string for thermistors in trats2
    http://www.spinics.net/lists/linux-samsung-soc/msg33037.html

2. [PATCH 4/4 v2] ARM: DTS: Add NTC thermistor nodes to Exynos5420
based Peach_PIT
http://www.spinics.net/lists/linux-samsung-soc/msg33038.html

>
>>
>> Reviewed-by: Doug Anderson <dianders@chromium.org>
>> Tested-by: Doug Anderson <dianders@chromium.org>
>
>
>
> --
> Shine bright,
> (: Nav :)



-- 
Thanks,
(: Nav :)

^ permalink raw reply	[flat|nested] 50+ messages in thread

* Re: [PATCH 0/4 v2] hwmon: ntc_thermistor: prepose vendor prefix change
  2014-06-25 14:12     ` Guenter Roeck
  (?)
@ 2014-07-17  4:21         ` Naveen Krishna Ch
  -1 siblings, 0 replies; 50+ messages in thread
From: Naveen Krishna Ch @ 2014-07-17  4:21 UTC (permalink / raw)
  To: Guenter Roeck
  Cc: Kukjin Kim, Naveen Krishna Chatradhi,
	linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
	linux-iio-u79uwXL29TY76Z2rM5mHXA, jdelvare-l3A5Bk7waGM,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA, lars-Qo5EllUWu/uELgA04lAiVw

Hello Kukjin,

On 25 June 2014 19:42, Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org> wrote:
> On 06/25/2014 03:57 AM, Kukjin Kim wrote:
>>
>> Naveen Krishna Chatradhi wrote:
>>>
>>>
>> + Jean Delvare, Guenter Roeck
>>
>> I'm adding maintainers for drivers/hwmon/ntc* but I'm not sure.
>>
>> Hi,
>>
>> This series looks good to me. I will take 3/4 and 4/4 for exynos DT
>> changes once
>> hwmon/ntc maintainer pick the others.
>>
>
> I applied both patches. Currently going through my test cycle.
> I'll send them to Linus Thursday or Friday.

I see the 1/4 and 2/4 merged in togreg branch of
http://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git

Can you pull the 3/4 and 4/4 patches.

>
> Guenter
>



-- 
Regards,
(: Naveen :)

^ permalink raw reply	[flat|nested] 50+ messages in thread

* Re: [PATCH 0/4 v2] hwmon: ntc_thermistor: prepose vendor prefix change
@ 2014-07-17  4:21         ` Naveen Krishna Ch
  0 siblings, 0 replies; 50+ messages in thread
From: Naveen Krishna Ch @ 2014-07-17  4:21 UTC (permalink / raw)
  To: Guenter Roeck
  Cc: Kukjin Kim, Naveen Krishna Chatradhi, linux-samsung-soc,
	linux-iio, jdelvare, linux-arm-kernel, devicetree, lars

Hello Kukjin,

On 25 June 2014 19:42, Guenter Roeck <linux@roeck-us.net> wrote:
> On 06/25/2014 03:57 AM, Kukjin Kim wrote:
>>
>> Naveen Krishna Chatradhi wrote:
>>>
>>>
>> + Jean Delvare, Guenter Roeck
>>
>> I'm adding maintainers for drivers/hwmon/ntc* but I'm not sure.
>>
>> Hi,
>>
>> This series looks good to me. I will take 3/4 and 4/4 for exynos DT
>> changes once
>> hwmon/ntc maintainer pick the others.
>>
>
> I applied both patches. Currently going through my test cycle.
> I'll send them to Linus Thursday or Friday.

I see the 1/4 and 2/4 merged in togreg branch of
http://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git

Can you pull the 3/4 and 4/4 patches.

>
> Guenter
>



-- 
Regards,
(: Naveen :)

^ permalink raw reply	[flat|nested] 50+ messages in thread

* [PATCH 0/4 v2] hwmon: ntc_thermistor: prepose vendor prefix change
@ 2014-07-17  4:21         ` Naveen Krishna Ch
  0 siblings, 0 replies; 50+ messages in thread
From: Naveen Krishna Ch @ 2014-07-17  4:21 UTC (permalink / raw)
  To: linux-arm-kernel

Hello Kukjin,

On 25 June 2014 19:42, Guenter Roeck <linux@roeck-us.net> wrote:
> On 06/25/2014 03:57 AM, Kukjin Kim wrote:
>>
>> Naveen Krishna Chatradhi wrote:
>>>
>>>
>> + Jean Delvare, Guenter Roeck
>>
>> I'm adding maintainers for drivers/hwmon/ntc* but I'm not sure.
>>
>> Hi,
>>
>> This series looks good to me. I will take 3/4 and 4/4 for exynos DT
>> changes once
>> hwmon/ntc maintainer pick the others.
>>
>
> I applied both patches. Currently going through my test cycle.
> I'll send them to Linus Thursday or Friday.

I see the 1/4 and 2/4 merged in togreg branch of
http://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git

Can you pull the 3/4 and 4/4 patches.

>
> Guenter
>



-- 
Regards,
(: Naveen :)

^ permalink raw reply	[flat|nested] 50+ messages in thread

* Re: [PATCH 0/4 v2] hwmon: ntc_thermistor: prepose vendor prefix change
  2014-07-17  4:21         ` Naveen Krishna Ch
  (?)
@ 2014-07-17 14:05             ` Javier Martinez Canillas
  -1 siblings, 0 replies; 50+ messages in thread
From: Javier Martinez Canillas @ 2014-07-17 14:05 UTC (permalink / raw)
  To: Naveen Krishna Ch
  Cc: Guenter Roeck, Kukjin Kim, Naveen Krishna Chatradhi,
	linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA, linux-iio,
	jdelvare-l3A5Bk7waGM,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA, Lars-Peter Clausen

Hello Naveen,

On Thu, Jul 17, 2014 at 6:21 AM, Naveen Krishna Ch
<naveenkrishna.ch-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>
> Can you pull the 3/4 and 4/4 patches.
>

Patch 4/4 depends on the max77802 support series [0] since the ADC
uses the max77802 ldo9 regulator as its voltage supply. So that patch
can't be merged before the series land in mainline.

Best regards,
Javier

[0]: https://lkml.org/lkml/2014/7/14/273

^ permalink raw reply	[flat|nested] 50+ messages in thread

* Re: [PATCH 0/4 v2] hwmon: ntc_thermistor: prepose vendor prefix change
@ 2014-07-17 14:05             ` Javier Martinez Canillas
  0 siblings, 0 replies; 50+ messages in thread
From: Javier Martinez Canillas @ 2014-07-17 14:05 UTC (permalink / raw)
  To: Naveen Krishna Ch
  Cc: Guenter Roeck, Kukjin Kim, Naveen Krishna Chatradhi,
	linux-samsung-soc, linux-iio, jdelvare, linux-arm-kernel,
	devicetree, Lars-Peter Clausen

Hello Naveen,

On Thu, Jul 17, 2014 at 6:21 AM, Naveen Krishna Ch
<naveenkrishna.ch@gmail.com> wrote:
>
> Can you pull the 3/4 and 4/4 patches.
>

Patch 4/4 depends on the max77802 support series [0] since the ADC
uses the max77802 ldo9 regulator as its voltage supply. So that patch
can't be merged before the series land in mainline.

Best regards,
Javier

[0]: https://lkml.org/lkml/2014/7/14/273

^ permalink raw reply	[flat|nested] 50+ messages in thread

* [PATCH 0/4 v2] hwmon: ntc_thermistor: prepose vendor prefix change
@ 2014-07-17 14:05             ` Javier Martinez Canillas
  0 siblings, 0 replies; 50+ messages in thread
From: Javier Martinez Canillas @ 2014-07-17 14:05 UTC (permalink / raw)
  To: linux-arm-kernel

Hello Naveen,

On Thu, Jul 17, 2014 at 6:21 AM, Naveen Krishna Ch
<naveenkrishna.ch@gmail.com> wrote:
>
> Can you pull the 3/4 and 4/4 patches.
>

Patch 4/4 depends on the max77802 support series [0] since the ADC
uses the max77802 ldo9 regulator as its voltage supply. So that patch
can't be merged before the series land in mainline.

Best regards,
Javier

[0]: https://lkml.org/lkml/2014/7/14/273

^ permalink raw reply	[flat|nested] 50+ messages in thread

end of thread, other threads:[~2014-07-17 14:05 UTC | newest]

Thread overview: 50+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-25  6:29 [PATCH 0/4 v2] hwmon: ntc_thermistor: prepose vendor prefix change Naveen Krishna Chatradhi
2014-06-25  6:29 ` Naveen Krishna Chatradhi
     [not found] ` <1403677773-21141-1-git-send-email-ch.naveen-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-06-25  6:29   ` [PATCH 1/4 v2] devicetree: bindings: Document murata vendor prefix Naveen Krishna Chatradhi
2014-06-25  6:29     ` Naveen Krishna Chatradhi
2014-06-25  6:29     ` Naveen Krishna Chatradhi
     [not found]     ` <1403677773-21141-2-git-send-email-ch.naveen-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-06-25 14:10       ` Guenter Roeck
2014-06-25 14:10         ` Guenter Roeck
2014-06-25 14:10         ` Guenter Roeck
2014-06-25  6:29   ` [PATCH 3/4 v2] ARM: DTS: use new compatible string for thermistors in trats2 Naveen Krishna Chatradhi
2014-06-25  6:29     ` Naveen Krishna Chatradhi
2014-06-25  6:29     ` Naveen Krishna Chatradhi
     [not found]     ` <1403677773-21141-4-git-send-email-ch.naveen-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-06-25  6:35       ` Chanwoo Choi
2014-06-25  6:35         ` Chanwoo Choi
2014-06-25  6:35         ` Chanwoo Choi
2014-06-25  6:29 ` [PATCH 2/4 v2] hwmon: ntc_thermistor: Use the manufacturer name properly Naveen Krishna Chatradhi
2014-06-25  6:29   ` Naveen Krishna Chatradhi
     [not found]   ` <1403677773-21141-3-git-send-email-ch.naveen-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-06-25 10:36     ` Javier Martinez Canillas
2014-06-25 10:36       ` Javier Martinez Canillas
2014-06-25 10:36       ` Javier Martinez Canillas
2014-06-25 10:42       ` Naveen Krishna Ch
2014-06-25 10:42         ` Naveen Krishna Ch
2014-06-25 14:10   ` Guenter Roeck
2014-06-25 14:10     ` Guenter Roeck
2014-06-25  6:29 ` [PATCH 4/4 v2] ARM: DTS: Add NTC thermistor nodes to Exynos5420 based Peach_PIT Naveen Krishna Chatradhi
2014-06-25  6:29   ` Naveen Krishna Chatradhi
     [not found]   ` <1403677773-21141-5-git-send-email-ch.naveen-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-06-25 10:38     ` Javier Martinez Canillas
2014-06-25 10:38       ` Javier Martinez Canillas
2014-06-25 10:38       ` Javier Martinez Canillas
2014-06-25 20:40     ` Doug Anderson
2014-06-25 20:40       ` Doug Anderson
2014-06-25 20:40       ` Doug Anderson
     [not found]       ` <CAD=FV=WeuFhGK=JNEm20CT73J=c1Zc_dZGQT6bKeob895M+kQA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-06-26  6:16         ` Naveen Krishna Ch
2014-06-26  6:16           ` Naveen Krishna Ch
2014-06-26  6:16           ` Naveen Krishna Ch
     [not found]           ` <CAHfPSqBL9hH+r8Fy4GbbY1E_sJVCP-gpDHATDJgRHP4wKrFaiA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-06-26  8:45             ` Naveen Krishna Ch
2014-06-26  8:45               ` Naveen Krishna Ch
2014-06-26  8:45               ` Naveen Krishna Ch
2014-06-26 11:46             ` Naveen Krishna Ch
2014-06-26 11:46               ` Naveen Krishna Ch
2014-06-26 11:46               ` Naveen Krishna Ch
2014-06-25 10:57 ` [PATCH 0/4 v2] hwmon: ntc_thermistor: prepose vendor prefix change Kukjin Kim
2014-06-25 10:57   ` Kukjin Kim
2014-06-25 14:12   ` Guenter Roeck
2014-06-25 14:12     ` Guenter Roeck
     [not found]     ` <53AAD8C8.3080506-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2014-07-17  4:21       ` Naveen Krishna Ch
2014-07-17  4:21         ` Naveen Krishna Ch
2014-07-17  4:21         ` Naveen Krishna Ch
     [not found]         ` <CAHfPSqCGf2d6xXDGr974+4ipNsYx3-fOLT+u2OGN=c9FVPEkZg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-07-17 14:05           ` Javier Martinez Canillas
2014-07-17 14:05             ` Javier Martinez Canillas
2014-07-17 14:05             ` Javier Martinez Canillas

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.