* [PATCH] sound: oss: mpu401.c: Cleaning up variable is set more than once
@ 2014-06-25 12:18 Rickard Strandqvist
2014-06-25 12:32 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Rickard Strandqvist @ 2014-06-25 12:18 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai
Cc: Rickard Strandqvist, Julia Lawall, alsa-devel, linux-kernel
A struct member variable is set to the same value more than once
This was found using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
sound/oss/mpu401.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/oss/mpu401.c b/sound/oss/mpu401.c
index 3bbc3ec..31d7f72 100644
--- a/sound/oss/mpu401.c
+++ b/sound/oss/mpu401.c
@@ -972,7 +972,6 @@ int attach_mpu401(struct address_info *hw_config, struct module *owner)
devc->m_busy = 0;
devc->m_state = ST_INIT;
devc->shared_irq = hw_config->always_detect;
- devc->irq = hw_config->irq;
spin_lock_init(&devc->lock);
if (devc->irq < 0)
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sound: oss: mpu401.c: Cleaning up variable is set more than once
2014-06-25 12:18 [PATCH] sound: oss: mpu401.c: Cleaning up variable is set more than once Rickard Strandqvist
@ 2014-06-25 12:32 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2014-06-25 12:32 UTC (permalink / raw)
To: Rickard Strandqvist
Cc: Jaroslav Kysela, Julia Lawall, alsa-devel, linux-kernel
At Wed, 25 Jun 2014 14:18:24 +0200,
Rickard Strandqvist wrote:
>
> A struct member variable is set to the same value more than once
>
> This was found using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Applied, thanks.
Takashi
> ---
> sound/oss/mpu401.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/sound/oss/mpu401.c b/sound/oss/mpu401.c
> index 3bbc3ec..31d7f72 100644
> --- a/sound/oss/mpu401.c
> +++ b/sound/oss/mpu401.c
> @@ -972,7 +972,6 @@ int attach_mpu401(struct address_info *hw_config, struct module *owner)
> devc->m_busy = 0;
> devc->m_state = ST_INIT;
> devc->shared_irq = hw_config->always_detect;
> - devc->irq = hw_config->irq;
> spin_lock_init(&devc->lock);
>
> if (devc->irq < 0)
> --
> 1.7.10.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-25 12:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-25 12:18 [PATCH] sound: oss: mpu401.c: Cleaning up variable is set more than once Rickard Strandqvist
2014-06-25 12:32 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.