* [PATCH] ASoC: davinci-mcasp: Fix S24_LE and U24_LE support
@ 2014-06-26 5:09 Peter Ujfalusi
2014-06-26 7:29 ` Daniel Mack
2014-06-30 14:53 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Peter Ujfalusi @ 2014-06-26 5:09 UTC (permalink / raw)
To: Mark Brown, Liam Girdwood; +Cc: alsa-devel, zonque
In case of S24_LE/U24_LE modes we expect 24bits on the bus while the samples
are stored and transferred in memory on 32bits (lower 3 bytes of the 4
bytes).
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
sound/soc/davinci/davinci-mcasp.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c
index 9afb14629a17..6d5de26eae2f 100644
--- a/sound/soc/davinci/davinci-mcasp.c
+++ b/sound/soc/davinci/davinci-mcasp.c
@@ -720,6 +720,10 @@ static int davinci_mcasp_hw_params(struct snd_pcm_substream *substream,
case SNDRV_PCM_FORMAT_U24_LE:
case SNDRV_PCM_FORMAT_S24_LE:
+ dma_params->data_type = 4;
+ word_length = 24;
+ break;
+
case SNDRV_PCM_FORMAT_U32_LE:
case SNDRV_PCM_FORMAT_S32_LE:
dma_params->data_type = 4;
--
2.0.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: davinci-mcasp: Fix S24_LE and U24_LE support
2014-06-26 5:09 [PATCH] ASoC: davinci-mcasp: Fix S24_LE and U24_LE support Peter Ujfalusi
@ 2014-06-26 7:29 ` Daniel Mack
2014-06-30 14:53 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Mack @ 2014-06-26 7:29 UTC (permalink / raw)
To: Peter Ujfalusi, Mark Brown, Liam Girdwood; +Cc: alsa-devel, zonque
On 06/26/2014 07:09 AM, Peter Ujfalusi wrote:
> In case of S24_LE/U24_LE modes we expect 24bits on the bus while the samples
> are stored and transferred in memory on 32bits (lower 3 bytes of the 4
> bytes).
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Tested-by: Daniel Mack <daniel@zonque.org>
Thanks!
Daniel
> ---
> sound/soc/davinci/davinci-mcasp.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c
> index 9afb14629a17..6d5de26eae2f 100644
> --- a/sound/soc/davinci/davinci-mcasp.c
> +++ b/sound/soc/davinci/davinci-mcasp.c
> @@ -720,6 +720,10 @@ static int davinci_mcasp_hw_params(struct snd_pcm_substream *substream,
>
> case SNDRV_PCM_FORMAT_U24_LE:
> case SNDRV_PCM_FORMAT_S24_LE:
> + dma_params->data_type = 4;
> + word_length = 24;
> + break;
> +
> case SNDRV_PCM_FORMAT_U32_LE:
> case SNDRV_PCM_FORMAT_S32_LE:
> dma_params->data_type = 4;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: davinci-mcasp: Fix S24_LE and U24_LE support
2014-06-26 5:09 [PATCH] ASoC: davinci-mcasp: Fix S24_LE and U24_LE support Peter Ujfalusi
2014-06-26 7:29 ` Daniel Mack
@ 2014-06-30 14:53 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2014-06-30 14:53 UTC (permalink / raw)
To: Peter Ujfalusi; +Cc: alsa-devel, Liam Girdwood, zonque
[-- Attachment #1.1: Type: text/plain, Size: 244 bytes --]
On Thu, Jun 26, 2014 at 08:09:24AM +0300, Peter Ujfalusi wrote:
> In case of S24_LE/U24_LE modes we expect 24bits on the bus while the samples
> are stored and transferred in memory on 32bits (lower 3 bytes of the 4
> bytes).
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-06-30 14:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-26 5:09 [PATCH] ASoC: davinci-mcasp: Fix S24_LE and U24_LE support Peter Ujfalusi
2014-06-26 7:29 ` Daniel Mack
2014-06-30 14:53 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.