From: Ian Campbell <Ian.Campbell@citrix.com>
To: Thomas Leonard <talex5@gmail.com>
Cc: David Scott <Dave.Scott@eu.citrix.com>,
Anil Madhavapeddy <anil@recoil.org>,
Julien Grall <julien.grall@linaro.org>,
Samuel Thibault <samuel.thibault@ens-lyon.org>,
xen-devel@lists.xenproject.org,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH ARM v5 17/20] mini-os: headers for ARM
Date: Fri, 27 Jun 2014 14:11:07 +0100 [thread overview]
Message-ID: <1403874667.3169.31.camel@kazak.uk.xensource.com> (raw)
In-Reply-To: <CAG4opy-6vXRPA=JcKRA1gm8-J8_BzUREkPj6D=XsA5jEKLasyA@mail.gmail.com>
On Fri, 2014-06-27 at 14:02 +0100, Thomas Leonard wrote:
> >> +#define BUG() while(1){}
> >
> > It looks odd to use onely while (1). Shouldn't you call do_exit as x86 does?
>
> Note that patch #20 changes this to dump the registers and stack.
>
> [ also, exiting on BUG is annoying because you may lose the console
> output if the VM dies before xl attaches to it. ]
That's what on_crash=preserve and xenconsoled's logging capabilities are
for. I expect SCHEDOP_crash is probably better than exiting though.
Ian.
next prev parent reply other threads:[~2014-06-27 13:11 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-26 11:28 [PATCH ARM v5 00/20] mini-os: initial ARM support Thomas Leonard
2014-06-26 11:28 ` [PATCH ARM v5 01/20] mini-os: build fixes Thomas Leonard
2014-06-26 11:28 ` [PATCH ARM v5 02/20] mini-os: fixed shutdown thread Thomas Leonard
2014-06-26 11:28 ` [PATCH ARM v5 03/20] mini-os: fixed format string error in unbind_evtchn Thomas Leonard
2014-06-26 11:28 ` [PATCH ARM v5 04/20] mini-os: use unbind_evtchn in unbind_all_ports Thomas Leonard
2014-06-26 11:28 ` [PATCH ARM v5 05/20] mini-os: made off_t type signed Thomas Leonard
2014-06-26 11:28 ` [PATCH ARM v5 06/20] mini-os: switched initial C entry point to arch_init Thomas Leonard
2014-06-26 11:28 ` [PATCH ARM v5 07/20] mini-os: whitespace Thomas Leonard
2014-06-26 11:35 ` Samuel Thibault
2014-06-26 11:28 ` [PATCH ARM v5 08/20] mini-os: added arch_init_gnttab Thomas Leonard
2014-06-26 11:36 ` Samuel Thibault
2014-06-26 11:28 ` [PATCH ARM v5 09/20] mini-os: don't require XEN_HAVE_PV_UPCALL_MASK Thomas Leonard
2014-06-26 11:37 ` Samuel Thibault
2014-06-26 11:28 ` [PATCH ARM v5 10/20] mini-os: add missing casts to MM printk Thomas Leonard
2014-06-26 11:37 ` Samuel Thibault
2014-06-26 11:28 ` [PATCH ARM v5 11/20] mini-os: added HYPERVISOR_xsm_op Thomas Leonard
2014-06-26 11:38 ` Samuel Thibault
2014-06-27 13:13 ` Ian Campbell
2014-06-27 13:56 ` Thomas Leonard
2014-06-27 15:43 ` Thomas Leonard
2014-06-27 15:50 ` Samuel Thibault
2014-06-27 16:47 ` Ian Campbell
2014-06-26 11:28 ` [PATCH ARM v5 12/20] mini-os: added arch_unbind_ports Thomas Leonard
2014-06-26 11:38 ` Samuel Thibault
2014-06-26 11:28 ` [PATCH ARM v5 13/20] mini-os: moved __pte to x86 Thomas Leonard
2014-06-26 11:39 ` Samuel Thibault
2014-06-26 11:28 ` [PATCH ARM v5 14/20] mini-os: moved unlikely/likely macros to new compiler.h Thomas Leonard
2014-06-26 11:40 ` Samuel Thibault
2014-06-26 11:28 ` [PATCH ARM v5 15/20] mini-os: enable test_xenbus again Thomas Leonard
2014-06-26 11:40 ` Samuel Thibault
2014-06-27 11:05 ` Ian Campbell
2014-06-27 12:48 ` Thomas Leonard
2014-06-27 12:54 ` Ian Campbell
2014-06-26 11:28 ` [PATCH ARM v5 16/20] mini-os: use irqs_disabled() helper in schedule Thomas Leonard
2014-06-26 11:42 ` Samuel Thibault
2014-06-26 11:28 ` [PATCH ARM v5 17/20] mini-os: headers for ARM Thomas Leonard
2014-06-26 16:26 ` Julien Grall
2014-06-27 13:02 ` Thomas Leonard
2014-06-27 13:11 ` Ian Campbell [this message]
2014-06-26 11:28 ` [PATCH ARM v5 18/20] mini-os: import libfdt Thomas Leonard
2014-06-28 12:01 ` Julien Grall
2014-06-28 12:27 ` Thomas Leonard
2014-06-28 15:14 ` Julien Grall
2014-06-28 16:35 ` Anil Madhavapeddy
2014-06-28 16:45 ` Julien Grall
2014-06-26 11:28 ` [PATCH ARM v5 19/20] mini-os: initial ARM support Thomas Leonard
2014-06-28 18:31 ` Julien Grall
2014-06-30 19:12 ` Thomas Leonard
2014-06-30 21:08 ` Julien Grall
2014-07-02 8:41 ` Ian Campbell
2014-07-02 8:23 ` Ian Campbell
2014-07-02 9:22 ` karim.allah.ahmed
2014-06-26 11:28 ` [PATCH ARM v5 20/20] mini-os: arm: show registers, stack and exception vector on fault Thomas Leonard
2014-06-27 13:34 ` [PATCH ARM v5 00/20] mini-os: initial ARM support Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403874667.3169.31.camel@kazak.uk.xensource.com \
--to=ian.campbell@citrix.com \
--cc=Dave.Scott@eu.citrix.com \
--cc=anil@recoil.org \
--cc=julien.grall@linaro.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=talex5@gmail.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.