All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] virtio: console: remove unnecessary null test before debugfs_remove_recursive
@ 2014-06-29  8:41 Fabian Frederick
  2014-06-30  6:46   ` Amit Shah
  0 siblings, 1 reply; 5+ messages in thread
From: Fabian Frederick @ 2014-06-29  8:41 UTC (permalink / raw)
  To: linux-kernel; +Cc: Fabian Frederick, Amit Shah, Arnd Bergmann, virtualization

Fix checkpatch warning:
WARNING: debugfs_remove_recursive(NULL) is safe this check is probably not required

Cc: Amit Shah <amit.shah@redhat.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: virtualization@lists.linux-foundation.org
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
 drivers/char/virtio_console.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c
index 60aafb8..b585b47 100644
--- a/drivers/char/virtio_console.c
+++ b/drivers/char/virtio_console.c
@@ -2262,8 +2262,7 @@ static int __init init(void)
 unregister:
 	unregister_virtio_driver(&virtio_console);
 free:
-	if (pdrvdata.debugfs_dir)
-		debugfs_remove_recursive(pdrvdata.debugfs_dir);
+	debugfs_remove_recursive(pdrvdata.debugfs_dir);
 	class_destroy(pdrvdata.class);
 	return err;
 }
@@ -2276,8 +2275,7 @@ static void __exit fini(void)
 	unregister_virtio_driver(&virtio_rproc_serial);
 
 	class_destroy(pdrvdata.class);
-	if (pdrvdata.debugfs_dir)
-		debugfs_remove_recursive(pdrvdata.debugfs_dir);
+	debugfs_remove_recursive(pdrvdata.debugfs_dir);
 }
 module_init(init);
 module_exit(fini);
-- 
1.8.4.5


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] virtio: console: remove unnecessary null test before debugfs_remove_recursive
  2014-06-29  8:41 [PATCH 1/1] virtio: console: remove unnecessary null test before debugfs_remove_recursive Fabian Frederick
@ 2014-06-30  6:46   ` Amit Shah
  0 siblings, 0 replies; 5+ messages in thread
From: Amit Shah @ 2014-06-30  6:46 UTC (permalink / raw)
  To: Fabian Frederick
  Cc: linux-kernel, Arnd Bergmann, virtualization, Rusty Russell

On (Sun) 29 Jun 2014 [10:41:33], Fabian Frederick wrote:
> Fix checkpatch warning:
> WARNING: debugfs_remove_recursive(NULL) is safe this check is probably not required
> 
> Cc: Amit Shah <amit.shah@redhat.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: virtualization@lists.linux-foundation.org
> Signed-off-by: Fabian Frederick <fabf@skynet.be>

Reviewed-by: Amit Shah <amit.shah@redhat.com>

Rusty, can you pick this up please?

Thanks,

		Amit

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] virtio: console: remove unnecessary null test before debugfs_remove_recursive
@ 2014-06-30  6:46   ` Amit Shah
  0 siblings, 0 replies; 5+ messages in thread
From: Amit Shah @ 2014-06-30  6:46 UTC (permalink / raw)
  To: Fabian Frederick; +Cc: linux-kernel, Arnd Bergmann, virtualization

On (Sun) 29 Jun 2014 [10:41:33], Fabian Frederick wrote:
> Fix checkpatch warning:
> WARNING: debugfs_remove_recursive(NULL) is safe this check is probably not required
> 
> Cc: Amit Shah <amit.shah@redhat.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: virtualization@lists.linux-foundation.org
> Signed-off-by: Fabian Frederick <fabf@skynet.be>

Reviewed-by: Amit Shah <amit.shah@redhat.com>

Rusty, can you pick this up please?

Thanks,

		Amit

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] virtio: console: remove unnecessary null test before debugfs_remove_recursive
  2014-06-30  6:46   ` Amit Shah
  (?)
@ 2014-07-09  0:23   ` Rusty Russell
  -1 siblings, 0 replies; 5+ messages in thread
From: Rusty Russell @ 2014-07-09  0:23 UTC (permalink / raw)
  To: Amit Shah, Fabian Frederick; +Cc: linux-kernel, Arnd Bergmann, virtualization

Amit Shah <amit.shah@redhat.com> writes:
> On (Sun) 29 Jun 2014 [10:41:33], Fabian Frederick wrote:
>> Fix checkpatch warning:
>> WARNING: debugfs_remove_recursive(NULL) is safe this check is probably not required
>> 
>> Cc: Amit Shah <amit.shah@redhat.com>
>> Cc: Arnd Bergmann <arnd@arndb.de>
>> Cc: virtualization@lists.linux-foundation.org
>> Signed-off-by: Fabian Frederick <fabf@skynet.be>
>
> Reviewed-by: Amit Shah <amit.shah@redhat.com>
>
> Rusty, can you pick this up please?

Applied.

Thanks,
Rusty.

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [PATCH 1/1] virtio: console: remove unnecessary null test before debugfs_remove_recursive
@ 2014-06-29  8:41 Fabian Frederick
  0 siblings, 0 replies; 5+ messages in thread
From: Fabian Frederick @ 2014-06-29  8:41 UTC (permalink / raw)
  To: linux-kernel; +Cc: Fabian Frederick, Amit Shah, Arnd Bergmann, virtualization

Fix checkpatch warning:
WARNING: debugfs_remove_recursive(NULL) is safe this check is probably not required

Cc: Amit Shah <amit.shah@redhat.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: virtualization@lists.linux-foundation.org
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
 drivers/char/virtio_console.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c
index 60aafb8..b585b47 100644
--- a/drivers/char/virtio_console.c
+++ b/drivers/char/virtio_console.c
@@ -2262,8 +2262,7 @@ static int __init init(void)
 unregister:
 	unregister_virtio_driver(&virtio_console);
 free:
-	if (pdrvdata.debugfs_dir)
-		debugfs_remove_recursive(pdrvdata.debugfs_dir);
+	debugfs_remove_recursive(pdrvdata.debugfs_dir);
 	class_destroy(pdrvdata.class);
 	return err;
 }
@@ -2276,8 +2275,7 @@ static void __exit fini(void)
 	unregister_virtio_driver(&virtio_rproc_serial);
 
 	class_destroy(pdrvdata.class);
-	if (pdrvdata.debugfs_dir)
-		debugfs_remove_recursive(pdrvdata.debugfs_dir);
+	debugfs_remove_recursive(pdrvdata.debugfs_dir);
 }
 module_init(init);
 module_exit(fini);
-- 
1.8.4.5

^ permalink raw reply related	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-07-09  0:35 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-29  8:41 [PATCH 1/1] virtio: console: remove unnecessary null test before debugfs_remove_recursive Fabian Frederick
2014-06-30  6:46 ` Amit Shah
2014-06-30  6:46   ` Amit Shah
2014-07-09  0:23   ` Rusty Russell
  -- strict thread matches above, loose matches on Subject: below --
2014-06-29  8:41 Fabian Frederick

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.