[PATCH] swapon: align --summary fields

[PATCH] swapon: align --summary fields

[Sami Kerola]

This commit makes  partitions and files to have remaining three columns
aligned.  Below print out demonstrates earlier misalignment.

$ swapon -s
Filename                                Type            Size    Used    Priority
/dev/sda2                               partition       4194300 0       3
/home/src/util-linux/newswap            file    496     0       -1

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
---
 sys-utils/swapon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys-utils/swapon.c b/sys-utils/swapon.c
index 8c36b2c..53cd6f9 100644
--- a/sys-utils/swapon.c
+++ b/sys-utils/swapon.c
@@ -209,7 +209,7 @@ static int display_summary(void)
 	printf(_("%s\t\t\t\tType\t\tSize\tUsed\tPriority\n"), _("Filename"));
 
 	while (mnt_table_next_fs(st, itr, &fs) == 0) {
-		printf("%-39s\t%s\t%jd\t%jd\t%d\n",
+		printf("%-39s\t%-8s\t%jd\t%jd\t%d\n",
 			mnt_fs_get_source(fs),
 			mnt_fs_get_swaptype(fs),
 			mnt_fs_get_size(fs),
-- 
2.0.1

Re: [PATCH] swapon: align --summary fields

[Karel Zak]

On Sun, Jun 29, 2014 at 07:12:13PM +0100, Sami Kerola wrote:
> This commit makes  partitions and files to have remaining three columns
> aligned.  Below print out demonstrates earlier misalignment.
> 
> $ swapon -s
> Filename                                Type            Size    Used    Priority
> /dev/sda2                               partition       4194300 0       3
> /home/src/util-linux/newswap            file    496     0       -1
> 
> Signed-off-by: Sami Kerola <kerolasa@iki.fi>
> ---
>  sys-utils/swapon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

 Applied, thanks.

 Maybe we can mark the --summary output format deprecated in favour of
 --show. The old fixed output sucks.

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com