From: Ian Campbell <Ian.Campbell@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Tamas Lengyel <tamas.lengyel@zentific.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Aravindh Puthiyaparambil <aravindp@cisco.com>
Subject: Re: Issues regarding "mem_access: Add helper API to setup ring and enable mem_access"
Date: Mon, 30 Jun 2014 14:09:11 +0100 [thread overview]
Message-ID: <1404133751.14488.56.camel@kazak.uk.xensource.com> (raw)
In-Reply-To: <53B1611D.2080502@citrix.com>
On Mon, 2014-06-30 at 14:07 +0100, Andrew Cooper wrote:
> On 30/06/14 13:44, Ian Campbell wrote:
> > On Mon, 2014-06-30 at 13:42 +0100, Ian Jackson wrote:
> >> Tamas Lengyel writes ("Re: [Xen-devel] Issues regarding "mem_access: Add helper API to setup ring and enable mem_access""):
> >>> > Now with this function being reintroduced, it becomes more complicated
> >>> > to determine which version of the mem_access API does Xen actually
> >>> > provide. A #define indicating mem_access API version would nicely
> >>> > overcome this issue, or naming xc_mem_event_enable something else.
> >>>
> >>> Doesn't configure support checking for functions with a given prototype?
> >>>
> >>> It does but in a very hacky way, essentially trying to compile code where the
> >>> function is being called with different prototypes. We can work around it but a
> >>> clean solution would be preferred at some point.
> >> I agree with your criticism, TBH. Aravindh/Ian, can we rename this
> >> function ?
> > I have no objection to some other name.
> >
> >>> This is now a rather opaque behavior of libxc. As it is not merged
> >>> into master I guess I will just submit a patch for it..
> >> Yes. I think this would be the right approach to addressing both of
> >> these problems. (Please send two patches, one for each.)
> >>
> >> Thanks,
> >> Ian.
>
> There is a bug in Xen. domctl pause and unpause hypercalls are not
> properly refcounted. Patch on its way.
I had convinced myself by reading that they were, but Tamas'
experimental evidence obviously counters that ;-)
Ian.
next prev parent reply other threads:[~2014-06-30 13:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-23 16:31 Issues regarding "mem_access: Add helper API to setup ring and enable mem_access" Tamas Lengyel
2014-06-27 15:20 ` Ian Campbell
2014-06-30 12:06 ` Tamas Lengyel
2014-06-30 12:42 ` Ian Jackson
2014-06-30 12:44 ` Ian Campbell
2014-06-30 13:07 ` Andrew Cooper
2014-06-30 13:09 ` Ian Campbell [this message]
2014-06-30 13:10 ` Andrew Cooper
2014-06-30 14:12 ` Jan Beulich
2014-06-30 14:19 ` Andrew Cooper
2014-06-30 14:49 ` Tamas Lengyel
2014-06-30 22:14 ` Aravindh Puthiyaparambil (aravindp)
2014-06-30 22:31 ` Aravindh Puthiyaparambil (aravindp)
2014-07-02 11:54 ` Tamas Lengyel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404133751.14488.56.camel@kazak.uk.xensource.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=aravindp@cisco.com \
--cc=tamas.lengyel@zentific.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.