All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tamas Lengyel <tamas.lengyel@zentific.com>
To: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
	Aravindh Puthiyaparambil <aravindp@cisco.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Issues regarding "mem_access: Add helper API to setup ring and enable mem_access"
Date: Mon, 23 Jun 2014 18:31:40 +0200	[thread overview]
Message-ID: <CAErYnsjqjYZx=b=ZvrWh3eHGxHF7pWkSv_0HzscZApZMcSuKKA@mail.gmail.com> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 1082 bytes --]

Hi everyone,
commit 6ae2df93c277b4093b3e54c9606387
d1ba6d10fe into xen-staging includes a new function in xenctrl.h,
xc_mem_event_enable. This function name however has been used previously in
xenctrl.h up till at least Xen 4.1.2 for a different purpose. We have been
using autoconf to check which version of the mem_access API is available in
Xen by checking if xc_mem_event_enable is available, signaling that the
mem_access API is Xen 4.1 style, and for xc_mem_access_enable signaling
4.2+ style API. See
https://github.com/bdpayne/libvmi/blob/master/configure.ac#L140 for more
details.

Now with this function being reintroduced, it becomes more complicated to
determine which version of the mem_access API does Xen actually provide. A
#define indicating mem_access API version would nicely overcome this issue,
or  naming xc_mem_event_enable something else.

Furthermore, the new xc_mem_event_enable function unconditionally unpauses
the VM. This may not be a desired behavior in all cases, especially if the
VM was in a paused state when the function was called.

Best,
Tamas

[-- Attachment #1.2: Type: text/html, Size: 1308 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

             reply	other threads:[~2014-06-23 16:31 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-23 16:31 Tamas Lengyel [this message]
2014-06-27 15:20 ` Issues regarding "mem_access: Add helper API to setup ring and enable mem_access" Ian Campbell
2014-06-30 12:06   ` Tamas Lengyel
2014-06-30 12:42     ` Ian Jackson
2014-06-30 12:44       ` Ian Campbell
2014-06-30 13:07         ` Andrew Cooper
2014-06-30 13:09           ` Ian Campbell
2014-06-30 13:10             ` Andrew Cooper
2014-06-30 14:12               ` Jan Beulich
2014-06-30 14:19                 ` Andrew Cooper
2014-06-30 14:49         ` Tamas Lengyel
2014-06-30 22:14           ` Aravindh Puthiyaparambil (aravindp)
2014-06-30 22:31           ` Aravindh Puthiyaparambil (aravindp)
2014-07-02 11:54             ` Tamas Lengyel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAErYnsjqjYZx=b=ZvrWh3eHGxHF7pWkSv_0HzscZApZMcSuKKA@mail.gmail.com' \
    --to=tamas.lengyel@zentific.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=aravindp@cisco.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.