* [PATCH] powerpc/powernv: Check for IRQHAPPENED before sleeping
@ 2014-06-30 6:24 ` Preeti U Murthy
0 siblings, 0 replies; 8+ messages in thread
From: Preeti U Murthy @ 2014-06-30 6:24 UTC (permalink / raw)
To: benh, mikey, mpe; +Cc: shreyas, svaidy, linuxppc-dev, linux-kernel
Commit 8d6f7c5a: "powerpc/powernv: Make it possible to skip the IRQHAPPENED
check in power7_nap()" added code that prevents even cores which enter sleep
on idle, from checking for pending interrupts. Fix this.
Signed-off-by: Preeti U Murthy <preeti@linux.vnet.ibm.com>
---
arch/powerpc/kernel/idle_power7.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/kernel/idle_power7.S b/arch/powerpc/kernel/idle_power7.S
index 2480256..5cf3d36 100644
--- a/arch/powerpc/kernel/idle_power7.S
+++ b/arch/powerpc/kernel/idle_power7.S
@@ -131,7 +131,7 @@ _GLOBAL(power7_nap)
_GLOBAL(power7_sleep)
li r3,1
- li r4,0
+ li r4,1
b power7_powersave_common
/* No return */
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] powerpc/powernv: Check for IRQHAPPENED before sleeping
@ 2014-06-30 6:24 ` Preeti U Murthy
0 siblings, 0 replies; 8+ messages in thread
From: Preeti U Murthy @ 2014-06-30 6:24 UTC (permalink / raw)
To: benh, mikey, mpe; +Cc: shreyas, linuxppc-dev, linux-kernel
Commit 8d6f7c5a: "powerpc/powernv: Make it possible to skip the IRQHAPPENED
check in power7_nap()" added code that prevents even cores which enter sleep
on idle, from checking for pending interrupts. Fix this.
Signed-off-by: Preeti U Murthy <preeti@linux.vnet.ibm.com>
---
arch/powerpc/kernel/idle_power7.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/kernel/idle_power7.S b/arch/powerpc/kernel/idle_power7.S
index 2480256..5cf3d36 100644
--- a/arch/powerpc/kernel/idle_power7.S
+++ b/arch/powerpc/kernel/idle_power7.S
@@ -131,7 +131,7 @@ _GLOBAL(power7_nap)
_GLOBAL(power7_sleep)
li r3,1
- li r4,0
+ li r4,1
b power7_powersave_common
/* No return */
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] powerpc/powernv: Check for IRQHAPPENED before sleeping
2014-06-30 6:24 ` Preeti U Murthy
@ 2014-06-30 14:01 ` Michael Neuling
-1 siblings, 0 replies; 8+ messages in thread
From: Michael Neuling @ 2014-06-30 14:01 UTC (permalink / raw)
To: Preeti U Murthy; +Cc: benh, mpe, shreyas, svaidy, linuxppc-dev, linux-kernel
On Mon, 2014-06-30 at 11:54 +0530, Preeti U Murthy wrote:
> Commit 8d6f7c5a: "powerpc/powernv: Make it possible to skip the IRQHAPPENED
> check in power7_nap()" added code that prevents even cores which enter sleep
> on idle, from checking for pending interrupts. Fix this.
>
> Signed-off-by: Preeti U Murthy <preeti@linux.vnet.ibm.com>
Acked-by: Michael Neuling <mikey@neuling.org>
> ---
>
> arch/powerpc/kernel/idle_power7.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kernel/idle_power7.S b/arch/powerpc/kernel/idle_power7.S
> index 2480256..5cf3d36 100644
> --- a/arch/powerpc/kernel/idle_power7.S
> +++ b/arch/powerpc/kernel/idle_power7.S
> @@ -131,7 +131,7 @@ _GLOBAL(power7_nap)
>
> _GLOBAL(power7_sleep)
> li r3,1
> - li r4,0
> + li r4,1
> b power7_powersave_common
> /* No return */
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] powerpc/powernv: Check for IRQHAPPENED before sleeping
@ 2014-06-30 14:01 ` Michael Neuling
0 siblings, 0 replies; 8+ messages in thread
From: Michael Neuling @ 2014-06-30 14:01 UTC (permalink / raw)
To: Preeti U Murthy; +Cc: linux-kernel, shreyas, linuxppc-dev
On Mon, 2014-06-30 at 11:54 +0530, Preeti U Murthy wrote:
> Commit 8d6f7c5a: "powerpc/powernv: Make it possible to skip the IRQHAPPEN=
ED
> check in power7_nap()" added code that prevents even cores which enter sl=
eep
> on idle, from checking for pending interrupts. Fix this.
>=20
> Signed-off-by: Preeti U Murthy <preeti@linux.vnet.ibm.com>
Acked-by: Michael Neuling <mikey@neuling.org>
> ---
>=20
> arch/powerpc/kernel/idle_power7.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/arch/powerpc/kernel/idle_power7.S b/arch/powerpc/kernel/idle=
_power7.S
> index 2480256..5cf3d36 100644
> --- a/arch/powerpc/kernel/idle_power7.S
> +++ b/arch/powerpc/kernel/idle_power7.S
> @@ -131,7 +131,7 @@ _GLOBAL(power7_nap)
> =20
> _GLOBAL(power7_sleep)
> li r3,1
> - li r4,0
> + li r4,1
> b power7_powersave_common
> /* No return */
> =20
>=20
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] powerpc/powernv: Check for IRQHAPPENED before sleeping
2014-06-30 6:24 ` Preeti U Murthy
@ 2014-07-01 0:52 ` Michael Ellerman
-1 siblings, 0 replies; 8+ messages in thread
From: Michael Ellerman @ 2014-07-01 0:52 UTC (permalink / raw)
To: Preeti U Murthy; +Cc: benh, mikey, shreyas, svaidy, linuxppc-dev, linux-kernel
On Mon, 2014-06-30 at 11:54 +0530, Preeti U Murthy wrote:
> Commit 8d6f7c5a: "powerpc/powernv: Make it possible to skip the IRQHAPPENED
> check in power7_nap()" added code that prevents even cores which enter sleep
> on idle, from checking for pending interrupts. Fix this.
To be clear, it is a bug in the original commit. Mikey and I pair programmed
that code, and he was *definitely* typing at that point ;)
Can you please include in the changelog what the symptom of the bug is, and
have you seen it in practice?
The bad commit went into 3.16-rc1, so we don't need to backport this to any
stable release.
cheers
> diff --git a/arch/powerpc/kernel/idle_power7.S b/arch/powerpc/kernel/idle_power7.S
> index 2480256..5cf3d36 100644
> --- a/arch/powerpc/kernel/idle_power7.S
> +++ b/arch/powerpc/kernel/idle_power7.S
> @@ -131,7 +131,7 @@ _GLOBAL(power7_nap)
>
> _GLOBAL(power7_sleep)
> li r3,1
> - li r4,0
> + li r4,1
> b power7_powersave_common
> /* No return */
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] powerpc/powernv: Check for IRQHAPPENED before sleeping
@ 2014-07-01 0:52 ` Michael Ellerman
0 siblings, 0 replies; 8+ messages in thread
From: Michael Ellerman @ 2014-07-01 0:52 UTC (permalink / raw)
To: Preeti U Murthy; +Cc: mikey, linux-kernel, shreyas, linuxppc-dev
On Mon, 2014-06-30 at 11:54 +0530, Preeti U Murthy wrote:
> Commit 8d6f7c5a: "powerpc/powernv: Make it possible to skip the IRQHAPPENED
> check in power7_nap()" added code that prevents even cores which enter sleep
> on idle, from checking for pending interrupts. Fix this.
To be clear, it is a bug in the original commit. Mikey and I pair programmed
that code, and he was *definitely* typing at that point ;)
Can you please include in the changelog what the symptom of the bug is, and
have you seen it in practice?
The bad commit went into 3.16-rc1, so we don't need to backport this to any
stable release.
cheers
> diff --git a/arch/powerpc/kernel/idle_power7.S b/arch/powerpc/kernel/idle_power7.S
> index 2480256..5cf3d36 100644
> --- a/arch/powerpc/kernel/idle_power7.S
> +++ b/arch/powerpc/kernel/idle_power7.S
> @@ -131,7 +131,7 @@ _GLOBAL(power7_nap)
>
> _GLOBAL(power7_sleep)
> li r3,1
> - li r4,0
> + li r4,1
> b power7_powersave_common
> /* No return */
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] powerpc/powernv: Check for IRQHAPPENED before sleeping
2014-07-01 0:52 ` Michael Ellerman
@ 2014-07-01 3:15 ` Michael Neuling
-1 siblings, 0 replies; 8+ messages in thread
From: Michael Neuling @ 2014-07-01 3:15 UTC (permalink / raw)
To: Michael Ellerman
Cc: Preeti U Murthy, benh, shreyas, svaidy, linuxppc-dev, linux-kernel
On Tue, 2014-07-01 at 10:52 +1000, Michael Ellerman wrote:
> On Mon, 2014-06-30 at 11:54 +0530, Preeti U Murthy wrote:
> > Commit 8d6f7c5a: "powerpc/powernv: Make it possible to skip the IRQHAPPENED
> > check in power7_nap()" added code that prevents even cores which enter sleep
> > on idle, from checking for pending interrupts. Fix this.
>
> To be clear, it is a bug in the original commit. Mikey and I pair programmed
> that code, and he was *definitely* typing at that point ;)
It's always nice to know that in battle a comrade will throw himself on
a grenade to save you. :-P
Actually, I'm pretty sure this happened when you were away (probably on
a beach somewhere), I was forward porting the patch set, hit a conflict
and fucked it up.
Mikey
>
> Can you please include in the changelog what the symptom of the bug is, and
> have you seen it in practice?
>
> The bad commit went into 3.16-rc1, so we don't need to backport this to any
> stable release.
>
> cheers
>
> > diff --git a/arch/powerpc/kernel/idle_power7.S b/arch/powerpc/kernel/idle_power7.S
> > index 2480256..5cf3d36 100644
> > --- a/arch/powerpc/kernel/idle_power7.S
> > +++ b/arch/powerpc/kernel/idle_power7.S
> > @@ -131,7 +131,7 @@ _GLOBAL(power7_nap)
> >
> > _GLOBAL(power7_sleep)
> > li r3,1
> > - li r4,0
> > + li r4,1
> > b power7_powersave_common
> > /* No return */
> >
> >
>
>
>
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] powerpc/powernv: Check for IRQHAPPENED before sleeping
@ 2014-07-01 3:15 ` Michael Neuling
0 siblings, 0 replies; 8+ messages in thread
From: Michael Neuling @ 2014-07-01 3:15 UTC (permalink / raw)
To: Michael Ellerman; +Cc: linux-kernel, shreyas, Preeti U Murthy, linuxppc-dev
On Tue, 2014-07-01 at 10:52 +1000, Michael Ellerman wrote:
> On Mon, 2014-06-30 at 11:54 +0530, Preeti U Murthy wrote:
> > Commit 8d6f7c5a: "powerpc/powernv: Make it possible to skip the IRQHAPP=
ENED
> > check in power7_nap()" added code that prevents even cores which enter =
sleep
> > on idle, from checking for pending interrupts. Fix this.
>=20
> To be clear, it is a bug in the original commit. Mikey and I pair program=
med
> that code, and he was *definitely* typing at that point ;)
It's always nice to know that in battle a comrade will throw himself on
a grenade to save you. :-P
Actually, I'm pretty sure this happened when you were away (probably on
a beach somewhere), I was forward porting the patch set, hit a conflict
and fucked it up. =20
Mikey
>=20
> Can you please include in the changelog what the symptom of the bug is, a=
nd
> have you seen it in practice?
>=20
> The bad commit went into 3.16-rc1, so we don't need to backport this to a=
ny
> stable release.
>=20
> cheers
>=20
> > diff --git a/arch/powerpc/kernel/idle_power7.S b/arch/powerpc/kernel/id=
le_power7.S
> > index 2480256..5cf3d36 100644
> > --- a/arch/powerpc/kernel/idle_power7.S
> > +++ b/arch/powerpc/kernel/idle_power7.S
> > @@ -131,7 +131,7 @@ _GLOBAL(power7_nap)
> > =20
> > _GLOBAL(power7_sleep)
> > li r3,1
> > - li r4,0
> > + li r4,1
> > b power7_powersave_common
> > /* No return */
> > =20
> >=20
>=20
>=20
>=20
>=20
>=20
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-07-01 3:16 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-30 6:24 [PATCH] powerpc/powernv: Check for IRQHAPPENED before sleeping Preeti U Murthy
2014-06-30 6:24 ` Preeti U Murthy
2014-06-30 14:01 ` Michael Neuling
2014-06-30 14:01 ` Michael Neuling
2014-07-01 0:52 ` Michael Ellerman
2014-07-01 0:52 ` Michael Ellerman
2014-07-01 3:15 ` Michael Neuling
2014-07-01 3:15 ` Michael Neuling
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.