From: Alexandre Courbot <acourbot@nvidia.com> To: Linus Walleij <linus.walleij@linaro.org> Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Alexandre Courbot <acourbot@nvidia.com> Subject: [RFC 0/3] gpio: move interfaces into their own files Date: Tue, 1 Jul 2014 14:45:13 +0900 [thread overview] Message-ID: <1404193516-4384-1-git-send-email-acourbot@nvidia.com> (raw) Hi Linus, I was thinking of doing this since a while already but the recent discussion on shared GPIOs made me think I should push this to you and see what you think. Right now we have 3 different interfaces for GPIO: - The core gpiod interface - The legacy integer interface, which mostly relies on gpiod - The sysfs interface, which relies on gpiod but should probably rely on the integer interface instead This series separates the code for the interfaces into their own source file and shares what needs to be through the private gpiolib.h header. Label support is made mandatory in order to reduce the amount of things added into gpiolib.h. Separating the code should make the various interfaces easier to grasp, and will make it easier to implement interface-specific features. It also points out some direct usages of descriptors/gpiolib core functions that should be gotten rid of in order to make these real "consumers" of the gpiod interface. This series has been tested and I'm fine with it being merged now if you agree with the idea. It would probably be preferable from a cosmetic point of view to first turn fix the extra consumers and then separate them so less things end up being exported in gpiolib.h, but moving things first has the advantage of clearly highlighting what needs to be done and spares us some rebasing hassle. Alexandre Courbot (3): gpio: always compile label support gpio: move sysfs support to its own file gpio: move integer GPIO support to its own file drivers/gpio/Makefile | 2 + drivers/gpio/gpiolib-legacy.c | 112 +++++ drivers/gpio/gpiolib-sysfs.c | 829 ++++++++++++++++++++++++++++++++ drivers/gpio/gpiolib.c | 1043 +---------------------------------------- drivers/gpio/gpiolib.h | 91 ++++ 5 files changed, 1040 insertions(+), 1037 deletions(-) create mode 100644 drivers/gpio/gpiolib-legacy.c create mode 100644 drivers/gpio/gpiolib-sysfs.c -- 2.0.0
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Courbot <acourbot@nvidia.com> To: Linus Walleij <linus.walleij@linaro.org> Cc: <linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>, Alexandre Courbot <acourbot@nvidia.com> Subject: [RFC 0/3] gpio: move interfaces into their own files Date: Tue, 1 Jul 2014 14:45:13 +0900 [thread overview] Message-ID: <1404193516-4384-1-git-send-email-acourbot@nvidia.com> (raw) Hi Linus, I was thinking of doing this since a while already but the recent discussion on shared GPIOs made me think I should push this to you and see what you think. Right now we have 3 different interfaces for GPIO: - The core gpiod interface - The legacy integer interface, which mostly relies on gpiod - The sysfs interface, which relies on gpiod but should probably rely on the integer interface instead This series separates the code for the interfaces into their own source file and shares what needs to be through the private gpiolib.h header. Label support is made mandatory in order to reduce the amount of things added into gpiolib.h. Separating the code should make the various interfaces easier to grasp, and will make it easier to implement interface-specific features. It also points out some direct usages of descriptors/gpiolib core functions that should be gotten rid of in order to make these real "consumers" of the gpiod interface. This series has been tested and I'm fine with it being merged now if you agree with the idea. It would probably be preferable from a cosmetic point of view to first turn fix the extra consumers and then separate them so less things end up being exported in gpiolib.h, but moving things first has the advantage of clearly highlighting what needs to be done and spares us some rebasing hassle. Alexandre Courbot (3): gpio: always compile label support gpio: move sysfs support to its own file gpio: move integer GPIO support to its own file drivers/gpio/Makefile | 2 + drivers/gpio/gpiolib-legacy.c | 112 +++++ drivers/gpio/gpiolib-sysfs.c | 829 ++++++++++++++++++++++++++++++++ drivers/gpio/gpiolib.c | 1043 +---------------------------------------- drivers/gpio/gpiolib.h | 91 ++++ 5 files changed, 1040 insertions(+), 1037 deletions(-) create mode 100644 drivers/gpio/gpiolib-legacy.c create mode 100644 drivers/gpio/gpiolib-sysfs.c -- 2.0.0
next reply other threads:[~2014-07-01 5:47 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-07-01 5:45 Alexandre Courbot [this message] 2014-07-01 5:45 ` [RFC 0/3] gpio: move interfaces into their own files Alexandre Courbot 2014-07-01 5:45 ` [RFC 1/3] gpio: always compile label support Alexandre Courbot 2014-07-01 5:45 ` Alexandre Courbot 2014-07-08 8:17 ` Linus Walleij 2014-07-01 5:45 ` [RFC 2/3] gpio: move sysfs support to its own file Alexandre Courbot 2014-07-01 5:45 ` Alexandre Courbot 2014-07-08 8:21 ` Linus Walleij 2014-07-08 8:31 ` Alexandre Courbot 2014-07-01 5:45 ` [RFC 3/3] gpio: move integer GPIO " Alexandre Courbot 2014-07-01 5:45 ` Alexandre Courbot 2014-07-08 8:25 ` Linus Walleij
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1404193516-4384-1-git-send-email-acourbot@nvidia.com \ --to=acourbot@nvidia.com \ --cc=linus.walleij@linaro.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.