* [PATCH] crypto: caam - fix memleak in caam_jr module
@ 2014-07-02 11:49 Cristian Stoica
0 siblings, 0 replies; 2+ messages in thread
From: Cristian Stoica @ 2014-07-02 11:49 UTC (permalink / raw)
To: Herbert Xu; +Cc: linux-crypto, David S. Miller
This patch fixes a memory leak that appears when caam_jr module is unloaded.
Cc: <stable@vger.kernel.org> # 3.13+
Signed-off-by: Cristian Stoica <cristian.stoica@freescale.com>
---
drivers/crypto/caam/jr.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/crypto/caam/jr.c b/drivers/crypto/caam/jr.c
index 1d80bd3..f127f86 100644
--- a/drivers/crypto/caam/jr.c
+++ b/drivers/crypto/caam/jr.c
@@ -117,6 +117,7 @@ static int caam_jr_remove(struct platform_device *pdev)
if (ret)
dev_err(jrdev, "Failed to shut down job ring\n");
irq_dispose_mapping(jrpriv->irq);
+ kfree(jrpriv);
return ret;
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] crypto: caam - fix memleak in caam_jr module
@ 2014-07-03 7:52 Vakul Garg
0 siblings, 0 replies; 2+ messages in thread
From: Vakul Garg @ 2014-07-03 7:52 UTC (permalink / raw)
To: cristian.stoica; +Cc: linux-crypto
This patch fixes a memory leak that appears when caam_jr module is unloaded.
Cc: <stable@vger.kernel.org> # 3.13+
Signed-off-by: Cristian Stoica <cristian.stoica@freescale.com>
---
drivers/crypto/caam/jr.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/crypto/caam/jr.c b/drivers/crypto/caam/jr.c
index 1d80bd3..f127f86 100644
--- a/drivers/crypto/caam/jr.c
+++ b/drivers/crypto/caam/jr.c
@@ -117,6 +117,7 @@ static int caam_jr_remove(struct platform_device *pdev)
if (ret)
dev_err(jrdev, "Failed to shut down job ring\n");
irq_dispose_mapping(jrpriv->irq);
+ kfree(jrpriv);
Can you replace kmalloc for jrpriv with devm_kzalloc() instead?
This will fix leaks for jrpriv in other places as well and make code compact.
return ret;
}
--
1.8.3.1
--
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-03 7:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-02 11:49 [PATCH] crypto: caam - fix memleak in caam_jr module Cristian Stoica
2014-07-03 7:52 Vakul Garg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.