* [PATCH 1/1] drm/omap: remove null test before kfree
@ 2014-07-04 19:17 Fabian Frederick
2014-07-06 10:55 ` David Herrmann
0 siblings, 1 reply; 3+ messages in thread
From: Fabian Frederick @ 2014-07-04 19:17 UTC (permalink / raw)
To: linux-kernel
Cc: Fabian Frederick, David Airlie, David Herrmann, Tomi Valkeinen,
dri-devel
Fix checkpatch warning:
WARNING: kfree(NULL) is safe this check is probably not required
Cc: David Airlie <airlied@linux.ie>
Cc: David Herrmann <dh.herrmann@gmail.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
drivers/gpu/drm/omapdrm/omap_gem.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/omap_gem.c b/drivers/gpu/drm/omapdrm/omap_gem.c
index 95dbce2..be0c2e8 100644
--- a/drivers/gpu/drm/omapdrm/omap_gem.c
+++ b/drivers/gpu/drm/omapdrm/omap_gem.c
@@ -1183,9 +1183,7 @@ int omap_gem_op_sync(struct drm_gem_object *obj, enum omap_gem_op op)
}
}
spin_unlock(&sync_lock);
-
- if (waiter)
- kfree(waiter);
+ kfree(waiter);
}
return ret;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] drm/omap: remove null test before kfree
2014-07-04 19:17 [PATCH 1/1] drm/omap: remove null test before kfree Fabian Frederick
@ 2014-07-06 10:55 ` David Herrmann
0 siblings, 0 replies; 3+ messages in thread
From: David Herrmann @ 2014-07-06 10:55 UTC (permalink / raw)
To: Fabian Frederick; +Cc: linux-kernel, David Airlie, Tomi Valkeinen, dri-devel
Hi
On Fri, Jul 4, 2014 at 9:17 PM, Fabian Frederick <fabf@skynet.be> wrote:
> Fix checkpatch warning:
> WARNING: kfree(NULL) is safe this check is probably not required
>
> Cc: David Airlie <airlied@linux.ie>
> Cc: David Herrmann <dh.herrmann@gmail.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
Thanks
David
> ---
> drivers/gpu/drm/omapdrm/omap_gem.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/omap_gem.c b/drivers/gpu/drm/omapdrm/omap_gem.c
> index 95dbce2..be0c2e8 100644
> --- a/drivers/gpu/drm/omapdrm/omap_gem.c
> +++ b/drivers/gpu/drm/omapdrm/omap_gem.c
> @@ -1183,9 +1183,7 @@ int omap_gem_op_sync(struct drm_gem_object *obj, enum omap_gem_op op)
> }
> }
> spin_unlock(&sync_lock);
> -
> - if (waiter)
> - kfree(waiter);
> + kfree(waiter);
> }
> return ret;
> }
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] drm/omap: remove null test before kfree
@ 2014-07-06 10:55 ` David Herrmann
0 siblings, 0 replies; 3+ messages in thread
From: David Herrmann @ 2014-07-06 10:55 UTC (permalink / raw)
To: Fabian Frederick; +Cc: Tomi Valkeinen, linux-kernel, dri-devel
Hi
On Fri, Jul 4, 2014 at 9:17 PM, Fabian Frederick <fabf@skynet.be> wrote:
> Fix checkpatch warning:
> WARNING: kfree(NULL) is safe this check is probably not required
>
> Cc: David Airlie <airlied@linux.ie>
> Cc: David Herrmann <dh.herrmann@gmail.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
Thanks
David
> ---
> drivers/gpu/drm/omapdrm/omap_gem.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/omap_gem.c b/drivers/gpu/drm/omapdrm/omap_gem.c
> index 95dbce2..be0c2e8 100644
> --- a/drivers/gpu/drm/omapdrm/omap_gem.c
> +++ b/drivers/gpu/drm/omapdrm/omap_gem.c
> @@ -1183,9 +1183,7 @@ int omap_gem_op_sync(struct drm_gem_object *obj, enum omap_gem_op op)
> }
> }
> spin_unlock(&sync_lock);
> -
> - if (waiter)
> - kfree(waiter);
> + kfree(waiter);
> }
> return ret;
> }
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-07-06 10:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-04 19:17 [PATCH 1/1] drm/omap: remove null test before kfree Fabian Frederick
2014-07-06 10:55 ` David Herrmann
2014-07-06 10:55 ` David Herrmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.