* [PATCH for-2.1] target-i386: Add "kvmclock-stable-bit" feature bit name
@ 2014-07-04 19:44 ` Eduardo Habkost
0 siblings, 0 replies; 4+ messages in thread
From: Eduardo Habkost @ 2014-07-04 19:44 UTC (permalink / raw)
To: qemu-devel, Andreas Färber, Paolo Bonzini, kvm
Cc: Marcelo Tosatti, Igor Mammedov
KVM_FEATURE_CLOCKSOURCE_STABLE_BIT is enabled by default and supported
by KVM. But not having a name defined makes QEMU treat it as an unknown
and unmigratable feature flag (as any unknown feature may possibly
require state to be migrated), and disable it by default on "-cpu host".
As a side-effect, the new name also makes the flag configurable,
allowing the user to disable it (which may be useful for testing or for
compatibility with old kernels).
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
target-i386/cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 45c662d..6d008ab 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -241,7 +241,7 @@ static const char *kvm_feature_name[] = {
NULL, NULL, NULL, NULL,
NULL, NULL, NULL, NULL,
NULL, NULL, NULL, NULL,
- NULL, NULL, NULL, NULL,
+ "kvmclock-stable-bit", NULL, NULL, NULL,
NULL, NULL, NULL, NULL,
};
--
1.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* [Qemu-devel] [PATCH for-2.1] target-i386: Add "kvmclock-stable-bit" feature bit name
@ 2014-07-04 19:44 ` Eduardo Habkost
0 siblings, 0 replies; 4+ messages in thread
From: Eduardo Habkost @ 2014-07-04 19:44 UTC (permalink / raw)
To: qemu-devel, Andreas Färber, Paolo Bonzini, kvm
Cc: Igor Mammedov, Marcelo Tosatti
KVM_FEATURE_CLOCKSOURCE_STABLE_BIT is enabled by default and supported
by KVM. But not having a name defined makes QEMU treat it as an unknown
and unmigratable feature flag (as any unknown feature may possibly
require state to be migrated), and disable it by default on "-cpu host".
As a side-effect, the new name also makes the flag configurable,
allowing the user to disable it (which may be useful for testing or for
compatibility with old kernels).
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
target-i386/cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 45c662d..6d008ab 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -241,7 +241,7 @@ static const char *kvm_feature_name[] = {
NULL, NULL, NULL, NULL,
NULL, NULL, NULL, NULL,
NULL, NULL, NULL, NULL,
- NULL, NULL, NULL, NULL,
+ "kvmclock-stable-bit", NULL, NULL, NULL,
NULL, NULL, NULL, NULL,
};
--
1.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH for-2.1] target-i386: Add "kvmclock-stable-bit" feature bit name
2014-07-04 19:44 ` [Qemu-devel] " Eduardo Habkost
@ 2014-07-05 9:54 ` Paolo Bonzini
-1 siblings, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2014-07-05 9:54 UTC (permalink / raw)
To: Eduardo Habkost, qemu-devel, Andreas Färber, kvm
Cc: Marcelo Tosatti, Igor Mammedov
Il 04/07/2014 21:44, Eduardo Habkost ha scritto:
> KVM_FEATURE_CLOCKSOURCE_STABLE_BIT is enabled by default and supported
> by KVM. But not having a name defined makes QEMU treat it as an unknown
> and unmigratable feature flag (as any unknown feature may possibly
> require state to be migrated), and disable it by default on "-cpu host".
>
> As a side-effect, the new name also makes the flag configurable,
> allowing the user to disable it (which may be useful for testing or for
> compatibility with old kernels).
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> target-i386/cpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 45c662d..6d008ab 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -241,7 +241,7 @@ static const char *kvm_feature_name[] = {
> NULL, NULL, NULL, NULL,
> NULL, NULL, NULL, NULL,
> NULL, NULL, NULL, NULL,
> - NULL, NULL, NULL, NULL,
> + "kvmclock-stable-bit", NULL, NULL, NULL,
> NULL, NULL, NULL, NULL,
> };
>
>
Applied to uq/master, thanks.
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH for-2.1] target-i386: Add "kvmclock-stable-bit" feature bit name
@ 2014-07-05 9:54 ` Paolo Bonzini
0 siblings, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2014-07-05 9:54 UTC (permalink / raw)
To: Eduardo Habkost, qemu-devel, Andreas Färber, kvm
Cc: Igor Mammedov, Marcelo Tosatti
Il 04/07/2014 21:44, Eduardo Habkost ha scritto:
> KVM_FEATURE_CLOCKSOURCE_STABLE_BIT is enabled by default and supported
> by KVM. But not having a name defined makes QEMU treat it as an unknown
> and unmigratable feature flag (as any unknown feature may possibly
> require state to be migrated), and disable it by default on "-cpu host".
>
> As a side-effect, the new name also makes the flag configurable,
> allowing the user to disable it (which may be useful for testing or for
> compatibility with old kernels).
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> target-i386/cpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 45c662d..6d008ab 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -241,7 +241,7 @@ static const char *kvm_feature_name[] = {
> NULL, NULL, NULL, NULL,
> NULL, NULL, NULL, NULL,
> NULL, NULL, NULL, NULL,
> - NULL, NULL, NULL, NULL,
> + "kvmclock-stable-bit", NULL, NULL, NULL,
> NULL, NULL, NULL, NULL,
> };
>
>
Applied to uq/master, thanks.
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-07-05 9:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-04 19:44 [PATCH for-2.1] target-i386: Add "kvmclock-stable-bit" feature bit name Eduardo Habkost
2014-07-04 19:44 ` [Qemu-devel] " Eduardo Habkost
2014-07-05 9:54 ` Paolo Bonzini
2014-07-05 9:54 ` [Qemu-devel] " Paolo Bonzini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.