* [PATCH] refs: Fix valgrind suppression file
@ 2014-07-04 20:24 David Turner
2014-07-07 18:20 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: David Turner @ 2014-07-04 20:24 UTC (permalink / raw)
To: git; +Cc: David Turner
Add all of the ways in which check_refname_format violates valgrind's
expectations to the valgrind suppression file; remove an assumption about
the call chain of check_refname_format from same.
Signed-off-by: David Turner <dturner@twitter.com>
---
| 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)
--git a/t/valgrind/default.supp b/t/valgrind/default.supp
index 332ab1a..9d51c92 100644
--- a/t/valgrind/default.supp
+++ b/t/valgrind/default.supp
@@ -50,10 +50,17 @@
fun:copy_ref
}
{
- ignore-sse-check_refname_format
+ ignore-sse-check_refname_format-addr
Memcheck:Addr8
fun:check_refname_format
- fun:cmd_check_ref_format
- fun:handle_builtin
- fun:main
+}
+{
+ ignore-sse-check_refname_format-cond
+ Memcheck:Cond
+ fun:check_refname_format
+}
+{
+ ignore-sse-check_refname_format-value
+ Memcheck:Value8
+ fun:check_refname_format
}
--
2.0.0.390.gcb682f8
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] refs: Fix valgrind suppression file
2014-07-04 20:24 [PATCH] refs: Fix valgrind suppression file David Turner
@ 2014-07-07 18:20 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2014-07-07 18:20 UTC (permalink / raw)
To: David Turner; +Cc: git, David Turner
David Turner <dturner@twopensource.com> writes:
> Add all of the ways in which check_refname_format violates valgrind's
> expectations to the valgrind suppression file; remove an assumption about
> the call chain of check_refname_format from same.
>
> Signed-off-by: David Turner <dturner@twitter.com>
> ---
> t/valgrind/default.supp | 15 +++++++++++----
> 1 file changed, 11 insertions(+), 4 deletions(-)
I'll queue, but it makes me feel more and more disgusted with that
SSE patch, to be honest.
>
> diff --git a/t/valgrind/default.supp b/t/valgrind/default.supp
> index 332ab1a..9d51c92 100644
> --- a/t/valgrind/default.supp
> +++ b/t/valgrind/default.supp
> @@ -50,10 +50,17 @@
> fun:copy_ref
> }
> {
> - ignore-sse-check_refname_format
> + ignore-sse-check_refname_format-addr
> Memcheck:Addr8
> fun:check_refname_format
> - fun:cmd_check_ref_format
> - fun:handle_builtin
> - fun:main
> +}
> +{
> + ignore-sse-check_refname_format-cond
> + Memcheck:Cond
> + fun:check_refname_format
> +}
> +{
> + ignore-sse-check_refname_format-value
> + Memcheck:Value8
> + fun:check_refname_format
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-07 18:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-04 20:24 [PATCH] refs: Fix valgrind suppression file David Turner
2014-07-07 18:20 ` Junio C Hamano
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.