[PATCH v2] Rename NOP transceiver in JZ4740 platform data

[PATCH v2] Rename NOP transceiver in JZ4740 platform data

[Apelete Seketeli]

Hello,

The name of the NOP transceiver driver was changed during v3.16
release cycle from usb_phy_gen_xceiv to usb_phy_generic.

The patch that comes as a follow up of this message renames
accordingly the NOP transceiver driver in JZ4740 platform data to fix
a subsequent kernel panic.

Changes since v1: 
  - specify commit 4525bee summary line in parens and give more
    details about the bug that was fixed in the commit message.

Please consider for merge in 3.16 if possible since it fixes an issue
that makes the Ben Nanonote unable to boot.

Changes were rebased on top of the linux-mips master branch, built and
tested successfully.

The following changes since commit bc0b9d9:

  Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux

are available in the git repository at:

  git://git.seketeli.net/~apelete/linux-mips.git rename-jz4740-xceiv

Apelete Seketeli (1):
  mips: jz4740: rename usb_nop_xceiv to usb_phy_generic

 arch/mips/jz4740/platform.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
1.7.10.4

[PATCH v2] mips: jz4740: rename usb_nop_xceiv to usb_phy_generic

[Apelete Seketeli]

Rename usb_nop_xceiv to usb_phy_generic in platform data to match the
name change of the nop transceiver driver in commit 4525bee (usb: phy:
rename usb_nop_xceiv to usb_phy_generic).

The name change induced a kernel panic due to an unhandled kernel
unaligned access while trying to dereference musb->xceiv->io_ops in
musb_init_controller().

Signed-off-by: Apelete Seketeli <apelete@seketeli.net>
---
 arch/mips/jz4740/platform.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/jz4740/platform.c b/arch/mips/jz4740/platform.c
index a447101..0b12f27 100644
--- a/arch/mips/jz4740/platform.c
+++ b/arch/mips/jz4740/platform.c
@@ -59,7 +59,7 @@ struct platform_device jz4740_usb_ohci_device = {
 
 /* USB Device Controller */
 struct platform_device jz4740_udc_xceiv_device = {
-	.name = "usb_phy_gen_xceiv",
+	.name = "usb_phy_generic",
 	.id   = 0,
 };
 
-- 
1.7.10.4

Re: [PATCH v2] mips: jz4740: rename usb_nop_xceiv to usb_phy_generic

[Lars-Peter Clausen]

On 07/05/2014 09:30 PM, Apelete Seketeli wrote:
> Rename usb_nop_xceiv to usb_phy_generic in platform data to match the
> name change of the nop transceiver driver in commit 4525bee (usb: phy:
> rename usb_nop_xceiv to usb_phy_generic).
>
> The name change induced a kernel panic due to an unhandled kernel
> unaligned access while trying to dereference musb->xceiv->io_ops in
> musb_init_controller().
>
> Signed-off-by: Apelete Seketeli <apelete@seketeli.net>

Acked-by: Lars-Peter Clausen <lars@metafoo.de>

Ralf, the commit that caused this regression is in v3.16-rc1, can you queue 
this fix for v3.16-rcX?

Thanks,
- Lars