* [PATCH] video: fbdev: msm: mddi.c: Cleaning up variable that is never used
@ 2014-07-05 12:31 ` Rickard Strandqvist
0 siblings, 0 replies; 4+ messages in thread
From: Rickard Strandqvist @ 2014-07-05 12:31 UTC (permalink / raw)
To: Jean-Christophe Plagniol-Villard, Tomi Valkeinen
Cc: Rickard Strandqvist, Rickard Strandqvist, Jingoo Han,
Laurent Pinchart, Rob Clark, Daniel Vetter, linux-fbdev,
linux-kernel
From: Rickard Strandqvist <rickard.strandqvist@sonymobile.com>
Variable ar assigned a value that is never used.
I have also removed all the code that thereby serves no purpose.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/video/fbdev/msm/mddi.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/video/fbdev/msm/mddi.c b/drivers/video/fbdev/msm/mddi.c
index e0f8011..d65ff75a 100644
--- a/drivers/video/fbdev/msm/mddi.c
+++ b/drivers/video/fbdev/msm/mddi.c
@@ -257,12 +257,12 @@ static irqreturn_t mddi_isr(int irq, void *data)
struct msm_mddi_client_data *cdata = data;
struct mddi_info *mddi = container_of(cdata, struct mddi_info,
client_data);
- uint32_t active, status;
+ uint32_t active;
spin_lock(&mddi->int_lock);
active = mddi_readl(INT);
- status = mddi_readl(STAT);
+ mddi_readl(STAT);
mddi_writel(active, INT);
@@ -548,7 +548,6 @@ uint32_t mddi_remote_read(struct msm_mddi_client_data *cdata, uint32_t reg)
struct mddi_llentry *ll;
struct mddi_register_access *ra;
struct reg_read_info ri;
- unsigned s;
int retry_count = 2;
unsigned long irq_flags;
@@ -572,7 +571,7 @@ uint32_t mddi_remote_read(struct msm_mddi_client_data *cdata, uint32_t reg)
ll->next = 0;
ll->reserved = 0;
- s = mddi_readl(STAT);
+ mddi_readl(STAT);
ri.reg = reg;
ri.status = -1;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] video: fbdev: msm: mddi.c: Cleaning up variable that is never used
@ 2014-07-05 12:31 ` Rickard Strandqvist
0 siblings, 0 replies; 4+ messages in thread
From: Rickard Strandqvist @ 2014-07-05 12:31 UTC (permalink / raw)
To: Jean-Christophe Plagniol-Villard, Tomi Valkeinen
Cc: Rickard Strandqvist, Rickard Strandqvist, Jingoo Han,
Laurent Pinchart, Rob Clark, Daniel Vetter, linux-fbdev,
linux-kernel
From: Rickard Strandqvist <rickard.strandqvist@sonymobile.com>
Variable ar assigned a value that is never used.
I have also removed all the code that thereby serves no purpose.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/video/fbdev/msm/mddi.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/video/fbdev/msm/mddi.c b/drivers/video/fbdev/msm/mddi.c
index e0f8011..d65ff75a 100644
--- a/drivers/video/fbdev/msm/mddi.c
+++ b/drivers/video/fbdev/msm/mddi.c
@@ -257,12 +257,12 @@ static irqreturn_t mddi_isr(int irq, void *data)
struct msm_mddi_client_data *cdata = data;
struct mddi_info *mddi = container_of(cdata, struct mddi_info,
client_data);
- uint32_t active, status;
+ uint32_t active;
spin_lock(&mddi->int_lock);
active = mddi_readl(INT);
- status = mddi_readl(STAT);
+ mddi_readl(STAT);
mddi_writel(active, INT);
@@ -548,7 +548,6 @@ uint32_t mddi_remote_read(struct msm_mddi_client_data *cdata, uint32_t reg)
struct mddi_llentry *ll;
struct mddi_register_access *ra;
struct reg_read_info ri;
- unsigned s;
int retry_count = 2;
unsigned long irq_flags;
@@ -572,7 +571,7 @@ uint32_t mddi_remote_read(struct msm_mddi_client_data *cdata, uint32_t reg)
ll->next = 0;
ll->reserved = 0;
- s = mddi_readl(STAT);
+ mddi_readl(STAT);
ri.reg = reg;
ri.status = -1;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] video: fbdev: msm: mddi.c: Cleaning up variable that is never used
2014-07-05 12:31 ` Rickard Strandqvist
@ 2014-07-06 18:42 ` Rickard Strandqvist
-1 siblings, 0 replies; 4+ messages in thread
From: Rickard Strandqvist @ 2014-07-06 18:42 UTC (permalink / raw)
To: Jean-Christophe Plagniol-Villard, Tomi Valkeinen
Cc: Rickard Strandqvist, Jingoo Han, Laurent Pinchart, Rob Clark,
linux-fbdev, linux-kernel
Variable ar assigned a value that is never used.
I have also removed all the code that thereby serves no purpose.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/video/fbdev/msm/mddi.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/video/fbdev/msm/mddi.c b/drivers/video/fbdev/msm/mddi.c
index e0f8011..d65ff75a 100644
--- a/drivers/video/fbdev/msm/mddi.c
+++ b/drivers/video/fbdev/msm/mddi.c
@@ -257,12 +257,12 @@ static irqreturn_t mddi_isr(int irq, void *data)
struct msm_mddi_client_data *cdata = data;
struct mddi_info *mddi = container_of(cdata, struct mddi_info,
client_data);
- uint32_t active, status;
+ uint32_t active;
spin_lock(&mddi->int_lock);
active = mddi_readl(INT);
- status = mddi_readl(STAT);
+ mddi_readl(STAT);
mddi_writel(active, INT);
@@ -548,7 +548,6 @@ uint32_t mddi_remote_read(struct msm_mddi_client_data *cdata, uint32_t reg)
struct mddi_llentry *ll;
struct mddi_register_access *ra;
struct reg_read_info ri;
- unsigned s;
int retry_count = 2;
unsigned long irq_flags;
@@ -572,7 +571,7 @@ uint32_t mddi_remote_read(struct msm_mddi_client_data *cdata, uint32_t reg)
ll->next = 0;
ll->reserved = 0;
- s = mddi_readl(STAT);
+ mddi_readl(STAT);
ri.reg = reg;
ri.status = -1;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] video: fbdev: msm: mddi.c: Cleaning up variable that is never used
@ 2014-07-06 18:42 ` Rickard Strandqvist
0 siblings, 0 replies; 4+ messages in thread
From: Rickard Strandqvist @ 2014-07-06 18:42 UTC (permalink / raw)
To: Jean-Christophe Plagniol-Villard, Tomi Valkeinen
Cc: Rickard Strandqvist, Jingoo Han, Laurent Pinchart, Rob Clark,
linux-fbdev, linux-kernel
Variable ar assigned a value that is never used.
I have also removed all the code that thereby serves no purpose.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/video/fbdev/msm/mddi.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/video/fbdev/msm/mddi.c b/drivers/video/fbdev/msm/mddi.c
index e0f8011..d65ff75a 100644
--- a/drivers/video/fbdev/msm/mddi.c
+++ b/drivers/video/fbdev/msm/mddi.c
@@ -257,12 +257,12 @@ static irqreturn_t mddi_isr(int irq, void *data)
struct msm_mddi_client_data *cdata = data;
struct mddi_info *mddi = container_of(cdata, struct mddi_info,
client_data);
- uint32_t active, status;
+ uint32_t active;
spin_lock(&mddi->int_lock);
active = mddi_readl(INT);
- status = mddi_readl(STAT);
+ mddi_readl(STAT);
mddi_writel(active, INT);
@@ -548,7 +548,6 @@ uint32_t mddi_remote_read(struct msm_mddi_client_data *cdata, uint32_t reg)
struct mddi_llentry *ll;
struct mddi_register_access *ra;
struct reg_read_info ri;
- unsigned s;
int retry_count = 2;
unsigned long irq_flags;
@@ -572,7 +571,7 @@ uint32_t mddi_remote_read(struct msm_mddi_client_data *cdata, uint32_t reg)
ll->next = 0;
ll->reserved = 0;
- s = mddi_readl(STAT);
+ mddi_readl(STAT);
ri.reg = reg;
ri.status = -1;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-07-06 18:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-06 18:42 [PATCH] video: fbdev: msm: mddi.c: Cleaning up variable that is never used Rickard Strandqvist
2014-07-06 18:42 ` Rickard Strandqvist
-- strict thread matches above, loose matches on Subject: below --
2014-07-05 12:31 Rickard Strandqvist
2014-07-05 12:31 ` Rickard Strandqvist
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.