* [PATCH v2] pinctrl: pinctrl-msm.c: Cleaning up variable that is never used
@ 2014-07-07 19:08 Rickard Strandqvist
2014-07-09 10:20 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Rickard Strandqvist @ 2014-07-07 19:08 UTC (permalink / raw)
To: Linus Walleij, linux-kernel; +Cc: Rickard Strandqvist
Variable ar assigned a value that is never used.
I have also removed all the code that thereby serves no purpose.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/pinctrl/pinctrl-msm.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-msm.c b/drivers/pinctrl/pinctrl-msm.c
index df6dda4c..821c562 100644
--- a/drivers/pinctrl/pinctrl-msm.c
+++ b/drivers/pinctrl/pinctrl-msm.c
@@ -176,9 +176,6 @@ static void msm_pinmux_disable(struct pinctrl_dev *pctldev,
g = &pctrl->soc->groups[group];
- if (WARN_ON(g->mux_bit < 0))
- return;
-
spin_lock_irqsave(&pctrl->lock, flags);
/* Clear the mux bits to select gpio mode */
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] pinctrl: pinctrl-msm.c: Cleaning up variable that is never used
2014-07-07 19:08 [PATCH v2] pinctrl: pinctrl-msm.c: Cleaning up variable that is never used Rickard Strandqvist
@ 2014-07-09 10:20 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2014-07-09 10:20 UTC (permalink / raw)
To: Rickard Strandqvist; +Cc: linux-kernel
On Mon, Jul 7, 2014 at 9:08 PM, Rickard Strandqvist
<rickard_strandqvist@spectrumdigital.se> wrote:
> Variable ar assigned a value that is never used.
> I have also removed all the code that thereby serves no purpose.
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Aw sorry - the disable() functions were all deleted in another
patch set so this is no longer a problem.
I should have noticed at once, but my brain is a bit messy due
to too many things to think about :-/
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-09 10:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-07 19:08 [PATCH v2] pinctrl: pinctrl-msm.c: Cleaning up variable that is never used Rickard Strandqvist
2014-07-09 10:20 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.