[PATCH 0/4] iscsi: iscsi changes for 3.17

[PATCH 0/4] iscsi: iscsi changes for 3.17

[michaelc]

The following patches were made over Chrisoph's scsi-queue drivers-for-3.17
branch. They are some fixes to the get_host_stats code and new error code
for when a iscsi ping times out.

Note for applying/merging:

The patches also apply over James's scsi misc branch, but that branch
is missing some patches that Chrisoph has picked up.

[PATCH 1/4] iscsi class: fix get_host_stats error handling

[michaelc]

From: Mike Christie <michaelc@cs.wisc.edu>

iscsi_get_host_stats was dropping the error code returned
by drivers like qla4xxx.

Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
---
 drivers/scsi/scsi_transport_iscsi.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c
index b481e62..14bfa53 100644
--- a/drivers/scsi/scsi_transport_iscsi.c
+++ b/drivers/scsi/scsi_transport_iscsi.c
@@ -3467,6 +3467,10 @@ iscsi_get_host_stats(struct iscsi_transport *transport, struct nlmsghdr *nlh)
 		memset(buf, 0, host_stats_size);
 
 		err = transport->get_host_stats(shost, buf, host_stats_size);
+		if (err) {
+			kfree(skbhost_stats);
+			goto exit_host_stats;
+		}
 
 		actual_size = nlmsg_total_size(sizeof(*ev) + host_stats_size);
 		skb_trim(skbhost_stats, NLMSG_ALIGN(actual_size));
-- 
1.7.1

[PATCH 2/4] qla4xxx: fix get_host_stats error propagation

[michaelc]

From: Mike Christie <michaelc@cs.wisc.edu>

qla4xxx was not always returning -EXYZ error codes when
qla4xxx_get_host_stats failed.

Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
Acked-by: Vikas Chaudhary <vikas.chaudhary@qlogic.com>

---
 drivers/scsi/qla4xxx/ql4_os.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c
index c5d9564..b79b48c 100644
--- a/drivers/scsi/qla4xxx/ql4_os.c
+++ b/drivers/scsi/qla4xxx/ql4_os.c
@@ -1050,6 +1050,7 @@ static int qla4xxx_get_host_stats(struct Scsi_Host *shost, char *buf, int len)
 	if (!ql_iscsi_stats) {
 		ql4_printk(KERN_ERR, ha,
 			   "Unable to allocate memory for iscsi stats\n");
+		ret = -ENOMEM;
 		goto exit_host_stats;
 	}
 
@@ -1058,6 +1059,7 @@ static int qla4xxx_get_host_stats(struct Scsi_Host *shost, char *buf, int len)
 	if (ret != QLA_SUCCESS) {
 		ql4_printk(KERN_ERR, ha,
 			   "Unable to retrieve iscsi stats\n");
+		ret = -EIO;
 		goto exit_host_stats;
 	}
 	host_stats->mactx_frames = le64_to_cpu(ql_iscsi_stats->mac_tx_frames);
-- 
1.7.1

[PATCH 3/4] iscsi class: fix get_host_stats return code when not supported

[michaelc]

From: Mike Christie <michaelc@cs.wisc.edu>

When the get_host_stats call was not supported we were
returing EINVAL. This has us return ENOSYS, because for
software iscsi drivers where there is no host it is ok to not
have this callout.

Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
---
 drivers/scsi/scsi_transport_iscsi.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c
index 14bfa53..534d3fb 100644
--- a/drivers/scsi/scsi_transport_iscsi.c
+++ b/drivers/scsi/scsi_transport_iscsi.c
@@ -3429,7 +3429,7 @@ iscsi_get_host_stats(struct iscsi_transport *transport, struct nlmsghdr *nlh)
 	char *buf;
 
 	if (!transport->get_host_stats)
-		return -EINVAL;
+		return -ENOSYS;
 
 	priv = iscsi_if_transport_lookup(transport);
 	if (!priv)
-- 
1.7.1

[PATCH 4/4] libiscsi: return new error code when nop times out

[michaelc]

From: Mike Christie <michaelc@cs.wisc.edu>

When a iscsi nop as ping timedout we were failing with the
common connection error code, ISCSI_ERR_CONN_FAILED. This
patch adds a new error code for this problem so can properly
track/distinguish in userspace.

Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
---
 drivers/scsi/libiscsi.c |    2 +-
 include/scsi/iscsi_if.h |    1 +
 2 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
index f2db82b..b0813fd 100644
--- a/drivers/scsi/libiscsi.c
+++ b/drivers/scsi/libiscsi.c
@@ -2097,7 +2097,7 @@ static void iscsi_check_transport_timeouts(unsigned long data)
 				  conn->ping_timeout, conn->recv_timeout,
 				  last_recv, conn->last_ping, jiffies);
 		spin_unlock(&session->frwd_lock);
-		iscsi_conn_failure(conn, ISCSI_ERR_CONN_FAILED);
+		iscsi_conn_failure(conn, ISCSI_ERR_NOP_TIMEDOUT);
 		return;
 	}
 
diff --git a/include/scsi/iscsi_if.h b/include/scsi/iscsi_if.h
index fd0421c..95ed942 100644
--- a/include/scsi/iscsi_if.h
+++ b/include/scsi/iscsi_if.h
@@ -527,6 +527,7 @@ enum iscsi_err {
 	ISCSI_ERR_XMIT_FAILED		= ISCSI_ERR_BASE + 19,
 	ISCSI_ERR_TCP_CONN_CLOSE	= ISCSI_ERR_BASE + 20,
 	ISCSI_ERR_SCSI_EH_SESSION_RST	= ISCSI_ERR_BASE + 21,
+	ISCSI_ERR_NOP_TIMEDOUT		= ISCSI_ERR_BASE + 22,
 };
 
 /*
-- 
1.7.1

Re: [PATCH 0/4] iscsi: iscsi changes for 3.17

[Christoph Hellwig]

On Sat, Jul 12, 2014 at 03:51:47PM -0500, michaelc@cs.wisc.edu wrote:
> The following patches were made over Chrisoph's scsi-queue drivers-for-3.17
> branch. They are some fixes to the get_host_stats code and new error code
> for when a iscsi ping times out.

The series looks fine to me, I'll merge it as soon as I get the
remaining second reviews.

Re: [PATCH 0/4] iscsi: iscsi changes for 3.17

[Christoph Hellwig]

Can I get reviews for the remaining patches, please?

On Sat, Jul 12, 2014 at 03:51:47PM -0500, michaelc@cs.wisc.edu wrote:
> The following patches were made over Chrisoph's scsi-queue drivers-for-3.17
> branch. They are some fixes to the get_host_stats code and new error code
> for when a iscsi ping times out.
> 
> Note for applying/merging:
> 
> The patches also apply over James's scsi misc branch, but that branch
> is missing some patches that Chrisoph has picked up.
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
---end quoted text---

Re: [PATCH 1/4] iscsi class: fix get_host_stats error handling

[Hannes Reinecke]

On 07/12/2014 10:51 PM, michaelc@cs.wisc.edu wrote:
> From: Mike Christie <michaelc@cs.wisc.edu>
>
> iscsi_get_host_stats was dropping the error code returned
> by drivers like qla4xxx.
>
> Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
> ---
>   drivers/scsi/scsi_transport_iscsi.c |    4 ++++
>   1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c
> index b481e62..14bfa53 100644
> --- a/drivers/scsi/scsi_transport_iscsi.c
> +++ b/drivers/scsi/scsi_transport_iscsi.c
> @@ -3467,6 +3467,10 @@ iscsi_get_host_stats(struct iscsi_transport *transport, struct nlmsghdr *nlh)
>   		memset(buf, 0, host_stats_size);
>
>   		err = transport->get_host_stats(shost, buf, host_stats_size);
> +		if (err) {
> +			kfree(skbhost_stats);
> +			goto exit_host_stats;
> +		}
>
>   		actual_size = nlmsg_total_size(sizeof(*ev) + host_stats_size);
>   		skb_trim(skbhost_stats, NLMSG_ALIGN(actual_size));
>
What happens with the skbhost_stats allocated earlier? Shouldn't it 
be freed here, too?

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/4] qla4xxx: fix get_host_stats error propagation

[Hannes Reinecke]

On 07/12/2014 10:51 PM, michaelc@cs.wisc.edu wrote:
> From: Mike Christie <michaelc@cs.wisc.edu>
>
> qla4xxx was not always returning -EXYZ error codes when
> qla4xxx_get_host_stats failed.
>
> Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
> Acked-by: Vikas Chaudhary <vikas.chaudhary@qlogic.com>
>
> ---
>   drivers/scsi/qla4xxx/ql4_os.c |    2 ++
>   1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c
> index c5d9564..b79b48c 100644
> --- a/drivers/scsi/qla4xxx/ql4_os.c
> +++ b/drivers/scsi/qla4xxx/ql4_os.c
> @@ -1050,6 +1050,7 @@ static int qla4xxx_get_host_stats(struct Scsi_Host *shost, char *buf, int len)
>   	if (!ql_iscsi_stats) {
>   		ql4_printk(KERN_ERR, ha,
>   			   "Unable to allocate memory for iscsi stats\n");
> +		ret = -ENOMEM;
>   		goto exit_host_stats;
>   	}
>
> @@ -1058,6 +1059,7 @@ static int qla4xxx_get_host_stats(struct Scsi_Host *shost, char *buf, int len)
>   	if (ret != QLA_SUCCESS) {
>   		ql4_printk(KERN_ERR, ha,
>   			   "Unable to retrieve iscsi stats\n");
> +		ret = -EIO;
>   		goto exit_host_stats;
>   	}
>   	host_stats->mactx_frames = le64_to_cpu(ql_iscsi_stats->mac_tx_frames);
>
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/4] iscsi: iscsi changes for 3.17

[Vikas Chaudhary]

[-- Attachment #1: Type: text/plain, Size: 523 bytes --]



On 13/07/14 3:20 pm, "Christoph Hellwig" <hch@infradead.org> wrote:

>On Sat, Jul 12, 2014 at 03:51:47PM -0500, michaelc@cs.wisc.edu wrote:
>> The following patches were made over Chrisoph's scsi-queue
>>drivers-for-3.17
>> branch. They are some fixes to the get_host_stats code and new error
>>code
>> for when a iscsi ping times out.
>
>The series looks fine to me, I'll merge it as soon as I get the
>remaining second reviews.

Ack for series

Acked-by: Vikas Chaudhary <vikas.chaudhary@qlogic.com>


[-- Attachment #2: winmail.dat --]
[-- Type: application/ms-tnef, Size: 4154 bytes --]

Re: [PATCH 3/4] iscsi class: fix get_host_stats return code when not supported

[Hannes Reinecke]

On 07/12/2014 10:51 PM, michaelc@cs.wisc.edu wrote:
> From: Mike Christie <michaelc@cs.wisc.edu>
>
> When the get_host_stats call was not supported we were
> returing EINVAL. This has us return ENOSYS, because for
> software iscsi drivers where there is no host it is ok to not
> have this callout.
>
> Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
> ---
>   drivers/scsi/scsi_transport_iscsi.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c
> index 14bfa53..534d3fb 100644
> --- a/drivers/scsi/scsi_transport_iscsi.c
> +++ b/drivers/scsi/scsi_transport_iscsi.c
> @@ -3429,7 +3429,7 @@ iscsi_get_host_stats(struct iscsi_transport *transport, struct nlmsghdr *nlh)
>   	char *buf;
>
>   	if (!transport->get_host_stats)
> -		return -EINVAL;
> +		return -ENOSYS;
>
>   	priv = iscsi_if_transport_lookup(transport);
>   	if (!priv)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/4] libiscsi: return new error code when nop times out

[Hannes Reinecke]

On 07/12/2014 10:51 PM, michaelc@cs.wisc.edu wrote:
> From: Mike Christie <michaelc@cs.wisc.edu>
>
> When a iscsi nop as ping timedout we were failing with the
> common connection error code, ISCSI_ERR_CONN_FAILED. This
> patch adds a new error code for this problem so can properly
> track/distinguish in userspace.
>
> Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
> ---
>   drivers/scsi/libiscsi.c |    2 +-
>   include/scsi/iscsi_if.h |    1 +
>   2 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
> index f2db82b..b0813fd 100644
> --- a/drivers/scsi/libiscsi.c
> +++ b/drivers/scsi/libiscsi.c
> @@ -2097,7 +2097,7 @@ static void iscsi_check_transport_timeouts(unsigned long data)
>   				  conn->ping_timeout, conn->recv_timeout,
>   				  last_recv, conn->last_ping, jiffies);
>   		spin_unlock(&session->frwd_lock);
> -		iscsi_conn_failure(conn, ISCSI_ERR_CONN_FAILED);
> +		iscsi_conn_failure(conn, ISCSI_ERR_NOP_TIMEDOUT);
>   		return;
>   	}
>
> diff --git a/include/scsi/iscsi_if.h b/include/scsi/iscsi_if.h
> index fd0421c..95ed942 100644
> --- a/include/scsi/iscsi_if.h
> +++ b/include/scsi/iscsi_if.h
> @@ -527,6 +527,7 @@ enum iscsi_err {
>   	ISCSI_ERR_XMIT_FAILED		= ISCSI_ERR_BASE + 19,
>   	ISCSI_ERR_TCP_CONN_CLOSE	= ISCSI_ERR_BASE + 20,
>   	ISCSI_ERR_SCSI_EH_SESSION_RST	= ISCSI_ERR_BASE + 21,
> +	ISCSI_ERR_NOP_TIMEDOUT		= ISCSI_ERR_BASE + 22,
>   };
>
>   /*
>
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/4] iscsi class: fix get_host_stats error handling

[Mike Christie]

On 07/30/2014 07:50 AM, Hannes Reinecke wrote:
> On 07/12/2014 10:51 PM, michaelc@cs.wisc.edu wrote:
>> From: Mike Christie <michaelc@cs.wisc.edu>
>>
>> iscsi_get_host_stats was dropping the error code returned
>> by drivers like qla4xxx.
>>
>> Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
>> ---
>>   drivers/scsi/scsi_transport_iscsi.c |    4 ++++
>>   1 files changed, 4 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/scsi/scsi_transport_iscsi.c
>> b/drivers/scsi/scsi_transport_iscsi.c
>> index b481e62..14bfa53 100644
>> --- a/drivers/scsi/scsi_transport_iscsi.c
>> +++ b/drivers/scsi/scsi_transport_iscsi.c
>> @@ -3467,6 +3467,10 @@ iscsi_get_host_stats(struct iscsi_transport
>> *transport, struct nlmsghdr *nlh)
>>           memset(buf, 0, host_stats_size);
>>
>>           err = transport->get_host_stats(shost, buf, host_stats_size);
>> +        if (err) {
>> +            kfree(skbhost_stats);
>> +            goto exit_host_stats;
>> +        }
>>
>>           actual_size = nlmsg_total_size(sizeof(*ev) + host_stats_size);
>>           skb_trim(skbhost_stats, NLMSG_ALIGN(actual_size));
>>
> What happens with the skbhost_stats allocated earlier? Shouldn't it be
> freed here, too?
> 

You mean for this success path right. It is not freed here by the iscsi
code on purpose. For the code path here where we have successfully
called into the driver then a couple lines below we will do

iscsi_multicast_skb() -> nlmsg_multicast()

which will pass the skbhost_stats skb to the netlink layer. The
netlink/socket/skb code then frees it when it is done with it.

Re: [PATCH 1/4] iscsi class: fix get_host_stats error handling

[Hannes Reinecke]

On 08/01/2014 12:32 AM, Mike Christie wrote:
> On 07/30/2014 07:50 AM, Hannes Reinecke wrote:
>> On 07/12/2014 10:51 PM, michaelc@cs.wisc.edu wrote:
>>> From: Mike Christie <michaelc@cs.wisc.edu>
>>>
>>> iscsi_get_host_stats was dropping the error code returned
>>> by drivers like qla4xxx.
>>>
>>> Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
>>> ---
>>>    drivers/scsi/scsi_transport_iscsi.c |    4 ++++
>>>    1 files changed, 4 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/drivers/scsi/scsi_transport_iscsi.c
>>> b/drivers/scsi/scsi_transport_iscsi.c
>>> index b481e62..14bfa53 100644
>>> --- a/drivers/scsi/scsi_transport_iscsi.c
>>> +++ b/drivers/scsi/scsi_transport_iscsi.c
>>> @@ -3467,6 +3467,10 @@ iscsi_get_host_stats(struct iscsi_transport
>>> *transport, struct nlmsghdr *nlh)
>>>            memset(buf, 0, host_stats_size);
>>>
>>>            err = transport->get_host_stats(shost, buf, host_stats_size);
>>> +        if (err) {
>>> +            kfree(skbhost_stats);
>>> +            goto exit_host_stats;
>>> +        }
>>>
>>>            actual_size = nlmsg_total_size(sizeof(*ev) + host_stats_size);
>>>            skb_trim(skbhost_stats, NLMSG_ALIGN(actual_size));
>>>
>> What happens with the skbhost_stats allocated earlier? Shouldn't it be
>> freed here, too?
>>
>
> You mean for this success path right. It is not freed here by the iscsi
> code on purpose. For the code path here where we have successfully
> called into the driver then a couple lines below we will do
>
> iscsi_multicast_skb() -> nlmsg_multicast()
>
> which will pass the skbhost_stats skb to the netlink layer. The
> netlink/socket/skb code then frees it when it is done with it.
>
No, I meant the failure path.

You do an alloc_skb above, then get_host_stats failed, and you exit 
the function without freeing the skb.
Or do I miss something?


Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/4] iscsi class: fix get_host_stats error handling

[Mike Christie]

On 08/01/2014 08:31 AM, Hannes Reinecke wrote:
> On 08/01/2014 12:32 AM, Mike Christie wrote:
>> On 07/30/2014 07:50 AM, Hannes Reinecke wrote:
>>> On 07/12/2014 10:51 PM, michaelc@cs.wisc.edu wrote:
>>>> From: Mike Christie <michaelc@cs.wisc.edu>
>>>>
>>>> iscsi_get_host_stats was dropping the error code returned
>>>> by drivers like qla4xxx.
>>>>
>>>> Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
>>>> ---
>>>>    drivers/scsi/scsi_transport_iscsi.c |    4 ++++
>>>>    1 files changed, 4 insertions(+), 0 deletions(-)
>>>>
>>>> diff --git a/drivers/scsi/scsi_transport_iscsi.c
>>>> b/drivers/scsi/scsi_transport_iscsi.c
>>>> index b481e62..14bfa53 100644
>>>> --- a/drivers/scsi/scsi_transport_iscsi.c
>>>> +++ b/drivers/scsi/scsi_transport_iscsi.c
>>>> @@ -3467,6 +3467,10 @@ iscsi_get_host_stats(struct iscsi_transport
>>>> *transport, struct nlmsghdr *nlh)
>>>>            memset(buf, 0, host_stats_size);
>>>>
>>>>            err = transport->get_host_stats(shost, buf,
>>>> host_stats_size);
>>>> +        if (err) {
>>>> +            kfree(skbhost_stats);
>>>> +            goto exit_host_stats;
>>>> +        }
>>>>
>>>>            actual_size = nlmsg_total_size(sizeof(*ev) +
>>>> host_stats_size);
>>>>            skb_trim(skbhost_stats, NLMSG_ALIGN(actual_size));
>>>>
>>> What happens with the skbhost_stats allocated earlier? Shouldn't it be
>>> freed here, too?
>>>
>>
>> You mean for this success path right. It is not freed here by the iscsi
>> code on purpose. For the code path here where we have successfully
>> called into the driver then a couple lines below we will do
>>
>> iscsi_multicast_skb() -> nlmsg_multicast()
>>
>> which will pass the skbhost_stats skb to the netlink layer. The
>> netlink/socket/skb code then frees it when it is done with it.
>>
> No, I meant the failure path.
> 
> You do an alloc_skb above, then get_host_stats failed, and you exit the
> function without freeing the skb.

Ah, actually I am freeing it, but I now realize with the wrong function,
so I think that is why I was confused by your comment.  Above I added a
kfree() of the skb. I should be using kfree_skb. Will fix it up. Thanks.