Re: [RFC PATCH v2 1/7] Removed all code from sedf not needed for basic EDF functionality

From: Dario Faggioli <dario.faggioli@citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Ian Campbell <ian.campbell@citrix.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	George Dunlap <george.dunlap@eu.citrix.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	Robert VanVossen <robert.vanvossen@dornerworks.com>,
	Xen-devel <xen-devel@lists.xen.org>,
	Nathan Studer <nate.studer@gmail.com>,
	Josh Whitehead <josh.whitehead@dornerworks.com>
Subject: Re: [RFC PATCH v2 1/7] Removed all code from sedf not needed for basic EDF functionality
Date: Mon, 14 Jul 2014 18:06:48 +0200	[thread overview]
Message-ID: <1405354008.29306.682.camel@Solace> (raw)
In-Reply-To: <20140711195414.GM23257@laptop.dumpdata.com>

[-- Attachment #1.1: Type: text/plain, Size: 1639 bytes --]

On ven, 2014-07-11 at 15:54 -0400, Konrad Rzeszutek Wilk wrote:
> On Fri, Jul 11, 2014 at 09:05:27AM +0200, Dario Faggioli wrote:
> > On mer, 2014-07-09 at 16:55 -0400, Josh Whitehead wrote:
> > > A large amount of code had been added to the sedf scheduler over the years that
> > > had made it everything but a "simple" EDF scheduler.
> > >
> > Indeed! :-)
> > 
> > > --- a/xen/common/sched_sedf.c
> > > +++ b/xen/common/sched_sedf.c
> >  
> > > -#define EXTRA_NONE (0)
> > > -#define EXTRA_AWARE (1)
> > > -#define EXTRA_RUN_PEN (2)
> > > -#define EXTRA_RUN_UTIL (4)
> > > -#define EXTRA_WANT_PEN_Q (8)
> > > -#define EXTRA_PEN_Q (0)
> > > -#define EXTRA_UTIL_Q (1)
> > >  #define SEDF_ASLEEP (16)
> > >
> > As said when reviewing other patches in the series, do not limit to
> > removing the flags, do also "renumber" the remaining one, instead of
> > living it #defined to 16.
> > 
> > I can clearly see someone looking at the code rather puzzled about why,
> > since there is only one flag, it is associated to the 5th bit! :-P
> > 
> > The rest of this patch looks fine to me.
> 
> Is that an 'Reviewed-by' or 'Acked-by' ?
> 
It's not, actually. I'll say it explicitly when that will be the case.

BTW, given all the discussion about renaming/new file, etc., even if it
were, it'd be pretty pointless at this stage, I think.

Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel