All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dario Faggioli <dario.faggioli@citrix.com>
To: Josh Whitehead <josh.whitehead@dornerworks.com>
Cc: Ian Campbell <ian.campbell@citrix.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	George Dunlap <george.dunlap@eu.citrix.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	Robert VanVossen <robert.vanvossen@dornerworks.com>,
	Xen-devel <xen-devel@lists.xen.org>,
	Nathan Studer <nate.studer@gmail.com>
Subject: Re: [RFC PATCH v2 5/7] Add cbs parameter support and removed sedf parameters with a LIBXL_API_VERSION gate from libxl.
Date: Thu, 10 Jul 2014 16:26:59 +0200	[thread overview]
Message-ID: <1405002419.29306.52.camel@Solace> (raw)
In-Reply-To: <1404939348-4926-6-git-send-email-josh.whitehead@dornerworks.com>


[-- Attachment #1.1: Type: text/plain, Size: 1161 bytes --]

On mer, 2014-07-09 at 16:55 -0400, Josh Whitehead wrote:
> From: Robbie VanVossen <robert.vanvossen@dornerworks.com>
> 
> We made an attempt at doing the versioning gate in this file.  Please let us
> know if further changes are needed, and where they are needed to properly guard
> the API.
> 
So, since you're adding soft to libxl_domain_sched_params, so you need
to add something like:

/*
 * Some comments...
 */
#define LIBXL_HAVE_DOMAIN_SCHED_PARAMS_SOFT 1

in libxl.h.

Look at LIBXL_HAVE_DOMAIN_NODEAFFINITY,
LIBXL_HAVE_VCPUINFO_SOFT_AFFINITY for inspiration. :-)

If it were me, I think I'd include _SEDF_ in the name as well:

#define LIBXL_HAVE_DOMAIN_SCHED_SEDF_PARAMS_SOFT 1

or:

#define LIBXL_HAVE_DOMAIN_SCHEDPARAM_SEDF_SOFT 1

And I now see that Ian said plenty already in his email about
LIBXL_API_VERSION. I'll continue there...

Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  parent reply	other threads:[~2014-07-10 14:26 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-09 20:55 [RFC PATCH v2 0/7] Repurpose SEDF Scheduler for Real-time Use Josh Whitehead
2014-07-09 20:55 ` [RFC PATCH v2 1/7] Removed all code from sedf not needed for basic EDF functionality Josh Whitehead
2014-07-11  7:05   ` Dario Faggioli
2014-07-11 19:54     ` Konrad Rzeszutek Wilk
2014-07-14 16:06       ` Dario Faggioli
2014-07-09 20:55 ` [RFC PATCH v2 2/7] Fixed formatting and misleading comments/variables. Added comments and renamed variables to accurately reflect modern terminology Josh Whitehead
2014-07-11  3:59   ` Dario Faggioli
2014-07-09 20:55 ` [RFC PATCH v2 3/7] Added constant bandwidth server functionality to sedf scheduler Josh Whitehead
2014-07-11  9:37   ` Dario Faggioli
2014-07-09 20:55 ` [RFC PATCH v2 4/7] Add cbs parameter support and removed sedf parameters from libxc Josh Whitehead
2014-07-10 23:17   ` Dario Faggioli
2014-07-09 20:55 ` [RFC PATCH v2 5/7] Add cbs parameter support and removed sedf parameters with a LIBXL_API_VERSION gate from libxl Josh Whitehead
2014-07-10 14:09   ` Ian Campbell
2014-07-10 14:55     ` Ian Jackson
2014-07-10 23:02     ` Dario Faggioli
2014-07-11 11:12       ` Ian Campbell
2014-07-10 14:26   ` Dario Faggioli [this message]
2014-07-09 20:55 ` [RFC PATCH v2 6/7] Changed slice to budget in libxc for the sedf scheduler Josh Whitehead
2014-07-10 14:15   ` Ian Campbell
2014-07-10 23:11   ` Dario Faggioli
2014-07-11 11:11     ` Ian Campbell
2014-07-11 13:51       ` Dario Faggioli
2014-07-09 20:55 ` [RFC PATCH v2 7/7] Changed slice to budget in libxl " Josh Whitehead
2014-07-10 14:43 ` [RFC PATCH v2 0/7] Repurpose SEDF Scheduler for Real-time Use Ian Campbell
2014-07-11  5:01   ` Dario Faggioli
2014-07-11 11:15     ` Ian Campbell
2014-07-11 13:35       ` Dario Faggioli
2014-07-11 13:50         ` Ian Campbell
2014-07-11 13:58           ` Dario Faggioli
2014-07-11 20:02     ` Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1405002419.29306.52.camel@Solace \
    --to=dario.faggioli@citrix.com \
    --cc=george.dunlap@eu.citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=josh.whitehead@dornerworks.com \
    --cc=nate.studer@gmail.com \
    --cc=robert.vanvossen@dornerworks.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.